Apache
/
activemq
mirror of https://github.com/apache/activemq.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

make sure we properly close down the advisory consumer; great catch by Manuel! 

git-svn-id: https://svn.apache.org/repos/asf/activemq/trunk@551857 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
James Strachan 2007-06-29 11:34:20 +00:00
parent ec6e6a55a7
commit 56be6b93d3
1 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
activemq-core/src/main/java/org/apache/activemq/AdvisoryConsumer.java
View File

@ -27,8 +27,11 @@ import org.apache.activemq.command.DataStructure;
import org.apache.activemq.command.DestinationInfo; import org.apache.activemq.command.DestinationInfo;
import org.apache.activemq.command.MessageAck; import org.apache.activemq.command.MessageAck;
import org.apache.activemq.command.MessageDispatch; import org.apache.activemq.command.MessageDispatch;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
public class AdvisoryConsumer implements ActiveMQDispatcher { public class AdvisoryConsumer implements ActiveMQDispatcher {
private static final transient Log log = LogFactory.getLog(AdvisoryConsumer.class);
private final ActiveMQConnection connection; private final ActiveMQConnection connection;
private ConsumerInfo info; private ConsumerInfo info;
@ -46,8 +49,14 @@ public class AdvisoryConsumer implements ActiveMQDispatcher {
this.connection.syncSendPacket(this.info); this.connection.syncSendPacket(this.info);
} }
public void dispose() { public synchronized void dispose() {
if (!closed) { if (!closed) {
try {
this.connection.asyncSendPacket(info.createRemoveCommand());
}
catch (JMSException e) {
log.info("Failed to send remove command: " + e, e);
}
this.connection.removeDispatcher(info.getConsumerId()); this.connection.removeDispatcher(info.getConsumerId());
closed = true; closed = true;
} }