From 673c2928a1b567958c2d9eabe2995a039f2aa1e2 Mon Sep 17 00:00:00 2001 From: "Christopher L. Shannon" Date: Sat, 28 Nov 2015 13:25:53 -0500 Subject: [PATCH] https://issues.apache.org/jira/browse/AMQ-6066 Improving performance of OrderedPendingList contains method Thanks for David Sitsky for the patch --- .../activemq/broker/region/cursors/OrderedPendingList.java | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/activemq-broker/src/main/java/org/apache/activemq/broker/region/cursors/OrderedPendingList.java b/activemq-broker/src/main/java/org/apache/activemq/broker/region/cursors/OrderedPendingList.java index 31870b110a..28fc13cfa0 100644 --- a/activemq-broker/src/main/java/org/apache/activemq/broker/region/cursors/OrderedPendingList.java +++ b/activemq-broker/src/main/java/org/apache/activemq/broker/region/cursors/OrderedPendingList.java @@ -162,11 +162,7 @@ public class OrderedPendingList implements PendingList { @Override public boolean contains(MessageReference message) { if (message != null) { - for (PendingNode value : map.values()) { - if (value.getMessage().equals(message)) { - return true; - } - } + return this.map.containsKey(message.getMessageId()); } return false; }