Apache/activemq
1
0
Fork 0
mirror of https://github.com/apache/activemq.git synced 2025-02-17 23:45:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #554 from coheigea/AMQ-8020

Browse Source 
AMQ-8020 - Replace toLowerCase().equals() with equalsIgnoreCase
This commit is contained in:
Jean-Baptiste Onofré 2020-08-11 09:32:23 +02:00 committed by GitHub
commit 6fef652beb
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
activemq-broker/src/main/java/org/apache/activemq/broker/jmx/DestinationsViewFilter.java
View File

@ -196,7 +196,7 @@ public class DestinationsViewFilter implements Serializable {
Object leftValue = getter.invoke(left.getValue()); Object leftValue = getter.invoke(left.getValue());
Object rightValue = getter.invoke(right.getValue()); Object rightValue = getter.invoke(right.getValue());
if (leftValue instanceof Comparable && rightValue instanceof Comparable) { if (leftValue instanceof Comparable && rightValue instanceof Comparable) {
if (getSortOrder().toLowerCase().equals("desc")) { if (getSortOrder().equalsIgnoreCase("desc")) {
return ((Comparable) rightValue).compareTo(leftValue); return ((Comparable) rightValue).compareTo(leftValue);
} else { } else {
return ((Comparable) leftValue).compareTo(rightValue); return ((Comparable) leftValue).compareTo(rightValue);

4
activemq-broker/src/main/java/org/apache/activemq/util/BooleanEditor.java
View File

@ -35,9 +35,9 @@ public class BooleanEditor extends PropertyEditorSupport {
} }
public void setAsText(String text) throws java.lang.IllegalArgumentException { public void setAsText(String text) throws java.lang.IllegalArgumentException {
if (text.toLowerCase().equals("true")) { if (text.equalsIgnoreCase("true")) {
setValue(Boolean.TRUE); setValue(Boolean.TRUE);
} else if (text.toLowerCase().equals("false")) { } else if (text.equalsIgnoreCase("false")) {
setValue(Boolean.FALSE); setValue(Boolean.FALSE);
} else { } else {
throw new java.lang.IllegalArgumentException(text); throw new java.lang.IllegalArgumentException(text);

2
activemq-http/src/main/java/org/apache/activemq/transport/util/HttpTransportUtils.java
View File

@ -27,7 +27,7 @@ public class HttpTransportUtils {
StringBuilder remoteAddress = new StringBuilder(); StringBuilder remoteAddress = new StringBuilder();
String scheme = request.getScheme(); String scheme = request.getScheme();
remoteAddress.append(scheme != null && scheme.toLowerCase().equals("https") ? "wss://" : "ws://"); remoteAddress.append(scheme != null && scheme.equalsIgnoreCase("https") ? "wss://" : "ws://");
remoteAddress.append(request.getRemoteAddr()); remoteAddress.append(request.getRemoteAddr());
remoteAddress.append(":"); remoteAddress.append(":");
remoteAddress.append(request.getRemotePort()); remoteAddress.append(request.getRemotePort());