Apache
/
activemq
mirror of https://github.com/apache/activemq.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

If multicast is not properly configured.. we run the chance of filling the logs with error messages on a vanila install. 

We now gard against this by only reporting the error mesasge the first time we hit the error. We keep trying to do mutlicast advertising, but
suppress futher error messages.

git-svn-id: https://svn.apache.org/repos/asf/incubator/activemq/trunk@393054 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Hiram R. Chirino 2006-04-10 20:41:13 +00:00
parent daddd413a2
commit 700ba75d55
1 changed files with 12 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
activemq-core/src/main/java/org/apache/activemq/transport/discovery/multicast/MulticastDiscoveryAgent.java
View File

@ -73,6 +73,7 @@ public class MulticastDiscoveryAgent implements DiscoveryAgent,Runnable{
private long keepAliveInterval=DEFAULT_IDLE_TIME;
private long lastAdvertizeTime=0;
private AtomicBoolean started=new AtomicBoolean(false);
private boolean reportAdvertizeFailed=true;
private final Executor executor = new ThreadPoolExecutor(1, 1, 30, TimeUnit.SECONDS, new LinkedBlockingQueue(), new ThreadFactory() {
public Thread newThread(Runnable runable) {
@ -296,7 +297,7 @@ public class MulticastDiscoveryAgent implements DiscoveryAgent,Runnable{
}
private void doAdvertizeSelf(){
if(selfService!=null){
if(selfService!=null ){
String payload=getType();
payload+=started.get()?ALIVE:DEAD;
payload+=DELIMITER+brokerName+DELIMITER;
@ -305,8 +306,16 @@ public class MulticastDiscoveryAgent implements DiscoveryAgent,Runnable{
byte[] data=payload.getBytes();
DatagramPacket packet=new DatagramPacket(data,0,data.length,sockAddress);
mcast.send(packet);
}catch(IOException e){
log.error("Failed to advertise our service: "+payload,e);
} catch(IOException e) {
// If a send fails, chances are all subsequent sends will fail too.. No need to keep reporting the
// same error over and over.
if( reportAdvertizeFailed ) {
reportAdvertizeFailed=false;
log.error("Failed to advertise our service: "+payload,e);
if( "Operation not permitted".equals(e.getMessage()) ) {
log.error("The 'Operation not permitted' error has been know to be caused by improper firewall/network setup. Please make sure that the OS is properly configured to allow multicast traffic over: "+mcast.getLocalAddress());
}
}
}
}
}