Revert "https://issues.apache.org/jira/browse/AMQ-6221"

Reverting commit to keep sync out of the client messages

This reverts commit e0c5499964.

activemq-client/src/main/java/org/apache/activemq/command/ActiveMQTextMessage.java

@@ -45,7 +45,7 @@ public class ActiveMQTextMessage extends ActiveMQMessage implements TextMessage
 
     public static final byte DATA_STRUCTURE_TYPE = CommandTypes.ACTIVEMQ_TEXT_MESSAGE;
 
-    protected volatile String text;
+    protected String text;
 
     @Override
     public Message copy() {
@@ -55,11 +55,15 @@ public class ActiveMQTextMessage extends ActiveMQMessage implements TextMessage
     }
 
     private void copy(ActiveMQTextMessage copy) {
-        synchronized(this) {
+        //AMQ-6218 - Save text before calling super.copy() to prevent a race condition when
+        //concurrent store and dispatch is enabled in KahaDB
+        //The issue is sometimes beforeMarshall() gets called in between the time content and
+        //text are copied to the new object leading to both fields being null when text should
+        //not be null
+        String text = this.text;
         super.copy(copy);
         copy.text = text;
     }
-    }
 
     @Override
     public byte getDataStructureType() {
@@ -73,31 +77,22 @@ public class ActiveMQTextMessage extends ActiveMQMessage implements TextMessage
 
     @Override
     public void setText(String text) throws MessageNotWriteableException {
-        synchronized(this) {
         checkReadOnlyBody();
         this.text = text;
         setContent(null);
     }
-    }
 
     @Override
     public String getText() throws JMSException {
-        ByteSequence content;
+        ByteSequence content = getContent();
-        String text;
+        String text = this.text;
-
-        synchronized(this) {
-            content = getContent();
-            text = this.text;
-        }
 
         if (text == null && content != null) {
             text = decodeContent(content);
-            synchronized(this) {
             this.text = text;
             setContent(null);
             setCompressed(false);
         }
-        }
         return text;
     }
 
@@ -136,43 +131,16 @@ public class ActiveMQTextMessage extends ActiveMQMessage implements TextMessage
 
     @Override
     public void storeContentAndClear() {
-        ByteSequence content;
+        storeContent();
-        String text;
-        synchronized(this) {
-            content = getContent();
-            text = this.text;
-        }
-        if (content == null && text != null) {
-            content = marshallContent(text);
-        }
-        synchronized(this) {
-            setContent(content);
         text=null;
     }
-    }
 
     @Override
     public void storeContent() {
-        ByteSequence content;
-        String text;
-        synchronized(this) {
-            content = getContent();
-            text = this.text;
-        }
-
-        if (content == null && text != null) {
-            content = marshallContent(text);
-        }
-
-        synchronized(this) {
-            setContent(content);
-        }
-    }
-
-    private ByteSequence marshallContent(String text) {
-        ByteSequence content = null;
         try {
-            if (text != null) {
+            ByteSequence content = getContent();
+            String text = this.text;
+            if (content == null && text != null) {
                 ByteArrayOutputStream bytesOut = new ByteArrayOutputStream();
                 OutputStream os = bytesOut;
                 ActiveMQConnection connection = getConnection();
@@ -183,24 +151,20 @@ public class ActiveMQTextMessage extends ActiveMQMessage implements TextMessage
                 DataOutputStream dataOut = new DataOutputStream(os);
                 MarshallingSupport.writeUTF8(dataOut, text);
                 dataOut.close();
-                content = bytesOut.toByteSequence();
+                setContent(bytesOut.toByteSequence());
             }
         } catch (IOException e) {
             throw new RuntimeException(e);
         }
-        return content;
     }
 
-
     // see https://issues.apache.org/activemq/browse/AMQ-2103
     // and https://issues.apache.org/activemq/browse/AMQ-2966
     @Override
     public void clearMarshalledState() throws JMSException {
-        synchronized(this) {
         super.clearMarshalledState();
         this.text = null;
     }
-    }
 
     /**
      * Clears out the message body. Clearing a message's body does not clear its
@@ -215,20 +179,13 @@ public class ActiveMQTextMessage extends ActiveMQMessage implements TextMessage
      */
     @Override
     public void clearBody() throws JMSException {
-        synchronized(this) {
         super.clearBody();
         this.text = null;
     }
-    }
 
     @Override
     public int getSize() {
-        ByteSequence content;
+        String text = this.text;
-        String text;
-        synchronized(this) {
-            content = getContent();
-            text = this.text;
-        }
         if (size == 0 && content == null && text != null) {
             size = getMinimumMessageSize();
             if (marshalledProperties != null) {