Apache
/
activemq
mirror of https://github.com/apache/activemq.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1260 from levrun/enhanced_for_loop_transport_connection 

for loop can be replaced with enhanced for
This commit is contained in:
JB Onofré 2024-07-13 06:50:30 +02:00 committed by GitHub
parent 4e3084d9bb d00cbe5b5c
commit 95af27c512
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
activemq-broker/src/main/java/org/apache/activemq/broker/TransportConnection.java
View File

@ -1214,8 +1214,7 @@ public class TransportConnection implements Connection, Task, CommandVisitor {
// Run the MessageDispatch callbacks so that message references get // Run the MessageDispatch callbacks so that message references get
// cleaned up. // cleaned up.
synchronized (dispatchQueue) { synchronized (dispatchQueue) {
for (Iterator<Command> iter = dispatchQueue.iterator(); iter.hasNext(); ) { for (Command command : dispatchQueue) {
Command command = iter.next();
if (command.isMessageDispatch()) { if (command.isMessageDispatch()) {
MessageDispatch md = (MessageDispatch) command; MessageDispatch md = (MessageDispatch) command;
TransmitCallback sub = md.getTransmitCallback(); TransmitCallback sub = md.getTransmitCallback();
@ -1421,8 +1420,7 @@ public class TransportConnection implements Connection, Task, CommandVisitor {
String duplexNetworkConnectorId = config.getName() + "@" + info.getBrokerId(); String duplexNetworkConnectorId = config.getName() + "@" + info.getBrokerId();
CopyOnWriteArrayList<TransportConnection> connections = this.connector.getConnections(); CopyOnWriteArrayList<TransportConnection> connections = this.connector.getConnections();
synchronized (connections) { synchronized (connections) {
for (Iterator<TransportConnection> iter = connections.iterator(); iter.hasNext(); ) { for (TransportConnection c : connections) {
TransportConnection c = iter.next();
if ((c != this) && (duplexNetworkConnectorId.equals(c.getDuplexNetworkConnectorId()))) { if ((c != this) && (duplexNetworkConnectorId.equals(c.getDuplexNetworkConnectorId()))) {
LOG.warn("Stopping an existing active duplex connection [{}] for network connector ({}).", c, duplexNetworkConnectorId); LOG.warn("Stopping an existing active duplex connection [{}] for network connector ({}).", c, duplexNetworkConnectorId);
c.stopAsync(); c.stopAsync();