Apache
/
activemq
mirror of https://github.com/apache/activemq.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

AMQ-9157 - Add missing dispatched advisory topic to getAllDestinationAdvisoryTopics() method in AdvisorySupport 

Adds missing dispached advisory topics to getAllDestinationAvisoryTopics()
method in AdvisorySupport which is used to clean up on destination removal
and also a note about virtual destination consumer advisories
This commit is contained in:
Christopher L. Shannon (cshannon) 2022-11-17 09:16:07 -05:00
parent f6e26085cf
commit 9f9a35eb29
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
activemq-client/src/main/java/org/apache/activemq/advisory/AdvisorySupport.java
View File

@ -94,6 +94,12 @@ public final class AdvisorySupport {
public static ActiveMQTopic[] getAllDestinationAdvisoryTopics(ActiveMQDestination destination) throws JMSException {
ArrayList<ActiveMQTopic> result = new ArrayList<ActiveMQTopic>();
//Note - Sicne this method is primarily used for removing destinations and clean up
//don't add VirtualDestinationConsumerAdvisoryTopic here as we want to keep listening
//for demand on composite destinations that may be forwarded for Virtual topics even after dest removal.
//This is because virtual destinations or composite destinations can trigger demand so we need to still listen
//Cleanup will happen automatically if there are no consumers on the advisory (due to the bridge
//no longer including the destination) when the inactive GC task runs
result.add(getConsumerAdvisoryTopic(destination));
result.add(getProducerAdvisoryTopic(destination));
result.add(getExpiredMessageTopic(destination));
@ -103,6 +109,7 @@ public final class AdvisorySupport {
result.add(getMessageDiscardedAdvisoryTopic(destination));
result.add(getMessageDeliveredAdvisoryTopic(destination));
result.add(getMessageConsumedAdvisoryTopic(destination));
result.add(getMessageDispatchedAdvisoryTopic(destination));
result.add(getMessageDLQdAdvisoryTopic(destination));
result.add(getFullAdvisoryTopic(destination));