Apache
/
activemq
mirror of https://github.com/apache/activemq.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Need to test the underlying connection to ensure we aren't using an old 

one that isn't cleaned up since each checked grabs a new
PooledConnection wrapper.
This commit is contained in:
Timothy Bish 2016-05-10 15:41:58 -04:00
parent 71893f1434
commit c81a9348ee
1 changed files with 11 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
activemq-jms-pool/src/test/java/org/apache/activemq/jms/pool/PooledConnectionSecurityExceptionTest.java
View File

@ -107,7 +107,7 @@ public class PooledConnectionSecurityExceptionTest {
@Test @Test
public void testFailureGetsNewConnectionOnRetry() throws Exception { public void testFailureGetsNewConnectionOnRetry() throws Exception {
final Connection connection1 = pooledConnFact.createConnection("invalid", "credentials"); final PooledConnection connection1 = (PooledConnection) pooledConnFact.createConnection("invalid", "credentials");
try { try {
connection1.start(); connection1.start();
@ -121,11 +121,12 @@ public class PooledConnectionSecurityExceptionTest {
@Override @Override
public boolean isSatisified() throws Exception { public boolean isSatisified() throws Exception {
return connection1 != pooledConnFact.createConnection("invalid", "credentials"); return connection1.getConnection() !=
((PooledConnection) pooledConnFact.createConnection("invalid", "credentials")).getConnection();
} }
})); }));
Connection connection2 = pooledConnFact.createConnection("invalid", "credentials"); PooledConnection connection2 = (PooledConnection) pooledConnFact.createConnection("invalid", "credentials");
try { try {
connection2.start(); connection2.start();
fail("Should fail to connect"); fail("Should fail to connect");
@ -133,7 +134,7 @@ public class PooledConnectionSecurityExceptionTest {
LOG.info("Caught expected security error"); LOG.info("Caught expected security error");
} }
assertNotSame(connection1, connection2); assertNotSame(connection1.getConnection(), connection2.getConnection());
} }
@Test @Test
@ -141,7 +142,6 @@ public class PooledConnectionSecurityExceptionTest {
pooledConnFact.setMaxConnections(10); pooledConnFact.setMaxConnections(10);
Connection connection1 = pooledConnFact.createConnection("invalid", "credentials"); Connection connection1 = pooledConnFact.createConnection("invalid", "credentials");
try { try {
connection1.start(); connection1.start();
fail("Should fail to connect"); fail("Should fail to connect");
@ -189,13 +189,13 @@ public class PooledConnectionSecurityExceptionTest {
public void testFailoverWithInvalidCredentials() throws Exception { public void testFailoverWithInvalidCredentials() throws Exception {
ActiveMQConnectionFactory cf = new ActiveMQConnectionFactory( ActiveMQConnectionFactory cf = new ActiveMQConnectionFactory(
"failover:(" + connectionURI + ")"); "failover:(" + connectionURI + "?trace=true)");
pooledConnFact = new PooledConnectionFactory(); pooledConnFact = new PooledConnectionFactory();
pooledConnFact.setConnectionFactory(cf); pooledConnFact.setConnectionFactory(cf);
pooledConnFact.setMaxConnections(1); pooledConnFact.setMaxConnections(1);
final Connection connection1 = pooledConnFact.createConnection("invalid", "credentials"); final PooledConnection connection1 = (PooledConnection) pooledConnFact.createConnection("invalid", "credentials");
try { try {
connection1.start(); connection1.start();
@ -210,12 +210,13 @@ public class PooledConnectionSecurityExceptionTest {
@Override @Override
public boolean isSatisified() throws Exception { public boolean isSatisified() throws Exception {
return connection1 != pooledConnFact.createConnection("invalid", "credentials"); return connection1.getConnection() !=
((PooledConnection) pooledConnFact.createConnection("invalid", "credentials")).getConnection();
} }
})); }));
final Connection connection2 = pooledConnFact.createConnection("invalid", "credentials"); final PooledConnection connection2 = (PooledConnection) pooledConnFact.createConnection("invalid", "credentials");
assertNotSame(connection1, connection2); assertNotSame(connection1.getConnection(), connection2.getConnection());
try { try {
connection2.start(); connection2.start();