Apache
/
activemq
mirror of https://github.com/apache/activemq.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

https://issues.apache.org/jira/browse/AMQ-4182 - remove remaining use of finalize()

This commit is contained in:
Dejan Bosanac 2014-04-24 16:05:42 +02:00
parent f70dc74312
commit ec35588e56
2 changed files with 4 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
activemq-broker/src/main/java/org/apache/activemq/transport/TransportLogger.java
View File

@ -145,16 +145,11 @@ public class TransportLogger extends TransportFilter {
return next.toString();
}
/**
* We need to override this method
* so that we can unregister the associated
* MBean to avoid a memory leak.
*/
public void finalize() throws Throwable {
@Override
public void stop() throws Exception {
super.stop();
if (view != null) {
view.unregister();
view.unregister();
}
}
}

8
activemq-client/src/main/java/org/apache/activemq/ActiveMQConnection.java
View File

@ -1627,14 +1627,6 @@ public class ActiveMQConnection implements Connection, TopicConnection, QueueCon
started.set(false);
}
@Override
public void finalize() throws Throwable{
Scheduler s = this.scheduler;
if (s != null){
s.stop();
}
}
/**
* Changes the associated username/password that is associated with this
* connection. If the connection has been used, you must called cleanup()