AMQ-4122 - add log warning if lease will expire due to mal configuration

git-svn-id: https://svn.apache.org/repos/asf/activemq/trunk@1450213 13f79535-47bb-0310-9956-ffa450edef68

activemq-broker/src/main/java/org/apache/activemq/broker/Lockable.java

@@ -54,4 +54,5 @@ public interface Lockable {
      */
     public void setLockKeepAlivePeriod(long lockKeepAlivePeriod);
 
+    long getLockKeepAlivePeriod();
 }

activemq-broker/src/main/java/org/apache/activemq/broker/LockableServiceSupport.java

@@ -74,6 +74,11 @@ public abstract class LockableServiceSupport extends ServiceSupport implements L
         this.lockKeepAlivePeriod = lockKeepAlivePeriod;
     }
 
+    @Override
+    public long getLockKeepAlivePeriod() {
+        return lockKeepAlivePeriod;
+    }
+
     @Override
     public void preStart() throws Exception {
         init();

activemq-jdbc-store/src/main/java/org/apache/activemq/store/jdbc/LeaseDatabaseLocker.java

@@ -64,6 +64,12 @@ public class LeaseDatabaseLocker extends AbstractLocker {
     public void doStart() throws Exception {
         stopping = false;
 
+        if (lockAcquireSleepInterval < persistenceAdapter.getLockKeepAlivePeriod()) {
+            LOG.warn("Persistence adapter keep alive period: " + persistenceAdapter.getLockKeepAlivePeriod()
+                    + ", which renews the lease, is less than lockAcquireSleepInterval: " + lockAcquireSleepInterval
+                    + ", the lease duration. These values will allow the lease to expire.");
+        }
+
         LOG.info(getLeaseHolderId() + " attempting to acquire exclusive lease to become the Master broker");
         String sql = statements.getLeaseObtainStatement();
         LOG.debug(getLeaseHolderId() + " locking Query is "+sql);