From f4971bf2dcc66be39beec48b98c470c2490a0f24 Mon Sep 17 00:00:00 2001 From: "Hiram R. Chirino" Date: Thu, 20 Mar 2008 19:31:36 +0000 Subject: [PATCH] Avoid local consumer starvation. We were not properly keeping the list sorted. git-svn-id: https://svn.apache.org/repos/asf/activemq/trunk@639422 13f79535-47bb-0310-9956-ffa450edef68 --- .../java/org/apache/activemq/broker/region/Queue.java | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/activemq-core/src/main/java/org/apache/activemq/broker/region/Queue.java b/activemq-core/src/main/java/org/apache/activemq/broker/region/Queue.java index 5b7c8c8a73..0dcf0a4407 100755 --- a/activemq-core/src/main/java/org/apache/activemq/broker/region/Queue.java +++ b/activemq-core/src/main/java/org/apache/activemq/broker/region/Queue.java @@ -1145,14 +1145,8 @@ public class Queue extends BaseDestination implements Task { private void addToConsumerList(Subscription sub) { if (useConsumerPriority) { - int index = Collections - .binarySearch(consumers, sub, orderedCompare); - // insert into the ordered list - if (index < 0) { - consumers.add(-index - 1, sub); - } else { - consumers.add(sub); - } + consumers.add(sub); + Collections.sort(consumers, orderedCompare); } else { consumers.add(sub); }