mirror of https://github.com/apache/activemq.git
https://issues.apache.org/jira/browse/AMQ-3375: stomp consumer might not receive all msgs of a virtual topic queue with memory limits. Committing tims test case which works fine post resolution of https://issues.apache.org/jira/browse/AMQ-3434
git-svn-id: https://svn.apache.org/repos/asf/activemq/trunk@1153463 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Gary Tully
parent
4798cea181
commit
fa2b058dd5
|
|
@ -0,0 +1,284 @@
|
|||
/**
|
||||
* Licensed to the Apache Software Foundation (ASF) under one or more
|
||||
* contributor license agreements. See the NOTICE file distributed with
|
||||
* this work for additional information regarding copyright ownership.
|
||||
* The ASF licenses this file to You under the Apache License, Version 2.0
|
||||
* (the "License"); you may not use this file except in compliance with
|
||||
* the License. You may obtain a copy of the License at
|
||||
*
|
||||
* http://www.apache.org/licenses/LICENSE-2.0
|
||||
*
|
||||
* Unless required by applicable law or agreed to in writing, software
|
||||
* distributed under the License is distributed on an "AS IS" BASIS,
|
||||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||
* See the License for the specific language governing permissions and
|
||||
* limitations under the License.
|
||||
*/
|
||||
package org.apache.activemq.transport.stomp;
|
||||
|
||||
import static org.junit.Assert.assertTrue;
|
||||
|
||||
import java.io.File;
|
||||
import java.net.URI;
|
||||
import java.util.ArrayList;
|
||||
import java.util.HashMap;
|
||||
import java.util.HashSet;
|
||||
import java.util.List;
|
||||
import java.util.concurrent.CountDownLatch;
|
||||
|
||||
import javax.management.ObjectName;
|
||||
|
||||
import junit.framework.Assert;
|
||||
|
||||
import org.apache.activemq.broker.BrokerFactory;
|
||||
import org.apache.activemq.broker.BrokerService;
|
||||
import org.apache.activemq.broker.jmx.QueueViewMBean;
|
||||
import org.apache.activemq.broker.region.policy.FilePendingQueueMessageStoragePolicy;
|
||||
import org.apache.activemq.broker.region.policy.PolicyEntry;
|
||||
import org.apache.activemq.broker.region.policy.PolicyMap;
|
||||
import org.apache.activemq.store.kahadb.KahaDBPersistenceAdapter;
|
||||
import org.apache.activemq.usage.SystemUsage;
|
||||
import org.junit.After;
|
||||
import org.junit.Before;
|
||||
import org.junit.Test;
|
||||
import org.slf4j.Logger;
|
||||
import org.slf4j.LoggerFactory;
|
||||
|
||||
public class StompVirtualTopicTest {
|
||||
|
||||
private static final Logger LOG = LoggerFactory.getLogger(StompVirtualTopicTest.class);
|
||||
private static final int NUM_MSGS = 100000;
|
||||
|
||||
private BrokerService broker = null;
|
||||
private String failMsg = null;
|
||||
private URI brokerUri;
|
||||
|
||||
@Before
|
||||
public void setUp() throws Exception {
|
||||
LOG.info("Starting up");
|
||||
|
||||
broker = createBroker();
|
||||
broker.start();
|
||||
broker.waitUntilStarted();
|
||||
|
||||
brokerUri = new URI(broker.getTransportConnectors().get(0).getPublishableConnectString());
|
||||
}
|
||||
|
||||
protected BrokerService createBroker() throws Exception {
|
||||
BrokerService broker = BrokerFactory.createBroker(new URI("broker://()/localhost"));
|
||||
broker.setUseJmx(true);
|
||||
broker.setDeleteAllMessagesOnStartup(true);
|
||||
broker.addConnector("stomp://localhost:0?transport.closeAsync=false");
|
||||
|
||||
File testDataDir = new File("target/activemq-data/StompVirtualTopicTest");
|
||||
broker.setDataDirectoryFile(testDataDir);
|
||||
KahaDBPersistenceAdapter persistenceAdapter = new KahaDBPersistenceAdapter();
|
||||
persistenceAdapter.setDirectory(new File(testDataDir, "kahadb"));
|
||||
broker.setPersistenceAdapter(persistenceAdapter);
|
||||
|
||||
applyMemoryLimitPolicy(broker);
|
||||
|
||||
return broker;
|
||||
}
|
||||
|
||||
private void applyMemoryLimitPolicy(BrokerService broker) {
|
||||
final SystemUsage memoryManager = new SystemUsage();
|
||||
memoryManager.getMemoryUsage().setLimit(5818230784L);
|
||||
memoryManager.getStoreUsage().setLimit(6442450944L);
|
||||
memoryManager.getTempUsage().setLimit(3221225472L);
|
||||
broker.setSystemUsage(memoryManager);
|
||||
|
||||
final List<PolicyEntry> policyEntries = new ArrayList<PolicyEntry>();
|
||||
final PolicyEntry entry = new PolicyEntry();
|
||||
entry.setQueue(">");
|
||||
entry.setProducerFlowControl(false);
|
||||
entry.setMemoryLimit(10485760);
|
||||
entry.setPendingQueuePolicy(new FilePendingQueueMessageStoragePolicy());
|
||||
policyEntries.add(entry);
|
||||
|
||||
final PolicyMap policyMap = new PolicyMap();
|
||||
policyMap.setPolicyEntries(policyEntries);
|
||||
broker.setDestinationPolicy(policyMap);
|
||||
}
|
||||
|
||||
@After
|
||||
public void tearDown() throws Exception {
|
||||
if (broker != null) {
|
||||
broker.stop();
|
||||
}
|
||||
}
|
||||
|
||||
@Test
|
||||
public void testStompOnVirtualTopics() throws Exception {
|
||||
LOG.info("Running Stomp Producer");
|
||||
|
||||
StompConsumer consumerWorker = new StompConsumer(this);
|
||||
Thread consumer = new Thread(consumerWorker);
|
||||
|
||||
consumer.start();
|
||||
consumerWorker.awaitStartCompleted();
|
||||
Thread.sleep(500);
|
||||
|
||||
StompConnection stompConnection = new StompConnection();
|
||||
stompConnection.open("localhost", brokerUri.getPort());
|
||||
stompConnection.sendFrame("CONNECT\n" + "login: system\n" + "passcode: manager\n\n" + Stomp.NULL);
|
||||
StompFrame frame = stompConnection.receive();
|
||||
assertTrue(frame.toString().startsWith("CONNECTED"));
|
||||
|
||||
for (int i=0; i<NUM_MSGS-1; i++) {
|
||||
stompConnection.send("/topic/VirtualTopic.FOO", "Hello World {" + (i + 1) + "}");
|
||||
}
|
||||
|
||||
LOG.info("Sending last packet with receipt header");
|
||||
HashMap<String, Object> headers = new HashMap<String, Object>();
|
||||
headers.put("receipt", "1234");
|
||||
stompConnection.appendHeaders(headers);
|
||||
String msg = "SEND\n" + "destination:/topic/VirtualTopic.FOO\n" +
|
||||
"receipt: msg-1\n" + "\n\n" + "Hello World {" + (NUM_MSGS-1) + "}" + Stomp.NULL;
|
||||
stompConnection.sendFrame(msg);
|
||||
|
||||
msg = stompConnection.receiveFrame();
|
||||
assertTrue(msg.contains("RECEIPT"));
|
||||
|
||||
// Does the sleep resolve the problem?
|
||||
try {
|
||||
Thread.sleep(6000);
|
||||
} catch (java.lang.InterruptedException e) {
|
||||
LOG.error(e.getMessage());
|
||||
}
|
||||
stompConnection.disconnect();
|
||||
Thread.sleep(2000);
|
||||
stompConnection.close();
|
||||
LOG.info("Stomp Producer finished. Waiting for consumer to join.");
|
||||
|
||||
//wait for consumer to shut down
|
||||
consumer.join();
|
||||
LOG.info("Test finished.");
|
||||
|
||||
// check if consumer set failMsg, then let the test fail.
|
||||
if (null != failMsg) {
|
||||
LOG.error(failMsg);
|
||||
Assert.fail(failMsg);
|
||||
}
|
||||
}
|
||||
|
||||
/*
|
||||
* Allow Consumer thread to indicate the test has failed.
|
||||
* JUnits Assert.fail() does not work in threads spawned.
|
||||
*/
|
||||
protected void setFail(String msg) {
|
||||
this.failMsg = msg;
|
||||
}
|
||||
|
||||
class StompConsumer implements Runnable {
|
||||
final Logger log = LoggerFactory.getLogger(StompConsumer.class);
|
||||
private StompVirtualTopicTest parent = null;
|
||||
private CountDownLatch latch = new CountDownLatch(1);
|
||||
private HashSet<String> received = new HashSet<String>();
|
||||
private HashSet<String> dups = new HashSet<String>();
|
||||
|
||||
public StompConsumer(StompVirtualTopicTest ref) {
|
||||
parent = ref;
|
||||
}
|
||||
|
||||
public void awaitStartCompleted() {
|
||||
try {
|
||||
this.latch.await();
|
||||
} catch (InterruptedException e) {
|
||||
}
|
||||
}
|
||||
|
||||
public void run() {
|
||||
|
||||
LOG.info("Running Stomp Consumer");
|
||||
|
||||
StompConnection stompConnection = new StompConnection();
|
||||
int counter = 0;
|
||||
|
||||
try {
|
||||
stompConnection.open("localhost", brokerUri.getPort());
|
||||
stompConnection.sendFrame("CONNECT\n" + "login: system\n" + "passcode: manager\n\n" + Stomp.NULL);
|
||||
StompFrame frame = stompConnection.receive();
|
||||
assertTrue(frame.toString().startsWith("CONNECTED"));
|
||||
stompConnection.subscribe("/queue/Consumer.A.VirtualTopic.FOO", "auto");
|
||||
|
||||
Thread.sleep(2000);
|
||||
latch.countDown();
|
||||
|
||||
for (counter=0; counter<StompVirtualTopicTest.NUM_MSGS; counter++) {
|
||||
frame = stompConnection.receive(15000);
|
||||
log.trace("Received msg with content: " + frame.getBody());
|
||||
if(!received.add(frame.getBody())) {
|
||||
dups.add(frame.getBody());
|
||||
}
|
||||
}
|
||||
|
||||
// another receive should not return any more msgs
|
||||
try {
|
||||
frame = stompConnection.receive(3000);
|
||||
Assert.assertNull(frame);
|
||||
} catch (Exception e) {
|
||||
LOG.info("Correctly received " + e + " while trying to consume an additional msg." +
|
||||
" This is expected as the queue should be empty now.");
|
||||
}
|
||||
|
||||
// in addition check QueueSize using JMX
|
||||
long queueSize = reportQueueStatistics();
|
||||
|
||||
if (queueSize != 0) {
|
||||
parent.setFail("QueueSize not 0 after test has finished.");
|
||||
}
|
||||
|
||||
log.debug("Stomp Consumer Received " + counter + " of " + StompVirtualTopicTest.NUM_MSGS +
|
||||
" messages. Check QueueSize in JMX and try to browse the queue.");
|
||||
|
||||
if(!dups.isEmpty()) {
|
||||
for(String msg : dups) {
|
||||
LOG.debug("Received duplicate message: " + msg);
|
||||
}
|
||||
|
||||
parent.setFail("Received " + StompVirtualTopicTest.NUM_MSGS +
|
||||
" messages but " + dups.size() + " were dups.");
|
||||
}
|
||||
|
||||
} catch (Exception ex) {
|
||||
log.error(ex.getMessage() + " after consuming " + counter + " msgs.");
|
||||
|
||||
try {
|
||||
reportQueueStatistics();
|
||||
} catch (Exception e) {
|
||||
}
|
||||
|
||||
parent.setFail("Stomp Consumer received " + counter + " of " + StompVirtualTopicTest.NUM_MSGS +
|
||||
" messages. Check QueueSize in JMX and try to browse the queue.");
|
||||
|
||||
} finally {
|
||||
try {
|
||||
stompConnection.disconnect();
|
||||
Thread.sleep(2000);
|
||||
stompConnection.close();
|
||||
} catch (Exception e) {
|
||||
log.error("unexpected exception on sleep", e);
|
||||
}
|
||||
}
|
||||
|
||||
log.info("Test Finished.");
|
||||
}
|
||||
|
||||
private long reportQueueStatistics() throws Exception {
|
||||
|
||||
ObjectName queueViewMBeanName = new ObjectName("org.apache.activemq:Type=Queue" +
|
||||
",Destination=Consumer.A.VirtualTopic.FOO" +
|
||||
",BrokerName=localhost");
|
||||
QueueViewMBean queue = (QueueViewMBean)
|
||||
broker.getManagementContext().newProxyInstance(queueViewMBeanName, QueueViewMBean.class, true);
|
||||
|
||||
LOG.info("Consumer.A.VirtualTopic.FOO Inflight: " + queue.getInFlightCount() +
|
||||
", enqueueCount: " + queue.getEnqueueCount() + ", dequeueCount: " +
|
||||
queue.getDequeueCount() + ", dispatchCount: " + queue.getDispatchCount());
|
||||
|
||||
return queue.getQueueSize();
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
Loading…
Reference in New Issue