ee61ed69f8
AMQ-7301 - TransportConnector errors should log the root cause
...
(cherry picked from commit 57a1a77abb
2020-03-11 06:49:35 -04:00
1550ae42f7
Revert "[AMQ-7314] Fix counter increment when lastDelivereSeqId > BrokerSequenceId"
...
This reverts commit df1750fe01
2020-03-10 06:29:34 +01:00
b43f5b8cf2
Avoid potential overflow in int multiplication before it is converted to long.
2020-03-08 11:50:21 +01:00
a73a85e6c2
AMQ-7438 - Harden deserialization
2020-03-06 17:22:07 +00:00
b60efeaad8
[AMQ-7301] Improve logging when initialize Stomp NIO SSL connection
2020-03-05 15:00:53 +01:00
c0e7949468
Merge pull request #500 from jbonofre/AMQ-7303
...
[AMQ-7303] Improve logging in case of security exception on transport connection
2020-03-04 21:44:37 +01:00
7435d7b058
Merge pull request #499 from jbonofre/AMQ-7346
...
[AMQ-7346] Improve logging of the network connector
2020-03-04 21:42:37 +01:00
945cd6b7de
[AMQ-7303] Improve logging in case of security exception on transport connection
2020-03-04 18:57:02 +01:00
3c4a644f3d
[AMQ-7346] Improve logging of the network connector
2020-03-04 17:54:37 +01:00
3c302dce33
[AMQ-7347] Don't log error in case of topic subscription failure. It's useless as the JMX exception is thrown and pollute the log.
2020-03-04 16:22:17 +01:00
df1750fe01
[AMQ-7314] Fix counter increment when lastDelivereSeqId > BrokerSequenceId
2020-03-02 15:31:16 +01:00
51081e4edf
Merge pull request #479 from coheigea/AMQ-7423
...
AMQ-7423 - Remove synchronization from JAAS PropertiesLoader
2020-02-28 07:30:57 +01:00
7ef90e243f
Add missing format argument for log message in AbortSlowAckConsumerStrategy#abortAllQualifiedSlowConsumers.
2020-02-27 22:03:41 +01:00
67fb6f8871
AMQ-7423 - Remove synchronization from JAAS PropertiesLoader
2020-02-27 15:29:26 +00:00
d878d877d5
[AMQ-7410] Align dependencies with Apache Karaf
2020-02-26 13:11:33 +01:00
4522061527
Fix issue where the registry lookup was a hardcoded name and didn't account for the connector path
2020-02-24 11:10:46 +00:00
bfb810c507
Merge pull request #466 from coheigea/misc_fixes
...
AMQ-7413 - Misc logging fixes
2020-02-22 07:49:55 +01:00
b020cba744
Fix some incorrect SLF4J logger calls
...
In some cases, there were an inconsistent number of formatting anchors.
In other cases, formatting anchors were used, but because the
trace/debug/info/warn/error(String, Throwable) variant was used, the
string is a message string rather than a format string.
These issues were found by SLF4J Helper for NetBeans IDE:
http://plugins.netbeans.org/plugin/72557/
2020-02-19 08:26:36 +00:00
057cf666a0
Fix an apparent copy/paste typo
2020-02-19 08:02:20 +00:00
7b528ecee7
Fix some typos
2020-02-19 08:01:41 +00:00
758bd279f8
AMQ-7412 - Fix NPE in SimpleAuthenticationPlugin
2020-02-19 07:29:44 +00:00
1c3a71620f
Merge pull request #451 from jgallimore/AMQ-7404
...
AMQ-7404 add debug logging for selectors loaded from the cache file
2020-02-14 08:21:00 +01:00
a9d89572ef
Merge pull request #449 from PascalSchumacher/setter_getter_synchronization
...
AMQ-7402: Inconsistent synchronization of getters/setters of some cla…
2020-02-13 08:15:57 +01:00
4ecdd5a2a8
Merge pull request #448 from PascalSchumacher/fix_unused_format_arguments_in_log_messages
...
Fix unused format arguments in log messages.
2020-02-13 07:53:32 +01:00
6764511fa1
Fix unused format arguments in log messages.
2020-02-12 17:52:28 +01:00
5356893fac
AMQ-7402: Inconsistent synchronization of getters/setters of some classes
...
Make synchronization consistent or remove it and declare the field volatile.
2020-02-12 17:48:34 +01:00
097506a458
[AMQ-7399] org.apache.activemq.SERIALIZABLE_PACKAGES doesn't include java* by default
2020-02-12 13:43:03 +01:00
e6befbc875
AMQ-7404 add debug logging for selectors loaded from the cache file
2020-02-12 11:15:59 +00:00
f1d0100832
Provide RMI registry implementation to prevent re-bind
2020-02-11 21:10:56 +01:00
6417d62f60
Merge pull request #428 from coheigea/AMQ-7376
...
AMQ-7376 - Use correct type for collections retrieval
2020-02-09 08:33:04 +01:00
85851f7ce8
[AMQ-7391] Minor typo fixed
...
Credit: Alexandre Fruchaud <mmacphail>
2020-01-28 10:46:48 +01:00
127852d2e7
AMQ-7142 - Inserting Bouncy Castle Provider Early in Java Security Provider Chain Breaks KeyStore Loading
2020-01-27 10:43:39 +00:00
675fb7bcae
AMQ-7376 - Use correct type for collections retrieval
2020-01-20 18:35:01 +00:00
0c6f9a9a1e
AMQ-7352 - Add support for anonymous producer advisories
...
By default this behavior is turned off but can be enabled by setting
anonymousProducerAdvisorySupport on the BrokerService to true
2019-11-22 13:35:32 -05:00
dcb5ba1fb3
Merge pull request #275 from PascalSchumacher/BrokerService_fix_typo
...
BrokerService: fix typo in field and parameter name
2019-11-18 17:42:44 +01:00
f3f8271503
[AMQ-7301] Use warn for connection failure instead of error.
2019-11-12 15:19:13 +01:00
a5f0602505
Merge pull request #395 from couclock/AMQ-7312
...
AMQ-7312 virtualSelectorCacheBrokerPlugin addConsumer issue
2019-10-18 19:09:32 +02:00
4af6f40186
AMQ-6494 is related, fix intermittent failure of RedeliveryPolicyTest related to vm transport server being shutdown while in use via async onException handler
2019-10-03 11:08:05 +01:00
86a069ac5d
AMQ-7312 virtualSelectorCacheBrokerPlugin addConsumer issue
2019-09-29 16:18:24 +02:00
644b529ef6
AMQ-7185 - rework to leave tx-inflight messages pending in the cursor to avoid duplicates on completion, fix and test
2019-09-24 17:32:54 +01:00
289750d7c9
AMQ-7308 - ensure kahadb message add does not auto create the message store in error, expect an existing store. fix and test
2019-09-20 10:22:56 +01:00
501d55337a
AMQ-7302 - make jmx ops that pageIn aware of cursor memory limits to avoid excessive looping, fix and test
2019-09-10 11:46:04 +01:00
fb2296ac74
AMQ-7270 - remove toggle on maxPageSize, request page in of entire queue only when cache is in play or broker is non persistent, fix and test
2019-08-07 17:47:59 +01:00
09003e8fef
AMQ-7102 - Improve ManagedRegionBroker performance by replacing
...
registeredMBeans CopyOnWriteSet with a Concurrent hashmap backed set
2019-07-31 12:56:57 -04:00
75023f2bed
Remove default "secret" password from the LDAPAuthorizationMap
2019-07-15 18:24:48 +01:00
c7eff84058
AMQ-7238 - Ensure remoteId subscription map is also cleared when local
...
map is cleared inside DemandForwardingBridgeSupport
2019-07-08 08:38:34 -04:00
de3f77063f
AMQ-7234 - fix up memory usage wait timeout such that topic pfc in a transaction can see connection context state changes, fix and test
2019-06-21 16:55:13 +01:00
dc56fa3f6e
AMQ-7228 - Avoid unnecessary lock contention when getting pending
...
metrics
2019-06-14 10:46:21 -04:00
7404b43f2d
AMQ-7193 - resolve intermittent NPE on duplex network connector start; wait for start completion before dispatching inbound messages, fix and test
2019-05-02 16:31:26 +01:00
bf3a9f44f6
AMQ-7191 - Prevent extra creation of openwire verifier objects per new
...
connection when using the auto transport
2019-04-30 08:41:08 -04:00
487d4a112e
AMQ-7185 - track durable sub prepared acks in preCommit callback and release/remove on xa outcome, avoid duplicate delivery; fix and test
2019-04-17 14:31:11 +01:00
ccf56875b0
NO-JIRA - Update spring schemas and missing license files
2019-03-15 07:24:31 -04:00
2d394b383c
AMQ-7167 - ensure remote IP is visible in acceptor error messages from the transport connector - test and fix
2019-03-13 10:21:19 +00:00
a000a73431
no jira - init throwable cause to identify error on shutdown
2019-03-13 10:14:06 +00:00
87467dc61e
AMQ-7159 - Adding a new attribute on PersistenceAdapterViewMBean to show information about Storage write/read latency
2019-03-06 11:41:08 -08:00
7fdad3a73d
AMQ-7151 - Remove dependency on Guava from activemq-broker
...
Guava is supposed to only be used for the leveldb store and as a test
dependency elsewhere but there is one spot it is used in activemq-broker for
filtering collections. With Java 8 this can be easily rewritten to avoid the use of Guava.
This commit is based on the patch submitted by Filip Hrisafov
2019-02-18 07:49:47 -05:00
daea192eef
AMQ-7085 - Properly start TempUsage inside Queue start
...
This fix allows temp usage changes to the broker temp usage to propagate
properly to a Queue's temp usage settings
Patch applied with thanks to David Sitsky
2019-01-17 07:58:36 -05:00
5c23dd53ad
AMQ7135 : do a purge before deleting the destination
...
(cherry picked from commit 9f513f8878
2019-01-14 13:44:52 -03:30
4a21edc8d5
[AMQ-7126] Improvement to perf of 5266Test
2019-01-07 21:22:34 -03:30
8cc0c5ad6c
AMQ-7106 - fix pending stop support by avoiding sync through single shared status var - fix and test
2018-11-21 10:23:13 +00:00
9cb680c0ba
AMQ-7102 - don't track objectNames that have not been registered due to suppressMBean filter, fix and test
2018-11-15 17:45:18 +00:00
bc8c78cd32
AMQ-7009 - apply fix to memorymessagestore setBatch with thanks to Nezih BEN FREDJ for test and suggestion
2018-11-14 14:21:27 +00:00
d2b0affedb
AMQ-7094 - track the objectName with an annotated mbean such that the jmx audit log event can extract that target of an mbean operation, fix and test
2018-11-08 12:10:01 +00:00
f2cde24a62
AMQ-7088 - fix deadlock on remove add interaction from mqtt virtual topic sub use case
2018-11-01 10:11:08 +00:00
bf8eb08aca
AMQ-7086 - make kahadb gc/cleanup on shutdown optional to trade availability over disk usage for fast failover
2018-10-31 14:29:05 +00:00
9dd751149f
AMQ-7079 AMQ-7077 AMQ-6421 - check for consumers that have been destroyed
2018-10-18 16:49:29 +01:00
4dee173962
AMQ-7077 AMQ-6421 - tie queue consumer slow flag detection to abort slow consumer policy, fire advisory when set.
2018-10-17 11:04:47 +01:00
3ac3a420a1
AMQ-7071 - Mark previously dispatched messages as redelivered if
...
connection for durable topic subscription is improperly closed leading
to a lastDeliveredSequenceId as unknown
2018-10-12 08:35:37 -04:00
5246151288
AMQ-7062 - have redelivery plugin ignore messages detected as duplicates
2018-09-26 11:22:59 +01:00
cae66f5d37
AMQ-6086 - variant with broker.schedulerSupport=true; same fix with additional test
2018-09-25 16:29:24 +01:00
cdbddcafa2
AMQ-7057 - support transport connector warnOnRemoteClose to suppress eof warnings on loadbalance or health check socket ping
2018-09-20 14:58:34 +01:00
69fad2a135
Add support for hostname verification
2018-08-31 06:39:49 -04:00
54c56a0573
AMQ-7037 - add sslContext attribute to networkConnector, allow broker or jvm defaults to be overridden
2018-08-20 16:40:26 +01:00
50d27e7e54
AMQ-7035 - use NonCachedMessageEvaluationContext in place of MessageEvaluationContext to avoid unnecessary reference count management and subsequent leaks. Rework AMQ-6465 with additional JMX related tests
2018-08-15 16:21:57 +01:00
bdfa3394ad
AMQ-7030 - trap exceptions on future.get, fix and test
2018-08-02 14:45:31 +01:00
5b1412ddfd
Avoid overflow errors - see KAFKA-4290
...
Add test for overflow values
Bind test sockets to free ports
2018-07-27 08:32:36 -04:00
b79fcd0a76
AMQ-7017 - Prevent ArithmeticException in ProducerBrokerExchange
...
Check for zero to prevent divide by zero error inside
getPercentageBlocked() method
Thank you to Matthew Stratton for the patch
2018-07-27 07:40:49 -04:00
0b76d3a0ea
AMQ-7021 - add unsynchronised accessors to destination map for usage with rw lock from abstract region; allow concurrent read of the destination map
2018-07-26 10:42:10 +01:00
c29d7477d0
no jira - fix warn formatting error
2018-07-05 11:54:22 +01:00
83514ef799
AMQ-7001 - ensure cursor pending cached id list is pruned of futures that end in an exception, fix and test
2018-07-03 21:18:36 +01:00
76490a2c7f
AMQ-7002 - Change jobid identifier to messageid format
2018-06-27 10:29:40 -06:00
e0aa091d9e
AMQ-7002 - ensure uniqueue jobids, fix and test via patch from Jamie goodyear applied with thanks
2018-06-27 14:14:44 +01:00
57a6f2373e
AMQ-6854 - ensure non null return in the event on no space to page in
2018-06-13 13:10:52 +01:00
1ebf186279
AMQ-3405 - rework fix to use original destination strategy which may be different from the default shared strategy. new test
2018-06-07 11:38:42 +01:00
6d14e4e85b
AMQ-6979 - fix test regression, avoid gc during shutdown such that the error check on the logging remains valid
2018-05-31 13:44:01 +01:00
cdb38b3275
AMQ-6979 - use scheduler as trigger task - do heavy lifting via the task runner executor, take care to trap errors to keep scheduler timer alive AMQ-5129
2018-05-30 22:03:50 +01:00
026c6f4403
AMQ-6967 - ensure there are some messages paged in for periodic expiry check if non are in memory
2018-05-21 14:26:45 +01:00
01384c714d
AMQ-6707 - fix destination filter delegate param, refactor-auto-gen method; jees
2018-05-18 14:44:05 +01:00
2eff835ee2
AMQ-6703 - fix regression in MBeanTest - StoreQueueCursor not sharing its audit - have purge use rollback and delegate to both cursors
2018-05-18 11:36:54 +01:00
8d3674be3d
AMQ-6707 - remove duplicated started state flag
2018-05-15 14:55:02 +01:00
09bf8f89b8
AMQ-6707 - ensure trace logging does not flip cacheEnabled flag outside required sync
2018-05-15 12:00:22 +01:00
573b366ca0
AMQ-6100 - use setOriginalDestination=false to make this behaviour optional b/c amqp cannot see the original dest property due to immutability of the message properties and folks can depend on the existing original destination behaviour
2018-05-10 10:55:15 +01:00
c1e7dbd53b
AMQ-6707 - fix trace log reporting in error
2018-05-09 12:17:29 +01:00
ea70e827c0
AMQ-6707 - JDBC XA recovery and completion.
...
ensure pending transactions are visible for recovery without restart
sync store and cursor size during and after completion
ensure pending messages are not visible to browsers
retain transaction state on jdbc error
a bunch of new tests around xa completion
2018-04-26 14:58:48 +01:00
1d2226e6cf
Revert "AMQ-6947 - Make sure counters are updated correct on message drop"
...
This reverts commit 021c82859c
2018-04-18 12:34:18 -04:00
7123534e1b
Revert "AMQ-6947 - Update Queue metrics on expiration"
...
This reverts commit 6e468b4540
2018-04-18 12:34:07 -04:00
6e468b4540
AMQ-6947 - Update Queue metrics on expiration
...
The updated dropMessage method only decrements the destination metrics
if a message is removed from the pagedInMessages list to prevent
duplicate updates. There is also a case where we still need to update
metrics if the message never makes it into the pagedInMessages list in
the first place and that is on expiration so this patch fixes that. A
couple existing tests found this issue.
2018-04-18 09:04:11 -04:00
021c82859c
AMQ-6947 - Make sure counters are updated correct on message drop
...
Only update metrics counters when message is removed from the
pagedInMessages list which is important to check in case of duplicates
2018-04-17 08:25:08 -04:00
65b0f2ad0d
AMQ-6940 - Add flag to disable TopicSubscription in flight stats
...
To save memory usage in some use cases add a new flag to PolicyEntry
called useTopicSubscriptionInflightStats to allow disabling the
inflight stats
2018-03-29 13:25:36 -04:00
f69fd6f002
AMQ-6940 - Reduce memory footprint for inflight statistics
...
For the TopicSubscription case we can reduce the inflight statistics
memory footprint by not storing the entire message reference for in
flight messages and instead just a subset of the information needed.
2018-03-29 09:00:26 -04:00
Christopher L. Shannon (cshannon)
jbonofre
Pascal Schumacher
Colm O hEigeartaigh
Jonathan Gallimore
Daniel Trebbien
gtully
Dany LECOQ
Alan Protasio
hkesler
jgoodyear
giliva
Jeff Genender