Commit Graph

301 Commits

Author SHA1 Message Date
Daniel Trebbien b020cba744 Fix some incorrect SLF4J logger calls
In some cases, there were an inconsistent number of formatting anchors.

In other cases, formatting anchors were used, but because the
trace/debug/info/warn/error(String, Throwable) variant was used, the
string is a message string rather than a format string.

These issues were found by SLF4J Helper for NetBeans IDE:
http://plugins.netbeans.org/plugin/72557/
2020-02-19 08:26:36 +00:00
Daniel Trebbien 3faad9b357 Use simpler SLF4J API functions
Eliminates the need to construct a new (temporary) Object array object.

These changes were suggested by SLF4J Helper for NetBeans IDE:
http://plugins.netbeans.org/plugin/72557/
2020-02-19 07:54:25 +00:00
Jean-Baptiste Onofré 4ecdd5a2a8
Merge pull request #448 from PascalSchumacher/fix_unused_format_arguments_in_log_messages
Fix unused format arguments in log messages.
2020-02-13 07:53:32 +01:00
Pascal Schumacher 6764511fa1 Fix unused format arguments in log messages. 2020-02-12 17:52:28 +01:00
jbonofre 097506a458 [AMQ-7399] org.apache.activemq.SERIALIZABLE_PACKAGES doesn't include java* by default 2020-02-12 13:43:03 +01:00
gtully b9851a8fc2 fix intermittent failure, two brokers in the mix 2019-12-02 15:14:42 +00:00
Jean-Baptiste Onofré f5b1800b0e
Merge pull request #278 from asutosh936/AMQ-6905
AMQ-6905 : Upgraded ActivationConfigProperty as per API Documentation
2019-11-18 17:48:34 +01:00
gtully 5bd2abf85d AMQ-5790 - rework the fix from AMQ-4486 to tie the inbound xaResource connection lifectyle to the rar start/stop 2019-02-26 12:26:18 +00:00
gtully b9c8f6228c no jira - fix up contention between rar and test creating the embedded broker - intermittent ci failure 2018-10-18 11:16:32 +01:00
Christopher L. Shannon (cshannon) e39db56934 AMQ-6970 - Adding SSL params for RAR
Fixing missing ssl parameters when configuring rar. Also fixing
configuration logic of inproper null checks inside
ActiveMQManagedConnectionFactory

Thank you to Flavia Rainone for the patch
2018-07-27 07:25:35 -04:00
gtully 8fd107559c AMQ-7000 - remove unnecessary time dependent assertion from test, breaks ci 2018-06-27 13:06:53 +01:00
gtully 5ebee0ace7 AMQ-7000 - ensure server sessions with closed active sessions get removed from the pool on stop, fix and test 2018-06-26 11:07:04 +01:00
asutosh936 a1f15f4511 AMQ-6905 : Upgraded ActivationConfigProperty as per API Documentation 2018-03-03 13:18:39 -06:00
Christopher L. Shannon (cshannon) a9fe4e33c3 [maven-release-plugin] prepare for next development iteration 2017-06-27 13:41:28 -04:00
Christopher L. Shannon (cshannon) 5f0d6943cb [maven-release-plugin] prepare release activemq-5.15.0 2017-06-27 13:41:01 -04:00
Christopher L. Shannon (cshannon) 4b8cd46a00 NO-JIRA: Adding missing license header 2017-06-27 13:34:09 -04:00
Torsten Mielke a1e595c18f [AMQ-6700] Leak of ActiveMQ Connection Executor threads and ActiveMQConnection objects in JCA layer 2017-06-12 10:02:27 +02:00
gtully 2bd3379932 [AMQ-6068] make full cleanup of the rar managed connection conditional on a user specified client id being present 2017-05-04 11:08:32 +01:00
gtully 85181d630c [AMQ-6548] ensure any pending xa transaction is marked rollback only on delivery failure exception from on message, before delegating to potential clientInternalExceptionListener. Variant of patch applied with additional test - thanks to Andrey Dyachikhin for the patch inspiration 2017-01-17 16:51:27 +00:00
Hadrian Zbarcea be24a133ef This closes #88 (merged as a65ac586). More file permissions fixes. 2016-11-03 14:26:34 -04:00
Hadrian Zbarcea d5a929c0d2 This closes #205. Won't fix. (fix even more file permissions) 2016-11-03 14:11:40 -04:00
Hadrian Zbarcea d54d046b8a This closes #185. Won't fix. (fix more file permissions) 2016-11-03 11:54:33 -04:00
Christopher L. Shannon (cshannon) 114706a7b4 https://issues.apache.org/jira/browse/AMQ-6478
Fixing compilation error with JDK 8
2016-10-25 06:47:43 -04:00
Christopher L. Shannon (cshannon) 06a21dbbb3 [maven-release-plugin] prepare for next development iteration 2016-08-02 09:03:37 -04:00
Christopher L. Shannon (cshannon) 71cbc65283 [maven-release-plugin] prepare release activemq-5.14.0 2016-08-02 09:02:54 -04:00
gtully 51b413309c fix intermittent ci failure w.r.t timing of initial delivery 2016-07-27 12:07:18 +01:00
Timothy Bish 0b65c8d93c Do a bit more resource cleanup on tearDown 2016-06-15 19:15:21 -04:00
Timothy Bish c9b208f0a3 Ensure that connections created with vm Transport connections get
closed.
2016-06-09 14:50:40 -04:00
Christopher L. Shannon (cshannon) 161730fda2 https://issues.apache.org/jira/browse/AMQ-6150
code cleanup
2016-02-01 13:04:07 +00:00
Marc Breslow 4a937def7d Fix Impossible Cast issues in MemoryTopicSub:
- recoverSubscription()
-- map is defined as LinkedHashMap<MessageId, Message>
-- msg is defined as <map> entry.getValue() so must be a Message
-- condition if (msg.getClass() == MessageId.class) could never be true
-- no need to cast at all when using generics

- recoverNextMessages()
-- basically same code copy/pasted so same fix

Removed 2 conditions from ServerSessionPoolImpl that would result in impossible casts. Conditions removed were trying to cast ActiveMQQueueSession and ActiveMQTopicSession to ActiveMQSession which is illegal.

Since it isn't obvious what to do if you get an ActiveMQQueueSession or ActiveMQTopicSession from getServerSession() I make it fall back to the else condition which raises an async exception. This is better than getting a ClassCastException at runtime.

Remove impossible cast in MemoryMessageStore
2016-02-01 12:57:50 +00:00
Timothy Bish 4ecff14030 NO-JIRA Update master version to 5.14.0-SNAPSHOT to match the eventual
release version.
2016-01-20 12:40:20 -05:00
gtully 5a27bdf07e https://issues.apache.org/jira/browse/AMQ-6068 - fix and test. Cleanup from ra managed connection needs to remove the connection info, leaving the tcp connection free for another identity. Possibly this could be conditional on having a user supplied clientId 2015-12-01 14:28:07 +00:00
Christopher L. Shannon (cshannon) cfb4ca9f54 [maven-release-plugin] prepare for next development iteration 2015-11-30 13:48:58 +00:00
Christopher L. Shannon (cshannon) abfe038ddf [maven-release-plugin] prepare release activemq-5.13.0 2015-11-30 13:48:11 +00:00
Christopher L. Shannon (cshannon) d983d525ce https://issues.apache.org/jira/browse/AMQ-5941
Modifying ActiveMQResourceAdapter to implement Serializable to support
WebLogic.
2015-08-24 13:02:02 +00:00
Christopher L. Shannon (cshannon) 04ee70a161 https://issues.apache.org/jira/browse/AMQ-5889
Adding support for auto detection of wire protocols over a transport.
OpenWire, AMQP, STOMP, and MQTT can all be detected and the broker
will properly handle each one over a given Transport.  Currently
auto TCP, NIO, SSL, and NIO+SSL transports can handle auto-detection
of the wire format and client but support could be added in the
future for other transports like websockets.
2015-08-11 19:39:29 +00:00
Timothy Bish 6cdd750ddc [maven-release-plugin] prepare for next development iteration 2015-08-10 11:04:26 -04:00
Timothy Bish a9eeb03520 [maven-release-plugin] prepare release activemq-5.12.0 2015-08-10 11:04:17 -04:00
Timothy Bish da36f78a6a https://issues.apache.org/jira/browse/AMQ-5596
Remove some additional references to old JMS Streams properties.
2015-08-03 17:11:44 -04:00
gtully c85c7c1472 AMQ-5400 - rework to remove static lock - impacted parallel delivery and hense performance. Fix and additional tet 2015-07-16 12:38:52 +01:00
gtully 59958ad269 https://issues.apache.org/jira/browse/AMQ-5552 - exclude two tests that show intermittent failures in ci 2015-07-14 11:03:01 +01:00
Timothy Bish ba1bd264d9 https://issues.apache.org/jira/browse/AMQ-5621
Clean up tests, remove hard coded ports, add test timeouts, move data
dirs into target so they get removed on clean.
2015-07-09 17:35:32 -04:00
gtully a05a9a2129 https://issues.apache.org/jira/browse/AMQ-5552 - added profile for activemq.tests=smoke to run a fast subset of tests that gives a fast verification of a full build 2015-07-09 14:10:38 +01:00
gtully 91d48280b8 https://issues.apache.org/jira/browse/AMQ-5400 - add test case showing the need for maxSessions config 2015-06-30 11:34:03 +01:00
Howard Gao a1062c273f https://issues.apache.org/jira/browse/AMQ-5811
Added synchronization blocks around sentitive code to
prevent concurrent modification of the HashMap.
2015-06-19 11:13:08 -04:00
Andy Taylor 9becfc0bed AMQ-5782 Added support to the Resource Adapter for SSL 2015-05-21 09:15:14 +01:00
gtully eb6c082631 https://issues.apache.org/jira/browse/AMQ-5735 - fix up semantics around lastDeliveredSequenceId 2015-04-22 16:32:17 +01:00
Dejan Bosanac c705523cd0 https://issues.apache.org/jira/browse/AMQ-5710 - connection cleanup should not remove connection from the broker 2015-04-07 17:21:59 +02:00
gtully 1d71cb7036 https://issues.apache.org/jira/browse/AMQ-5674 - revisit change - use single redelivey delay attribute for both initial and subsequent delays - resolves regression in BrokerRedeliveryTest 2015-04-03 14:19:15 +01:00
Dejan Bosanac 20832f1f1b https://issues.apache.org/jira/browse/AMQ-5674 - initialRedeliveryDelay not respected 2015-03-18 17:07:59 +01:00