Commit Graph

999 Commits

Author SHA1 Message Date
jbonofre 1a2de52c5f Fix slf4j logger use 2021-03-20 10:58:07 +01:00
Christopher L. Shannon (cshannon) 2cf3decd8e AMQ-8184 - Re-enable NIO tests
Re-enable the nio transport tests in activemq-unit-tests by default to
catch transport errors. Also fix broken tests
2021-03-11 11:16:29 -05:00
Christopher L. Shannon (cshannon) 2712464b78 AMQ-8183 - apply maxFrameSize high cpu usage fix to Auto nio transport
also
2021-03-11 11:13:35 -05:00
Christopher L. Shannon (cshannon) 1654e6c79c AMQ-8169: Synchronize on serviceRead inside NIOSSLTransport
This is needed to prevent concurrent access to the SSLEngine during
initialization. This is a regression from when auto+nio+ssl was added.
2021-03-08 11:28:33 -05:00
Jean-Baptiste Onofré 4dc6903c18
Merge pull request #610 from jbonofre/AMQ-7443
[AMQ-7443] Add connection remote addr in the prefetch warn log message
2021-01-14 06:05:37 +01:00
Jean-Baptiste Onofré d9febc0977
Merge pull request #609 from jbonofre/AMQ-7246
[AMQ-7246] Add scheduledMessageCount and delayedMessageCount attributes on the JobSchedulerViewMBean
2021-01-13 18:49:11 +01:00
jbonofre cbc1baa07a [AMQ-8097] Deal with deserialization with xstream unmarshal poison ack 2021-01-13 16:13:25 +01:00
jbonofre 7339e0516c [AMQ-7443] Add connection remote addr in the prefetch warn log message 2021-01-13 06:23:28 +01:00
jbonofre f01e35f7d9 [AMQ-7246] Add scheduledMessageCount attribute on the JobSchedulerView MBean 2021-01-12 18:58:34 +01:00
jbonofre 0146d5eb3e [AMQ-8060] Re add allowLinkStealing on transport connector for backward compatibility 2021-01-07 12:28:26 +01:00
Roman Nevezhyn 651c5ff2cf - Tests AMQ-8104
- Fixes AMQ-8104
2020-12-16 12:54:03 -08:00
jbonofre 2bc87c2c5f [AMQ-8068] Fix topic memory leak on message eviction using UniquePropertyMessageEvictionStrategy 2020-11-23 06:26:37 +01:00
Jean-Baptiste Onofré fbdb302968
Merge pull request #571 from dhmgit/durable-sub-message-expiration
Adding an option which allows messages to expire on active durable subscriptions
2020-11-22 07:10:43 +01:00
murali.mogalayapalli 55914d3ac1 [AMQ-8028] Add sendWhenNotMatched option to composite destination filter 2020-11-21 14:20:08 +01:00
jbonofre 43af228f2a Improve stability of KahaDB tests 2020-11-18 09:02:25 +01:00
dhmgit 2f2fe6855f adding an option which allows messages to expire on active durable subscriptions 2020-11-10 10:22:32 -05:00
Benjamin Graf a2e718f259 AMQ-8055 - rename posion to correct poison 2020-10-23 09:50:18 +02:00
gtully 5c8086961f AMQ-8023 - rework fix to deal with addSub interleaved with removeDestination advisory processing, serialise add/remove dest such that add is not lost and new sub resubscribes ok, extra verifications in the test 2020-08-27 16:31:50 +01:00
gtully c0e6d47121 AMQ-8023 - retain sync add call, duplicate sub suppression depends on it, regression in AMQ3274Test 2020-08-26 14:39:43 +01:00
gtully 0e2b24be36 AMQ-8023 - serialize sub add with destination removal advisory processing to avoid resub blocking a necessary purge via removal, fix and test via mqtt clean session scenario 2020-08-25 16:56:50 +01:00
Jean-Baptiste Onofré 213f381c95
Merge pull request #550 from coheigea/AMQ-7512
AMQ-7512 - Consolidate XBean byte parsing
2020-08-11 09:47:49 +02:00
Jean-Baptiste Onofré d2851888bf
Merge pull request #551 from coheigea/AMQ-7513
AMQ-7513 - Fix http://activemq.org links
2020-08-11 09:42:43 +02:00
Colm O hEigeartaigh e3e2fda509 AMQ-8020 - Replace toLowerCase().equals() with equalsIgnoreCase 2020-08-10 16:01:08 +01:00
Christopher Shannon 0a189f833e AMQ-8012 - Move synchronized block after null check 2020-07-24 16:22:24 -04:00
Christopher L. Shannon (cshannon) 62f5576fe5 AMQ-8012 - Improve thread safety of SubQueueSelectorCacheBroker
When returning a copy of the set of selectors we need to synchronize
2020-07-24 14:15:57 -04:00
Christopher L. Shannon (cshannon) 1dcc7d4b2c Merge branch 'AMQ-8012'
This closes #553
2020-07-24 14:13:45 -04:00
Matt Pavlovich 083acb9691 [AMQ-8012] Fix for ConcurrentModificationException in SubQueueSelectorCacheBroker
- Remove non-thread-safe method getSelectors()
 - Update all references to use the thread-safe getSelectorsForDestination() method
2020-07-24 12:22:12 -05:00
Christopher L. Shannon (cshannon) 17defa79d4 NO-JIRA: Update branch to 5.17.0-SNAPSHOT after release 2020-07-14 07:27:43 -04:00
Colm O hEigeartaigh fca3b615eb AMQ-7513 - Fix http://activemq.org links 2020-07-10 17:29:01 +01:00
Colm O hEigeartaigh 930b18df65 AMQ-7512 - Consolidate XBean byte parsing 2020-07-10 17:22:09 +01:00
Jean-Baptiste Onofré 334476ac63 [maven-release-plugin] prepare for next development iteration 2020-06-25 07:26:41 +02:00
Jean-Baptiste Onofré 86dd78b1aa [maven-release-plugin] prepare release activemq-5.16.0 2020-06-25 07:26:13 +02:00
Jean-Baptiste Onofré 6908749c2f Fix version 2020-06-25 07:13:04 +02:00
Jean-Baptiste Onofré ff2dae82f3 [maven-release-plugin] prepare release activemq-5.16.0 2020-06-24 21:56:52 +02:00
jbonofre 4ed2ba22a9 Cancel 5.16.0 release 2020-06-24 15:19:34 +02:00
Jean-Baptiste Onofré cd1e9f8697 [maven-release-plugin] prepare for next development iteration 2020-06-23 17:40:26 +02:00
Jean-Baptiste Onofré 2e890c6224 [maven-release-plugin] prepare release activemq-5.16.0 2020-06-23 17:39:53 +02:00
jbonofre 4e1df1979b [AMQ-7493] Fix RejectedExecutionException in the BrokerService 2020-06-22 16:24:29 +02:00
Christopher L. Shannon (cshannon) cc0bcdd5dc AMQ-7496 - Properly decrement inflight message size on message
expiration

Also clean up some of the handling of inflight metrics in Prefetch
subscription
2020-06-10 11:36:34 -04:00
Jean-Baptiste Onofré ef5975b1b7
Merge pull request #538 from PascalSchumacher/fix_some_javadoc_parameter_warnings_2
Fix javadoc warnings related to non-existing parameter names.
2020-05-23 06:38:40 +02:00
Colm O hEigeartaigh aa8900ca70 AMQ-7490 - Fix JMX regression 2020-05-22 09:56:59 +01:00
Pascal Schumacher efcca7d062 Fix javadoc warnings related to non-existing parameter names. 2020-05-22 10:49:39 +02:00
Pascal Schumacher 67e06c82f7 Fix some javadoc warnings releated to non-existing parameter names. 2020-05-17 11:38:05 +02:00
Jean-Baptiste Onofré 0444dd96b2
Merge pull request #505 from PascalSchumacher/potential_overflow_in_int_multiplication
Avoid potential overflow in int multiplication before it is converted…
2020-05-16 07:17:13 +02:00
Jean-Baptiste Onofré 41bef94293
Merge pull request #521 from coheigea/AMQ-7458
AMQ-7458 - Implement bounds checking on the message scheduling proper…
2020-05-15 15:52:23 +02:00
jbonofre e9caa75b1a [AMQ-7473] Add stopOnError configuration to stop the broker when locker has an exception 2020-05-13 07:53:00 +02:00
Jean-Baptiste Onofré 1f914bba65
Merge pull request #502 from coheigea/AMQ-7438
AMQ-7438 - Harden deserialization
2020-05-12 08:01:37 +02:00
Colm O hEigeartaigh 24aaa4698c AMQ-7458 - Implement bounds checking on the message scheduling properties 2020-03-27 12:14:03 +00:00
jbonofre 05c43fe347 [AMQ-7301] Fix typo (double from) 2020-03-12 10:21:35 +01:00
jbonofre d800f1bdb4 [AMQ-7301] Remove guava dependency to implement own getRootCause() method 2020-03-11 18:47:19 +01:00
jbonofre 960bc24d17 [AMQ-7301] Fix build and using a single log message 2020-03-11 17:21:01 +01:00
Christopher L. Shannon (cshannon) ee61ed69f8 AMQ-7301 - TransportConnector errors should log the root cause
(cherry picked from commit 57a1a77abb)
2020-03-11 06:49:35 -04:00
jbonofre 1550ae42f7 Revert "[AMQ-7314] Fix counter increment when lastDelivereSeqId > BrokerSequenceId"
This reverts commit df1750fe01.
2020-03-10 06:29:34 +01:00
Pascal Schumacher b43f5b8cf2 Avoid potential overflow in int multiplication before it is converted to long. 2020-03-08 11:50:21 +01:00
Colm O hEigeartaigh a73a85e6c2 AMQ-7438 - Harden deserialization 2020-03-06 17:22:07 +00:00
jbonofre b60efeaad8 [AMQ-7301] Improve logging when initialize Stomp NIO SSL connection 2020-03-05 15:00:53 +01:00
Jean-Baptiste Onofré c0e7949468
Merge pull request #500 from jbonofre/AMQ-7303
[AMQ-7303] Improve logging in case of security exception on transport connection
2020-03-04 21:44:37 +01:00
Jean-Baptiste Onofré 7435d7b058
Merge pull request #499 from jbonofre/AMQ-7346
[AMQ-7346] Improve logging of the network connector
2020-03-04 21:42:37 +01:00
jbonofre 945cd6b7de [AMQ-7303] Improve logging in case of security exception on transport connection 2020-03-04 18:57:02 +01:00
jbonofre 3c4a644f3d [AMQ-7346] Improve logging of the network connector 2020-03-04 17:54:37 +01:00
jbonofre 3c302dce33 [AMQ-7347] Don't log error in case of topic subscription failure. It's useless as the JMX exception is thrown and pollute the log. 2020-03-04 16:22:17 +01:00
jbonofre df1750fe01 [AMQ-7314] Fix counter increment when lastDelivereSeqId > BrokerSequenceId 2020-03-02 15:31:16 +01:00
Jean-Baptiste Onofré 51081e4edf
Merge pull request #479 from coheigea/AMQ-7423
AMQ-7423 - Remove synchronization from JAAS PropertiesLoader
2020-02-28 07:30:57 +01:00
Pascal Schumacher 7ef90e243f Add missing format argument for log message in AbortSlowAckConsumerStrategy#abortAllQualifiedSlowConsumers. 2020-02-27 22:03:41 +01:00
Colm O hEigeartaigh 67fb6f8871 AMQ-7423 - Remove synchronization from JAAS PropertiesLoader 2020-02-27 15:29:26 +00:00
jbonofre d878d877d5 [AMQ-7410] Align dependencies with Apache Karaf 2020-02-26 13:11:33 +01:00
Jonathan Gallimore 4522061527 Fix issue where the registry lookup was a hardcoded name and didn't account for the connector path 2020-02-24 11:10:46 +00:00
Jean-Baptiste Onofré bfb810c507
Merge pull request #466 from coheigea/misc_fixes
AMQ-7413 - Misc logging fixes
2020-02-22 07:49:55 +01:00
Daniel Trebbien b020cba744 Fix some incorrect SLF4J logger calls
In some cases, there were an inconsistent number of formatting anchors.

In other cases, formatting anchors were used, but because the
trace/debug/info/warn/error(String, Throwable) variant was used, the
string is a message string rather than a format string.

These issues were found by SLF4J Helper for NetBeans IDE:
http://plugins.netbeans.org/plugin/72557/
2020-02-19 08:26:36 +00:00
Daniel Trebbien 057cf666a0 Fix an apparent copy/paste typo 2020-02-19 08:02:20 +00:00
Daniel Trebbien 7b528ecee7 Fix some typos 2020-02-19 08:01:41 +00:00
Colm O hEigeartaigh 758bd279f8 AMQ-7412 - Fix NPE in SimpleAuthenticationPlugin 2020-02-19 07:29:44 +00:00
Jean-Baptiste Onofré 1c3a71620f
Merge pull request #451 from jgallimore/AMQ-7404
AMQ-7404 add debug logging for selectors loaded from the cache file
2020-02-14 08:21:00 +01:00
Jean-Baptiste Onofré a9d89572ef
Merge pull request #449 from PascalSchumacher/setter_getter_synchronization
AMQ-7402: Inconsistent synchronization of getters/setters of some cla…
2020-02-13 08:15:57 +01:00
Jean-Baptiste Onofré 4ecdd5a2a8
Merge pull request #448 from PascalSchumacher/fix_unused_format_arguments_in_log_messages
Fix unused format arguments in log messages.
2020-02-13 07:53:32 +01:00
Pascal Schumacher 6764511fa1 Fix unused format arguments in log messages. 2020-02-12 17:52:28 +01:00
Pascal Schumacher 5356893fac AMQ-7402: Inconsistent synchronization of getters/setters of some classes
Make synchronization consistent or remove it and declare the field volatile.
2020-02-12 17:48:34 +01:00
jbonofre 097506a458 [AMQ-7399] org.apache.activemq.SERIALIZABLE_PACKAGES doesn't include java* by default 2020-02-12 13:43:03 +01:00
Jonathan Gallimore e6befbc875 AMQ-7404 add debug logging for selectors loaded from the cache file 2020-02-12 11:15:59 +00:00
Jonathan Gallimore f1d0100832 Provide RMI registry implementation to prevent re-bind 2020-02-11 21:10:56 +01:00
Jean-Baptiste Onofré 6417d62f60 Merge pull request #428 from coheigea/AMQ-7376
AMQ-7376 - Use correct type for collections retrieval
2020-02-09 08:33:04 +01:00
Jean-Baptiste Onofré 85851f7ce8 [AMQ-7391] Minor typo fixed
Credit: Alexandre Fruchaud <mmacphail>
2020-01-28 10:46:48 +01:00
Colm O hEigeartaigh 127852d2e7 AMQ-7142 - Inserting Bouncy Castle Provider Early in Java Security Provider Chain Breaks KeyStore Loading 2020-01-27 10:43:39 +00:00
Colm O hEigeartaigh 675fb7bcae AMQ-7376 - Use correct type for collections retrieval 2020-01-20 18:35:01 +00:00
Christopher L. Shannon (cshannon) 0c6f9a9a1e AMQ-7352 - Add support for anonymous producer advisories
By default this behavior is turned off but can be enabled by setting
anonymousProducerAdvisorySupport on the BrokerService to true
2019-11-22 13:35:32 -05:00
Jean-Baptiste Onofré dcb5ba1fb3
Merge pull request #275 from PascalSchumacher/BrokerService_fix_typo
BrokerService: fix typo in field and parameter name
2019-11-18 17:42:44 +01:00
Jean-Baptiste Onofré f3f8271503 [AMQ-7301] Use warn for connection failure instead of error. 2019-11-12 15:19:13 +01:00
Jean-Baptiste Onofré a5f0602505
Merge pull request #395 from couclock/AMQ-7312
AMQ-7312 virtualSelectorCacheBrokerPlugin addConsumer issue
2019-10-18 19:09:32 +02:00
gtully 4af6f40186 AMQ-6494 is related, fix intermittent failure of RedeliveryPolicyTest related to vm transport server being shutdown while in use via async onException handler 2019-10-03 11:08:05 +01:00
Dany LECOQ 86a069ac5d AMQ-7312 virtualSelectorCacheBrokerPlugin addConsumer issue 2019-09-29 16:18:24 +02:00
gtully 644b529ef6 AMQ-7185 - rework to leave tx-inflight messages pending in the cursor to avoid duplicates on completion, fix and test 2019-09-24 17:32:54 +01:00
gtully 289750d7c9 AMQ-7308 - ensure kahadb message add does not auto create the message store in error, expect an existing store. fix and test 2019-09-20 10:22:56 +01:00
gtully 501d55337a AMQ-7302 - make jmx ops that pageIn aware of cursor memory limits to avoid excessive looping, fix and test 2019-09-10 11:46:04 +01:00
gtully fb2296ac74 AMQ-7270 - remove toggle on maxPageSize, request page in of entire queue only when cache is in play or broker is non persistent, fix and test 2019-08-07 17:47:59 +01:00
Christopher L. Shannon (cshannon) 09003e8fef AMQ-7102 - Improve ManagedRegionBroker performance by replacing
registeredMBeans CopyOnWriteSet with a Concurrent hashmap backed set
2019-07-31 12:56:57 -04:00
Colm O hEigeartaigh 75023f2bed Remove default "secret" password from the LDAPAuthorizationMap 2019-07-15 18:24:48 +01:00
Christopher L. Shannon (cshannon) c7eff84058 AMQ-7238 - Ensure remoteId subscription map is also cleared when local
map is cleared inside DemandForwardingBridgeSupport
2019-07-08 08:38:34 -04:00
gtully de3f77063f AMQ-7234 - fix up memory usage wait timeout such that topic pfc in a transaction can see connection context state changes, fix and test 2019-06-21 16:55:13 +01:00
Christopher L. Shannon (cshannon) dc56fa3f6e AMQ-7228 - Avoid unnecessary lock contention when getting pending
metrics
2019-06-14 10:46:21 -04:00
gtully 7404b43f2d AMQ-7193 - resolve intermittent NPE on duplex network connector start; wait for start completion before dispatching inbound messages, fix and test 2019-05-02 16:31:26 +01:00