1268 Commits

Author SHA1 Message Date
Matt Pavlovich
cda1007ef6 [AMQ-9257] Disabled expire message checking when pauseDispatch=true (#1005)
(cherry picked from commit 9a5b61f6a28184cfe832871302ece16069ebb71d)
2023-06-08 08:25:03 -05:00
Christopher L. Shannon
1707cc194b AMQ-9262 - Fix network subscriptions for composite consumers (#1014)
This fixes network subscriptions that are generated on demand when a
consumer uses composite destinations. Before this fix conduit
subscriptions didn't work correctly. This fix now splits up the
composite dest and generates correct demand for each of the individual
destinations.

(cherry picked from commit 901956d4ddb6a0ea9fe5fedf39732117ab68f087)
2023-06-07 07:20:43 -04:00
Jean-Baptiste Onofré
ebab05897a [maven-release-plugin] prepare for next development iteration 2023-02-22 06:36:53 +01:00
Jean-Baptiste Onofré
720570e967 [maven-release-plugin] prepare release activemq-5.17.4 2023-02-22 06:36:43 +01:00
Matt Pavlovich
47962eea25 [AMQ-9217] Fix per-destination audits on IndividualDeadLetterStrategy
(cherry picked from commit 28f7eb7ee87c47e43cc3db11fcd550ef872327b3)
2023-02-16 11:00:27 -05:00
Matt Pavlovich
48c73d9638 [AMQ-9207] Upgrade various dependencies (#964)
com.thoughtworks.xstream:xstream .................... 1.4.19 -> 1.4.20
commons-daemon:commons-daemon ......................... 1.3.2 -> 1.3.3
org.apache.ant:ant ................................ 1.10.12 -> 1.10.13
org.apache.shiro:shiro-core ......................... 1.10.1 -> 1.11.0
org.apache.shiro:shiro-spring ....................... 1.10.1 -> 1.11.0
org.codehaus.jettison:jettison ........................ 1.5.2 -> 1.5.3
regexp:regexp ............................................. 1.3 -> 1.5
org.apache.httpcomponents:httpclient ................ 4.5.13 -> 4.5.14
org.apache.httpcomponents:httpcore .................. 4.4.15 -> 4.4.16

- regexp/regexp -> jakarta-regexp/jakarta/regexp

(cherry picked from commit 34454567c813def45c965b9143b24fe7f4fb5117)
2023-02-04 06:14:57 +01:00
Christopher L. Shannon (cshannon)
5e12551a4a AMQ-9193 - Improve broker shutdown in unit tests
This should improve test reliability for the unit tests so brokers don't
hang around after the end of a test on error. Also increase the surefire
re-run count to 3 times before failing.

(cherry picked from commit a083ff4d23e9ea0997efa5aa596ed5f1c3c6ee24)
2023-01-11 06:23:05 -05:00
Christopher L. Shannon (cshannon)
4ac6065ace AMQ-9192 - Fix flaky AdvisoryTests
Properly shutdown broker for each test and speed up tests by sending
less messages

(cherry picked from commit 044f5346e93d9b133fcecccb6000d16967aa0f1e)
2023-01-10 15:31:01 -05:00
Jean-Baptiste Onofré
5926eee624 [maven-release-plugin] prepare for next development iteration 2022-11-29 14:49:59 +01:00
Jean-Baptiste Onofré
80a5ee343f [maven-release-plugin] prepare release activemq-5.17.3 2022-11-29 14:49:50 +01:00
Endre Stølsvik
2de859f758 AMQ-8617: RedeliveryPolicy:Exponential Backoff + NonBlockingRedelivery = too long delays
(cherry picked from commit 393a696955cbf97b90576e4a85b3ce1a02268ad7)

Scenario on client:

1. Employing RedeliveryPolicy with exponential backoff (keeping maximum
redeliveries at default 6)
2. Enabled non-blocking redelivery
3. Receiving e.g. 100 consecutive poison messages (which eventually
should DLQ after max redeliveries)

This will result in massive redelivery delays due to a logic bug.

The reason is that redeliveryDelay is a field variable kept on the
ActiveMQMessageConsumer, instead of being a property on the message - or
that the redelivery delay was calculated per message based on the
redelivery count.

When consecutive messages rollbacks multiple times, the redeliveryDelay
field is continuously multiplied by the backoff multiplier, resulting in
enormous delays.

Fix: Ditch the field variable, instead calculating the redeliveryDelay
per delivery from the redelivery count. (This happens to be identical to
how it is done in afterRollback() in ActiveMQSession:1004.)

Test is added - which fails with the previous code, and passes with
this. Added a debug log line for the calculated delay.
2022-11-22 08:56:09 +01:00
Christopher L. Shannon (cshannon)
20dc305a49 AMQ-9175 - Properly set broker on ConnectionContext inside
MemoryTransactionStores

This fixes a NPE when using the messageDelivered advisory and
transactions

(cherry picked from commit f83c5f1ba156ed850acf76dc42f944b4150d21f8)
2022-11-21 11:12:07 -05:00
Christopher L. Shannon (cshannon)
29dcd3f8bf AMQ-9159 - Add a test case to verify inflight message stats for wildcard
consumer when a destination is removed

(cherry picked from commit f6e26085cfa3693b2872b1c53354c674c0cbca49)
2022-11-17 09:11:38 -05:00
Christopher L. Shannon (cshannon)
27e16b1d48 NO-JIRA: Add timeout for flaky test
(cherry picked from commit b6540746a23f6b8d96279392551c3b50626f02d8)
2022-11-16 13:22:26 -05:00
Christopher L. Shannon (cshannon)
f90a7bf535 AMQ-9168 - Send message expired advisory and not discard advisory when
Topic subscriptions expire a message

This fixes topic subs to send the right advisory type, if enabled, when
the server discards a message on dispatch to a topic sub. Also add some
more expiration tests for other subscription types

(cherry picked from commit 757a712890996d71cf380c56fc2cefbd5a82ec88)
2022-11-16 06:47:17 -05:00
Matt Pavlovich
d830dc2954 [AMQ-9163] Add 'Started' attribute to ConnectorView (#932)
(cherry picked from commit c25975389f031a787414b404c848a4757f7180e5)
2022-11-15 10:18:06 +01:00
Christopher L. Shannon
9a298e6caa Increase forkedProcessTimeoutInSeconds for tests to decrease timeout failures (#930)
(cherry picked from commit f473efe163e23bb289c89f12c1f8856e6e8ff83c)
2022-11-11 05:49:40 -05:00
Christopher L. Shannon (cshannon)
3047807763 AMQ-9152: Make test classes abstract to fix surefire plugin
(cherry picked from commit ea10d984d01c665ca1883cfcc38a66719f997596)
2022-11-03 15:48:28 -04:00
Christopher L. Shannon (cshannon)
81773c85d7 AMQ-9152: Fix surefire setup to run all tests that are not excluded
(cherry picked from commit ba0b7a25a0fb8d225147748f28f69ba5abee01b5)
2022-11-03 15:48:18 -04:00
Christopher L. Shannon (cshannon)
9c5a6219ea AMQ-9156 - Make sure in flight metrics are properly decremented on
subscription destroys and dispatch failures

(cherry picked from commit 58666afffde7eb43509d155e709e76e6fdba8084)
2022-11-03 10:42:45 -04:00
Christopher L. Shannon (cshannon)
8cc7a45455 AMQ-9107 - rework performance improvement for consumer closing in
managed region broker

This new approach just looks matching Subscriptions from the region for the
destination which prevents having to store another map and falls back to
the old approach if something went wrong.

(cherry picked from commit d46b74d674c2a67193bb95384290da266adf9a25)
2022-11-03 06:50:44 -04:00
Christopher L. Shannon (cshannon)
bc9e728123 AMQ-9153: Fix slow consumer advisory for queue subscriptions
Due to changes with Queues to check if consumers are full before adding
more messages to the subscription, the Queue dispatch logic needed to be
updated to mark subscriptions as slow and send advisories if configured
instead of relying on the subscription itself to do it.

(cherry picked from commit 596ee316874894ad0342475d8f242913bd507cd1)
2022-11-01 10:31:50 -04:00
Lucas Tétreault
fb89765fdf Add a test for offline durable subscriptions for AMQ-9107
(cherry picked from commit 98b7d3443cca2be964637962f86d265b8375c632)
2022-11-01 07:06:41 +01:00
Robbie Gemmell
aad85e2c4a AMQ-9074: use -noindex to remove various .js files, disable html source listings for javadoc
(cherry picked from commit 52574a794a97e0d3d64d6c26a5b5a545facfdc95)
2022-09-07 18:04:01 -04:00
Jean-Baptiste Onofré
cad3839fe1 [maven-release-plugin] prepare for next development iteration 2022-08-25 09:22:35 +02:00
Jean-Baptiste Onofré
b6ecffe80a [maven-release-plugin] prepare release activemq-5.17.2 2022-08-25 09:22:27 +02:00
Jean-Baptiste Onofré
f9678aa3e0 Add missing ASF header 2022-08-24 09:39:02 +02:00
Matt Pavlovich
b70b2960a4 [AMQ-8981] Fix CustomBridgeFactoryTest
(cherry picked from commit 82a2374764d4002e72f37457143f3207d732cf04)
2022-08-23 07:13:54 +02:00
Jean-Baptiste Onofré
f23eb49c6f [AMQ-9030] Upgrade to maven-antrun-plugin 3.0.0
(cherry picked from commit fb3dea365628801fcbecbb09ca217820283c4436)
2022-08-18 07:16:39 +02:00
Enrico Olivelli
8d9fdd3b07 AMQ-8613 Improve performance of selectors with a big sequence of OR and AND logical expressions
(cherry picked from commit 4b08978062d05beb15cfb83b4e47cea298ae95ba)
2022-08-17 07:47:29 +02:00
Lucas Tétreault
c44008e852 [AMQ-9005] remove xalan dependency due to it being end of life
(cherry picked from commit e550748b4cb2da128a9ea5ac886cc6700f4e9c97)
2022-08-01 06:39:51 +02:00
Jean-Baptiste Onofré
8abb50aa16 [maven-release-plugin] prepare for next development iteration 2022-04-25 14:23:42 +02:00
Jean-Baptiste Onofré
0898aab016 [maven-release-plugin] prepare release activemq-5.17.1 2022-04-25 14:23:33 +02:00
Jean-Baptiste Onofré
c44bf3c5f7 Fix OfflineDurableSubscriberTimeoutTest on some machine (including Jenkins)
(cherry picked from commit ffab5274a441c097a2a54d9aac43025edc147061)
2022-04-06 07:45:03 +02:00
Christopher L. Shannon
aa10747e94 AMQ-8550 - Check for null keystore/truststore passwords
Inside ActiveMQSslConnectionFactory the passwords should be checked for
null so a NPE isn't thrown. Null will be passed to the factories instead
and the keystore/truststore factories will try and load the keystores
using null for the password which may or may not work depending on the
implementation and if password is set.

(cherry picked from commit b93d58259c86d5e1141d1004cf8d75cf4a4376a6)
2022-04-05 13:41:54 -04:00
Jean-Baptiste Onofré
bd08484445 [maven-release-plugin] prepare for next development iteration 2022-03-09 21:47:58 +01:00
Jean-Baptiste Onofré
1f3ccad9bb [maven-release-plugin] prepare release activemq-5.17.0 2022-03-09 21:47:47 +01:00
Jean-Baptiste Onofré
a9cb53bd38 Cancel 5.17.0 release 2022-03-09 21:42:04 +01:00
Christopher L. Shannon (cshannon)
482a5e819d AMQ-8530 - Update to geronimo-annotation_1.3_spec
(cherry picked from commit 3d06efe93d8560d7836cc5d1caf42bf6916d1c2b)
2022-03-09 12:54:31 -05:00
Christopher L. Shannon
f25ff1bca2 AMQ-8528: Fix test failures in integration module
-DurableFiveBrokerNetworkBridgeTest: Fix refactoring mistake
-SpringTest: Fix Spring xml files
-BrokerRedeliveryTest: Fix after sendDuplicateFromStoreToDLQ default
changed to false
-AMQ4952Test: Fix after sendDuplicateFromStoreToDLQ default
changed to false
-AMQ3537Test: Add missing package to SERIALIZABLE_PACKAGES
-OfflineDurableSubscriberTimeoutTest: Fix after log4j2 update
-JDBCConcurrentDLQTest: Fix after log4j2 update

(cherry picked from commit 32e72b0879713bb017bd258efddfa18355504123)
2022-03-08 13:33:37 -05:00
Christopher L. Shannon
15a2f3de2c NO-JIRA: Activate quick-tests by default (#792)
(cherry picked from commit c4d9d70987d1a59868e46837110ff16546c2dbc6)
2022-03-08 13:23:41 -05:00
Jean-Baptiste Onofré
2582384511 [maven-release-plugin] prepare for next development iteration 2022-03-07 15:41:59 +01:00
Jean-Baptiste Onofré
8ad238bb7d [maven-release-plugin] prepare release activemq-5.17.0 2022-03-07 15:41:49 +01:00
Christopher L. Shannon (cshannon)
b31cc6f2cb AMQ-7309: Compilation fixes after revert of JMS 2.0 api change 2022-03-03 16:58:17 -05:00
Christopher L. Shannon (cshannon)
da9e5276f1 AMQ-8520: Log4j2 test fixes
Also fixes Log4jConfigView

(cherry picked from commit ae30dce4e24ce5e0467d2a3219627cbefef1f0ae)
2022-03-03 16:42:22 -05:00
Matt Pavlovich
4d662648be [AMQ-8520] WIP: Convert activemq-unit-tests to log4j2
(cherry picked from commit 7ec5254bb59924b09d124fc19c797c2587bceea6)
2022-03-03 16:42:20 -05:00
Christopher L. Shannon (cshannon)
efe3f5b7d4 AMQ-8520: Re-enable all modules to compile and build by default
Updates the modules part of the previous full.test profile to always
build but skip running tests by default.

Also fixed miss dependency updates including log4j and jetty

(cherry picked from commit f240cb58067636e1b32d17f8748c8028019da262)
2022-03-03 16:41:38 -05:00
Christopher L. Shannon (cshannon)
8a4c928806 Revert "[AMQ-7309] Update to jakarta.jms/jakarta.jms-api:2.0.3 (#682)"
This reverts commit 67256c61b1560127e3a56ba9dede61cad3001f4a.
2022-03-01 10:25:01 -05:00
Jean-Baptiste Onofré
e597017200
Merge pull request #662 from jbonofre/AMQ-7426
[AMQ-7426] Upgrade to log4j2
2022-02-27 13:23:53 +01:00
Matt Pavlovich
094dbc89f3
[AMQ-8515] FailoverTransport should handle MaxFrameSizeExceededException (#785) 2022-02-25 19:46:45 -06:00