Christopher L. Shannon (cshannon)
903dec615c
https://issues.apache.org/jira/browse/AMQ-6194
...
Fixing an issue that caused statistics for a transactional temporary
queue to be updated twice by mistake. Moved the statistics update into
tryOrderedCursorAdd so that the update is called immediately only if
not inside a transaction.
2016-03-07 14:15:35 +00:00
gtully
d8cf54b0a9
https://issues.apache.org/jira/browse/AMQ-4495 - revisit. Reinstate check for space on pagein, so that highWaterMark is respected and full state is not reached, hense pfc is not triggered in error
2016-03-01 11:44:41 +00:00
Brian D. Johnson
552c0f0f7a
https://issues.apache.org/jira/browse/AMQ-6188 - reset BaseDestination.lastActiveTime each time a message is delivered to the broker.
2016-02-26 20:46:32 +00:00
Timothy Bish
c2ad0c3251
AMQ-6183 Add isDispatchSync to the subscription view and deprecate the
...
meaningless one in the producer view
2016-02-24 17:25:01 -05:00
Jeff Genender
49974279a7
AMQ-6175 - Web console needs to only obtain lists of MBeans that are not
...
suppressed.
2016-02-18 14:25:30 -07:00
gtully
b0c0441d09
https://issues.apache.org/jira/browse/AMQ-6171 - fix vm transport replacement of : from brokerName in error, fix networkConnector retry logic in the event of localTransport creation failure
2016-02-15 14:14:19 +00:00
gtully
499e39e52c
https://issues.apache.org/jira/browse/AMQ-6164 - allow journal write batching on a single destination
2016-02-09 12:50:27 +00:00
Timothy Bish
386210fafe
https://issues.apache.org/jira/browse/AMQ-6159
...
Ensure proper repeat counts are scheduled.
2016-02-04 17:16:58 -05:00
Christopher L. Shannon (cshannon)
33dded13df
https://issues.apache.org/jira/browse/AMQ-6036
...
Slight refactoring to make the WildcardFinder class use a static method
so that we don't have to allocate throw away objects that will
immediately be garbage collected.
2016-02-04 16:53:02 +00:00
Patrik Dudits
278d29dadc
https://issues.apache.org/jira/browse/AMQ-6036
...
Parsing message selector for wildcard matches for ignoreWildcardSelectors feature
2016-02-04 16:51:51 +01:00
gtully
c17b7fdc7f
add trace level log to shared file locker keepAlive
2016-02-04 13:28:59 +00:00
Marc Breslow
4a937def7d
Fix Impossible Cast issues in MemoryTopicSub:
...
- recoverSubscription()
-- map is defined as LinkedHashMap<MessageId, Message>
-- msg is defined as <map> entry.getValue() so must be a Message
-- condition if (msg.getClass() == MessageId.class) could never be true
-- no need to cast at all when using generics
- recoverNextMessages()
-- basically same code copy/pasted so same fix
Removed 2 conditions from ServerSessionPoolImpl that would result in impossible casts. Conditions removed were trying to cast ActiveMQQueueSession and ActiveMQTopicSession to ActiveMQSession which is illegal.
Since it isn't obvious what to do if you get an ActiveMQQueueSession or ActiveMQTopicSession from getServerSession() I make it fall back to the else condition which raises an async exception. This is better than getting a ClassCastException at runtime.
Remove impossible cast in MemoryMessageStore
2016-02-01 12:57:50 +00:00
gtully
5af5b59d3b
https://issues.apache.org/jira/browse/AMQ-6151 - respect prioritizeMessages for pending and redelivered messages
2016-02-01 12:19:49 +00:00
Daniel Kulp
a772b0ef72
Remove a printStackTrace for an exception that is also logged. Produces noise on console
2016-01-27 10:06:36 -05:00
Timothy Bish
4ecff14030
NO-JIRA Update master version to 5.14.0-SNAPSHOT to match the eventual
...
release version.
2016-01-20 12:40:20 -05:00
Christopher L. Shannon (cshannon)
7b7e362465
https://issues.apache.org/jira/browse/AMQ-6129
...
fixing typo
2016-01-15 15:09:37 +00:00
Christopher L. Shannon (cshannon)
10c998b0bc
https://issues.apache.org/jira/browse/AMQ-6129
...
Adding NetworkBridgeStatistics and also a received count for bridges
when they are in duplex mode.
2016-01-15 14:54:04 +00:00
gtully
2b84cd60ba
https://issues.apache.org/jira/browse/AMQ-6128 - fix and test - fix values on priority ordered pending - messages assigned to browsers need to be ordered
2016-01-15 14:31:09 +00:00
Timothy Bish
505a76a8bb
https://issues.apache.org/jira/browse/AMQ-6059
...
Ensure that a message sent to the store for the DLQ is rewritten so that
its updated values are written to prevent exirpation loops and loss of
reollback cause etc.
2016-01-12 11:51:48 -05:00
Timothy Bish
66cfc7bab3
AMQ-6121
...
AMQ-6122
Prevent messages on DLQ for looping back onto the same DLQ. Prevents
expired messages from bouncing back and duplicate messages from the
store from causing a deadlock.
2016-01-11 10:57:38 -05:00
Altaflux
3bb7e4a5c8
Network of brokers on duplex mode reports InstanceAlreadyExistsException on already existing destinations
...
https://issues.apache.org/jira/browse/AMQ-6052
closes #164
2016-01-11 12:59:33 +00:00
Altaflux
6b1e87410d
Network of brokers on duplex mode reports InstanceAlreadyExistsException on already existing destinations
2016-01-11 12:59:33 +00:00
Dejan Bosanac
5f8a3df5a4
https://issues.apache.org/jira/browse/AMQ-6116 - improve security context
2016-01-08 17:05:58 +01:00
gtully
e3df09b9db
https://issues.apache.org/jira/browse/AMQ-6094 - regression via https://issues.apache.org/jira/browse/AMQ-6014 - incorrect ref count on message expiry event during cursor move for dispatch. Fix and test - thanks for the test
2016-01-05 14:09:16 +00:00
Timothy Bish
8906a53ae5
https://issues.apache.org/jira/browse/AMQ-6105
...
Remove deprecated methods from JMX tree
2015-12-22 13:33:36 -05:00
Timothy Bish
564d55023e
https://issues.apache.org/jira/browse/AMQ-6102
...
Call to the statistics instance of the subscription to reset the
counters.
2015-12-21 17:03:24 -05:00
Dejan Bosanac
4e63ee7cc7
https://issues.apache.org/jira/browse/AMQ-6100 - Virtual topic message destination should be the target queue
2015-12-21 15:19:22 +01:00
Timothy Bish
46654b2dee
https://issues.apache.org/jira/browse/AMQ-6093
...
Remove deprecated URL accessors from BrokerViewMBean
2015-12-17 13:55:08 -05:00
Christopher L. Shannon (cshannon)
a253ad3c71
https://issues.apache.org/jira/browse/AMQ-6091
...
The JavaRuntimeConfigurationBroker can now apply a subset of policy
properties retrospectively to existing destinations versus applying
all properties of the policy update.
2015-12-17 14:35:50 +00:00
gtully
455a628305
https://issues.apache.org/jira/browse/AMQ-6086 - avoid logging npe on attempted start of persistence adapter post stop
2015-12-14 16:32:10 +00:00
gtully
35df815fb8
https://issues.apache.org/jira/browse/AMQ-6086 - start exception can prevent stop from exiting fully, need to be more selective in creation on stop.
2015-12-14 15:40:05 +00:00
gtully
da076f4a63
https://issues.apache.org/jira/browse/AMQ-6086 - add some determinism to interleaved stop and start calls on broker service
2015-12-11 16:22:31 +00:00
gtully
93092f7ea0
https://issues.apache.org/jira/browse/AMQ-6070 - rework regression - KahaDBStoreRecoveryExpiryTest had NPE in the logs, region dest not set on recovery listener for expiry case
2015-12-11 15:27:28 +00:00
gtully
768fa17085
https://issues.apache.org/jira/browse/AMQ-6005 - have plist whack it existing state on start. Start the temp store after the primary persistence adapter which does the locking
2015-12-10 14:24:03 +00:00
gtully
d7febddb67
https://issues.apache.org/jira/browse/AMQ-6084 - add broker.adjustUsageLimits to disable the adjustment of limits to what is available. In this way, a broker will fail to start if constrained, ensuring it won't accept connections and block pending resources if it has earlier exited for that reason
2015-12-10 11:23:56 +00:00
Christopher L. Shannon (cshannon)
5772e7bed8
https://issues.apache.org/jira/browse/AMQ-6080
...
fixing typos
2015-12-08 13:18:11 +00:00
gtully
88ec9dad9d
https://issues.apache.org/jira/browse/AMQ-5454 https://issues.apache.org/jira/browse/AMQ-6070 - in the case of duplicates from the store the regiondestination was not set
2015-12-08 11:25:50 +00:00
gtully
179dc3acb2
https://issues.apache.org/jira/browse/AMQ-6070 - rework for virtual topic case, use the destination from the transient region destination rather than the message, such that consumer queue advisories work for delivered etc
2015-12-08 11:05:25 +00:00
gtully
75ff17af41
https://issues.apache.org/jira/browse/AMQ-6070 - set correct originalDestination property value in advisories
2015-12-03 12:14:18 +00:00
Christopher L. Shannon (cshannon)
d346a765e3
https://issues.apache.org/jira/browse/AMQ-6062
...
Updated QueueBrowserSubscription to use a ConcurrentMap to avoid a
potential race condition when multiple queue browsers browse
multiple queues.
2015-12-02 15:51:55 +00:00
Christopher L. Shannon (cshannon)
8363c99b51
https://issues.apache.org/jira/browse/AMQ-6069
...
Fixed contains method in PrioritizedPendinList which was not returning
correctly. This was causing messages to not be removed from the
dispatchPendingList when purge was called inside a Queue leading to an
eventual OOM error if enough messages were purged. This fix also
improves performance of the contains method.
2015-12-02 13:24:32 +00:00
Christopher L. Shannon (cshannon)
cfb4ca9f54
[maven-release-plugin] prepare for next development iteration
2015-11-30 13:48:58 +00:00
Christopher L. Shannon (cshannon)
abfe038ddf
[maven-release-plugin] prepare release activemq-5.13.0
2015-11-30 13:48:11 +00:00
gtully
f09000d1e6
https://issues.apache.org/jira/browse/AMQ-6065 - ensure no call to exit. fix mock test to account for extra call
2015-11-30 13:24:19 +00:00
gtully
1bef4de4dc
Revert " https://issues.apache.org/jira/browse/AMQ-6065 "
...
CPL dependency is not fully compatable with ASF and is not really necessary
This reverts commit 39a20bd788
.
2015-11-30 13:24:18 +00:00
Christopher L. Shannon
39a20bd788
https://issues.apache.org/jira/browse/AMQ-6065
...
Fixed test case so that a System.exit call will not take down the
JVM and cause the test suite to abort in Jenkins early
2015-11-29 10:05:27 -05:00
Christopher L. Shannon
673c2928a1
https://issues.apache.org/jira/browse/AMQ-6066
...
Improving performance of OrderedPendingList contains method
Thanks for David Sitsky for the patch
2015-11-28 13:25:53 -05:00
gtully
2aa172f905
https://issues.apache.org/jira/browse/AMQ-6065 - allow ioexception handler to flip the systemExitOnShutdown broker attribute before calling stop, i.e: exit on store io errors
2015-11-27 14:21:20 +00:00
gtully
0a12bcb928
https://issues.apache.org/jira/browse/AMQ-2191 https://issues.apache.org/jira/browse/AMQ-3529 - rework fixes to remove uncertanty from dealing with intettuptedexception. Sync requests will trap interrupts that ocurr while waiting for responses and fail the connection with an interruptedioexception. Interrupts pending before requests will be suppressed, allowing possible clean shutdown. It is not safe to replay openwire ops b/c they are not idempotent, the only safe option is to have a teardown of the broker side state from a close
2015-11-27 12:21:56 +00:00
Christopher L. Shannon (cshannon)
29d943429c
https://issues.apache.org/jira/browse/AMQ-5393
...
Reverting commit because allowing 0 doesn't actually set the usage to
0 size. It ends up disabling the check all together which was the
opposite intention of the commit.
This reverts commit 3b658f8e1a
.
2015-11-25 17:59:41 +00:00
Christopher L. Shannon (cshannon)
35b7ac250b
https://issues.apache.org/jira/browse/AMQ-5898
...
Removing assertion in VirtualDestinationInterceptor to allow
multiple composite destinations to forward to a physical destination
2015-11-25 13:33:32 +00:00
Christopher L. Shannon (cshannon)
3b658f8e1a
https://issues.apache.org/jira/browse/AMQ-5393
...
Allowing disk limit percentages to be 0
2015-11-25 13:18:59 +00:00
Christopher L. Shannon (cshannon)
bc9edf00d1
https://issues.apache.org/jira/browse/AMQ-6058
...
Updating patch to make sure SelectorAwareVirtualTopics are covered
and code cleanup
2015-11-23 20:35:32 +00:00
Chad Zobrisky
dca6e4506e
AMQ-6058 added a check to make sure the destination starts with the virtual topic prefix.
2015-11-23 20:10:26 +00:00
gtully
4318eba4a3
https://issues.apache.org/jira/browse/AMQ-6014 - topic store prefetch should take ownership like in the non persistent case - DurableSubscriberNonPersistentMessageTest regression
2015-11-23 12:27:03 +00:00
Christopher L. Shannon (cshannon)
cc6213ebf2
https://issues.apache.org/jira/browse/AMQ-5712
...
Switching addMessageLast to tryAddMessageLast when messages are added
to a Queue pending cursor to allow a potential deadlock to be
avoided. There is more work to be done here but this will at least
prevent a deadlock from occurring.
Fix and test based off of a patch created by Timothy Bish.
2015-11-20 20:58:27 +00:00
gtully
15412bae64
AMQ4221Test - remove system exit as it breaks surefire fork, https://issues.apache.org/jira/browse/AMQ-6004 interrupt causes errors on shutdown. Two are sorted but the check for errors in the logs may still cause intermittent failures
2015-11-18 16:08:29 +00:00
Christopher L. Shannon (cshannon)
09054fc4a8
https://issues.apache.org/jira/browse/AMQ-6050
...
Clearing the subscription from the local map in
DemandForwardingBridgeSupport to make sure that demand can be properly
recreated again.
2015-11-18 15:06:33 +00:00
Timothy Bish
078a101cf7
https://issues.apache.org/jira/browse/AMQ-6000
...
Fix and test, wakeup queue dispatch when resume is called.
2015-11-10 15:39:51 -05:00
Timothy Bish
938aa626c2
https://issues.apache.org/jira/browse/AMQ-6039
...
If the rename option fails, then we must try a complete copy since the
move can cross file systems.
2015-11-10 11:12:50 -05:00
Christopher L. Shannon (cshannon)
cc81680e10
https://issues.apache.org/jira/browse/AMQ-6027
...
Adding support for consumers on virtual destinations to create network
demand. This behavior is turned off by default but can be enabled.
For example, if a consumer comes online for a queue that is part of a
VirtualTopic, this will cause a network of brokers to forward messages
because a demand subscription will be created. Same for if a consumer
comes online for a forwarded destination from a composite
destination.
There is also an option to enable flow based on the existence of a
virtual destination if the virtual destination is forwarding to a
Queue.
Full configuration instructions for this feature will be on the wiki page.
2015-11-09 20:07:43 +00:00
Timothy Bish
014d5594d6
AMQ-6032 Repack message prior to scheduler dispatch to store updated
...
properties in marshaled form.
2015-10-30 14:11:06 -04:00
Christopher L. Shannon (cshannon)
c5506f5b17
Switching getter method to public
...
Switching isReduceMethodFootprint() to public access so it can be
accessed.
2015-10-30 15:39:24 +00:00
gtully
5d697cff3b
https://issues.apache.org/jira/browse/AMQ-6016 - rework fix for https://issues.apache.org/jira/browse/AMQ-2106 - account group assignment on a per destination basis to prevent modification during consumer ordering
2015-10-21 14:02:56 +01:00
gtully
a01578ad4c
fix stop/stop or stop no start NPE on sharedfilelocker
2015-10-20 13:02:57 +01:00
gtully
dc19d28af9
https://issues.apache.org/jira/browse/AMQ-3573 https://issues.apache.org/jira/browse/AMQ-2834 - only validate limits if they are set
2015-10-20 12:17:23 +01:00
gtully
1ad0117932
https://issues.apache.org/jira/browse/AMQ-6014 - fix up reference counting for durable subs such that ack on one sub does not decrement usage for offline subs. Fix and test
2015-10-19 16:22:57 +01:00
gtully
b285d10188
https://issues.apache.org/jira/browse/AMQ-4705 - ensure jvm lock system property is cleared in the event of lock release throwing exception.
2015-10-14 15:08:59 +01:00
Christopher L. Shannon (cshannon)
af09b4586b
Improving disk usage log message
...
Improving the warning message for a percent disk usage check so it is
more clear what the original limit was set to and what the current
limit is being set to.
2015-10-14 11:35:18 +00:00
Christopher L. Shannon (cshannon)
6fef9eea65
Cleaning up logging
...
Fixing one of the logging statements for the disk usage check process
that warns when the amount of free space is too low
2015-10-07 11:55:20 +00:00
Timothy Bish
81b4b9ae3d
https://issues.apache.org/jira/browse/AMQ-5996
...
When possible check for noLocl changes on durable subscription
reactivation and recreate the durable sub if it changes. For both
selector change and noLocal change also update the AbstractSubscription
selectorExpression so it matches with what was requested.
2015-10-01 19:23:58 -04:00
gtully
86c826c461
https://issues.apache.org/jira/browse/AMQ-5568 - verify delete return code for win platform failure. Thanks to Erik Wramner for the heads up
2015-09-22 12:56:13 +01:00
Christopher L. Shannon (cshannon)
00d19e7b66
Removing inadvertantly checked in file
2015-09-21 17:13:36 +00:00
gtully
cc9b9b0843
https://issues.apache.org/jira/browse/AMQ-5938 - remove unnecessary topic cast - breaks auth scenario. Fix and test
2015-09-21 14:48:44 +01:00
Christopher L. Shannon (cshannon)
d2bd152960
Tweaking some unit tests to improve reliability
2015-09-17 11:28:14 +00:00
Dejan Bosanac
ee4672baaf
https://issues.apache.org/jira/browse/AMQ-5972 - wildcard policy entries not applied in correct order
2015-09-17 11:08:21 +02:00
Christopher L. Shannon (cshannon)
4cddd2c015
https://issues.apache.org/jira/browse/AMQ-5963
...
Disk limits can now be specified as a percentage of the partition size
that the store is located on. The usual checks of the max size
exceeding the available space will still apply. When using a
percentage, the store can always regrow itself if space becomes
available.
https://issues.apache.org/jira/browse/AMQ-5964
https://issues.apache.org/jira/browse/AMQ-5965
https://issues.apache.org/jira/browse/AMQ-5969
2015-09-15 14:50:18 +00:00
Christopher L. Shannon (cshannon)
4f8d56aaf6
https://issues.apache.org/jira/browse/AMQ-5967
...
Updating temporary limit disk check to take into account space being
used by the temporary store itself
2015-09-14 19:46:57 +00:00
Christopher L. Shannon (cshannon)
734fb7dda3
https://issues.apache.org/jira/browse/AMQ-5923
...
Adding metrics to track the pending message size for a queue and for
subscribers. This is useful so that not only the pending count is
known but also the total message size left to consume. Also improving
the message size store tests as well.
2015-09-09 18:12:15 +00:00
Timothy Bish
f58683ea07
https://issues.apache.org/jira/browse/AMQ-5959
...
Add check to avoid NPE
2015-09-08 10:03:23 -04:00
gtully
c7b93d1232
https://issues.apache.org/jira/browse/AMQ-5953 - transaction broker, fix sync of xatransaction get with insert
2015-09-03 16:56:20 +01:00
Timothy Bish
505916b927
AMQ-5949 Treat maxSendRetries of -1 as infinite.
2015-09-02 16:37:24 -04:00
Dejan Bosanac
ee54f09303
https://issues.apache.org/jira/browse/AMQ-5831 - revisit topic subscriptions
2015-08-26 12:28:39 +02:00
gtully
10a74ce737
https://issues.apache.org/jira/browse/AMQ-5943 - patch, with test, applied with thanks to Torsten Mielke
2015-08-25 12:07:02 +01:00
gtully
11579bb918
https://issues.apache.org/jira/browse/AMQ-5938 - add remove(messageId) op to offline durable subs jmx view
2015-08-21 13:17:09 +01:00
gtully
3c2ed9352b
AMQ-5933 - add test and fix
2015-08-19 15:02:41 +01:00
gtully
ffdaeb2bd1
AMQ-5920 - make using a vt transaction configurable, a transaction negates concurrentstoreanddispatch and imposes local 2pc on mKahadb so needs to be off by default
2015-08-17 15:35:36 +01:00
Christopher L. Shannon (cshannon)
3c358b32fd
AMQ-5889 - refactoring and cleanup
2015-08-13 15:49:50 +00:00
Christopher L. Shannon (cshannon)
e14aca871c
https://issues.apache.org/jira/browse/AMQ-5889
...
-Cleaned up missing license headers and refactored packages.
-Added configuration options for a protocol detection timeout and
for the max number of connections accepted at the same time.
-Fixed a regression with connection counts
-Also added some more tests
2015-08-13 14:41:29 +00:00
Christopher L. Shannon (cshannon)
04ee70a161
https://issues.apache.org/jira/browse/AMQ-5889
...
Adding support for auto detection of wire protocols over a transport.
OpenWire, AMQP, STOMP, and MQTT can all be detected and the broker
will properly handle each one over a given Transport. Currently
auto TCP, NIO, SSL, and NIO+SSL transports can handle auto-detection
of the wire format and client but support could be added in the
future for other transports like websockets.
2015-08-11 19:39:29 +00:00
Timothy Bish
6cdd750ddc
[maven-release-plugin] prepare for next development iteration
2015-08-10 11:04:26 -04:00
Timothy Bish
a9eeb03520
[maven-release-plugin] prepare release activemq-5.12.0
2015-08-10 11:04:17 -04:00
Christopher L. Shannon
c6542a921b
AMQ-5748 - Cleanup and clearing cache on shutdown
2015-08-09 09:39:14 -04:00
Christopher L. Shannon (cshannon)
a49d46e3ca
https://issues.apache.org/jira/browse/AMQ-5748
...
Updating MemoryTopicMessageStore to decrement store statistics on cache
eviction. Updating KahaDBMessageStoreSizeStatTest to account for the
fact that a LRU cache is used so the last 100 messages are kept in
memroy.
2015-08-08 17:59:19 +00:00
Timothy Bish
a3c8bee1f0
https://issues.apache.org/jira/browse/AMQ-5605
...
Attempt to resolve high CPU usage after error by ensuring that the
transport is disposed along with the fire of the local error.
2015-08-07 16:21:52 -04:00
Christopher L. Shannon (cshannon)
2b7bb6f81b
https://issues.apache.org/jira/browse/AMQ-5837
...
Switching to a List to track dispatched messages in a TopicSubscription
to be consistent with a PrefetchSubscription and to prevent an error
in case acks come back out of order.
2015-08-06 17:14:09 +00:00
gtully
340728f2d1
AMQ-5920 - use implicit broker transaction for virtual topic fanout and add concurrentSend=true option to use an executor to fanout. Combination gives a 3x reduction in fanout roundtrip for small persistent messages to 100 consumer queues
2015-08-06 11:56:47 +01:00
Christopher L. Shannon (cshannon)
457dbd8b64
https://issues.apache.org/jira/browse/AMQ-5919
...
Converting printStackTrace statements to slf4j so that exceptions
are logged properly
2015-08-05 16:29:29 +00:00
Timothy Bish
82e3ce805e
https://issues.apache.org/jira/browse/AMQ-5916
...
Apply patch from Ganesh Murthy to resolve issue of creation of durable
subscriber fails via broker AdminView due to lack of SecurityContext on
ConnectionContext
2015-08-04 14:51:15 -04:00
Timothy Bish
5e05df1cb7
Fix a bunch of javadoc warnings produced during release profile builds.
2015-08-04 11:54:46 -04:00