Commit Graph

197 Commits

Author SHA1 Message Date
gtully e1c707e813 https://issues.apache.org/jira/browse/AMQ-5856 - fix typo that lead to recursive call - test regression in MQTTConnectTest 2015-07-08 12:18:05 +01:00
Timothy Bish 455f1ca475 https://issues.apache.org/jira/browse/AMQ-5872
The code that adds subscriptions for retroactive subscribers did not
account for the case where the last ack position in the ackLocations
table is used as a placeholder for the next incoming message and there
may not be an element in the messageReference tracker for that index
especially after restart when the index is reloaded.  The code needed to
check this when it iterates of the existing message references to add a
value so to avoid the NPE.  

Also cleaned up the MQTT tests such that they place their data dir in
./target so that old stores get removed on 'mvn clean'
2015-07-02 17:04:35 -04:00
Timothy Bish 27edaffded https://issues.apache.org/jira/browse/AMQ-5856
Clean up the MQTT over WebSocket code to allow for handling link
stealing and inactivity monitor.  Ensures that the web socket instances
get cleaned up on errors and avoids leaks that might otherwise arise.
Adds new tests for MQTT over WebSocket.

Adds some missing license headers as well.
2015-06-29 18:35:08 -04:00
Timothy Bish 789eb9abf9 https://issues.apache.org/jira/browse/AMQ-5834
Ensure that a publish receives an ACK even when the user is not
authorized to write to the target destination
2015-06-10 14:59:02 -04:00
Timothy Bish af999fe2b2 https://issues.apache.org/jira/browse/AMQ-5303
Resolves issues with the virtual topic subscription strategy especially
when subscribing durably to the Topic portion of a virtual destination.
2015-06-05 18:05:03 -04:00
Timothy Bish 47e954d0f6 https://issues.apache.org/jira/browse/AMQ-5303
Fix for subscription recovery of durable topic subscriptions using
default subscription strategy and subscribing to a VirtualTopic
instance.
2015-06-04 15:14:52 -04:00
Timothy Bish f37b005acf https://issues.apache.org/jira/browse/AMQ-5776
Add better support for maxFrameSize configuration that fits with the
defaults configuration for the broker by allowing the maxFrameSize to be
configured via ?wireFormat.maxFrameSize on STOMP, AMQP, and MQTT.
Previously we only supported transport.wireFormat.maxFrameSize.
2015-06-02 15:25:11 -04:00
Timothy Bish 3125caee5b https://issues.apache.org/jira/browse/AMQ-5794
implement transport.connectAttemptTimeout option across the transports
fro OpenWire, STOMP, AMQP and MQTT and add tests to cover.
2015-05-26 12:29:23 -04:00
Timothy Bish 3454a8b596 https://issues.apache.org/jira/browse/AMQ-5781
add maxFrameSize to the transport and enforce across the TCP, SSL, NIO
and NIO+SSL transport connectors.
2015-05-18 17:50:55 -04:00
Timothy Bish fd2805fe1c https://issues.apache.org/jira/browse/AMQ-5441
Don't dip into the store to recover durable topic subscriptions or queue
subscriptions depending on the subscription strategy in use.  The needed
information is always kept in either TopicRegion or QueueRegion even
after restart as all stored destinations are reloaded as the broker is
started.
2015-05-15 16:01:54 -04:00
gtully f5283a9045 https://issues.apache.org/jira/browse/AMQ-5734 - fix intermittent failure - seems the retained empty message gets dispatched so we need to consume it or it may have been dispatched to the client, causing a later failure 2015-04-28 16:18:22 +01:00
Timothy Bish 9ef4259297 https://issues.apache.org/jira/browse/AMQ-5616
Use ConcurrentMap in declarations
2015-04-28 11:15:08 -04:00
Dejan Bosanac 45eecf3351 upgrade java paho mqtt client 2015-04-21 15:04:04 +02:00
Dejan Bosanac a4fbe70872 https://issues.apache.org/jira/browse/AMQ-5734
Support MQTT 3.1 silent subscription fail
2015-04-20 18:17:09 +02:00
Timothy Bish 1c72579d7a https://issues.apache.org/jira/browse/AMQ-5598
Parallel connection test, could not reproduce issue.
2015-03-06 16:27:04 -05:00
Dejan Bosanac 4f57744934 https://issues.apache.org/jira/browse/AMQ-5594 - mqtt and virtual topic subs; more refined removing of destinations, as we don't want to remove all descendant destination in a wildcard case 2015-03-02 14:40:07 +01:00
Timothy Bish 101b7123fa https://issues.apache.org/jira/browse/AMQ-5607
Some cleanups of the tests to speed things up.
2015-02-20 19:24:46 -05:00
Dejan Bosanac 05c3112402 https://issues.apache.org/jira/browse/AMQ-5594 - virtual topics and wildcards 2015-02-18 18:29:20 +01:00
gtully ae595c95b1 [maven-release-plugin] prepare for next development iteration 2015-01-30 12:46:19 +00:00
gtully 4ba1a1689f [maven-release-plugin] prepare release activemq-5.11.0 2015-01-30 12:46:08 +00:00
gtully bf5a2997c7 [maven-release-plugin] prepare for next development iteration 2015-01-26 16:48:46 +00:00
gtully eec2955bde [maven-release-plugin] prepare release activemq-5.11.0 2015-01-26 16:48:37 +00:00
gtully 64fa706d54 Revert "[maven-release-plugin] prepare release activemq-5.11.0"
This reverts commit f47fbe4b89.
2015-01-26 16:39:35 +00:00
gtully f47fbe4b89 [maven-release-plugin] prepare release activemq-5.11.0 2015-01-26 16:17:43 +00:00
Dejan Bosanac d5470254af https://issues.apache.org/jira/browse/AMQ-5530 - default mqtt subscription prefetch 2015-01-26 12:53:56 +01:00
Dejan Bosanac 7948d69056 https://issues.apache.org/jira/browse/AMQ-5511 - retained message for zero-byte clientId client 2015-01-09 12:58:53 +01:00
Timothy Bish 7ebc6ceef8 https://issues.apache.org/jira/browse/AMQ-5481
Add some additional logs to MQTT at the trace level.
2015-01-06 10:32:56 -05:00
Timothy Bish 4b7131ff85 https://issues.apache.org/jira/browse/AMQ-5468
Add a connect check in the inactivity monitor to account for opened
connections that might drop but not be spotted, in the case where the
connect frame is lost this can lead to connections that aren't fully
opened and won't be cleaned up until the broker detects the socket has
failed.  

By default the connection timer is set to 30 seconds, if no connect
frame is read by then the connection is dropped.  The broker can be
configured via the 'transport.connectAttemptTimeout' URI option, a value
<= zero disable the check.
2015-01-05 18:53:34 -05:00
Hadrian Zbarcea aedcae139b Revert "[maven-release-plugin] prepare release activemq-5.11.0"
This reverts commit 48b0cf396c.
2015-01-05 12:25:58 -05:00
Hadrian Zbarcea 89995f4723 Revert "[maven-release-plugin] prepare for next development iteration"
This reverts commit 7b285c6f52.
2015-01-05 12:25:47 -05:00
Dejan Bosanac 7b285c6f52 [maven-release-plugin] prepare for next development iteration 2014-12-29 12:44:32 +01:00
Dejan Bosanac 48b0cf396c [maven-release-plugin] prepare release activemq-5.11.0 2014-12-29 12:44:20 +01:00
Hadrian Zbarcea 08b1bedc6d [AMQ-5455] Use a working repository for the paho dependency 2014-11-24 19:31:32 -05:00
Ciprian Ciubotariu b9cbd93a68 Fix mqtt-client artifact missing from eclipse repository
Add alternate repository

Signed-off-by: Hadrian Zbarcea <hadrian@apache.org>
2014-11-24 17:40:53 -05:00
Timothy Bish 74d2c2425f https://issues.apache.org/jira/browse/AMQ-5390
Adds a test case to show that things work as expected.
2014-10-21 17:59:32 -04:00
Timothy Bish d9d9d5b666 https://issues.apache.org/jira/browse/AMQ-5389
https://issues.apache.org/jira/browse/AMQ-5387

Fixes some issues around processing of back to back frames and reading
of null blocks between messages.
2014-10-21 17:14:47 -04:00
Timothy Bish 6885ff0a62 https://issues.apache.org/jira/browse/AMQ-5365
Trap VirtualTopic names that leak from messages sent across a broker
network.
2014-10-20 15:05:08 -04:00
Dejan Bosanac 28b45341d1 https://issues.apache.org/jira/browse/AMQ-5399 - mqtt - out of order acks 2014-10-17 14:40:33 +02:00
Timothy Bish 62c20ebdcf Apply fix and add test for:
https://issues.apache.org/jira/browse/AMQ-5385
2014-10-09 12:40:13 -04:00
Dejan Bosanac fc3d90e8b7 https://issues.apache.org/jira/browse/AMQ-5377 - mqtt wildcard conversion 2014-10-01 12:18:32 +02:00
Daniel Kulp d510b8b334 Remove some unneeded repos, move one to just the module that needs it, add a defaultGoal 2014-08-19 12:15:46 -04:00
Timothy Bish eaed01992e fix the test builds. 2014-08-13 09:37:18 -04:00
Timothy Bish 59f8cfc604 https://issues.apache.org/jira/browse/AMQ-5290
Minor cleanup, change transport option from subscriptionStrategyName to
just subscriptionStrategy.
2014-08-12 14:59:51 -04:00
Timothy Bish ec049a0882 https://issues.apache.org/jira/browse/AMQ-5290
Some more refactorings to allow the strategies to have more control of
the subsciption model in use.
2014-08-11 14:03:35 -04:00
Timothy Bish 145b64ac2a Fix test name so it gets included in the surefire test runs. 2014-08-08 17:41:50 -04:00
Christian Posta c42b874972 Test for https://issues.apache.org/jira/browse/AMQ-5290 2014-08-06 15:53:39 -07:00
Timothy Bish 413e4840d6 https://issues.apache.org/jira/browse/AMQ-5290
Adds a subscription strategy model where the default is the normal
durable topic subscription based approach or a strategy that maps all
subscriptions and publish operations to a Virtual Topic model.  A
network of brokers can network the Queues instead of having the durable
topics subscriptions repaeted on each Broker.
2014-08-06 17:41:19 -04:00
Timothy Bish 052d293143 https://issues.apache.org/jira/browse/AMQ-5308
Improve performance of the codec for large message processing.
2014-08-05 12:43:36 -04:00
Dejan Bosanac c99e2d8372 https://issues.apache.org/jira/browse/AMQ-4719 - allowLinkStealing was not set/used properly by default on mqtt connector 2014-08-05 16:23:45 +02:00
Timothy Bish 7c04ead460 https://issues.apache.org/jira/browse/AMQ-5307
Fixed the MQTTCodec to properly handle frames that come in split up or
bunched together.
2014-08-04 18:58:03 -04:00
Timothy Bish d8f9686d2a https://issues.apache.org/jira/browse/AMQ-5290
Clean up some code to make future work a bit simpler.
2014-07-31 17:49:59 -04:00
Timothy Bish 5de0c8e2fb https://issues.apache.org/jira/browse/AMQ-5298
Fix the NPE case
2014-07-31 17:23:35 -04:00
Timothy Bish efa55278ec https://issues.apache.org/jira/browse/AMQ-5299
Fix duplicate call to unsubscribe.
2014-07-30 20:03:48 -04:00
Timothy Bish 2cd54248c6 https://issues.apache.org/jira/browse/AMQ-5290
Reduce memory overhead of the MQTT Protocol converter by not storing the
UTF8Buffer instances and instead simply store the needed String values.
We always access the String value anyway so all of the UTF8Buffer object
we store carry the overhead of both marshalled UTF-8 bytes and an
unmarshalled String object.
2014-07-30 12:00:38 -04:00
Timothy Bish 829a186f2a Revert to using non-parameterized tests, makes it simpler to debug. 2014-07-29 20:16:00 -04:00
Timothy Bish f55edcfa25 https://issues.apache.org/jira/browse/AMQ-5187
Allow virtual destination to recover retained messages.
2014-07-29 17:20:25 -04:00
Timothy Bish b11fc8faf4 Updated link stealing test to account for isConnected state not being
immediately updated which can lead to failure on a very fast machine.
2014-07-29 15:08:52 -04:00
Dhiraj Bokde bba026a42e Removed redundant broker stop/start in unit test 2014-07-28 14:24:38 -07:00
Dhiraj Bokde e8c5a9fdb4 https://issues.apache.org/jira/browse/AMQ-4719 added enableLinkStealing=true for MQTTSslTransportFactory, test for duplicate client ids for MQTT 2014-07-28 14:15:02 -07:00
Timothy Bish 8d04e2be8e Remove unneeded broker stop / start at test begin. 2014-07-28 15:57:08 -04:00
Dhiraj Bokde 73908d6498 https://issues.apache.org/jira/browse/AMQ-5292 Added support for publishDollarTopics transport option for MQTT to support Topics with '$' prefix 2014-07-28 12:38:43 -07:00
Timothy Bish 619864dd42 https://issues.apache.org/jira/browse/AMQ-5288
Fix MQTT to return meaningful error codes on connect fail.
2014-07-24 13:31:17 -04:00
Timothy Bish fb569e3fbc Refactored MQTT test suite to use parameterized tests and ensure that
the various tests are run on the currently supported transport
connectors.
2014-07-23 18:46:11 -04:00
Timothy Bish 93f686c5cf Test code cleanup 2014-07-23 15:57:52 -04:00
Daniel Kulp 4de5219a8f No point in waiting around for 5 seconds to prove that nothing will be received. 4 minutes off tests. 2014-07-21 15:56:05 -04:00
Timothy Bish 3653f81b5b https://issues.apache.org/jira/browse/AMQ-5233
Return the right code when a client connects with bad credentials.
2014-07-21 15:55:06 -04:00
Kevin Earls eae2112028 Exclude some MQTT tests on HP-UX, see AMQ-5267 2014-07-10 10:32:20 +02:00
Kevin Earls d4a376d885 added/updated timeouts to help resolve CI failures 2014-07-09 16:24:03 +02:00
Dejan Bosanac fa086396a7 [maven-release-plugin] prepare for next development iteration 2014-06-05 11:59:29 +02:00
Dejan Bosanac 58dd93e42e [maven-release-plugin] prepare release activemq-5.10.0 2014-06-05 11:59:17 +02:00
Dejan Bosanac c2cf78542f [maven-release-plugin] prepare for next development iteration 2014-06-04 11:33:17 +02:00
Dejan Bosanac 5bc741f227 [maven-release-plugin] prepare release activemq-5.10.0 2014-06-04 11:33:03 +02:00
Dhiraj Bokde 6c859676b3 Fixed AMQ-5160, fixed durable subscription retroactive recovery 2014-05-26 11:07:19 +02:00
Dhiraj Bokde 8644090377 Fixed AMQ-5160, fixed race condition for retained messages 2014-05-26 11:07:19 +02:00
Dhiraj Bokde 70f7c5805c Fixed AMQ-5160, fixed test testNoMessageReceivedAfterUnsubscribeMQTT 2014-05-26 11:07:19 +02:00
Dhiraj Bokde 0a39782bf5 Fixed AMQ-5160, polished MQTT tests 2014-05-26 11:07:19 +02:00
Dhiraj Bokde 88c6ee97e0 Fixed AMQ-5160, remove durable subscription in onUnsubscribe() 2014-05-26 11:07:19 +02:00
Dhiraj Bokde b36adffe71 Fixed AMQ-5160, removed redundant MQTTRetainedMessages 2014-05-26 11:07:19 +02:00
Dhiraj Bokde a581d010aa Fixed AMQ-5160, Added RegionBroker.getConnectionContext(), made Topic.recoverRetroactiveMessages() public to force message recovery from MQTTProtocolConverter for duplicate subscriptions, added new tests for retained messages and JMX interoperability 2014-05-26 11:07:18 +02:00
Dhiraj Bokde bcb60a482c Partial fix for AMQ-5160, attempts to resolve retained messages using subscription recovery policy, but fails to resend retained messages for duplicate subscriptions 2014-05-26 11:07:18 +02:00
Dejan Bosanac 64baf092f0 https://issues.apache.org/jira/browse/AMQ-5160 - test for retained messages wildcard security issue 2014-05-06 11:44:28 +02:00
Hadrian Zbarcea 4215db2f26 Temporarily disable failing test 2014-05-01 15:25:31 -04:00
Timothy Bish f4a8b117ce https://issues.apache.org/jira/browse/AMQ-5127
Add test case to show this is now fixed in 5.10
2014-03-31 12:42:44 -04:00
Timothy Bish 45c0dfb2bc https://issues.apache.org/jira/browse/AMQ-5092
Add patch that fixes the missing test case.
2014-03-24 10:16:12 -04:00
Timothy Bish afddc1a832 https://issues.apache.org/jira/browse/AMQ-5092
Apply patch3 to fix packet id generation
2014-03-21 17:10:06 -04:00
Dejan Bosanac 9c67f0df71 https://issues.apache.org/jira/browse/AMQ-5112 - improving mqtt tests 2014-03-21 11:25:32 +01:00
Dejan Bosanac 4ba4aa21d3 https://issues.apache.org/jira/browse/AMQ-5112 - mqtt transport thread safety 2014-03-20 11:31:44 +01:00
gtully bf8eb0e6ca https://issues.apache.org/jira/browse/AMQ-5108 - MQTT subscriptions for cleansession=true MUST be non-durable - patch applied with thanks to Dhiraj Bokde 2014-03-19 14:24:51 +00:00
Dejan Bosanac ac23b01749 AMQ-5101 - MQTT SUBACK packet MUST use return code 0x80 to report failed topic subscriptions 2014-03-14 14:10:12 +01:00
gtully 67f151fe0b https://issues.apache.org/jira/browse/AMQ-5092 - apply patch from Dhiraj Bokde with thanks 2014-03-12 13:00:38 +00:00
Hiram Chirino e7e317dc7e Applying patch AMQ-5074: MQTT paths with empty levels are not handled correctly.
Thanks Dhiraj!
2014-02-24 09:05:23 -05:00
Timothy Bish 7e56f348bc https://issues.apache.org/jira/browse/AMQ-5066
apply patch after review
2014-02-19 14:12:49 -05:00
Timothy Bish 0db7e69b4e https://issues.apache.org/jira/browse/AMQ-5065
Patch applied.
2014-02-19 14:09:34 -05:00
Timothy Bish b97fa15d53 https://issues.apache.org/jira/browse/AMQ-5059
apply patch
2014-02-17 13:33:07 -05:00
Timothy Bish b679787917 https://issues.apache.org/jira/browse/AMQ-5058 2014-02-17 12:35:33 -05:00
Hadrian Zbarcea 7b555c2898 AMQ-5047. Fix packaging issues related to maven version 2014-02-15 16:15:04 -05:00
Timothy Bish a059bf4a90 https://issues.apache.org/jira/browse/AMQ-5051
fix potential NPE
2014-02-13 16:39:12 -05:00
Hiram Chirino 706830268e More improvements for AMQ-5043. Drop all messages sent to topics starting '$' to honor MQTT 3.1.1 spec requirments. 2014-02-12 13:53:18 -05:00
Hiram Chirino 6e68a37115 More improvements for AMQ-5043. Reworked the MQTT inactivity monitor so that it's more accurate. 2014-02-12 13:26:16 -05:00
Hiram Chirino e2a7d6af5a More improvements for AMQ-5043. 2014-02-12 10:59:40 -05:00