Commit Graph

518 Commits

Author SHA1 Message Date
Christopher L. Shannon (cshannon) e99c814830 Fixing missing volatile on references in VMTransport to prevent a synchronization bug.
This resolves https://issues.apache.org/jira/browse/AMQ-5787
2015-05-20 15:09:17 -04:00
gtully 9ad65c62ed https://issues.apache.org/jira/browse/AMQ-5164 https://issues.apache.org/jira/browse/AMQ-4842 - master slave advisory needed to wait for failover reconnect - exponential backoff was sometimes giving to long a delay. Retroactive override needs to applied after policies. Tests reinstated 2015-05-20 09:57:05 +01:00
gtully 3fdf9861b2 https://issues.apache.org/jira/browse/AMQ-5783 - properly remove free topic from the store when there are no remaining subs. Issue: release of the index but remaining metadata refs to the old state. Mbean was also left dangling. test thanks to pat fox 2015-05-20 09:57:05 +01:00
gtully 17f4f349f3 more tidy up of derby usage in tests to ensure proper cleanup; ci failures 2015-05-20 09:57:05 +01:00
Timothy Bish fd2805fe1c https://issues.apache.org/jira/browse/AMQ-5441
Don't dip into the store to recover durable topic subscriptions or queue
subscriptions depending on the subscription strategy in use.  The needed
information is always kept in either TopicRegion or QueueRegion even
after restart as all stored destinations are reloaded as the broker is
started.
2015-05-15 16:01:54 -04:00
gtully 5e36f65e0e https://issues.apache.org/jira/browse/AMQ-4705 - lastmod granualarity is second on some nix. Also write on lock acquire to ensure modification time change 2015-05-15 13:23:12 +01:00
gtully 181e4d4617 https://issues.apache.org/jira/browse/AMQ-4705 - ensure cached lastModified is externally visible - hardened test showed window for missed mod 2015-05-14 13:48:14 +01:00
gtully b8a20e9ef6 skipped first dispatch on vmtransport needed a better test - reworked to avoid busy loop on full and ensured sync on started for enqueue. Sort FailoverStaticNetworkTest and NetworkOfTwentyBrokersTest intermittent failures 2015-05-13 13:56:24 +01:00
gtully ccbbecb4a4 https://issues.apache.org/jira/browse/AMQ-4705 - apply patch from ganesh murthy with thanks. Fix and test making use of last modified to track deletion and recreation events 2015-05-12 23:19:07 +01:00
gtully c89bb7a316 fix intermittent failure of FailoverStaticNetworkTest. Bridge fails to start triggerStartAsyncNetworkBridgeCreation thread waiting on localBrokerInfo. The command was dropped due to contention between dispatch and peer start. Fix and test. Relates to https://issues.apache.org/jira/browse/AMQ-3684 2015-05-12 22:10:57 +01:00
Dejan Bosanac e19293de5f https://issues.apache.org/jira/browse/AMQ-5772
Improve Broker.removeConnection() method, so that we pass the cause for removing it (if available)
2015-05-12 14:23:12 +02:00
Timothy Bish 16a1e2b686 https://issues.apache.org/jira/browse/AMQ-5768
Exclude advisory topics from the expired message check.
2015-05-08 13:45:21 -04:00
gtully 1359e8eae2 https://issues.apache.org/jira/browse/AMQ-4068 fix intermittent test failure. Rework usage check to prevent additions to the store rather than blocking scheduled dispatch from the store 2015-05-08 14:14:25 +01:00
Timothy Bish 1271d2ea03 https://issues.apache.org/jira/browse/AMQ-5758
Fix for potential NPE.
2015-05-06 15:13:15 -04:00
Timothy Bish 9ef4259297 https://issues.apache.org/jira/browse/AMQ-5616
Use ConcurrentMap in declarations
2015-04-28 11:15:08 -04:00
gtully c129051175 https://issues.apache.org/jira/browse/AMQ-5746 - separate out start from creation of scheduler store. test via Martyn Taylor with thanks. This closes #80 2015-04-27 16:16:49 +01:00
gtully 23ecbe80d0 https://issues.apache.org/jira/browse/AMQ-5743 - confine logging to the jmx purge op 2015-04-24 13:35:02 +01:00
gtully c85fa67e1c https://issues.apache.org/jira/browse/AMQ-5742 - fix and intermittent failure of DemandForwardingBridgeTest is sorted 2015-04-23 14:32:40 +01:00
gtully eb6c082631 https://issues.apache.org/jira/browse/AMQ-5735 - fix up semantics around lastDeliveredSequenceId 2015-04-22 16:32:17 +01:00
Timothy Bish a0835c2c21 https://issues.apache.org/jira/browse/AMQ-5371
Move option ignoreNetworkConsumers up to base AbortSlowConsumerStrategy
so it can be used for both the original version and the slow ack aware
version.
2015-04-20 15:20:33 -04:00
Martyn Taylor a65ac586c2 https://issues.apache.org/jira/browse/AMQ-5729 - Do not log passwords on MBean method calls.
Previous to this patch the AnnotatedMBean class would simply dump
any arguments passed in via JMX call to the log (when audit is enabled).
Method parameters can sometimes contain sensitive information such as
the password field on QueueView.sendTextMessage.

This patch adds a @Sensitive annotation to the JMX module allowing
implementations of MBean interfaces to mark method parameters as sensitive
preventing values from being logged.
2015-04-20 18:06:45 +01:00
Timothy Bish be66175079 https://issues.apache.org/jira/browse/AMQ-5719
This closes #86

commit 72837960cf
Author: Christopher L. Shannon (cshannon)
<christopher.l.shannon@gmail.com>

Updated durable related error messages in TopicRegion to include both
subscriptionName and clientId.
2015-04-14 17:42:30 -04:00
Dejan Bosanac f556076a2c https://issues.apache.org/jira/browse/AMQ-4929 - remove audit from TransactionBroker 2015-04-14 14:55:11 +02:00
Dejan Bosanac 2852a8bdb1 https://issues.apache.org/jira/browse/AMQ-4929 - remove BrokerService.supportFailoverSupport. This closes #60 2015-04-14 13:59:01 +02:00
Timothy Bish ec9a92f6fc https://issues.apache.org/jira/browse/AMQ-5649
Ensures that max producers on a connection includes anonymous producers
in its count, based on patch from: Christopher L. Shannon (cshannon)
<christopher.l.shannon@gmail.com>

Merged the test into the existing ConfigTest that validates the max
producers functionality.
2015-04-13 10:25:51 -04:00
Dejan Bosanac 2562cf21a2 https://issues.apache.org/jira/browse/AMQ-5718 - don't add messages to subscriber while it's discarding 2015-04-13 11:16:55 +02:00
Dejan Bosanac 69767a2f2f https://issues.apache.org/jira/browse/AMQ-5665 - memory store don't propagate connection context 2015-04-09 13:29:37 +02:00
Clebert Suconic ab8f54b066 fixing a race on SharedLockFile 2015-04-08 11:17:00 -04:00
Clebert Suconic 0a161380f8 AMQ-5709 Fixing tests
https://issues.apache.org/jira/browse/AMQ-5709

This is just fixing a test properly
2015-04-08 10:28:42 -04:00
Clebert Suconic 89c75ca28a AMQ-5709 Reworking Logging on Locker
https://issues.apache.org/jira/browse/AMQ-5709

This is about changing how the Log is done in case of not being able to lock (log only once)
2015-04-07 17:24:48 -04:00
Christian Posta 61da1faa4c https://issues.apache.org/jira/browse/AMQ-5672 Added an option for allowing only a single selector for the virtual destination selector cache. also added some JMX views into the selector cache that can be used at runtime. includes unit tests 2015-04-06 16:12:20 -07:00
gtully 1d71cb7036 https://issues.apache.org/jira/browse/AMQ-5674 - revisit change - use single redelivey delay attribute for both initial and subsequent delays - resolves regression in BrokerRedeliveryTest 2015-04-03 14:19:15 +01:00
Timothy Bish 6df02555fd https://issues.apache.org/jira/browse/AMQ-5680
Fix typo in getTempQueues method.
2015-04-01 09:52:33 -04:00
Dejan Bosanac 8bb58036a0 https://issues.apache.org/jira/browse/AMQ-5697 - authorization map and composite destinations 2015-03-31 17:13:37 +02:00
Christian Posta efc9a8d578 Fix for https://issues.apache.org/jira/browse/AMQ-5689 Queue dispatching hangs when there are redelivered messages that dont match current consumers selectors, refactored out the pendingDispatchList in Queue implementation 2015-03-27 15:19:56 -07:00
Timothy Bish 05ff52dc15 https://issues.apache.org/jira/browse/AMQ-5413
https://issues.apache.org/jira/browse/AMQ-5433
https://issues.apache.org/jira/browse/AMQ-5647
https://issues.apache.org/jira/browse/AMQ-5684

Adds support for AMQP drain and fixes some issues around incorrect
dispatching and credit handling.  Should resolve several issues that
have been seen using test suites from AmqpNetLite and other AMQP
clients.
2015-03-27 15:11:38 -04:00
Timothy Bish e33b3f5939 https://issues.apache.org/jira/browse/AMQ-5686
Call into the delegate for asyncAddTopicMessage to avoid a stack
overflow.
2015-03-24 16:07:07 -04:00
gtully 55f040e616 https://issues.apache.org/jira/browse/AMQ-5568 - ensure directory exists - fix ci 2015-03-10 16:18:50 +00:00
Dejan Bosanac 3b39d2cc2a https://issues.apache.org/jira/browse/AMQ-5644 - authorization map for wildcard subscriptions 2015-03-10 11:24:27 +01:00
Dejan Bosanac 24c2215f4e Revert "https://issues.apache.org/jira/browse/AMQ-5644 - authorization map for wildcard subscriptions"
This reverts commit 7777744dc2.
2015-03-06 18:06:17 +01:00
Dejan Bosanac 7777744dc2 https://issues.apache.org/jira/browse/AMQ-5644 - authorization map for wildcard subscriptions 2015-03-06 15:35:20 +01:00
gtully ab28b771e3 https://issues.apache.org/jira/browse/AMQ-5640 - fix by ensuring parent stat is updated on dest init, thanks for the nice test Torsten 2015-03-05 14:46:59 +00:00
gtully 8c66fba0aa https://issues.apache.org/jira/browse/AMQ-5568 - fix and test - only delete lock file if lock was held on stop 2015-03-05 13:27:40 +00:00
gtully 5313ad8a96 remove stack trace from auth failure log warn - stack trace is already covered by debug service level logging 2015-03-04 22:06:05 +00:00
Timothy Bish 67ccfcad88 https://issues.apache.org/jira/browse/AMQ-5470
Allow for early SASL authentication and failure if credentials not
valid.
2015-03-04 14:06:04 -05:00
gtully 741e3aad3e https://issues.apache.org/jira/browse/AMQ-5630 - add rejectDurableConsumers boolen attribute - when true, requests to create durable subscriptions will fail with a JMSException - not allowed 2015-03-03 13:30:10 +00:00
Dejan Bosanac 4f57744934 https://issues.apache.org/jira/browse/AMQ-5594 - mqtt and virtual topic subs; more refined removing of destinations, as we don't want to remove all descendant destination in a wildcard case 2015-03-02 14:40:07 +01:00
Timothy Bish 84c1419c3d https://issues.apache.org/jira/browse/AMQ-5621
Add the ability to toggle the default value of the ManagementContext
createConnector variable and set it to false for the surefire runs of
the unit tests, this should resolve failures of tests for no other
reason than a previous test failed to shutdown its broker.  Also speeds
up tests as they don't need to create this resource in order to use the
MBeans.
2015-02-27 14:59:31 -05:00
Timothy Bish 7af7c0143f https://issues.apache.org/jira/browse/AMQ-5597
Clean up the durable subscription unsubscribe handling to be in line
with the AMQP JMS mapping spec and switch to the QPid 0.32-SNAPSHOT
build for now to allow us to track and other changes we might want to
feed back there before release.
2015-02-27 12:18:49 -05:00
gtully 0142c4dc89 https://issues.apache.org/jira/browse/AMQ-5614 - additional expiration attribute on dead letter strategy and tests 2015-02-25 14:32:43 +00:00
gtully be919fbc94 https://issues.apache.org/jira/browse/AMQ-4483 - rework to use destination option to indicate dlq, dlq strategy is typically not in place for dlq dests, option is set when a dlq is first used via region broker sendTodlq, fix and tests 2015-02-25 14:32:43 +00:00
gtully 85b9c81a3f https://issues.apache.org/jira/browse/AMQ-5229 - implement ability to pause/resume dispatch of message to all consumers of a queue 2015-02-23 21:41:33 +00:00
Robert Gemmell 1406d40ac3 AMQ-5608: dont NPE during authentication attempt if no users were defined for the SimpleAuthenticationPlugin
https://issues.apache.org/jira/browse/AMQ-5608
2015-02-23 17:42:17 +00:00
Dejan Bosanac 05c3112402 https://issues.apache.org/jira/browse/AMQ-5594 - virtual topics and wildcards 2015-02-18 18:29:20 +01:00
Timothy Bish 94937e855a https://issues.apache.org/jira/browse/AMQ-5589
Reduce the overall time to run the AMQP tests
2015-02-16 16:47:12 -05:00
Dejan Bosanac 1cab713864 https://issues.apache.org/jira/browse/AMQ-5585 - move messages on memory limit 2015-02-13 15:16:52 +01:00
gtully db084ef776 fix AMQ1936Test,AMQ2021Test timeouts - hitting unnecessary 1s wait on shutdown command completion 2015-02-13 12:01:50 +00:00
gtully b60bfbbeb4 Revert "rework https://issues.apache.org/jira/browse/AMQ-3684 and https://issues.apache.org/jira/browse/AMQ-4532 to avoid intermittent hangs, processing shutdown wile shutdown is in progress - AMQ1936Test and AMQ2021Test - using just TransportDisposedIOException to propagate exception response and start shutdown process and ignoring broker side for logging"
This reverts commit 8cf98a070f.

seems there are a bunch of network tests that don't conform with the new approach - back to the drawing board
2015-02-12 18:00:58 +00:00
gtully 8cf98a070f rework https://issues.apache.org/jira/browse/AMQ-3684 and https://issues.apache.org/jira/browse/AMQ-4532 to avoid intermittent hangs, processing shutdown wile shutdown is in progress - AMQ1936Test and AMQ2021Test - using just TransportDisposedIOException to propagate exception response and start shutdown process and ignoring broker side for logging 2015-02-11 13:37:32 +00:00
gtully 3155c625c6 https://issues.apache.org/jira/browse/AMQ-5567 - fix and test - issue was eager dispatch with concurrent sends, recovery and outcome delivery now assign a new sequence id to message additions which sorts sequence order in the xa case 2015-02-06 12:56:29 +00:00
gtully ae595c95b1 [maven-release-plugin] prepare for next development iteration 2015-01-30 12:46:19 +00:00
gtully 4ba1a1689f [maven-release-plugin] prepare release activemq-5.11.0 2015-01-30 12:46:08 +00:00
gtully dc25f2a8f9 https://issues.apache.org/jira/browse/AMQ-5541 - support preemptive redelivery for non persistent case, fix and test 2015-01-27 16:43:35 +00:00
gtully 6c5dd2543e StoreDurableSubscriberCursor don't set its inner cursors' maxProducersToAudit correctly #57 - patch applied with thanks 2015-01-26 21:28:35 +00:00
gtully bf5a2997c7 [maven-release-plugin] prepare for next development iteration 2015-01-26 16:48:46 +00:00
gtully eec2955bde [maven-release-plugin] prepare release activemq-5.11.0 2015-01-26 16:48:37 +00:00
gtully 64fa706d54 Revert "[maven-release-plugin] prepare release activemq-5.11.0"
This reverts commit f47fbe4b89.
2015-01-26 16:39:35 +00:00
gtully f47fbe4b89 [maven-release-plugin] prepare release activemq-5.11.0 2015-01-26 16:17:43 +00:00
gtully 6cebd2c79e https://issues.apache.org/jira/browse/AMQ-5513 - interaction with - https://issues.apache.org/jira/browse/AMQ-5068 - need to ensure broker cached messages state reflects delivery attempt - RedeliveryRestartWithExceptionTest regression 2015-01-26 12:13:55 +00:00
gtully a2c5c22ec5 https://issues.apache.org/jira/browse/AMQ-5513 - additional test for reconnect/rebalance case - indicate the absense of delivery information to the destination 2015-01-23 15:23:35 +00:00
gtully 981c0f20fa fix hang on org.apache.activemq.network.FailoverStaticNetworkTest - network connector vm creation clashing with broker stop 2015-01-23 11:27:10 +00:00
gtully 189a75afdc fix AMQ4221Test failure on low disk space - use warn level when resetting to available. Test checked log for error messages 2015-01-22 11:41:06 +00:00
Claus Ibsen 5c7985c695 AMQ-5523: Average message size attribute on statistics plugin should not have decimals 2015-01-16 09:29:52 +01:00
Claus Ibsen dbf2c28b96 AMQ-5521: Average message size attribute on destination mbean should not have decimals 2015-01-16 09:22:28 +01:00
gtully cf62d58ae7 https://issues.apache.org/jira/browse/AMQ-5515 - tidy up jetty deps - fix jetty maven coords 2015-01-12 22:58:07 +00:00
gtully 869c193d1f fix mvn warn on missing plugin ver 2015-01-12 15:04:13 +00:00
gtully 849987e5dd https://issues.apache.org/jira/browse/AMQ-5513 - remove inadvertent change of statement log level 2015-01-12 13:12:25 +00:00
gtully 8dbb48a23f https://issues.apache.org/jira/browse/AMQ-4107 - apply patch - resolved intermittent failure of TwoMulticastDiscoveryBrokerTopicSendReceiveTest 2015-01-12 12:00:42 +00:00
gtully dbb1d8b83d https://issues.apache.org/jira/browse/AMQ-5513 - have lastDeliveredSequence -1 indicate nothing was received, respect this value in queue sub remove and durable sub deactivate. 0 still constitutes no info - so old clients see same behaviour as before 2015-01-09 13:30:59 +00:00
Hadrian Zbarcea 8e0865d5d1 [AMQ-5505]. Add getUptimeMillis to the BrokerView MBean. This closes #56 2015-01-05 13:23:19 -05:00
Hadrian Zbarcea aedcae139b Revert "[maven-release-plugin] prepare release activemq-5.11.0"
This reverts commit 48b0cf396c.
2015-01-05 12:25:58 -05:00
Hadrian Zbarcea 89995f4723 Revert "[maven-release-plugin] prepare for next development iteration"
This reverts commit 7b285c6f52.
2015-01-05 12:25:47 -05:00
Dejan Bosanac 7b285c6f52 [maven-release-plugin] prepare for next development iteration 2014-12-29 12:44:32 +01:00
Dejan Bosanac 48b0cf396c [maven-release-plugin] prepare release activemq-5.11.0 2014-12-29 12:44:20 +01:00
Dejan Bosanac 9f53e2bcae adding missing licences 2014-12-29 12:25:04 +01:00
gtully e16815ad3b https://issues.apache.org/jira/browse/AMQ-5174 - apply patch from paulGale with thanks replace jdbc specific lease io handler with generic lease io handler - closesThis closes #53 2014-12-22 12:37:43 +00:00
gtully 13c207292f fix failing DbRestartJDBCQueueTest 2014-12-15 14:21:47 +00:00
gtully 2d9959a6f6 https://issues.apache.org/jira/browse/AMQ-5476 - ZeroPrefetchConsumerTest regression - fix default in connection factory and refactor prefetchExtension support - https://issues.apache.org/activemq/browse/AMQ-2560 2014-12-15 14:21:47 +00:00
gtully d25c52ccb2 https://issues.apache.org/jira/browse/AMQ-5483 - fix and test - assigned group counts are updated when lru map evicts a group assignment 2014-12-11 14:42:00 +00:00
Timothy Bish 164e303e21 https://issues.apache.org/jira/browse/AMQ-5473
Apply patch that allows for durable subs to migrate when links are
stolen.
2014-12-09 10:35:58 -05:00
gtully bc3587cfc9 fix failing RecoverExpiredMessagesTest - remove duplicate ref to secedualler task in jdbc pa inheritance and fix persistence adapter ref in test 2014-12-08 14:00:43 +00:00
gtully 60ad053486 https://issues.apache.org/jira/browse/AMQ-2719 - resolve possible skipped dispatch - https://issues.apache.org/jira/browse/AMQ-2106 - remove overload so that distribution order is not compromised when consumers are removed with a valid last delivered sequence. Additional test that uses consumer recreation to redistribute groups 2014-12-05 13:59:04 +00:00
gtully 74f530a641 https://issues.apache.org/jira/browse/AMQ-5457 - fix and test - we now peek first in redeliveredWaitingDispatch 2014-11-25 14:23:33 +00:00
Timothy Bish 7d136de422 https://issues.apache.org/jira/browse/AMQ-5421
Ensure concurrent access to the destinations state data does not cause
errors.
2014-11-04 16:04:29 -05:00
gtully 52e1a05aaa https://issues.apache.org/jira/browse/AMQ-5347 - variant of patch and additional tests applied, prefetch=0 test without restart exposed ordering bug with fix for https://issues.apache.org/jira/browse/AMQ-2719 2014-10-31 16:40:41 +00:00
Dejan Bosanac dffccb1c7d https://issues.apache.org/jira/browse/AMQ-5417 - use proper classloader in TaskRunnerFactory 2014-10-29 11:30:15 +01:00
gtully 33089f3fbb https://issues.apache.org/jira/browse/AMQ-5266 track cursor pending additions size in debug logging 2014-10-23 16:56:24 +01:00
gtully 8b8f630080 isolate cursor storeHasMessage logic into durable topic sub cursor b/c only durable sub cursors have selectors that won't match, otherwise we should always read a page if the store has messages 2014-10-21 23:23:15 +01:00
gtully 67ead201e1 https://issues.apache.org/jira/browse/AMQ-5266 https://issues.apache.org/jira/browse/AMQ-4485 - single dest test with low limit exposed ignored setbatch in kahadb when sequence was not found in the index due to acking - resolved and validated with test that verifies dlq is empty 2014-10-21 16:05:46 +01:00
Timothy Bish 3873ecfe5d https://issues.apache.org/jira/browse/AMQ-5396
Reviewed the patch and it looks good, I made a small change to prevent
logging in the case where no old context exists so we don't spam the
logs.
2014-10-20 19:06:21 -04:00