927e01f0c8
Flexible AMQ7086Test on KahaDB for Jenkins
2020-02-26 08:22:19 +01:00
3faad9b357
Use simpler SLF4J API functions
...
Eliminates the need to construct a new (temporary) Object array object.
These changes were suggested by SLF4J Helper for NetBeans IDE:
http://plugins.netbeans.org/plugin/72557/
2020-02-19 07:54:25 +00:00
6d36c490e5
Fix inconsistent 'info'-level logger calls
...
Some calls to info() were guarded by checks that logging at the trace
level is enabled.
These issues were found by SLF4J Helper for NetBeans IDE:
http://plugins.netbeans.org/plugin/72557/
2020-02-19 07:41:31 +00:00
5356893fac
AMQ-7402: Inconsistent synchronization of getters/setters of some classes
...
Make synchronization consistent or remove it and declare the field volatile.
2020-02-12 17:48:34 +01:00
675fb7bcae
AMQ-7376 - Use correct type for collections retrieval
2020-01-20 18:35:01 +00:00
a0531943a4
Merge pull request #348 from nguyenhoan/patch-1
...
close DataByteArrayOutputStream buff of WriteBatch
2019-11-17 06:46:01 +01:00
892c9e2a2d
AMQ-7295 - Update JTA spec
2019-10-16 14:28:17 +01:00
ed5edb03d7
AMQ-7311 - track recovered prepared ack locations on a per subscriber basis, fix and test
2019-09-26 15:54:57 +01:00
289750d7c9
AMQ-7308 - ensure kahadb message add does not auto create the message store in error, expect an existing store. fix and test
2019-09-20 10:22:56 +01:00
4d5e41ca28
AMQ-7227 - ensure db.free file is moved in scheduler store upgrade process
2019-06-14 10:01:57 +01:00
ac01af8dec
Merge branch 'AMQ-7221'
...
This closes #364
Thanks to Alan Protasio for the patch
2019-06-11 07:51:33 -04:00
28a0cc6e5a
AMQ-7225 - fix intermittent failure, avoid gc of partial tx pending commit
2019-06-11 12:36:02 +01:00
93e726d6a7
AMQ-7225 - defer cleanup task operation till recovery processing complete, track prepared location in recovered ops to ensure they are retained on recovery failure. Fix and test
2019-06-10 15:33:13 +01:00
5eb8403b1f
AMQ-7221 - Delete Scheduled messages causes ActiveMQ create/write a unnecessary huge transaction file
2019-06-04 00:02:05 -07:00
bce979349e
AMQ-7219 - ActiveMQ replays journal file on a clean/unclean shutdown with transacted session + Non persistent Messages
2019-05-30 10:13:16 -07:00
b56819123b
AMQ-7196 - During startup ActiveMq load all the scheduleDB.data on memory causing OOM
2019-05-08 12:00:42 -07:00
cd1d5eb785
AMQ-7163 - If the broker had an unclean shutdown and number of free pages is Zero after the recovery, the next shutdown will also be 'unclean'
2019-03-06 15:33:52 -08:00
87467dc61e
AMQ-7159 - Adding a new attribute on PersistenceAdapterViewMBean to show information about Storage write/read latency
2019-03-06 11:41:08 -08:00
0262338687
close DataByteArrayOutputStream buff of WriteBatch
2019-02-26 19:07:26 -08:00
9e65435517
AMQ-7143 - Temporary transaction file (PageFile) being opened and closed many times, causing poor performance on high latency FS as NFS
2019-01-31 10:31:16 -05:00
c3714457f1
AMQ-7136 - Improve recovery of durable subscription metrics in KahaDB
...
Updated metrics recovery to only have to iterate over the order index 1
time to recovery the pending metrics for the subscriptions instead of
making a pass over the index once per subscription
2019-01-15 14:22:26 -05:00
4b51f8b66c
AMQ-7132 - ActiveMQ reads lots of index pages upon startup (after a graceful or ungraceful shutdown)
2019-01-14 10:54:26 -05:00
a16b227808
AMQ-7129 - code cleanup
2019-01-11 10:31:44 -05:00
fa2daa25e9
AMQ-7129 - fix durable message size statistics with individual ack
...
Make sure that the pending message size for a durable sub only includes
messages part of the ack range
2019-01-11 09:56:57 -05:00
25de20c77e
AMQ-7129 - Properly recover messages from KahaDB for a durable when there are
...
messages to recover before the stored lastAck value
With individual ack mode we need to check the durable ackPosition
sequence set in the KahaDB index on subsription load to see if there are
earlier messages before the lastAck value that still haven't been acked.
While this normally wouldn't happen it is possible in individual ack
mode
2019-01-09 14:34:06 -05:00
4a21edc8d5
[AMQ-7126] Improvement to perf of 5266Test
2019-01-07 21:22:34 -03:30
b86c666c40
[AMQ-7126] Prevent OOM when recovering KahaDB and memory space is insufficient to load full page. Thank you Heath Kesler and Johan Edstrom for investigation and patch.
2019-01-03 15:46:39 -03:30
612d4aeeb4
AMQ-7118 This closes #327 - with thanks to Heath Kesler
2018-12-04 12:54:30 -03:30
9012a7871b
AMQ-7091 - O(n) Memory consumption when broker has inactive durable subscribes causing OOM
2018-11-12 17:48:53 -03:30
85859fd8dc
AMQ-7082 We should make sure that pages managed during recovery are not recovered in error
...
variation of patch from Alan Protasio <alanprot@gmail.com> closes #317
2018-11-07 11:29:14 +00:00
0d34338919
AMQ-7082 - Make sure that the recovery will only mark pages as free if they were created in a previous execution
2018-11-06 04:48:22 -08:00
bf8eb08aca
AMQ-7086 - make kahadb gc/cleanup on shutdown optional to trade availability over disk usage for fast failover
2018-10-31 14:29:05 +00:00
8a1abd9bb2
AMQ-7084 - ensure allocated and unused free pages are visible to subsequent transactions, fix and test with test updates to reflect proper usage
2018-10-23 16:00:57 +01:00
fb1e642c15
AMQ-7082 - ensure flush sees free list, use lazySet to avoid store barrier, thanks cshannon
2018-10-22 15:16:26 +01:00
efa4e683bc
AMQ-7082 - fix final ref in test
2018-10-19 16:45:04 +01:00
79c74998dc
AMQ-7082 - recover index free pages in parallel with start, merge in flush, clean shutdown if complete. follow up on AMQ-6590
2018-10-19 16:00:23 +01:00
ed727d22e1
AMQ-7067 - track xa commit outcomes in ack compaction such that there are no dangling prepared tx on full recovery, fix and test
2018-10-17 18:13:36 +01:00
5d3a3fcca7
AMQ-6590 - rework fix to take the recovery hit on clean shutdown rather than on restart, trade off availability for short term disk usage
2018-10-17 12:32:04 +01:00
7c890d4776
AMQ-7067 - test and fix for eager ack compaction moving acks from data files with in progress tx and clearing the link from the prepare record, that now uses the same ack map
2018-10-12 14:51:37 +01:00
a311139bfe
AMQ-7067 - ensure updates to ackMessageFileMap are protected by the index lock
2018-10-09 12:55:11 +01:00
57c7939534
AMQ-7067 - tidy up tests and add prepare variant, limit rollback location recording to xa case. There is still some work to do for the ack compaction case to make it aware of the tx records such that those are transferred as necessary
2018-10-09 12:01:47 +01:00
99db9ef301
KahaDB Recovery can experience a dangling transaction when prepare and commit occur on different pagefiles.
...
Signed-off-by: gtully <gary.tully@gmail.com>
2018-10-09 10:19:35 +01:00
8f88dcda09
AMQ-7055 - Optimization on SequenceSet to prevent iterating through the whole set when a value bigger than the last value is added
...
Signed-off-by: gtully <gary.tully@gmail.com>
2018-09-20 10:38:44 +01:00
28819aea4a
AMQ-7015 - Changed attribute to purgeRecoveredXATransactionStrategy and
...
allow NEVER, COMMIT, and ROLLBACK
2018-07-25 12:57:17 -06:00
24b9ae2ed3
AMQ-7015 Added a purgeRecoveredXATransactions property on the KahaDB adaptor to purge prepared XA messages on recovery
2018-07-19 12:01:01 -06:00
83514ef799
AMQ-7001 - ensure cursor pending cached id list is pruned of futures that end in an exception, fix and test
2018-07-03 21:18:36 +01:00
4c972d97b9
AMQ-5875 - fix test regression in MultiKahaDBQueueDeletionTest
2018-05-31 10:20:53 +01:00
ceb97f6baa
AMQ-6707 - mKahadb, track recovered tx per store for completion, resolve test regression
2018-04-27 13:48:51 +01:00
ea70e827c0
AMQ-6707 - JDBC XA recovery and completion.
...
ensure pending transactions are visible for recovery without restart
sync store and cursor size during and after completion
ensure pending messages are not visible to browsers
retain transaction state on jdbc error
a bunch of new tests around xa completion
2018-04-26 14:58:48 +01:00
ec6fa19099
[AMQ-6815] rework to drop the batch reference from Location such that batches are free for gc when index pages are agressively cached
2018-01-11 12:56:40 +00:00
6da08b245e
[AMQ-6849] provide a virtualTopic dropOnResourceLimit attribute, default to false.
...
Enabling will allow dispatch to continue even when end to some consumer queues
fail due to resource constraints.
The existing systemUsage sendFailIfNoSpace and sendFailIfNoSpaceAfterTimeout are
promoted to destination policy options allowing selective destinations to fail a
send with an exception. The global system usage options are still in place.
When dropOnResourceLimit=true dispatch will continue in the event that any
subscription queue throws a resource limit exception on send failure.
2017-10-25 14:53:20 +01:00
e793260573
[AMQ-6831, AMQ-6771] trigger eofexception on read -1 - AMQ6522Test
2017-10-11 00:20:44 +01:00
f989992278
[AMQ-6831, AMQ-6771] fix up recovery check to ensure full batch is available in memory, regression from AMQ-6771
2017-10-10 17:24:09 +01:00
8c3ef6cadb
[AMQ-6815] have checkpoint validate status of async writes to avoid stale metadata and validate location size on read to avoid potential oom on restart
2017-09-19 16:51:00 +01:00
a359d8152c
[AMQ-6277] take account of producer audit not being updatated on recovery check, avoid unnecessary partial journal replay
2017-09-15 13:48:03 +01:00
42bf6e9061
[AMQ-4947] ensure index page file does not skip forcing metadata - size is important to the page file
2017-09-04 16:43:48 +01:00
8c218ee05d
[AMQ-6771] do linear sequential scan of journal when validating checksums - remove batch reads via seek/read which depend on write batch size
2017-07-17 12:18:25 +01:00
a9fe4e33c3
[maven-release-plugin] prepare for next development iteration
2017-06-27 13:41:28 -04:00
5f0d6943cb
[maven-release-plugin] prepare release activemq-5.15.0
2017-06-27 13:41:01 -04:00
b07821ab64
[AMQ-6625] remove kahadbioexceptionhandler by pushing allowIOResumption into persistence adapter. This allows the lease locker to still be used with kahadb for stopStartConnectors support
2017-06-15 17:28:31 +01:00
f4c11f73bb
[AMQ-6688] catch throwable on add task such that result error result is not lost on failed async send, fix and test
2017-05-29 17:14:05 +01:00
eb1a3eb77b
[AMQ-6670] - harden the test to avoid ci failure
2017-05-10 11:30:30 +01:00
053c38f99f
[AMQ-6670] - disable expiry processing that may page in and change the test
2017-05-08 11:53:55 +01:00
2518bded67
[AMQ-6670] - trap classcast and marshall errors on load message from journal such that errors are consistently propagated to the ioExceptionHandler
2017-05-05 15:43:09 +01:00
af03ad4679
[AMQ-6652] add final modifier to test
2017-04-11 11:39:22 +01:00
ca5e41bb7a
[AMQ-6652] ensure checkpoint pagefile flush includeds the checkpoint transaction
2017-04-10 17:15:07 +01:00
172c29091e
AMQ-6651: Add new implementations of the writeUTF8 and readUTF8 methods that are based on Apache Harmony code. This also avoid some code duplication that was occurring.
2017-04-10 10:49:17 -04:00
c1cbf509da
[AMQ-6644] - ensure journal files past last update are not included in the logged gc set in error
2017-04-04 12:21:31 +01:00
2731f04f1c
AMQ-6642: Fix potential NPE on updateMessage
...
Fixing potential NPE when calling updateMessage on a Queue store in
KahaDB if subscription statistics are enabled. Also reduced the
visibily from public to protected to subscription statistic related
methods that shouldn't be public and added null pointer checks there as
well.
https://issues.apache.org/jira/browse/AMQ-6642
2017-03-31 09:06:01 -04:00
c5a8b2c8b1
[AMQ-6625] ensure kahadb stops operation on the first IOException to facilitate auto recovery from partial writes
2017-03-13 13:49:41 +00:00
21ae1ef2e6
[AMQ-6606] - reset next batch so it does not get reused after error and refine fix to sync write batches b/c async locations will already be in the index
2017-03-07 12:28:58 +00:00
0d824a8e68
AMQ-6377: Storing JournalSyncStrategy as an enum
...
Switching MessageDatabase to store JournalSyncStrategy as its enum value
instead of String to avoid the performance penalty of comparing Strings
everytime isEnableJournalDiskSyncs() is called which currently happens
on every write.
2017-03-06 07:54:39 -05:00
d53b8f8d42
[AMQ-6606] avoid partial writes to the end of the journal - revert offset increment on ioexception, fix and test
2017-02-21 17:04:00 +00:00
9b64e188b5
[AMQ-6432] issue was journal scan on newly created ack file. I left the relevant braces from AMQ-6288 in place. Fix and test
2017-02-03 16:58:52 +00:00
e3b529129a
[AMQ-6432] improve the logging to see the current offset
2017-02-02 12:14:17 +00:00
83511c96e5
https://issues.apache.org/jira/browse/AMQ-6590
...
Removing un-needed imports
2017-02-02 07:09:57 -05:00
38d85be476
https://issues.apache.org/jira/browse/AMQ-6590
...
Fix KahaDB index free page recovery on unclean shutdown so that existing
free pages will be tracked and not lost.
2017-02-02 07:06:11 -05:00
0ad62f722f
https://issues.apache.org/jira/browse/AMQ-6572
...
On journal start use lastFileLength instead of maxFileLength when
checking for unused space in the last journal file as it is possible the
length of the last journal file is not the same length as maxFileLength
2017-01-23 11:01:20 -05:00
20522394cc
[AMQ-6567] ensure gc file removal/move is completed after index updates to avoid dangling index referenced on partial failure. Fix and test
2017-01-17 14:05:04 +00:00
281d600ae2
https://issues.apache.org/jira/browse/AMQ-6563
...
ensure that the lock is always released in the load method.
2017-01-13 11:48:19 -05:00
0ae90c0897
https://issues.apache.org/jira/browse/AMQ-6547 - add storeUsage attribute to mKahadb filtered adapter such that disk utilisation is available as a QOS
2016-12-20 14:47:22 +00:00
5fd63a0e4e
https://issues.apache.org/jira/browse/AMQ-6545
...
Fixing the order of locks acquired in the KahaDB journal to prevent a
deadlock during file rotation
2016-12-16 13:44:18 -05:00
0f0bdb21ef
https://issues.apache.org/jira/browse/AMQ-6524
...
Fixing a thread safety issue with memoryUsage when using concurrentStoreAndDispatch
that was causing memory usage to get out of sync.
The InnerFutureTask class inside KahaDB was not thread safe which was
the root cause of the problem.
2016-12-05 07:10:20 -05:00
dad629e889
[AMQ-6522] - remove hardcoded 32k batch limit from recovery check of the journal, fix and test
2016-11-29 11:32:03 +00:00
0a29533ed7
[AMQ-6520] respect kahadb indexDirectory for perDestination mKahaDB - fix and test
2016-11-25 16:44:28 +00:00
2c828b23df
https://issues.apache.org/jira/browse/AMQ-6504
...
Fix intermittent test failure
2016-11-21 12:37:52 -05:00
980162233f
https://issues.apache.org/jira/browse/AMQ-6504
...
Round the start time value not truncate to ensure delay falls on the
correct side of the scheduling block.
2016-11-11 14:48:49 -05:00
3b7613d930
AMQ-6451 - catch errors on preallocation. allocate direct buffer on start and reuse to ensure resource availability at runtime
2016-11-08 14:05:46 +00:00
e725451521
This closes #162 . Minor improvement in using the Logger api
2016-11-03 17:26:00 -04:00
be24a133ef
This closes #88 (merged as a65ac586). More file permissions fixes.
2016-11-03 14:26:34 -04:00
d5a929c0d2
This closes #205 . Won't fix. (fix even more file permissions)
2016-11-03 14:11:40 -04:00
d54d046b8a
This closes #185 . Won't fix. (fix more file permissions)
2016-11-03 11:54:33 -04:00
1a91decf9f
https://issues.apache.org/jira/browse/AMQ-6483
...
Fix conversion from long to int and back to long again.
2016-10-26 13:27:24 -04:00
538ed74510
NO-JIRA - ensure stack trace in incuded with exception that terminates data file appender thread
2016-10-07 16:26:07 +01:00
351faf2699
https://issues.apache.org/jira/browse/AMQ-6445
...
Fixing RandomAccessFile usage so that the file will be properly closed
even if there is an exception
2016-09-29 06:16:40 -04:00
a82c95cd29
https://issues.apache.org/jira/browse/AMQ-6436
...
The temporary store will now delete the old temp directory on start up
if lazyInit is true instead of waiting for the store to initialize to
clear up space. This prevents space on the disk from being wasted with
old data if the temp store isn't initialized
2016-09-23 15:47:27 -04:00
18571ce09b
https://issues.apache.org/jira/browse/AMQ-6430
...
Modifying patch so that only stores that persist the noLocal flag will
check if this flag has changed to prevent a subscription from being
deleted by mistake
2016-09-23 10:59:32 -04:00
f8bc19b96d
AMQ-6413 - ensure audit update on skipped store add for kahadb concurrentStoreAndDispatch. Fix and test
2016-09-01 16:46:21 +01:00
5a874816b7
AMQ-6403 - add indexDirectory attribute to kahadb plist impl - settable via broker service tempDataStore
2016-08-24 11:39:22 +01:00
b37b9eb5af
fix up cancelledTaskModMetric reporting in kahadb
2016-08-19 11:48:42 +01:00
jbonofre
Daniel Trebbien
Pascal Schumacher
Colm O hEigeartaigh
gtully
Christopher L. Shannon (cshannon)
Alan Protasio
Hoan Nguyen
jgoodyear
jgoodyear
Jeff Genender
hkesler
Hiram Chirino
Timothy Bish
Hadrian Zbarcea