60 Commits

Author SHA1 Message Date
Christopher L. Shannon (cshannon)
8a4c928806 Revert "[AMQ-7309] Update to jakarta.jms/jakarta.jms-api:2.0.3 (#682)"
This reverts commit 67256c61b1560127e3a56ba9dede61cad3001f4a.
2022-03-01 10:25:01 -05:00
jbonofre
472dcf8497 [AMQ-7426] Upgrade to log4j2 2022-02-24 15:20:51 +01:00
Matt Pavlovich
67256c61b1
[AMQ-7309] Update to jakarta.jms/jakarta.jms-api:2.0.3 (#682)
- API update only
 - Throw UnsupportedOperationException
 - Disable activemq-camel from build
 - Formatting fixes
 - Use geronimo-jms for osgi-related artifacts
 - Fix features.xml invalid xml header
 - Add a unit test to confirm JMS 2.0 methods for phase 1 (throw UnsupportedOperationException)
 - Add deliveryTime field to Message
 - Minor formatting fixes
2021-11-10 11:56:04 -06:00
Matt Pavlovich
5fe4999a4d [AMQ-8279] Fix type-o when converting new Boolean(true) to Boolean.TRUE 2021-05-26 10:43:17 -05:00
Matt Pavlovich
2cc17a2fa0 [AMQ-8279] Compiler warning cleanups
- Remove unsused imports (exept for generated classes)
 - Convert to T.valueOf on boxed primitives from new T()
2021-05-25 09:34:35 -05:00
Jean-Baptiste Onofré
d2851888bf
Merge pull request #551 from coheigea/AMQ-7513
AMQ-7513 - Fix http://activemq.org links
2020-08-11 09:42:43 +02:00
Timothy Bish
742a7f42f0 AMQ-8016 Fix introspection support not checking Boolean class types
Support class should check both primitive and Object based types for
conversion from String to boolean or Boolean targets
2020-07-31 11:42:47 -04:00
Christopher L. Shannon (cshannon)
6c0cb4143d AMQ-7516 - Fix XAConenctionPoolTest after change to make tmFromJndi an
object
2020-07-16 08:18:01 -04:00
Tomasz Adamski
871654ded6 Change org.apache.activemq.jms.pool.XaPooledConnectionFactory#tmFromJndi parameter to Boolean for JCA validation 2020-07-15 14:53:58 +02:00
Colm O hEigeartaigh
fca3b615eb AMQ-7513 - Fix http://activemq.org links 2020-07-10 17:29:01 +01:00
jbonofre
88525ce650 [AMQ-7121] Set setter accessible (for JDK 11) 2020-06-22 17:35:49 +02:00
Benjamin Graf
92dec52e1c [AMQ-7131] Add connectionTimeout to avoid starvation 2020-02-26 18:55:35 +01:00
Daniel Trebbien
b020cba744 Fix some incorrect SLF4J logger calls
In some cases, there were an inconsistent number of formatting anchors.

In other cases, formatting anchors were used, but because the
trace/debug/info/warn/error(String, Throwable) variant was used, the
string is a message string rather than a format string.

These issues were found by SLF4J Helper for NetBeans IDE:
http://plugins.netbeans.org/plugin/72557/
2020-02-19 08:26:36 +00:00
Daniel Trebbien
7b528ecee7 Fix some typos 2020-02-19 08:01:41 +00:00
Daniel Trebbien
210f583cbd Utilize parameterized logging 2020-02-19 07:40:38 +00:00
Pascal Schumacher
dac97e6294 [AMQ-7401] Make double-checked locking thread-safe by declaring the field volatile. 2020-02-10 19:06:17 +01:00
gtully
efc857fc1f AMQ-7233 - ensure sessions are cleaned up on pooledconnection.close before temp dests to ensure temp dests actually get deleted, fix and test 2019-06-19 10:29:33 +01:00
Christopher L. Shannon (cshannon)
525fd29d16 AMQ-6974 - test cleanup 2018-07-27 08:38:58 -04:00
giliva
5b1412ddfd Avoid overflow errors - see KAFKA-4290
Add test for overflow values

Bind test sockets to free ports
2018-07-27 08:32:36 -04:00
gtully
004be56127 AMQ-2659 - make configurable based on xaAckMode, otherwise pure xa case can default to autoack in error. Additional tests 2018-06-13 11:48:43 +01:00
gtully
5b4fb8aa2b [no jira] test to exercise pool setBlockIfSessionPoolIsFull false 2017-09-20 15:37:43 +01:00
Hadrian Zbarcea
be24a133ef This closes #88 (merged as a65ac586). More file permissions fixes. 2016-11-03 14:26:34 -04:00
Hadrian Zbarcea
d54d046b8a This closes #185. Won't fix. (fix more file permissions) 2016-11-03 11:54:33 -04:00
Timothy Bish
be032c9821 Close connection in test to try and release VM transport resources 2016-08-02 10:35:32 -04:00
Timothy Bish
0706fd0bc1 https://issues.apache.org/jira/browse/AMQ-6350
Allow for PooledConnectionFactory restart after being stopped.
2016-07-11 18:20:08 -04:00
Timothy Bish
27ce49f1c8 Ensure all PooledConnectionFactory instances are stopped at tests end to
ensure that pooled connections are all closed to release VM Transport
resrouces
2016-06-03 18:28:57 -04:00
sprgn
991d69f387 Fix error message typo.
Fix typo from javax.jmx.ConnectionFactory to javax.jms.ConnectionFactory
2016-05-20 15:20:09 +02:00
Timothy Bish
2e64abc38a https://issues.apache.org/jira/browse/AMQ-6290
Close failed connection on start if the reconnect on exception flag is
enabled.
2016-05-11 16:03:19 -04:00
Timothy Bish
c81a9348ee Need to test the underlying connection to ensure we aren't using an old
one that isn't cleaned up since each checked grabs a new
PooledConnection wrapper.
2016-05-10 15:41:58 -04:00
Timothy Bish
100c5e0b59 Add waitFor to check that once the async processing kicks in the pool
clears the bad connection and a new one is returned from the pool.
2016-05-09 15:15:43 -04:00
Timothy Bish
e3a68717f1 Fix race in test due to async processing of the SecurityException, start
might throw but the connection doesn't fire the exception listener until
afterwards which is what triggers the pool to close the connection.
2016-05-04 17:15:13 -04:00
Timothy Bish
102599ee28 Adds some additional tests for the connection pool around error handling
when JMSSecurityException is returned from the broker.
2016-04-20 18:34:29 -04:00
Timothy Bish
b65c0d1be4 https://issues.apache.org/jira/browse/AMQ-5510
https://issues.apache.org/jira/browse/AMQ-5534

PooledConnectioFactory added reconnection support but can break if the
holder of the connection adds their own ExceptionListener as the
PooledConnection doesn't protect the internal ExceptionListener from
replacement which leads to cases where the loaned Connection is not
automatically closed so that the next create returns the same failed
connection.
2016-04-20 09:48:06 -04:00
Timothy Bish
4e6cbcdc5f NO-JIRA Use a real transport connector for the test to prevent failures
in CI.
2016-03-15 11:40:17 -04:00
Christopher L. Shannon (cshannon)
7c7c505057 https://issues.apache.org/jira/browse/AMQ-5990
Disabling JMX for the Commons Pool implementation inside of
PooledConnectionFactory.  In the future if we want JMX we should
enable our own JMX stats that are independent of Commons Pool.
2015-10-01 18:08:37 +00:00
Timothy Bish
9ef4259297 https://issues.apache.org/jira/browse/AMQ-5616
Use ConcurrentMap in declarations
2015-04-28 11:15:08 -04:00
Jeff Genender
4441001c42 Updated API for commons-pool2 2015-04-16 16:01:39 +02:00
Jeff Genender
6d6ed4eaaf AMQ-5721 - Update ActiveMQ to use commons-pool2 instead of commons-pool.AMQ-5636 will need it. The JMS pool and other components should use it as well. 2015-04-16 16:01:39 +02:00
Timothy Bish
e6597c4604 https://issues.apache.org/jira/browse/AMQ-4441
Cleanup the test suite, disble unused broker features and add timeouts
etc.
2015-02-18 12:55:54 -05:00
Timothy Bish
f91abd3d46 https://issues.apache.org/jira/browse/AMQ-5564
Fixed session in the pool losing their reference to the anonymous
producer created when useAnonymousProducers is true.  The anonymous
producer stays live for the life of the pooled session.

Also added some synchronization safety to some methods that could get
into NPE trouble.
2015-02-05 17:50:43 -05:00
Dejan Bosanac
b53d8ea295 https://issues.apache.org/jira/browse/AMQ-5534 - generic jms pool reconnection 2015-01-22 12:51:11 +01:00
Dejan Bosanac
9f53e2bcae adding missing licences 2014-12-29 12:25:04 +01:00
Timothy Bish
1ee5108be6 Disable JMX on the test brokers as it's not needed in these tests,
prevents some failures and speeds things up a little.
2014-07-30 09:40:09 -04:00
Timothy Bish
b432173cfc https://issues.apache.org/jira/browse/AMQ-5268
Explicity set the properties from the generic JMS pooled
connectionfactory as the introspection based tools can easily get stuck
on getters that cause recursion or on inner types that have methods
which allow chaining.
2014-07-10 19:03:31 -04:00
Timothy Bish
c6d0aaa81b https://issues.apache.org/jira/browse/AMQ-5258
Fixed, early created connection is closed so that it can expire or error
out as needed.
2014-07-07 14:29:21 -04:00
Timothy Bish
577b29c0e5 https://issues.apache.org/jira/browse/AMQ-5224
Support for XAConnectionFactory that do not implement ConnectionFactory
2014-06-13 12:30:17 -04:00
Timothy Bish
459593c427 https://issues.apache.org/jira/browse/AMQ-5224
Ensure PooledConnectionFactory implements QueueConnectionFactory and
TopicConnectionFactory
2014-06-13 11:18:24 -04:00
Timothy Bish
9ae22642dc https://issues.apache.org/jira/browse/AMQ-5224
Fix some JavaDocs
2014-06-13 11:09:56 -04:00
Timothy Bish
878e3a16ca https://issues.apache.org/jira/browse/AMQ-5226
Ensure that connections are returned when created and then handed out as
FIFO after that.
2014-06-13 10:30:39 -04:00
Timothy Bish
f395c70608 https://issues.apache.org/jira/browse/AMQ-5015
Refactor the way sessions are pooled.  We don't need to keep the
PooledSession instances around since the state is unique to the session
it wraps we only need to keep the Session instances in the SessionPool
and create a new PooledSession on borrow to manage that session.  This
allows the PooledSession to have a real closed state that protects
against multiple close calls placing duplicate PooledSession instances
into the SessionPool.  This also simplifies the code in the
XaConnectionPool since it doesn't need to try and reset state in
PouledSessions before placing them back as it gets a fresh wrapper each
time with the correct state.
2014-06-12 19:12:56 -04:00