501d55337a
AMQ-7302 - make jmx ops that pageIn aware of cursor memory limits to avoid excessive looping, fix and test
2019-09-10 11:46:04 +01:00
fb2296ac74
AMQ-7270 - remove toggle on maxPageSize, request page in of entire queue only when cache is in play or broker is non persistent, fix and test
2019-08-07 17:47:59 +01:00
09003e8fef
AMQ-7102 - Improve ManagedRegionBroker performance by replacing
...
registeredMBeans CopyOnWriteSet with a Concurrent hashmap backed set
2019-07-31 12:56:57 -04:00
75023f2bed
Remove default "secret" password from the LDAPAuthorizationMap
2019-07-15 18:24:48 +01:00
c7eff84058
AMQ-7238 - Ensure remoteId subscription map is also cleared when local
...
map is cleared inside DemandForwardingBridgeSupport
2019-07-08 08:38:34 -04:00
de3f77063f
AMQ-7234 - fix up memory usage wait timeout such that topic pfc in a transaction can see connection context state changes, fix and test
2019-06-21 16:55:13 +01:00
dc56fa3f6e
AMQ-7228 - Avoid unnecessary lock contention when getting pending
...
metrics
2019-06-14 10:46:21 -04:00
7404b43f2d
AMQ-7193 - resolve intermittent NPE on duplex network connector start; wait for start completion before dispatching inbound messages, fix and test
2019-05-02 16:31:26 +01:00
bf3a9f44f6
AMQ-7191 - Prevent extra creation of openwire verifier objects per new
...
connection when using the auto transport
2019-04-30 08:41:08 -04:00
487d4a112e
AMQ-7185 - track durable sub prepared acks in preCommit callback and release/remove on xa outcome, avoid duplicate delivery; fix and test
2019-04-17 14:31:11 +01:00
ccf56875b0
NO-JIRA - Update spring schemas and missing license files
2019-03-15 07:24:31 -04:00
2d394b383c
AMQ-7167 - ensure remote IP is visible in acceptor error messages from the transport connector - test and fix
2019-03-13 10:21:19 +00:00
a000a73431
no jira - init throwable cause to identify error on shutdown
2019-03-13 10:14:06 +00:00
87467dc61e
AMQ-7159 - Adding a new attribute on PersistenceAdapterViewMBean to show information about Storage write/read latency
2019-03-06 11:41:08 -08:00
7fdad3a73d
AMQ-7151 - Remove dependency on Guava from activemq-broker
...
Guava is supposed to only be used for the leveldb store and as a test
dependency elsewhere but there is one spot it is used in activemq-broker for
filtering collections. With Java 8 this can be easily rewritten to avoid the use of Guava.
This commit is based on the patch submitted by Filip Hrisafov
2019-02-18 07:49:47 -05:00
daea192eef
AMQ-7085 - Properly start TempUsage inside Queue start
...
This fix allows temp usage changes to the broker temp usage to propagate
properly to a Queue's temp usage settings
Patch applied with thanks to David Sitsky
2019-01-17 07:58:36 -05:00
5c23dd53ad
AMQ7135 : do a purge before deleting the destination
...
(cherry picked from commit 9f513f8878
2019-01-14 13:44:52 -03:30
4a21edc8d5
[AMQ-7126] Improvement to perf of 5266Test
2019-01-07 21:22:34 -03:30
8cc0c5ad6c
AMQ-7106 - fix pending stop support by avoiding sync through single shared status var - fix and test
2018-11-21 10:23:13 +00:00
9cb680c0ba
AMQ-7102 - don't track objectNames that have not been registered due to suppressMBean filter, fix and test
2018-11-15 17:45:18 +00:00
bc8c78cd32
AMQ-7009 - apply fix to memorymessagestore setBatch with thanks to Nezih BEN FREDJ for test and suggestion
2018-11-14 14:21:27 +00:00
d2b0affedb
AMQ-7094 - track the objectName with an annotated mbean such that the jmx audit log event can extract that target of an mbean operation, fix and test
2018-11-08 12:10:01 +00:00
f2cde24a62
AMQ-7088 - fix deadlock on remove add interaction from mqtt virtual topic sub use case
2018-11-01 10:11:08 +00:00
bf8eb08aca
AMQ-7086 - make kahadb gc/cleanup on shutdown optional to trade availability over disk usage for fast failover
2018-10-31 14:29:05 +00:00
9dd751149f
AMQ-7079 AMQ-7077 AMQ-6421 - check for consumers that have been destroyed
2018-10-18 16:49:29 +01:00
4dee173962
AMQ-7077 AMQ-6421 - tie queue consumer slow flag detection to abort slow consumer policy, fire advisory when set.
2018-10-17 11:04:47 +01:00
3ac3a420a1
AMQ-7071 - Mark previously dispatched messages as redelivered if
...
connection for durable topic subscription is improperly closed leading
to a lastDeliveredSequenceId as unknown
2018-10-12 08:35:37 -04:00
5246151288
AMQ-7062 - have redelivery plugin ignore messages detected as duplicates
2018-09-26 11:22:59 +01:00
cae66f5d37
AMQ-6086 - variant with broker.schedulerSupport=true; same fix with additional test
2018-09-25 16:29:24 +01:00
cdbddcafa2
AMQ-7057 - support transport connector warnOnRemoteClose to suppress eof warnings on loadbalance or health check socket ping
2018-09-20 14:58:34 +01:00
69fad2a135
Add support for hostname verification
2018-08-31 06:39:49 -04:00
54c56a0573
AMQ-7037 - add sslContext attribute to networkConnector, allow broker or jvm defaults to be overridden
2018-08-20 16:40:26 +01:00
50d27e7e54
AMQ-7035 - use NonCachedMessageEvaluationContext in place of MessageEvaluationContext to avoid unnecessary reference count management and subsequent leaks. Rework AMQ-6465 with additional JMX related tests
2018-08-15 16:21:57 +01:00
bdfa3394ad
AMQ-7030 - trap exceptions on future.get, fix and test
2018-08-02 14:45:31 +01:00
5b1412ddfd
Avoid overflow errors - see KAFKA-4290
...
Add test for overflow values
Bind test sockets to free ports
2018-07-27 08:32:36 -04:00
b79fcd0a76
AMQ-7017 - Prevent ArithmeticException in ProducerBrokerExchange
...
Check for zero to prevent divide by zero error inside
getPercentageBlocked() method
Thank you to Matthew Stratton for the patch
2018-07-27 07:40:49 -04:00
0b76d3a0ea
AMQ-7021 - add unsynchronised accessors to destination map for usage with rw lock from abstract region; allow concurrent read of the destination map
2018-07-26 10:42:10 +01:00
c29d7477d0
no jira - fix warn formatting error
2018-07-05 11:54:22 +01:00
83514ef799
AMQ-7001 - ensure cursor pending cached id list is pruned of futures that end in an exception, fix and test
2018-07-03 21:18:36 +01:00
76490a2c7f
AMQ-7002 - Change jobid identifier to messageid format
2018-06-27 10:29:40 -06:00
e0aa091d9e
AMQ-7002 - ensure uniqueue jobids, fix and test via patch from Jamie goodyear applied with thanks
2018-06-27 14:14:44 +01:00
57a6f2373e
AMQ-6854 - ensure non null return in the event on no space to page in
2018-06-13 13:10:52 +01:00
1ebf186279
AMQ-3405 - rework fix to use original destination strategy which may be different from the default shared strategy. new test
2018-06-07 11:38:42 +01:00
6d14e4e85b
AMQ-6979 - fix test regression, avoid gc during shutdown such that the error check on the logging remains valid
2018-05-31 13:44:01 +01:00
cdb38b3275
AMQ-6979 - use scheduler as trigger task - do heavy lifting via the task runner executor, take care to trap errors to keep scheduler timer alive AMQ-5129
2018-05-30 22:03:50 +01:00
026c6f4403
AMQ-6967 - ensure there are some messages paged in for periodic expiry check if non are in memory
2018-05-21 14:26:45 +01:00
01384c714d
AMQ-6707 - fix destination filter delegate param, refactor-auto-gen method; jees
2018-05-18 14:44:05 +01:00
2eff835ee2
AMQ-6703 - fix regression in MBeanTest - StoreQueueCursor not sharing its audit - have purge use rollback and delegate to both cursors
2018-05-18 11:36:54 +01:00
8d3674be3d
AMQ-6707 - remove duplicated started state flag
2018-05-15 14:55:02 +01:00
09bf8f89b8
AMQ-6707 - ensure trace logging does not flip cacheEnabled flag outside required sync
2018-05-15 12:00:22 +01:00
573b366ca0
AMQ-6100 - use setOriginalDestination=false to make this behaviour optional b/c amqp cannot see the original dest property due to immutability of the message properties and folks can depend on the existing original destination behaviour
2018-05-10 10:55:15 +01:00
c1e7dbd53b
AMQ-6707 - fix trace log reporting in error
2018-05-09 12:17:29 +01:00
ea70e827c0
AMQ-6707 - JDBC XA recovery and completion.
...
ensure pending transactions are visible for recovery without restart
sync store and cursor size during and after completion
ensure pending messages are not visible to browsers
retain transaction state on jdbc error
a bunch of new tests around xa completion
2018-04-26 14:58:48 +01:00
1d2226e6cf
Revert "AMQ-6947 - Make sure counters are updated correct on message drop"
...
This reverts commit 021c82859c
2018-04-18 12:34:18 -04:00
7123534e1b
Revert "AMQ-6947 - Update Queue metrics on expiration"
...
This reverts commit 6e468b4540
2018-04-18 12:34:07 -04:00
6e468b4540
AMQ-6947 - Update Queue metrics on expiration
...
The updated dropMessage method only decrements the destination metrics
if a message is removed from the pagedInMessages list to prevent
duplicate updates. There is also a case where we still need to update
metrics if the message never makes it into the pagedInMessages list in
the first place and that is on expiration so this patch fixes that. A
couple existing tests found this issue.
2018-04-18 09:04:11 -04:00
021c82859c
AMQ-6947 - Make sure counters are updated correct on message drop
...
Only update metrics counters when message is removed from the
pagedInMessages list which is important to check in case of duplicates
2018-04-17 08:25:08 -04:00
65b0f2ad0d
AMQ-6940 - Add flag to disable TopicSubscription in flight stats
...
To save memory usage in some use cases add a new flag to PolicyEntry
called useTopicSubscriptionInflightStats to allow disabling the
inflight stats
2018-03-29 13:25:36 -04:00
f69fd6f002
AMQ-6940 - Reduce memory footprint for inflight statistics
...
For the TopicSubscription case we can reduce the inflight statistics
memory footprint by not storing the entire message reference for in
flight messages and instead just a subset of the information needed.
2018-03-29 09:00:26 -04:00
5e2adc0ed7
AMQ-6924 - Fix StoreDurableSubscriberCursor non-persistent message add
...
StoreDurableSubscriberCursor now properly uses a timeout value when
attempting to add to the temporary store for non-persistent messages to
prevent an indefinite wait on free space
2018-03-09 07:41:09 -05:00
060817552d
[AMQ-4261] use WARN level for producer flow control events, DEBUG if blockedProducerWarningInterval=0
2018-03-02 12:17:24 +00:00
82c9f9531e
[AMQ-6907] add selectorAware option to conditionalNetworkBridgeFilterFactory such that replay back to origin can happen if there are no matching local consumers
2018-02-28 16:07:52 +00:00
efaf9cd77e
[AMQ-6906] jdbc store; ensure rolled back prepared ack messages are recovered asap
2018-02-28 13:31:12 +00:00
ecb404b3eb
BrokerService: fix typo in field and parameter name
2018-02-20 21:41:50 +01:00
dd2572bcb1
[AMQ-6891] test and fix non tx variant of this leak
2018-01-30 10:51:30 +00:00
e5de25f4fc
NO-JIRA: Add missing license headers
2018-01-29 08:10:50 -05:00
f96a20e831
[AMQ-6891] apply fix and test from Radek Kraus with thanks. Pending cursor adds are now dropped on rollback
2018-01-26 13:18:00 +00:00
8c77e9553e
[AMQ-6880] fix filter match logic when transport connector updateClusterFilter is in play
2018-01-03 16:07:06 +00:00
a8a032af09
AMQ-6861 Allow customisation of network bridge creation logic.
2017-12-20 22:00:54 -05:00
56baba96c6
AMQ-6875 - Use the correct destination for Virtual destination consumers
...
when using Virtual Topics
2017-12-14 16:01:10 -05:00
9d98ee253f
sync code default with config default to use jvm mbean server
2017-11-24 10:36:52 +00:00
151e17abfe
[AMQ-6854] - periodic log warn on store limits reached in the same way
2017-11-21 14:56:02 +00:00
08aa5118ff
(AMQ-6858) - add extra precautionary check for demand subs
...
also remove test that intermittently fails with timing issues
2017-11-16 07:44:33 -05:00
6013441a9a
AMQ-6858 - handle resync of network proxy durables after restart
...
We need to properly handle the re-addition of network proxy durables
after the brokers are restarted so removal is done properly
2017-11-15 08:56:43 -05:00
3ca439cada
AMQ-6858 - Allow configuration of the client Id token in network bridge
...
The client id token that is used to separate parts of a generated local
client id in a network bridge should be configurable so bridge names and
broker names can contain underscores if desired
2017-11-14 15:23:26 -05:00
41211c78d1
AMQ-6858 - reworking durable subscription propagation fix
...
Significantly reworking previous fix so that the client id is properly
changed when tracking network proxy subscriptions. This makes it so
removal is done properly
2017-11-13 11:07:43 -05:00
96ce14b278
AMQ-6858 - Fix several durable subscription bridge propagation issues
...
Durable network proxy subs will now be properly created across multiple
bridges when 3 or more brokers are used. Demand will be properly synced
and removed.
2017-11-09 11:21:18 -05:00
b29ccf3488
[AMQ-6854] log warn if page in is blocked on usage preventing dispatch. Reuse blockedProducerWarningInterval to tweak reporting
2017-11-02 16:04:30 +00:00
03b19b9da4
[AMQ-6847] limit the retry loop to one iteration overa all pending messages such that new additions are not replayed to avoid duplicates
2017-11-01 11:26:36 +00:00
2ea5d1420b
[AMQ-6847] pause dispatch for message move to avoid redelivery with pending ack/remove/audit rollback
2017-10-27 11:40:06 +01:00
8e576be1d9
[AMQ-6849] - fix sendFailIfNoSpaceAfterTimeout policy entry default value
2017-10-26 11:36:03 +01:00
6da08b245e
[AMQ-6849] provide a virtualTopic dropOnResourceLimit attribute, default to false.
...
Enabling will allow dispatch to continue even when end to some consumer queues
fail due to resource constraints.
The existing systemUsage sendFailIfNoSpace and sendFailIfNoSpaceAfterTimeout are
promoted to destination policy options allowing selective destinations to fail a
send with an exception. The global system usage options are still in place.
When dropOnResourceLimit=true dispatch will continue in the event that any
subscription queue throws a resource limit exception on send failure.
2017-10-25 14:53:20 +01:00
41a100766c
[AMQ-6824] - fix up prefetchExtension growth on transaction completion and delivered ack and tie in boolean usePrefetchExtension
2017-09-26 11:30:18 +01:00
c691124d32
AMQ-6808 preserve destination for browsed scheduled messages
2017-09-15 09:02:36 -04:00
5e656d394c
https://issues.apache.org/jira/browse/AMQ-6799 - stop the jmx server connector properly
2017-09-01 13:02:53 +02:00
35bd3ad938
AMQ-6798 - Clean up store usage object on Queue stop
...
When queues are stopped the StoreUsage object needs to be stopped so it
will be removed from the parent StoreUsage. This allows the object to
be garbage collected and prevents a memory leak.
2017-08-24 09:24:36 -04:00
c7291f1ecf
https://issues.apache.org/jira/browse/AMQ-6799 - IOExceptionHandler during the startup
2017-08-24 14:04:36 +02:00
63f0b7e20d
[AMQ-6792] fire the failover exception handler before stop to ensure blocked write does not block stop request
2017-08-11 12:58:51 +01:00
8646bb1010
[AMQ-6788] Explain how to fix the problem in the exception
2017-08-08 20:55:56 +02:00
a67c75a9e1
[AMQ-6643] refine fix to allow wildcard subs to non wildcard subscription queues, enable simple wildcard sub to drain all subscription queues
2017-08-08 16:38:11 +01:00
a15626193c
[AMQ-6787] release securty context on failure to addConnection subsequent to auth, resolve leak. fix and test
2017-08-04 13:46:16 +01:00
ddfa96028c
[AMQ-6778] fix and test - no longer gate firing advisory on broker start flag b/c consumers may be present once transport connectors have started
2017-07-25 13:02:13 +01:00
d7f70837b7
[AMQ-6764] add logging of exit of jmx ops such that overlaps and delays are visible in the audit. fix and test
2017-07-10 14:10:05 +01:00
a9fe4e33c3
[maven-release-plugin] prepare for next development iteration
2017-06-27 13:41:28 -04:00
5f0d6943cb
[maven-release-plugin] prepare release activemq-5.15.0
2017-06-27 13:41:01 -04:00
2311749aa2
AMQ-6706 - Protecting preShutdownHooks with an AtomicBoolean
2017-06-20 11:05:29 -04:00
155461a0ba
AMQ-6706 Allow for hooks before broker stop occurs
...
When Camel is run embedded within ActiveMQ it's shutdown is called at
the point the broker is already stopped, this can lead to data loss as
there could be exchanges that have not ended.
This adds the ability to specify preStopHook(s) that can be invoked
during ActiveMQ shutdown but before the broker is shutdown.
With this Camel can gracefully shutdown while the broker is still
started.
2017-06-19 14:29:05 +02:00
b07821ab64
[AMQ-6625] remove kahadbioexceptionhandler by pushing allowIOResumption into persistence adapter. This allows the lease locker to still be used with kahadb for stopStartConnectors support
2017-06-15 17:28:31 +01:00
df3bd83c0d
[AMQ-6703] check for enable audit false
2017-06-15 11:22:20 +01:00
99f3d4c505
[AMQ-6703] have jmx purge clear the audit such that messages can be copied back, fix and test
2017-06-15 10:46:23 +01:00
b6cb0eacea
[AMQ-6702] add maxProducersToAudit and maxAuditDepth to dead letter strategy to cofigure the audit, fix and test
2017-06-13 14:26:15 +01:00
2a0b785a04
AMQ-6698 - Allow timeout of SSL handshake for auto+nio+ssl
...
The handshake now takes place inside of the async task that timesout so
that if the SSL handshake takes too long the connection attempt will
honor protocolDetectionTimeout and actually timeout. Also, change the
default of protocolDetectionTimeout to 30 seconds so it matches the rest
of the broker's default connection timeout settings.
2017-06-08 12:34:15 -04:00
7413ee00e1
[AMQ-6696] zero out usage for forwarded messages such that the original target is no longer referenced. fix and test
2017-06-02 12:23:58 +01:00
d2c0eddaad
[AMQ-6691] allow dlq flag to be set via jmx to allow retry op after a restart - use destinations element for long term persistence
2017-05-31 12:39:48 +01:00
8023b9ee44
[AMQ-6690] do nothing for move/copy jmx ops that try to modify self
2017-05-31 11:26:46 +01:00
00ee9491d9
[AMQ-6678] sync destructive purge on queue view mbean (jmx) to prevent concurrent calls
2017-05-29 11:21:00 +01:00
25f112c5c9
[AMQ-6687] ensure transacted sends blocked on pfc do not resume after tx completion. AMQ-4467 refine the fix such that PFC kicks in such that the cache will accept messsages that push it over it's limit while it is still under the limit
2017-05-25 12:43:08 +01:00
acab282d9c
[AMQ-6678] sync destructive queue view mbean (jmx) operations such that concurrent calls see consistent state
2017-05-18 12:37:54 +01:00
a0ba0bf4c6
[AMQ-6667] gate cursor cache enablement on a single pending send and tidy up setbatch to always check outstanding async future list. Fix and test
2017-05-03 11:36:06 +01:00
57795bafce
[AMQ-6665] - check for peercerts is now on tcp transport such that the bridge connection info can have the correct context
2017-04-27 12:07:12 +01:00
0e74c52e8a
[NO JIRA] tidy up MbeanInfo text in DestinationView
2017-04-26 12:10:24 +01:00
808a4c5c17
AMQ-6661 - Fix Auto MQTT protocol detection
...
Protocol detection now takes into account the variable length header in
the CONNECT packet.
2017-04-25 08:47:08 -04:00
729766e492
[AMQ-6494] ensure vm transport propagates onCommand exceptions to peer
2017-04-04 14:17:27 +01:00
0f7561e85a
Revert "AMQ-6494 Return ExceptionResponse during broker service shutdown"
...
the root cause seems to be in the vm transport iterator
This reverts commit dce2b61f87
2017-04-04 14:15:00 +01:00
679db08db3
[AMQ-6643] ensure a wildcard virtual topic subscriber is restricted to the wildcard destination - avoid duplicate and spurious dispatch. fix and test
2017-04-04 10:16:48 +01:00
4ef1fc74cf
[AMQ-6640] either broker dispatch to bridge or bridge dispatch to broker needs to be async - dispatchAsync network option is the trigger for the vm transport to be sync in line with the current defaults. original BacklogNetworkCrossTalkTest scenario exposed this. upshot is dispatchAsync=false is not compatible with duplicate subscription suppression which is fair.
2017-03-30 12:12:13 +01:00
d84a58656c
[AMQ-6640] allign use of sync vm transport usage on duplex end of networkconnector with initiator end. only duplexinbound for forwarding is async to allow thread for responses. vm transport options applied in one place and test more deterministic w.r.t the hang scenario
2017-03-29 23:50:47 +01:00
8e00c6c2bc
[AMQ-6640] fix duplicate suppression sync request on responder end of duplex network connector only b/c that has the async local transport. Additional test. Ensure broker sync is conditional on the need for duplicate suppression which should only be necessary in ring topologies when properly configured
2017-03-28 14:49:23 +01:00
c5a8b2c8b1
[AMQ-6625] ensure kahadb stops operation on the first IOException to facilitate auto recovery from partial writes
2017-03-13 13:49:41 +00:00
01b1f7f694
[AMQ-3233] respect policy entry blockedProducerWarningInterval for flow control warning, 0 disables and Xmillis makes it periodic, default period of 30s is not unlike the existing once behaviour. fix and tests
2017-03-03 11:23:23 +00:00
e67d48680f
[AMQ-6614] fix up jmx blockedSendsCount and producer view blocking flag for async send case. fix and test
2017-03-02 17:00:16 +00:00
b6521e292b
[AMQ-6414] additional logging that helped identify root cause
2017-02-27 17:01:16 +00:00
ef84db5e64
AMQ-6610: Fixing JDBC test
...
Durable destinations need to always be loaded on connector start
2017-02-27 07:34:22 -05:00
bab0887ed6
AMQ-6610 - Network connector mbean not registered on reload
...
On network connector add or update after broker start (such as the
runtime plugins) the mbean was not created. There was also a couple of
other properties not set. Fixed the network connector start to be the
same for normal broker start and runtime reload.
2017-02-24 14:05:27 -05:00
fad50812af
[AMQ-6547] revert mod from AMQ-3143 such that waitForSpace respects child usage, fix test and validate mKahadb blocking send
2017-02-14 11:33:59 +00:00
d86c98a687
[AMQ-6587] - fix root cause of deletion candidate seeing sub. contention between adding sub to dests and adding dests to sub, also removing sub from dests twice could leave dest stat negative allowing invalid candidate for gc
2017-02-10 11:38:03 +00:00
c049d3c1f7
Add a simple IDERunner for testing
...
Adds a simple class to run a broker instance with a TCP transport
connector and no persistence enabled for quick tests.
2017-02-07 17:28:28 -05:00
0ee4f5b843
[AMQ-6587] additional contention window with new sub while gc is in progress - need to verify new sub is actually subscribed to the candidate for deletion. Fix and test
2017-02-07 13:53:40 +00:00
9b9e3d3678
https://issues.apache.org/jira/browse/AMQ-6588
...
Add more detail to log output for easier tracking
2017-02-01 16:15:11 -05:00
e415d2921e
[AMQ-6587] ensure subs added to new destination before destination is exposed in the destination map. sort gc contention with wildcard subs and anonymous publish. fix and test
2017-02-01 15:08:46 +00:00
687badb4fd
AMQ-6577: honour usePrefetchExtension in TopicSubscription.
...
AMQ-6577: move usePrefetchExtension flag to AbstractSubscription to promote reuse.
2017-01-30 11:13:57 -05:00
d0c95146c3
https://issues.apache.org/jira/browse/AMQ-6579
...
Remove incorrect dispatch counter increment on message expiration in
TopicSubscription when a pending limit strategy is set
2017-01-25 11:16:43 -05:00
56bb079c82
https://issues.apache.org/jira/browse/AMQ-1940
...
Queue purge now acquires the sendLock to prevent new messages from
coming in while purging. The statistics are no longer zeroed out as
they should properly decrement as messages are removed. These changes
should prevent the statistics from going negative.
2017-01-24 08:46:15 -05:00
511b9b642a
[AMQ-6562] - suppress warn of durable sub duplicate from the store on cache exhaustion - expected in the absense of ordered sequenceid and setBatch. Fix leak of duplicates pending processing on batch fill for the durable sub case and remove eager page in for prefetch=0
2017-01-13 11:06:05 +00:00
d9c74d7317
https://issues.apache.org/jira/browse/AMQ-6561
...
Stop connections on all connection attempt errors, not just security
exceptions, to prevent dangling open sockets.
2017-01-12 10:21:08 -05:00
bdec3f6ddb
https://issues.apache.org/jira/browse/AMQ-6560
...
Converting flags in TransportConnection to AtomicBoolean to reduce
synchronization and improve thread safety
2017-01-12 07:36:50 -05:00
2769298cf6
https://issues.apache.org/jira/browse/AMQ-6555
...
Fixing Scheduler so that a rescheduled task will first cancel the
existing task so it does not get orphaned from the task map. Also
fixing Topic start so that it will only start once and not twice.
2017-01-10 10:25:15 -05:00
c76f109692
https://issues.apache.org/jira/browse/AMQ-4467 - modify fix check full against shared limit and high water mark against local limit, additional test
2017-01-10 11:18:00 +00:00
56917c07ec
https://issues.apache.org/jira/browse/AMQ-6549
...
Fix bad logger output
2017-01-03 09:57:13 -05:00
0ae90c0897
https://issues.apache.org/jira/browse/AMQ-6547 - add storeUsage attribute to mKahadb filtered adapter such that disk utilisation is available as a QOS
2016-12-20 14:47:22 +00:00
25703fbd1f
https://issues.apache.org/jira/browse/AMQ-6538
...
Fixing an issue with syncDurableSubs that cause a bridge failure when
adding multiple bridges between the same brokers
2016-12-13 11:58:57 -05:00
27238b2dd7
https://issues.apache.org/jira/browse/AMQ-6535
...
Fixing the auto+nio+ssl transport so that the protocol detection task
will properly terminate on timeout and not continue to run. Also
lowered the default detection timeout to 15 seconds instead of 30
seconds to match the InactivityMonitor default.
2016-12-12 11:17:19 -05:00
1a2e3eb0c7
[AMQ-6529] Make sure the LDAP ACL's are definitely loaded when needed.
2016-12-07 14:29:36 -05:00
8a28c06555
[AMQ-6441] add option to specify the hard limits on a usage such that spurious values from the file system can be overridden. this closes #202 thanks William Crowell for the patch with test
2016-12-07 18:09:34 +00:00
41bec0d658
Fixes AMQ-6441 where a negative value can be returned with large AWS EFS files systems when calling java.io.File.getTotalSpace()
2016-12-07 10:45:12 +00:00
3f7ca8406d
Revert AMQ-5659
...
Add safety measure against infinite loop when store exception prevents message removal. Thanks to metatechbe for the patch. This fixes #72."
This reverts commit 78492febc8
2016-12-05 07:26:59 -05:00
a73eb0eab5
https://issues.apache.org/jira/browse/AMQ-6435 - align jackson version used, with the rest of the project
2016-11-30 11:44:13 +01:00
78492febc8
AMQ-5659: Add safety measure against infinite loop when store exception prevents message removal. Thanks to metatechbe for the patch. This fixes #72 .
2016-11-29 18:58:17 +01:00
cfdff4edc5
[AMQ-6518] - fix up aveMessageSize dest stat and test
2016-11-25 10:38:09 +00:00
7077d2b910
[AMQ-3166] init rollbackonly exception cause such that xaexception has meaning, thanks to james (jtahlborn) for the suggestion
2016-11-22 16:07:55 +00:00
2c828b23df
https://issues.apache.org/jira/browse/AMQ-6504
...
Fix intermittent test failure
2016-11-21 12:37:52 -05:00
e050519ff6
https://issues.apache.org/jira/browse/AMQ-6500
...
Better handle prefetch extension and pull consumers over Topics to avoid
the remote not receiving all the messages available based on the credit
it has issued.
2016-11-18 11:59:01 -05:00
2537266740
[AMQ-4082] - ensure masked exception is report in the log on missing broker info from local or remote transports
2016-11-15 13:23:54 +00:00
7e648d512d
https://issues.apache.org/jira/browse/AMQ-6505
...
Fixing the auto transport protocol detection so that the byte buffer
that captures the initial bytes for detection is not shared across
threads. This was causing failed connections under high load and high cpu
usage under NIO
2016-11-12 10:02:32 -05:00
980162233f
https://issues.apache.org/jira/browse/AMQ-6504
...
Round the start time value not truncate to ensure delay falls on the
correct side of the scheduling block.
2016-11-11 14:48:49 -05:00
5076808b57
AMQ-6497 Add method to navigate interceptors
2016-11-04 17:18:49 -04:00
dce2b61f87
AMQ-6494 Return ExceptionResponse during broker service shutdown
2016-11-04 09:30:09 -04:00
be24a133ef
This closes #88 (merged as a65ac586). More file permissions fixes.
2016-11-03 14:26:34 -04:00
d5a929c0d2
This closes #205 . Won't fix. (fix even more file permissions)
2016-11-03 14:11:40 -04:00
d54d046b8a
This closes #185 . Won't fix. (fix more file permissions)
2016-11-03 11:54:33 -04:00
7c3bb40100
https://issues.apache.org/jira/browse/AMQ-6477
...
ReduceMemoryFootprint now applies to non-persistent messages if they
have been marshalled and topics now clear memory after the recovery
policy check
2016-10-25 10:19:03 -04:00
b9cb02ae54
https://issues.apache.org/jira/browse/AMQ-6476
...
Moving BrokerSubscriptionInfo processing into a new thread to prevent a
deadlock of the network bridge on startup
2016-10-24 07:52:09 -04:00
d206621a73
https://issues.apache.org/jira/browse/AMQ-6472
...
Durable sync over a network bridge will now also sync non-durable
subscriptions proplrly if the consumer belongs to a destination that is
configured to force network durable subscriptions.
2016-10-20 13:47:38 -04:00
406a34294b
https://issues.apache.org/jira/browse/AMQ-6465
...
Properly decrementing the message reference count in
DemandForwardingBridgeSupport when messages supression is checked for
durable subscriptions
2016-10-14 12:16:07 -04:00
74a5381b9a
AMQ-6463 - provide connection to scheduler context in case of deferred send or error
2016-10-11 11:58:37 +01:00
8493f6b4d7
AMQ-6459 - store based % usage needs to poll the store for the current value on each access
2016-10-07 14:31:52 +01:00
b6759b33dc
AMQ-6403 - init broker temp from provided temp store to align usage checks. Thanks for the patchh shailendra14k@gmail.com, made a mod to respect broker.tmpDataDirectory as a default. This closes #204
2016-10-06 11:47:55 +01:00
72650a0b8b
https://issues.apache.org/jira/browse/AMQ-6449
...
Disabling doclint now only activates for JDK 8
2016-10-03 07:37:53 -04:00
02082b1aec
NO-JIRA: More Java 8 JavaDoc fixes - also fixed findbugs for Java 8
2016-09-30 14:36:44 -04:00
5385fd1bb3
https://issues.apache.org/jira/browse/AMQ-6446 - use shared logger and pepend statements with connection counter. Old behaviour or per connection logger can be obtained with trace=true&jmxPort=0
2016-09-30 14:05:42 +01:00
e8ba0b0119
https://issues.apache.org/jira/browse/AMQ-6435 - destination mbean query api, return the right count
2016-09-27 12:53:49 +02:00
a82c95cd29
https://issues.apache.org/jira/browse/AMQ-6436
...
The temporary store will now delete the old temp directory on start up
if lazyInit is true instead of waiting for the store to initialize to
clear up space. This prevents space on the disk from being wasted with
old data if the temp store isn't initialized
2016-09-23 15:47:27 -04:00
18571ce09b
https://issues.apache.org/jira/browse/AMQ-6430
...
Modifying patch so that only stores that persist the noLocal flag will
check if this flag has changed to prevent a subscription from being
deleted by mistake
2016-09-23 10:59:32 -04:00
7c293b661f
https://issues.apache.org/jira/browse/AMQ-6430
...
When a nolocal durable consumer reconnects the new connectionId is properly captured for
the NoLocal expression so that nolocal works on reconnect. Also fixed
the detection of the nolocal value changing on consumer connect.
2016-09-21 09:34:46 -04:00
ffee8b442f
https://issues.apache.org/jira/browse/AMQ-6422 - match proton sender view credit to prefetchExtension - tracking credit to dispatch delta to track additional flow requests. Proton sender layer is distinct from the transport layer - they mirror each other
2016-09-21 10:33:20 +01:00
6630e81379
https://issues.apache.org/jira/browse/AMQ-6435 - destination mbean query api
2016-09-19 16:22:44 +02:00
a038655605
https://issues.apache.org/jira/browse/AMQ-6423
...
Fixing durable sync over a network bridge so that network subscriptions
that are no longer permissible are also cleaned up
2016-09-08 08:28:26 -04:00
88daeec28f
AMQ-6422 - include the inflight count in the prefetch for positive remote credit flows. Fix and test
2016-09-07 17:28:35 +01:00
88af1c70d9
https://issues.apache.org/jira/browse/AMQ-6418
...
Fixing mqtt link stealing default setting for auto transport
2016-09-07 08:17:34 -04:00
9ab94883a8
https://issues.apache.org/jira/browse/AMQ-6420
...
Properly copying wire format options map before applying to the
transport when using auto transports so that the options do not get
cleared and will be used for all future connections
2016-09-07 07:42:13 -04:00
98c5866c75
https://issues.apache.org/jira/browse/AMQ-6418
...
Properly setting the transport properties on the
AutoNIOSSLTransportServer and fixing the Stomp protocol to set the peer
certs when using auto+ssl
2016-09-06 10:17:05 -04:00
bb8d32c04a
https://issues.apache.org/jira/browse/AMQ-6387
...
Fix up the Memory Store such that it removes the references it adds to
messages when they are placed into the memory durable topic subscription
store.
2016-09-01 16:26:03 -04:00
ed0e786b60
https://issues.apache.org/jira/browse/AMQ-6414
...
Changing the nio+ssl transports to trigger a serviceRead after start up
to prevent blocking. The prevents the channels from not reading in
certain cases, most notably with the auto+nio+ssl transport when used
for a network bridge. Also added a couple tests and changed a network
bridge test to test out auto+nio+ssl.
2016-09-01 11:39:46 -04:00
2b1cda1964
AMQ-6406 - ensure duplicates trapped by the cursor-add or queue-page-in are removed from the message store
2016-08-25 15:01:19 +01:00
5a874816b7
AMQ-6403 - add indexDirectory attribute to kahadb plist impl - settable via broker service tempDataStore
2016-08-24 11:39:22 +01:00
6d44ae6e97
AMQ-5815 - remove obsolete remnant of fix for AMQ-2594. holding global lock before attempting to get index and checkpoint lock can lead to deadlock if checkpoint write lock request pops in
2016-08-15 11:37:38 +01:00
4800a7a1a4
AMQ-6392 - allow mapping of host names via the publish address strategy
2016-08-09 15:22:28 +01:00
9249315688
AMQ-6389 - init the size attribute prior to logging a message send in the logging plugin
2016-08-08 16:46:49 +01:00
06a21dbbb3
[maven-release-plugin] prepare for next development iteration
2016-08-02 09:03:37 -04:00
71cbc65283
[maven-release-plugin] prepare release activemq-5.14.0
2016-08-02 09:02:54 -04:00
e73ab34837
https://issues.apache.org/jira/browse/AMQ-6383
...
https://issues.apache.org/jira/browse/AMQ-6373
Adding a new flag that can be specified on a network bridge to allow
forcing of subscriptions to be durable. Cleaned up some unit tests.
2016-08-01 10:02:56 -04:00
82295fd2c6
https://issues.apache.org/jira/browse/AMQ-6381
...
Fixing DurableTopicSubscription so that an ack will properly update the
forwards statistic on an ack
2016-07-29 15:56:52 -04:00
cf3d419528
https://issues.apache.org/jira/browse/AMQ-6375
...
Adding non-blocking metrics to KahaDB to track message counts and sizes
for subscriptions. Turned off by default but can be enabled on the
KahaDBPersistenceAdapter
2016-07-26 12:02:44 -04:00
01cfa7727d
AMQ-6361 - fix additional test regression on topic sub expiry AMQ4083Test,MessageEvictionTest
2016-07-26 13:45:41 +01:00
3953b9aaef
https://issues.apache.org/jira/browse/AMQ-6373
...
Adding a new OpenWire command called BrokerSubscriptionInfo in order to
help synchronize durable subs across a network bridge. Added OpenWire
version 12. For dynamicallyIncludedDestination durable subs will now be
synchronized on a bridge reconnect as long as the bridge supports
conduitSubscriptions and dynamicOnly=false
2016-07-25 11:56:13 -04:00
6cc2c1190d
AMQ-6361 - fix contention over expiry processing with expiry task and client expiry ack, unit test regression sorted.
2016-07-22 15:18:31 +01:00
9f7d70ba0d
https://issues.apache.org/jira/browse/AMQ-6366
...
Need to make sure that the durableDestinations set on the duplex bridge
are only topics
2016-07-20 08:33:45 -04:00
e05db7cb5c
https://issues.apache.org/jira/browse/AMQ-6273
...
increment the connect attempt count explicitly to ensure reconnect
policy options are applied.
2016-07-19 17:26:24 -04:00
39184e2fb0
https://issues.apache.org/jira/browse/AMQ-6366
...
Fixing the duplex bridge case for restarting durable subscriptions when
dynamicOnly is false
2016-07-19 11:31:44 -04:00
cd5ea6c27f
https://issues.apache.org/jira/browse/AMQ-6361
...
Honor the expired ack from the client as the authority on expiration
2016-07-15 15:08:26 -04:00
42dabb7a7a
https://issues.apache.org/jira/browse/AMQ-6357
...
Preventing a divide by 0 error by taking a local reference to the
prefetch size to guarantee that the value doesn't change after the > 0
check
2016-07-14 10:07:02 -04:00
d635a36940
https://issues.apache.org/jira/browse/AMQ-6352
...
Fixing PList size tracking by moving the null assignment on removal to
after the onRemoval method is called to make sure that the decrement is
done properly.
2016-07-12 10:27:57 -04:00
31c55f7510
https://issues.apache.org/jira/browse/AMQ-6339
...
Add support for AMQP client to connect using WebSockets.
2016-06-30 14:52:40 -04:00
4e23adfcc9
https://issues.apache.org/jira/browse/AMQ-6340
...
combine the lists in the correct order for later redispatch.
2016-06-29 12:57:30 -04:00
6be36305f6
https://issues.apache.org/jira/browse/AMQ-6337
...
Checking for the correct number of arguments before reflectively
invoking a method in DefaultAuthorizationMap
2016-06-23 20:34:50 +00:00
03785a4d53
https://issues.apache.org/jira/browse/AMQ-6334
...
Fix error handling for connection establishment on the bridge.
2016-06-23 11:03:06 -04:00
1faa4afa90
https://issues.apache.org/jira/browse/AMQ-6331 - Honor excluded destinations in static routing on network connectors
2016-06-21 15:07:30 +02:00
a953f11d0e
https://issues.apache.org/jira/browse/AMQ-6323
...
Applying reduceMemoryFootprint for persistent Topic messages
2016-06-14 14:36:37 +00:00
9f9b0fb26a
https://issues.apache.org/jira/browse/AMQ-6322 - Introduce timeout in network bridge for waiting broker infos
2016-06-14 14:29:11 +02:00
f548aafa81
move test utility to broker module to allow reuse from jdbc module tests
2016-06-10 10:20:33 +01:00
98d2000833
https://issues.apache.org/jira/browse/AMQ-6275
...
Avoid unnecessary connection state lookup leading to lock ordering
issues.
2016-06-09 12:10:09 -04:00
6bf5987921
A fix for AMQ-6310
...
Checking for leading wildcard in the prefix for a virtualtopic,
modifying the behavior of shouldDispatch in the VirtualTopicInterceptor.
2016-06-04 16:51:27 -07:00
1f9b139f59
test for uuid temp request/reply from camel across network
2016-06-02 16:58:03 +01:00
29b833fe8e
fix shadowing and ensure close of connection, ci...
2016-05-26 11:30:32 +01:00
fe9d99e7a0
AMQ-3166 - implement rollbackOnlyOnAsyncException such that async exceptions on transactional sends or acks result in the transaction being marked rollback only and commit failing with an exception. Test that shows current state of play using alwaySendSync or AsyncCallback. rollbackOnlyOnAsyncException enabled by default.
2016-05-25 11:24:43 +01:00
b4e35fe8a3
AMQ-4181 - revert mod to testQueueBrowserWith2ConsumersInterleaved which cause intermittent ci failure - browse is a snapshot at time of creation. tidy up some gaps in pagein logic sync
2016-05-23 13:29:39 +01:00
0883011147
Fix data dir path change that shouldn't have been committed with the
...
other fixes.
2016-05-18 11:02:14 -04:00
c2230fda4b
https://issues.apache.org/jira/browse/AMQ-6286 - refine fix to distinguish multiple consumers in a transaction, verify insertion at head will preserve order
2016-05-18 10:09:39 +01:00
2c3046b816
Fix test timing out on slow spinning disks.
...
On a local drive with heave I/O this test took over 2.5 minutes to
complete, CI machines can see similar times, bumped timeout to 5 minutes
to account for this range.
2016-05-17 13:00:56 -04:00
1241e4120a
https://issues.apache.org/jira/browse/AMQ-6293
...
Fixing Queue destination statistics in dropMessage by adding sync in
between the check for dropped and actually dropping the message plus
fixing dequeue stats so messages aren't counted twice
2016-05-14 16:20:41 +00:00
b9334960e0
Add some additional time to the wait for completion assert. On a
...
sufficiently loaded system 30s is not quite enough. This is
reproducable if run while a heavily I/O based application is also
running in the background.
2016-05-13 12:50:13 -04:00
d3ea5c4f9f
https://issues.apache.org/jira/browse/AMQ-5621
...
Fixing LinkStealingTest by adding a wait because removeConnection
may not have been called yet when checking if the removeException
exists the first time
2016-05-10 11:44:17 +00:00
604f707d4d
https://issues.apache.org/jira/browse/AMQ-6286 - refactor insertAtHead from pendinglist to ordered variant
2016-05-10 11:45:27 +01:00
f47b370573
https://issues.apache.org/jira/browse/AMQ-6286 extend strictOrderDispatch to retain order of redispatched messages for a single consumer
2016-05-09 23:06:19 +01:00
6cf8bed0c5
https://issues.apache.org/jira/browse/AMQ-5621
...
Update test with additional checks and logging to try and see what is
happening when it is failing in CI.
2016-05-09 16:57:39 -04:00
9fc2661049
validate selector aware vt can give topic semantics by dropping messages when there is no consumer. Do selector cache plugin once to avoid adaptor check on each dispatch
2016-05-06 17:12:15 +01:00
5009b0c03b
https://issues.apache.org/jira/browse/AMQ-6247
...
Allow the provider position to be read from the system.
2016-05-06 09:37:51 -04:00
5096463b00
https://issues.apache.org/jira/browse/AMQ-6281
...
Deprecate the copyMessage option and remove usage, always copy a
forwarded message.
2016-05-05 12:59:29 -04:00
1ccd17791b
AMQ-6274 - set originalDestination for composite destinations
...
This closes #184
2016-05-05 11:38:48 -04:00
a28a091c55
https://issues.apache.org/jira/browse/AMQ-6264
...
Fire advisory for slow consumer outside the pending lock.
2016-05-04 16:32:01 -04:00
297eadf746
https://issues.apache.org/jira/browse/AMQ-6267
...
Added two new properties for configuration to a network bridge,
advisoryPrefetchSize and advisoryAckPercentage. By default
advisoryPrefetchSize is set to 0, which is disabled, and will use the
prefetchSize value unless otherwise set. Also added validation to
prefetchSize to make sure it is greater than 0 as 0 is not allowed.
2016-04-27 14:11:05 +00:00
8031d77f98
https://issues.apache.org/jira/browse/AMQ-6251
...
Make field volatile since it is written to outside of any locks and read
both in and out of locking.
2016-04-26 10:04:21 -04:00
11622b3af3
https://issues.apache.org/jira/browse/AMQ-6256
...
Moving beforeMarshall back to the store implementations because we don't
want all store implementations to marshall (such as memory store)
This reverts commit b9b98a45ce
2016-04-18 12:34:25 +00:00
9c8bd3360f
https://issues.apache.org/jira/browse/AMQ-6222
...
Reverting the change to move clearMarshalledState into the callback
listener as beforeMarshall is now called before the async message add
Revert 75990ef14a
2016-04-18 11:49:16 +00:00
b9b98a45ce
https://issues.apache.org/jira/browse/AMQ-6256
...
Moving beforeMarshall call out of the store and into the actual
destination
2016-04-15 14:17:00 +00:00
19fd084a83
https://issues.apache.org/jira/browse/AMQ-6252
...
Update for some added thread safety. Adds method healthStatus that will
regenrate the status from the healthList data which is more intuitive
than the getCurrentStatus which doesn't update state and requires
periodic calls to healthList to capture current metrics.
2016-04-14 16:53:17 -04:00
f9682b802f
https://issues.apache.org/jira/browse/AMQ-6127
...
LOG at info level for when broker is being stopped and a new connection
is not being accepted.
2016-04-12 16:28:23 -04:00
c1b58d3373
https://issues.apache.org/jira/browse/AMQ-6239
...
Refactor the iterator implementation in the PrioritizedPendingList to
not copy elements and instead use the level iterators. Add some
additional tests.
2016-04-12 11:35:03 -04:00
2a8218a9a8
https://issues.apache.org/jira/browse/AMQ-6151 - retain list for redeliveries and combine for dispatch/iteration such that redeliveries retain per priority order after prefetch
2016-04-06 15:09:36 +01:00
a3a8c1c525
https://issues.apache.org/jira/browse/AMQ-6215 - support 0 maxBrowsePageSize and maxExpirePageSize such that lazyDispatch ensures highest priority messages is available to a pull consumer
2016-04-05 13:23:06 +01:00
b2327db3b7
https://issues.apache.org/jira/browse/AMQ-6133
...
Disabling async queue message store when persistJMSRedelivered is turned
on for a destination. That flag will cause a sync update later on
dispatch which can cause a race condition if the original message add is
processed after the update. This can cause a duplicate message to be
stored.
2016-04-01 16:40:45 +00:00
48ba714b30
https://issues.apache.org/jira/browse/AMQ-6210
...
Clean up and apply filtering for temp destinations to removeConsumer as
well.
This closes #175
2016-03-28 14:40:00 -04:00
f3ecc293f0
https://issues.apache.org/jira/browse/AMQ-6210
...
Don't cache selectors for temp destinations.
2016-03-28 14:34:20 -04:00
c53b99c14d
NO-JIRA Fix test such that the broker ports are selected dynamically
...
instead of hardcoded.
2016-03-23 10:23:10 -04:00
75990ef14a
https://issues.apache.org/jira/browse/AMQ-6222
...
Moving clearedMarshalledState execution to the async listener on an
async add to the message store. This is necessary to make sure this
logic doens't execute until after the message is marshalled for the
store.
2016-03-22 17:54:13 +00:00
a4c748883a
https://issues.apache.org/jira/browse/AMQ-6211 - synchronize creating of jmx composite types
2016-03-14 17:10:13 +01:00
ae441cbc7d
https://issues.apache.org/jira/browse/AMQ-6208 - fix and test
2016-03-11 12:01:18 +00:00
a2781e3966
https://issues.apache.org/jira/browse/AMQ-6204
...
Fixing the removal logic on virtual destination remove inside of
Advisory Broker to clean up virtual destination maps properly. Added a
test to verify. Also added new debug logging to help track down any
future issues.
2016-03-09 19:54:08 +00:00
8b23e072ee
https://issues.apache.org/jira/browse/AMQ-5785
...
Avoid holding the intrinsic lock on the cursor when expiring the
messages.
2016-03-08 13:37:58 -05:00
078f39f589
https://issues.apache.org/jira/browse/AMQ-6199 - apply CursorMemoryHighWaterMark to topic subscriptions
2016-03-08 16:45:06 +00:00
gtully
Christopher L. Shannon (cshannon)
Colm O hEigeartaigh
Alan Protasio
hkesler
jgoodyear
giliva
Jeff Genender
Pascal Schumacher
Łukasz Dywicki
Erik Wramner
Dejan Bosanac
Christian Schneider
Zoran Regvart
Timothy Bish
Vasco Veloso
Daniel Kulp
William Crowell
Claus Ibsen
Hadrian Zbarcea
Jonathan Malek
Quinn Stevenson