gtully
ce604fba78
https://issues.apache.org/jira/browse/AMQ-6151 - respect prioritizeMessages for pending and redelivered messages
...
(cherry picked from commit 5af5b59d3b
)
2016-02-02 16:20:22 +00:00
Marc Breslow
0b481903aa
Fix Impossible Cast issues in MemoryTopicSub:
...
- recoverSubscription()
-- map is defined as LinkedHashMap<MessageId, Message>
-- msg is defined as <map> entry.getValue() so must be a Message
-- condition if (msg.getClass() == MessageId.class) could never be true
-- no need to cast at all when using generics
- recoverNextMessages()
-- basically same code copy/pasted so same fix
Removed 2 conditions from ServerSessionPoolImpl that would result in impossible casts. Conditions removed were trying to cast ActiveMQQueueSession and ActiveMQTopicSession to ActiveMQSession which is illegal.
Since it isn't obvious what to do if you get an ActiveMQQueueSession or ActiveMQTopicSession from getServerSession() I make it fall back to the else condition which raises an async exception. This is better than getting a ClassCastException at runtime.
Remove impossible cast in MemoryMessageStore
(cherry picked from commit 4a937def7d
)
2016-02-01 13:07:26 +00:00
Daniel Kulp
3e3cddc97e
Remove a printStackTrace for an exception that is also logged. Produces noise on console
2016-01-27 10:21:32 -05:00
Christopher L. Shannon (cshannon)
24a9fa79f4
https://issues.apache.org/jira/browse/AMQ-6129
...
fixing typo
(cherry picked from commit 7b7e362465
)
2016-01-15 15:13:26 +00:00
Christopher L. Shannon (cshannon)
087e5da254
https://issues.apache.org/jira/browse/AMQ-6129
...
Adding NetworkBridgeStatistics and also a received count for bridges
when they are in duplex mode.
(cherry picked from commit 10c998b0bc
)
2016-01-15 14:58:30 +00:00
Altaflux
aa8b64420b
Network of brokers on duplex mode reports InstanceAlreadyExistsException on already existing destinations
...
(cherry picked from commit 6b1e87410d
)
2016-01-14 15:57:41 +00:00
Timothy Bish
b04cfeb8af
https://issues.apache.org/jira/browse/AMQ-6059
...
Ensure that a message sent to the store for the DLQ is rewritten so that
its updated values are written to prevent exirpation loops and loss of
reollback cause etc.
(cherry picked from commit 505a76a8bb
)
2016-01-12 12:00:41 -05:00
Timothy Bish
b4405bed5e
AMQ-6121
...
AMQ-6122
Prevent messages on DLQ for looping back onto the same DLQ. Prevents
expired messages from bouncing back and duplicate messages from the
store from causing a deadlock.
(cherry picked from commit 66cfc7bab3
)
2016-01-12 12:00:26 -05:00
gtully
26665fa1b9
https://issues.apache.org/jira/browse/AMQ-6094 - regression via https://issues.apache.org/jira/browse/AMQ-6014 - incorrect ref count on message expiry event during cursor move for dispatch. Fix and test - thanks for the test
...
(cherry picked from commit e3df09b9db
)
2016-01-05 14:33:43 +00:00
Timothy Bish
871f0a6005
https://issues.apache.org/jira/browse/AMQ-6102
...
Call to the statistics instance of the subscription to reset the
counters.
(cherry picked from commit 564d55023e
)
2015-12-21 17:04:47 -05:00
Christopher L. Shannon (cshannon)
a12c21061e
https://issues.apache.org/jira/browse/AMQ-6091
...
The JavaRuntimeConfigurationBroker can now apply a subset of policy
properties retrospectively to existing destinations versus applying
all properties of the policy update.
(cherry picked from commit a253ad3c71
)
2015-12-18 18:22:19 +00:00
gtully
b4360c6e0e
https://issues.apache.org/jira/browse/AMQ-6086 - avoid logging npe on attempted start of persistence adapter post stop
...
(cherry picked from commit 455a628305
)
2015-12-14 19:09:15 +00:00
gtully
2ffd7498a8
https://issues.apache.org/jira/browse/AMQ-6086 - start exception can prevent stop from exiting fully, need to be more selective in creation on stop.
...
(cherry picked from commit 35df815fb8
)
2015-12-14 19:09:15 +00:00
gtully
e5b86116c4
https://issues.apache.org/jira/browse/AMQ-6086 - add some determinism to interleaved stop and start calls on broker service
...
(cherry picked from commit da076f4a63
)
2015-12-11 17:32:06 +00:00
gtully
aa2a85abe5
https://issues.apache.org/jira/browse/AMQ-6070 - rework regression - KahaDBStoreRecoveryExpiryTest had NPE in the logs, region dest not set on recovery listener for expiry case
...
(cherry picked from commit 93092f7ea0
)
2015-12-11 17:31:32 +00:00
gtully
9e8f020301
https://issues.apache.org/jira/browse/AMQ-6005 - have plist whack it existing state on start. Start the temp store after the primary persistence adapter which does the locking
...
(cherry picked from commit 768fa17085
)
2015-12-10 09:46:17 -05:00
gtully
2be754583c
https://issues.apache.org/jira/browse/AMQ-6084 - add broker.adjustUsageLimits to disable the adjustment of limits to what is available. In this way, a broker will fail to start if constrained, ensuring it won't accept connections and block pending resources if it has earlier exited for that reason
...
(cherry picked from commit d7febddb67
)
2015-12-10 09:46:03 -05:00
gtully
c67590104b
https://issues.apache.org/jira/browse/AMQ-5454 https://issues.apache.org/jira/browse/AMQ-6070 - in the case of duplicates from the store the regiondestination was not set
...
(cherry picked from commit 88ec9dad9d
)
2015-12-08 09:51:37 -05:00
gtully
558dcc0479
https://issues.apache.org/jira/browse/AMQ-6070 - rework for virtual topic case, use the destination from the transient region destination rather than the message, such that consumer queue advisories work for delivered etc
...
(cherry picked from commit 179dc3acb2
)
2015-12-08 09:51:23 -05:00
Christopher L. Shannon (cshannon)
1ebfa9ade2
https://issues.apache.org/jira/browse/AMQ-6080
...
fixing typos
(cherry picked from commit 5772e7bed8
)
2015-12-08 13:19:31 +00:00
gtully
e1cf0d2678
https://issues.apache.org/jira/browse/AMQ-6070 - set correct originalDestination property value in advisories
...
(cherry picked from commit 75ff17af41
)
2015-12-03 09:00:27 -05:00
Christopher L. Shannon (cshannon)
819e512138
https://issues.apache.org/jira/browse/AMQ-6062
...
Updated QueueBrowserSubscription to use a ConcurrentMap to avoid a
potential race condition when multiple queue browsers browse
multiple queues.
(cherry picked from commit d346a765e3
)
2015-12-02 15:53:59 +00:00
Christopher L. Shannon (cshannon)
db87a051ca
https://issues.apache.org/jira/browse/AMQ-6069
...
Fixed contains method in PrioritizedPendinList which was not returning
correctly. This was causing messages to not be removed from the
dispatchPendingList when purge was called inside a Queue leading to an
eventual OOM error if enough messages were purged. This fix also
improves performance of the contains method.
(cherry picked from commit 8363c99b51
)
2015-12-02 13:42:42 +00:00
Christopher L. Shannon (cshannon)
95fc593975
Update version for next patch release iteration.
2015-11-30 14:35:26 +00:00
Christopher L. Shannon (cshannon)
cfb4ca9f54
[maven-release-plugin] prepare for next development iteration
2015-11-30 13:48:58 +00:00
Christopher L. Shannon (cshannon)
abfe038ddf
[maven-release-plugin] prepare release activemq-5.13.0
2015-11-30 13:48:11 +00:00
gtully
f09000d1e6
https://issues.apache.org/jira/browse/AMQ-6065 - ensure no call to exit. fix mock test to account for extra call
2015-11-30 13:24:19 +00:00
gtully
1bef4de4dc
Revert " https://issues.apache.org/jira/browse/AMQ-6065 "
...
CPL dependency is not fully compatable with ASF and is not really necessary
This reverts commit 39a20bd788
.
2015-11-30 13:24:18 +00:00
Christopher L. Shannon
39a20bd788
https://issues.apache.org/jira/browse/AMQ-6065
...
Fixed test case so that a System.exit call will not take down the
JVM and cause the test suite to abort in Jenkins early
2015-11-29 10:05:27 -05:00
Christopher L. Shannon
673c2928a1
https://issues.apache.org/jira/browse/AMQ-6066
...
Improving performance of OrderedPendingList contains method
Thanks for David Sitsky for the patch
2015-11-28 13:25:53 -05:00
gtully
2aa172f905
https://issues.apache.org/jira/browse/AMQ-6065 - allow ioexception handler to flip the systemExitOnShutdown broker attribute before calling stop, i.e: exit on store io errors
2015-11-27 14:21:20 +00:00
gtully
0a12bcb928
https://issues.apache.org/jira/browse/AMQ-2191 https://issues.apache.org/jira/browse/AMQ-3529 - rework fixes to remove uncertanty from dealing with intettuptedexception. Sync requests will trap interrupts that ocurr while waiting for responses and fail the connection with an interruptedioexception. Interrupts pending before requests will be suppressed, allowing possible clean shutdown. It is not safe to replay openwire ops b/c they are not idempotent, the only safe option is to have a teardown of the broker side state from a close
2015-11-27 12:21:56 +00:00
Christopher L. Shannon (cshannon)
29d943429c
https://issues.apache.org/jira/browse/AMQ-5393
...
Reverting commit because allowing 0 doesn't actually set the usage to
0 size. It ends up disabling the check all together which was the
opposite intention of the commit.
This reverts commit 3b658f8e1a
.
2015-11-25 17:59:41 +00:00
Christopher L. Shannon (cshannon)
35b7ac250b
https://issues.apache.org/jira/browse/AMQ-5898
...
Removing assertion in VirtualDestinationInterceptor to allow
multiple composite destinations to forward to a physical destination
2015-11-25 13:33:32 +00:00
Christopher L. Shannon (cshannon)
3b658f8e1a
https://issues.apache.org/jira/browse/AMQ-5393
...
Allowing disk limit percentages to be 0
2015-11-25 13:18:59 +00:00
Christopher L. Shannon (cshannon)
bc9edf00d1
https://issues.apache.org/jira/browse/AMQ-6058
...
Updating patch to make sure SelectorAwareVirtualTopics are covered
and code cleanup
2015-11-23 20:35:32 +00:00
Chad Zobrisky
dca6e4506e
AMQ-6058 added a check to make sure the destination starts with the virtual topic prefix.
2015-11-23 20:10:26 +00:00
gtully
4318eba4a3
https://issues.apache.org/jira/browse/AMQ-6014 - topic store prefetch should take ownership like in the non persistent case - DurableSubscriberNonPersistentMessageTest regression
2015-11-23 12:27:03 +00:00
Christopher L. Shannon (cshannon)
cc6213ebf2
https://issues.apache.org/jira/browse/AMQ-5712
...
Switching addMessageLast to tryAddMessageLast when messages are added
to a Queue pending cursor to allow a potential deadlock to be
avoided. There is more work to be done here but this will at least
prevent a deadlock from occurring.
Fix and test based off of a patch created by Timothy Bish.
2015-11-20 20:58:27 +00:00
gtully
15412bae64
AMQ4221Test - remove system exit as it breaks surefire fork, https://issues.apache.org/jira/browse/AMQ-6004 interrupt causes errors on shutdown. Two are sorted but the check for errors in the logs may still cause intermittent failures
2015-11-18 16:08:29 +00:00
Christopher L. Shannon (cshannon)
09054fc4a8
https://issues.apache.org/jira/browse/AMQ-6050
...
Clearing the subscription from the local map in
DemandForwardingBridgeSupport to make sure that demand can be properly
recreated again.
2015-11-18 15:06:33 +00:00
Timothy Bish
078a101cf7
https://issues.apache.org/jira/browse/AMQ-6000
...
Fix and test, wakeup queue dispatch when resume is called.
2015-11-10 15:39:51 -05:00
Timothy Bish
938aa626c2
https://issues.apache.org/jira/browse/AMQ-6039
...
If the rename option fails, then we must try a complete copy since the
move can cross file systems.
2015-11-10 11:12:50 -05:00
Christopher L. Shannon (cshannon)
cc81680e10
https://issues.apache.org/jira/browse/AMQ-6027
...
Adding support for consumers on virtual destinations to create network
demand. This behavior is turned off by default but can be enabled.
For example, if a consumer comes online for a queue that is part of a
VirtualTopic, this will cause a network of brokers to forward messages
because a demand subscription will be created. Same for if a consumer
comes online for a forwarded destination from a composite
destination.
There is also an option to enable flow based on the existence of a
virtual destination if the virtual destination is forwarding to a
Queue.
Full configuration instructions for this feature will be on the wiki page.
2015-11-09 20:07:43 +00:00
Timothy Bish
014d5594d6
AMQ-6032 Repack message prior to scheduler dispatch to store updated
...
properties in marshaled form.
2015-10-30 14:11:06 -04:00
Christopher L. Shannon (cshannon)
c5506f5b17
Switching getter method to public
...
Switching isReduceMethodFootprint() to public access so it can be
accessed.
2015-10-30 15:39:24 +00:00
gtully
5d697cff3b
https://issues.apache.org/jira/browse/AMQ-6016 - rework fix for https://issues.apache.org/jira/browse/AMQ-2106 - account group assignment on a per destination basis to prevent modification during consumer ordering
2015-10-21 14:02:56 +01:00
gtully
a01578ad4c
fix stop/stop or stop no start NPE on sharedfilelocker
2015-10-20 13:02:57 +01:00
gtully
dc19d28af9
https://issues.apache.org/jira/browse/AMQ-3573 https://issues.apache.org/jira/browse/AMQ-2834 - only validate limits if they are set
2015-10-20 12:17:23 +01:00
gtully
1ad0117932
https://issues.apache.org/jira/browse/AMQ-6014 - fix up reference counting for durable subs such that ack on one sub does not decrement usage for offline subs. Fix and test
2015-10-19 16:22:57 +01:00