Commit Graph

320 Commits

Author SHA1 Message Date
Pascal Schumacher efcca7d062 Fix javadoc warnings related to non-existing parameter names. 2020-05-22 10:49:39 +02:00
gtully cedac472a1 [AMQ-7488] mkahadb - detect txStore corruption and suspend recovery, auto recover if no outcomes pending 2020-05-20 12:43:37 +01:00
Pascal Schumacher 67e06c82f7 Fix some javadoc warnings releated to non-existing parameter names. 2020-05-17 11:38:05 +02:00
Jean-Baptiste Onofré 0444dd96b2
Merge pull request #505 from PascalSchumacher/potential_overflow_in_int_multiplication
Avoid potential overflow in int multiplication before it is converted…
2020-05-16 07:17:13 +02:00
Pascal Schumacher b43f5b8cf2 Avoid potential overflow in int multiplication before it is converted to long. 2020-03-08 11:50:21 +01:00
Colm O hEigeartaigh a73a85e6c2 AMQ-7438 - Harden deserialization 2020-03-06 17:22:07 +00:00
gtully 5d03224880 no jira - additional trace logging to kahadb cleanup/gc to identify datafile for durable sub command and pending count by sub key 2020-02-28 09:47:02 +00:00
jbonofre d878d877d5 [AMQ-7410] Align dependencies with Apache Karaf 2020-02-26 13:11:33 +01:00
jbonofre 927e01f0c8 Flexible AMQ7086Test on KahaDB for Jenkins 2020-02-26 08:22:19 +01:00
Daniel Trebbien 3faad9b357 Use simpler SLF4J API functions
Eliminates the need to construct a new (temporary) Object array object.

These changes were suggested by SLF4J Helper for NetBeans IDE:
http://plugins.netbeans.org/plugin/72557/
2020-02-19 07:54:25 +00:00
Daniel Trebbien 6d36c490e5 Fix inconsistent 'info'-level logger calls
Some calls to info() were guarded by checks that logging at the trace
level is enabled.

These issues were found by SLF4J Helper for NetBeans IDE:
http://plugins.netbeans.org/plugin/72557/
2020-02-19 07:41:31 +00:00
Pascal Schumacher 5356893fac AMQ-7402: Inconsistent synchronization of getters/setters of some classes
Make synchronization consistent or remove it and declare the field volatile.
2020-02-12 17:48:34 +01:00
Colm O hEigeartaigh 675fb7bcae AMQ-7376 - Use correct type for collections retrieval 2020-01-20 18:35:01 +00:00
Jean-Baptiste Onofré a0531943a4
Merge pull request #348 from nguyenhoan/patch-1
close DataByteArrayOutputStream buff of WriteBatch
2019-11-17 06:46:01 +01:00
Colm O hEigeartaigh 892c9e2a2d AMQ-7295 - Update JTA spec 2019-10-16 14:28:17 +01:00
gtully ed5edb03d7 AMQ-7311 - track recovered prepared ack locations on a per subscriber basis, fix and test 2019-09-26 15:54:57 +01:00
gtully 289750d7c9 AMQ-7308 - ensure kahadb message add does not auto create the message store in error, expect an existing store. fix and test 2019-09-20 10:22:56 +01:00
gtully 4d5e41ca28 AMQ-7227 - ensure db.free file is moved in scheduler store upgrade process 2019-06-14 10:01:57 +01:00
Christopher L. Shannon (cshannon) ac01af8dec Merge branch 'AMQ-7221'
This closes #364

Thanks to Alan Protasio for the patch
2019-06-11 07:51:33 -04:00
gtully 28a0cc6e5a AMQ-7225 - fix intermittent failure, avoid gc of partial tx pending commit 2019-06-11 12:36:02 +01:00
gtully 93e726d6a7 AMQ-7225 - defer cleanup task operation till recovery processing complete, track prepared location in recovered ops to ensure they are retained on recovery failure. Fix and test 2019-06-10 15:33:13 +01:00
Alan Protasio 5eb8403b1f AMQ-7221 - Delete Scheduled messages causes ActiveMQ create/write a unnecessary huge transaction file 2019-06-04 00:02:05 -07:00
Alan Protasio bce979349e AMQ-7219 - ActiveMQ replays journal file on a clean/unclean shutdown with transacted session + Non persistent Messages 2019-05-30 10:13:16 -07:00
Alan Protasio b56819123b AMQ-7196 - During startup ActiveMq load all the scheduleDB.data on memory causing OOM 2019-05-08 12:00:42 -07:00
Alan Protasio cd1d5eb785 AMQ-7163 - If the broker had an unclean shutdown and number of free pages is Zero after the recovery, the next shutdown will also be 'unclean' 2019-03-06 15:33:52 -08:00
Alan Protasio 87467dc61e AMQ-7159 - Adding a new attribute on PersistenceAdapterViewMBean to show information about Storage write/read latency 2019-03-06 11:41:08 -08:00
Hoan Nguyen 0262338687
close DataByteArrayOutputStream buff of WriteBatch 2019-02-26 19:07:26 -08:00
Alan Protasio 9e65435517 AMQ-7143 - Temporary transaction file (PageFile) being opened and closed many times, causing poor performance on high latency FS as NFS 2019-01-31 10:31:16 -05:00
Christopher L. Shannon (cshannon) c3714457f1 AMQ-7136 - Improve recovery of durable subscription metrics in KahaDB
Updated metrics recovery to only have to iterate over the order index 1
time to recovery the pending metrics for the subscriptions instead of
making a pass over the index once per subscription
2019-01-15 14:22:26 -05:00
Alan Protasio 4b51f8b66c AMQ-7132 - ActiveMQ reads lots of index pages upon startup (after a graceful or ungraceful shutdown) 2019-01-14 10:54:26 -05:00
Christopher L. Shannon (cshannon) a16b227808 AMQ-7129 - code cleanup 2019-01-11 10:31:44 -05:00
Christopher L. Shannon (cshannon) fa2daa25e9 AMQ-7129 - fix durable message size statistics with individual ack
Make sure that the pending message size for a durable sub only includes
messages part of the ack range
2019-01-11 09:56:57 -05:00
Christopher L. Shannon (cshannon) 25de20c77e AMQ-7129 - Properly recover messages from KahaDB for a durable when there are
messages to recover before the stored lastAck value

With individual ack mode we need to check the durable ackPosition
sequence set in the KahaDB index on subsription load to see if there are
earlier messages before the lastAck value that still haven't been acked.
While this normally wouldn't happen it is possible in individual ack
mode
2019-01-09 14:34:06 -05:00
jgoodyear 4a21edc8d5 [AMQ-7126] Improvement to perf of 5266Test 2019-01-07 21:22:34 -03:30
jgoodyear b86c666c40 [AMQ-7126] Prevent OOM when recovering KahaDB and memory space is insufficient to load full page. Thank you Heath Kesler and Johan Edstrom for investigation and patch. 2019-01-03 15:46:39 -03:30
jgoodyear 612d4aeeb4 AMQ-7118 This closes #327 - with thanks to Heath Kesler 2018-12-04 12:54:30 -03:30
Alan Protasio 9012a7871b AMQ-7091 - O(n) Memory consumption when broker has inactive durable subscribes causing OOM 2018-11-12 17:48:53 -03:30
gtully 85859fd8dc AMQ-7082 We should make sure that pages managed during recovery are not recovered in error
variation of patch from Alan Protasio <alanprot@gmail.com> closes #317
2018-11-07 11:29:14 +00:00
Alan Protasio 0d34338919 AMQ-7082 - Make sure that the recovery will only mark pages as free if they were created in a previous execution 2018-11-06 04:48:22 -08:00
gtully bf8eb08aca AMQ-7086 - make kahadb gc/cleanup on shutdown optional to trade availability over disk usage for fast failover 2018-10-31 14:29:05 +00:00
gtully 8a1abd9bb2 AMQ-7084 - ensure allocated and unused free pages are visible to subsequent transactions, fix and test with test updates to reflect proper usage 2018-10-23 16:00:57 +01:00
gtully fb1e642c15 AMQ-7082 - ensure flush sees free list, use lazySet to avoid store barrier, thanks cshannon 2018-10-22 15:16:26 +01:00
gtully efa4e683bc AMQ-7082 - fix final ref in test 2018-10-19 16:45:04 +01:00
gtully 79c74998dc AMQ-7082 - recover index free pages in parallel with start, merge in flush, clean shutdown if complete. follow up on AMQ-6590 2018-10-19 16:00:23 +01:00
gtully ed727d22e1 AMQ-7067 - track xa commit outcomes in ack compaction such that there are no dangling prepared tx on full recovery, fix and test 2018-10-17 18:13:36 +01:00
gtully 5d3a3fcca7 AMQ-6590 - rework fix to take the recovery hit on clean shutdown rather than on restart, trade off availability for short term disk usage 2018-10-17 12:32:04 +01:00
gtully 7c890d4776 AMQ-7067 - test and fix for eager ack compaction moving acks from data files with in progress tx and clearing the link from the prepare record, that now uses the same ack map 2018-10-12 14:51:37 +01:00
gtully a311139bfe AMQ-7067 - ensure updates to ackMessageFileMap are protected by the index lock 2018-10-09 12:55:11 +01:00
gtully 57c7939534 AMQ-7067 - tidy up tests and add prepare variant, limit rollback location recording to xa case. There is still some work to do for the ack compaction case to make it aware of the tx records such that those are transferred as necessary 2018-10-09 12:01:47 +01:00
jgoodyear 99db9ef301 KahaDB Recovery can experience a dangling transaction when prepare and commit occur on different pagefiles.
Signed-off-by: gtully <gary.tully@gmail.com>
2018-10-09 10:19:35 +01:00