Commit Graph

1282 Commits

Author SHA1 Message Date
Christopher L. Shannon (cshannon) c3714457f1 AMQ-7136 - Improve recovery of durable subscription metrics in KahaDB
Updated metrics recovery to only have to iterate over the order index 1
time to recovery the pending metrics for the subscriptions instead of
making a pass over the index once per subscription
2019-01-15 14:22:26 -05:00
hkesler 5c23dd53ad AMQ7135 : do a purge before deleting the destination
(cherry picked from commit 9f513f8878)
2019-01-14 13:44:52 -03:30
Alan Protasio 4b51f8b66c AMQ-7132 - ActiveMQ reads lots of index pages upon startup (after a graceful or ungraceful shutdown) 2019-01-14 10:54:26 -05:00
Christopher L. Shannon (cshannon) fa2daa25e9 AMQ-7129 - fix durable message size statistics with individual ack
Make sure that the pending message size for a durable sub only includes
messages part of the ack range
2019-01-11 09:56:57 -05:00
Christopher L. Shannon (cshannon) 703b8cbda3 AMQ-7129 - minor junit test fix 2019-01-09 14:39:11 -05:00
Christopher L. Shannon (cshannon) 25de20c77e AMQ-7129 - Properly recover messages from KahaDB for a durable when there are
messages to recover before the stored lastAck value

With individual ack mode we need to check the durable ackPosition
sequence set in the KahaDB index on subsription load to see if there are
earlier messages before the lastAck value that still haven't been acked.
While this normally wouldn't happen it is possible in individual ack
mode
2019-01-09 14:34:06 -05:00
jgoodyear 4a21edc8d5 [AMQ-7126] Improvement to perf of 5266Test 2019-01-07 21:22:34 -03:30
Jeff Genender 273afef47c AMQ-7118 - Override hostname for naming to allow tests to apss on all
platforms
2019-01-07 17:07:08 -07:00
jgoodyear b86c666c40 [AMQ-7126] Prevent OOM when recovering KahaDB and memory space is insufficient to load full page. Thank you Heath Kesler and Johan Edstrom for investigation and patch. 2019-01-03 15:46:39 -03:30
jgoodyear 612d4aeeb4 AMQ-7118 This closes #327 - with thanks to Heath Kesler 2018-12-04 12:54:30 -03:30
Alan Protasio 2eda327aba AMQ-7107 - Make QueueBrowsingTest and UsageBlockedDispatchTest succeed with ConcurrentStoreAndDispachQueues=false 2018-11-21 13:18:12 -08:00
gtully 8cc0c5ad6c AMQ-7106 - fix pending stop support by avoiding sync through single shared status var - fix and test 2018-11-21 10:23:13 +00:00
gtully 9cb680c0ba AMQ-7102 - don't track objectNames that have not been registered due to suppressMBean filter, fix and test 2018-11-15 17:45:18 +00:00
gtully bc8c78cd32 AMQ-7009 - apply fix to memorymessagestore setBatch with thanks to Nezih BEN FREDJ for test and suggestion 2018-11-14 14:21:27 +00:00
Alan Protasio 9012a7871b AMQ-7091 - O(n) Memory consumption when broker has inactive durable subscribes causing OOM 2018-11-12 17:48:53 -03:30
gtully d2b0affedb AMQ-7094 - track the objectName with an annotated mbean such that the jmx audit log event can extract that target of an mbean operation, fix and test 2018-11-08 12:10:01 +00:00
gtully 82dec402aa no-jira - fix intermittent test failure when cron falls on next minute 2018-11-05 16:33:34 +00:00
gtully f2cde24a62 AMQ-7088 - fix deadlock on remove add interaction from mqtt virtual topic sub use case 2018-11-01 10:11:08 +00:00
Christopher L. Shannon e093a8c1d8 NO-JIRA - add missing license headers 2018-10-24 09:01:39 -04:00
Christopher L. Shannon 8e5d539665 AMQ-7067 - add missing license header 2018-10-24 08:55:35 -04:00
gtully 87087fc930 no-jira - fix flaky test that depends on the broker processing the previous ack 2018-10-22 11:50:54 +01:00
gtully 0e02b678d1 no-jira - fix flaky test that can get redelivery on async client ack and concurrent close 2018-10-22 11:21:42 +01:00
gtully 9dd751149f AMQ-7079 AMQ-7077 AMQ-6421 - check for consumers that have been destroyed 2018-10-18 16:49:29 +01:00
gtully 8690436b5b no jira - give test a second bite to avoid spurious timing related failures in ci 2018-10-18 10:32:33 +01:00
gtully ed727d22e1 AMQ-7067 - track xa commit outcomes in ack compaction such that there are no dangling prepared tx on full recovery, fix and test 2018-10-17 18:13:36 +01:00
gtully 4dee173962 AMQ-7077 AMQ-6421 - tie queue consumer slow flag detection to abort slow consumer policy, fire advisory when set. 2018-10-17 11:04:47 +01:00
gtully 7c890d4776 AMQ-7067 - test and fix for eager ack compaction moving acks from data files with in progress tx and clearing the link from the prepare record, that now uses the same ack map 2018-10-12 14:51:37 +01:00
Christopher L. Shannon (cshannon) 3ac3a420a1 AMQ-7071 - Mark previously dispatched messages as redelivered if
connection for durable topic subscription is improperly closed leading
to a lastDeliveredSequenceId as unknown
2018-10-12 08:35:37 -04:00
gtully 57c7939534 AMQ-7067 - tidy up tests and add prepare variant, limit rollback location recording to xa case. There is still some work to do for the ack compaction case to make it aware of the tx records such that those are transferred as necessary 2018-10-09 12:01:47 +01:00
jgoodyear 99db9ef301 KahaDB Recovery can experience a dangling transaction when prepare and commit occur on different pagefiles.
Signed-off-by: gtully <gary.tully@gmail.com>
2018-10-09 10:19:35 +01:00
gtully 5246151288 AMQ-7062 - have redelivery plugin ignore messages detected as duplicates 2018-09-26 11:22:59 +01:00
gtully cae66f5d37 AMQ-6086 - variant with broker.schedulerSupport=true; same fix with additional test 2018-09-25 16:29:24 +01:00
gtully cdbddcafa2 AMQ-7057 - support transport connector warnOnRemoteClose to suppress eof warnings on loadbalance or health check socket ping 2018-09-20 14:58:34 +01:00
gtully 2f5e5efec5 AMQ-7056 - modify tests to take account of changes from AMQ-7047 2018-09-20 10:25:51 +01:00
Alan Protasio b92aaa2f58 AMQ-7052 - Fix JdbcXARecoveryBrokerTest and mLevelDBXARecoveryBrokerTest tests
Signed-off-by: gtully <gary.tully@gmail.com>
2018-09-18 10:26:29 +01:00
Christopher L. Shannon (cshannon) 1e31df9800 AMQ-7047 - Switch default for hostname verification to be false for
server

For the client it makes sense to have it true by default but for the
server it makes sense to have it false by default
2018-08-31 13:04:14 -04:00
Christopher L. Shannon (cshannon) 69fad2a135 Add support for hostname verification 2018-08-31 06:39:49 -04:00
gtully 54c56a0573 AMQ-7037 - add sslContext attribute to networkConnector, allow broker or jvm defaults to be overridden 2018-08-20 16:40:26 +01:00
gtully 50d27e7e54 AMQ-7035 - use NonCachedMessageEvaluationContext in place of MessageEvaluationContext to avoid unnecessary reference count management and subsequent leaks. Rework AMQ-6465 with additional JMX related tests 2018-08-15 16:21:57 +01:00
gtully bdfa3394ad AMQ-7030 - trap exceptions on future.get, fix and test 2018-08-02 14:45:31 +01:00
Christopher L. Shannon (cshannon) 525fd29d16 AMQ-6974 - test cleanup 2018-07-27 08:38:58 -04:00
giliva 5b1412ddfd Avoid overflow errors - see KAFKA-4290
Add test for overflow values

Bind test sockets to free ports
2018-07-27 08:32:36 -04:00
gtully 0b76d3a0ea AMQ-7021 - add unsynchronised accessors to destination map for usage with rw lock from abstract region; allow concurrent read of the destination map 2018-07-26 10:42:10 +01:00
Jeff Genender 28819aea4a AMQ-7015 - Changed attribute to purgeRecoveredXATransactionStrategy and
allow NEVER, COMMIT, and ROLLBACK
2018-07-25 12:57:17 -06:00
hkesler 24b9ae2ed3 AMQ-7015 Added a purgeRecoveredXATransactions property on the KahaDB adaptor to purge prepared XA messages on recovery 2018-07-19 12:01:01 -06:00
jgoodyear 063d21f880 [AMQ-7013] Adding unit test 2018-07-18 10:39:29 -06:00
gtully e0aa091d9e AMQ-7002 - ensure uniqueue jobids, fix and test via patch from Jamie goodyear applied with thanks 2018-06-27 14:14:44 +01:00
gtully 57a6f2373e AMQ-6854 - ensure non null return in the event on no space to page in 2018-06-13 13:10:52 +01:00
gtully 004be56127 AMQ-2659 - make configurable based on xaAckMode, otherwise pure xa case can default to autoack in error. Additional tests 2018-06-13 11:48:43 +01:00
gtully 1ebf186279 AMQ-3405 - rework fix to use original destination strategy which may be different from the default shared strategy. new test 2018-06-07 11:38:42 +01:00
gtully 63b71affbc AMQ-6824 - harden test 2018-06-01 12:48:08 +01:00
gtully 8b40624837 AMQ-5837 - ensure test timeout > wait timeout for assertions so failures are visible 2018-06-01 12:39:37 +01:00
gtully 6d14e4e85b AMQ-6979 - fix test regression, avoid gc during shutdown such that the error check on the logging remains valid 2018-05-31 13:44:01 +01:00
gtully 4521f47e36 AMQ-6979 - fix test regression dependent on serial excution of expiry processing across destinations 2018-05-31 13:12:38 +01:00
gtully 51ec4590eb [AMQ-6906] exclude test from leveldb scenario dependent on tracked recovered acks 2018-05-31 10:26:03 +01:00
gtully cdb38b3275 AMQ-6979 - use scheduler as trigger task - do heavy lifting via the task runner executor, take care to trap errors to keep scheduler timer alive AMQ-5129 2018-05-30 22:03:50 +01:00
gtully 20ec044c41 refactor test to cleanup persistence adapter creation for combos - fix ci 2018-05-23 11:56:57 +01:00
gtully 026c6f4403 AMQ-6967 - ensure there are some messages paged in for periodic expiry check if non are in memory 2018-05-21 14:26:45 +01:00
gtully 01384c714d AMQ-6707 - fix destination filter delegate param, refactor-auto-gen method; jees 2018-05-18 14:44:05 +01:00
gtully 72613aaba6 AMQ-6707 - ensure entryLocator is used for rollback of prepared add to avoid NPE, relates to AMQ-5567 2018-05-18 10:32:00 +01:00
gtully 573b366ca0 AMQ-6100 - use setOriginalDestination=false to make this behaviour optional b/c amqp cannot see the original dest property due to immutability of the message properties and folks can depend on the existing original destination behaviour 2018-05-10 10:55:15 +01:00
gtully bd45d931ba [AMQ-6906] tidy up cleanup on jdbc error and combine updates in single completion to avoid prepared sequence update on non transacted add with error. More jdbc error related tests 2018-05-03 11:32:21 +01:00
gtully 314d5a5168 AMQ-6707 - skip tracked ack dependent test for leveldb 2018-04-27 14:06:04 +01:00
gtully ea70e827c0 AMQ-6707 - JDBC XA recovery and completion.
ensure pending transactions are visible for recovery without restart
sync store and cursor size during and after completion
ensure pending messages are not visible to browsers
retain transaction state on jdbc error
a bunch of new tests around xa completion
2018-04-26 14:58:48 +01:00
Christopher L. Shannon (cshannon) 84126d8a7a AMQ-6940 - test fix for AMQ6477 test
Need to remove the portion of the test that looks at the dispatched list
for TopicSubscription as that class no longer tracks message references
2018-03-30 06:34:36 -04:00
Christopher L. Shannon (cshannon) 65b0f2ad0d AMQ-6940 - Add flag to disable TopicSubscription in flight stats
To save memory usage in some use cases add a new flag to PolicyEntry
called useTopicSubscriptionInflightStats to allow disabling the
inflight stats
2018-03-29 13:25:36 -04:00
gtully 060817552d [AMQ-4261] use WARN level for producer flow control events, DEBUG if blockedProducerWarningInterval=0 2018-03-02 12:17:24 +00:00
gtully b57f4f3211 [no jira] extend the timeout b/c it was on the margins 2018-03-01 11:38:16 +00:00
gtully 82c9f9531e [AMQ-6907] add selectorAware option to conditionalNetworkBridgeFilterFactory such that replay back to origin can happen if there are no matching local consumers 2018-02-28 16:07:52 +00:00
gtully efaf9cd77e [AMQ-6906] jdbc store; ensure rolled back prepared ack messages are recovered asap 2018-02-28 13:31:12 +00:00
gtully dd2572bcb1 [AMQ-6891] test and fix non tx variant of this leak 2018-01-30 10:51:30 +00:00
Christopher L. Shannon (cshannon) e5de25f4fc NO-JIRA: Add missing license headers 2018-01-29 08:10:50 -05:00
gtully f96a20e831 [AMQ-6891] apply fix and test from Radek Kraus with thanks. Pending cursor adds are now dropped on rollback 2018-01-26 13:18:00 +00:00
gtully ec6fa19099 [AMQ-6815] rework to drop the batch reference from Location such that batches are free for gc when index pages are agressively cached 2018-01-11 12:56:40 +00:00
Łukasz Dywicki a8a032af09 AMQ-6861 Allow customisation of network bridge creation logic. 2017-12-20 22:00:54 -05:00
Carlo Dapor b40e5f93bd [AMQ-6601] AMQ with master and slave broker, shutting down slave causes dead-lock. 2017-12-18 23:08:22 -05:00
Christopher L. Shannon (cshannon) 56baba96c6 AMQ-6875 - Use the correct destination for Virtual destination consumers
when using Virtual Topics
2017-12-14 16:01:10 -05:00
Christopher L. Shannon (cshannon) 5fa0bbd515 AMQ-6871 - By default only send generic platform details
The default behavior by the OpenWire client will be to send generic
platform details to the server with a new flag to send more specific
information.
2017-12-06 08:41:51 -05:00
Christopher L. Shannon (cshannon) 08aa5118ff (AMQ-6858) - add extra precautionary check for demand subs
also remove test that intermittently fails with timing issues
2017-11-16 07:44:33 -05:00
Christopher L. Shannon (cshannon) 2e3a7f6114 (AMQ-6858) - test fix 2017-11-15 09:21:44 -05:00
Christopher L. Shannon (cshannon) 6013441a9a AMQ-6858 - handle resync of network proxy durables after restart
We need to properly handle the re-addition of network proxy durables
after the brokers are restarted so removal is done properly
2017-11-15 08:56:43 -05:00
Christopher L. Shannon (cshannon) 3ca439cada AMQ-6858 - Allow configuration of the client Id token in network bridge
The client id token that is used to separate parts of a generated local
client id in a network bridge should be configurable so bridge names and
broker names can contain underscores if desired
2017-11-14 15:23:26 -05:00
Christopher L. Shannon 41211c78d1 AMQ-6858 - reworking durable subscription propagation fix
Significantly reworking previous fix so that the client id is properly
changed when tracking network proxy subscriptions. This makes it so
removal is done properly
2017-11-13 11:07:43 -05:00
Christopher L. Shannon (cshannon) 96ce14b278 AMQ-6858 - Fix several durable subscription bridge propagation issues
Durable network proxy subs will now be properly created across multiple
bridges when 3 or more brokers are used.  Demand will be properly synced
and removed.
2017-11-09 11:21:18 -05:00
gtully b29ccf3488 [AMQ-6854] log warn if page in is blocked on usage preventing dispatch. Reuse blockedProducerWarningInterval to tweak reporting 2017-11-02 16:04:30 +00:00
gtully 03b19b9da4 [AMQ-6847] limit the retry loop to one iteration overa all pending messages such that new additions are not replayed to avoid duplicates 2017-11-01 11:26:36 +00:00
gtully 2ea5d1420b [AMQ-6847] pause dispatch for message move to avoid redelivery with pending ack/remove/audit rollback 2017-10-27 11:40:06 +01:00
gtully 005403e94b [no jira] more lenient for ci builds - intermittetnt failure 2017-10-27 11:37:04 +01:00
gtully 8e576be1d9 [AMQ-6849] - fix sendFailIfNoSpaceAfterTimeout policy entry default value 2017-10-26 11:36:03 +01:00
gtully 6da08b245e [AMQ-6849] provide a virtualTopic dropOnResourceLimit attribute, default to false.
Enabling will allow dispatch to continue even when end to some consumer queues
fail due to resource constraints.
The existing systemUsage sendFailIfNoSpace and sendFailIfNoSpaceAfterTimeout are
promoted to destination policy options allowing selective destinations to fail a
send with an exception. The global system usage options are still in place.
When dropOnResourceLimit=true dispatch will continue in the event that any
subscription queue throws a resource limit exception on send failure.
2017-10-25 14:53:20 +01:00
gtully be6f4b69c1 [no jira] calm this test a bit due to oom in ci builds 2017-10-25 13:08:00 +01:00
gtully 578eacab45 [AMQ-6824] remove time dependency in test assertion 2017-09-28 11:36:11 +01:00
gtully 41a100766c [AMQ-6824] - fix up prefetchExtension growth on transaction completion and delivered ack and tie in boolean usePrefetchExtension 2017-09-26 11:30:18 +01:00
Timothy Bish 61d3231d36 AMQ-6809 Fix issue where stream message getBytes returned wrong value
StreamMessage implementation should return zero when the full value of a
written byte array has been consumed before then returning -1 on the
next read.  Ands fix and additional testing of ActiveMQStreamMessage
2017-09-20 15:50:09 -04:00
Erik Wramner c691124d32 AMQ-6808 preserve destination for browsed scheduled messages 2017-09-15 09:02:36 -04:00
gtully a359d8152c [AMQ-6277] take account of producer audit not being updatated on recovery check, avoid unnecessary partial journal replay 2017-09-15 13:48:03 +01:00
Dejan Bosanac 5e656d394c https://issues.apache.org/jira/browse/AMQ-6799 - stop the jmx server connector properly 2017-09-01 13:02:53 +02:00
Christopher L. Shannon (cshannon) 35bd3ad938 AMQ-6798 - Clean up store usage object on Queue stop
When queues are stopped the StoreUsage object needs to be stopped so it
will be removed from the parent StoreUsage.  This allows the object to
be garbage collected and prevents a memory leak.
2017-08-24 09:24:36 -04:00
Dejan Bosanac c7291f1ecf https://issues.apache.org/jira/browse/AMQ-6799 - IOExceptionHandler during the startup 2017-08-24 14:04:36 +02:00
gtully 068b7946ce [AMQ-6643][AMQ-5594] fix test regression to reflect match strategy 2017-08-09 11:40:39 +01:00
gtully a67c75a9e1 [AMQ-6643] refine fix to allow wildcard subs to non wildcard subscription queues, enable simple wildcard sub to drain all subscription queues 2017-08-08 16:38:11 +01:00
gtully a15626193c [AMQ-6787] release securty context on failure to addConnection subsequent to auth, resolve leak. fix and test 2017-08-04 13:46:16 +01:00
gtully 206f77adac [AMQ-6778] - fix test regression that needs to account for presence of correct advisory dests 2017-07-26 11:58:04 +01:00
gtully ddfa96028c [AMQ-6778] fix and test - no longer gate firing advisory on broker start flag b/c consumers may be present once transport connectors have started 2017-07-25 13:02:13 +01:00
gtully d7f70837b7 [AMQ-6764] add logging of exit of jmx ops such that overlaps and delays are visible in the audit. fix and test 2017-07-10 14:10:05 +01:00
Christopher L. Shannon (cshannon) a9fe4e33c3 [maven-release-plugin] prepare for next development iteration 2017-06-27 13:41:28 -04:00
Christopher L. Shannon (cshannon) 5f0d6943cb [maven-release-plugin] prepare release activemq-5.15.0 2017-06-27 13:41:01 -04:00
gtully d70852eec8 [AMQ-6625] fix mock test expectation regression 2017-06-16 10:29:32 +01:00
gtully b07821ab64 [AMQ-6625] remove kahadbioexceptionhandler by pushing allowIOResumption into persistence adapter. This allows the lease locker to still be used with kahadb for stopStartConnectors support 2017-06-15 17:28:31 +01:00
gtully 99f3d4c505 [AMQ-6703] have jmx purge clear the audit such that messages can be copied back, fix and test 2017-06-15 10:46:23 +01:00
gtully b6cb0eacea [AMQ-6702] add maxProducersToAudit and maxAuditDepth to dead letter strategy to cofigure the audit, fix and test 2017-06-13 14:26:15 +01:00
Christopher L. Shannon (cshannon) 2a0b785a04 AMQ-6698 - Allow timeout of SSL handshake for auto+nio+ssl
The handshake now takes place inside of the async task that timesout so
that if the SSL handshake takes too long the connection attempt will
honor protocolDetectionTimeout and actually timeout.  Also, change the
default of protocolDetectionTimeout to 30 seconds so it matches the rest
of the broker's default connection timeout settings.
2017-06-08 12:34:15 -04:00
gtully 7413ee00e1 [AMQ-6696] zero out usage for forwarded messages such that the original target is no longer referenced. fix and test 2017-06-02 12:23:58 +01:00
gtully c50dc6ff00 [AMQ-6693] ignore the long term connection associated with the broker context, fix and test 2017-06-01 12:00:04 +01:00
gtully d2c0eddaad [AMQ-6691] allow dlq flag to be set via jmx to allow retry op after a restart - use destinations element for long term persistence 2017-05-31 12:39:48 +01:00
gtully 8023b9ee44 [AMQ-6690] do nothing for move/copy jmx ops that try to modify self 2017-05-31 11:26:46 +01:00
gtully 30d3162982 [no jira] tidy up test teardown - prevent subsequent ci failures in error 2017-05-26 11:49:04 +01:00
gtully 25f112c5c9 [AMQ-6687] ensure transacted sends blocked on pfc do not resume after tx completion. AMQ-4467 refine the fix such that PFC kicks in such that the cache will accept messsages that push it over it's limit while it is still under the limit 2017-05-25 12:43:08 +01:00
gtully acab282d9c [AMQ-6678] sync destructive queue view mbean (jmx) operations such that concurrent calls see consistent state 2017-05-18 12:37:54 +01:00
gtully ae97fbd52e fix cn to match jdk8 cert 2017-05-05 11:01:33 +01:00
gtully b30ae4e846 [AMQ-6665] - remove extranious import from test 2017-05-05 10:48:13 +01:00
gtully 07b0d913af conform to jdk8 algorithm constraints with keystores 2017-05-04 13:14:31 +01:00
gtully dcd9b9e186 use jdk8 allowed cypher in the restricted set 2017-05-04 12:58:25 +01:00
gtully 18d05ba5e0 modify test to validate setting isDLQ flag via startup destination query options 2017-05-03 16:17:29 +01:00
gtully 35f30102a6 [AMQ-2100] fix for intermittent ci failure 2017-05-03 12:31:09 +01:00
gtully c4a1346875 [AMQ-6465] fix up test interplay - clean on start and consume what is produced 2017-05-03 12:22:24 +01:00
gtully a0ba0bf4c6 [AMQ-6667] gate cursor cache enablement on a single pending send and tidy up setbatch to always check outstanding async future list. Fix and test 2017-05-03 11:36:06 +01:00
gtully 57795bafce [AMQ-6665] - check for peercerts is now on tcp transport such that the bridge connection info can have the correct context 2017-04-27 12:07:12 +01:00
gtully b64ac1dd77 [AMQ-6646] improve error reporting to include url 2017-04-04 17:30:29 +01:00
gtully 729766e492 [AMQ-6494] ensure vm transport propagates onCommand exceptions to peer 2017-04-04 14:17:27 +01:00
gtully 0f7561e85a Revert "AMQ-6494 Return ExceptionResponse during broker service shutdown"
the root cause seems to be in the vm transport iterator

This reverts commit dce2b61f87.
2017-04-04 14:15:00 +01:00
gtully 8b064889c6 [AMQ-6643] final modifier for test in the right place 2017-04-04 10:57:57 +01:00
gtully 2a2cb3997f [AMQ-6643] final modifier for test 2017-04-04 10:52:38 +01:00
gtully 679db08db3 [AMQ-6643] ensure a wildcard virtual topic subscriber is restricted to the wildcard destination - avoid duplicate and spurious dispatch. fix and test 2017-04-04 10:16:48 +01:00
gtully 4ef1fc74cf [AMQ-6640] either broker dispatch to bridge or bridge dispatch to broker needs to be async - dispatchAsync network option is the trigger for the vm transport to be sync in line with the current defaults. original BacklogNetworkCrossTalkTest scenario exposed this. upshot is dispatchAsync=false is not compatible with duplicate subscription suppression which is fair. 2017-03-30 12:12:13 +01:00
gtully 5ac9657c12 [AMQ-6640] shrink test duration for ci boxes 2017-03-30 10:16:18 +01:00
gtully d84a58656c [AMQ-6640] allign use of sync vm transport usage on duplex end of networkconnector with initiator end. only duplexinbound for forwarding is async to allow thread for responses. vm transport options applied in one place and test more deterministic w.r.t the hang scenario 2017-03-29 23:50:47 +01:00
gtully 770a73e9ba [no jira] add identity option to consumer bean to aid logging/debugging 2017-03-29 22:19:15 +01:00
gtully 8e00c6c2bc [AMQ-6640] fix duplicate suppression sync request on responder end of duplex network connector only b/c that has the async local transport. Additional test. Ensure broker sync is conditional on the need for duplicate suppression which should only be necessary in ring topologies when properly configured 2017-03-28 14:49:23 +01:00
gtully 36689beff7 [AMQ-6561] fix up unit test that expects socket to remain open after InvalidClientIDException, dubious expectation in the test that wants to verify broker is ok 2017-03-14 11:59:13 +00:00
gtully 01b1f7f694 [AMQ-3233] respect policy entry blockedProducerWarningInterval for flow control warning, 0 disables and Xmillis makes it periodic, default period of 30s is not unlike the existing once behaviour. fix and tests 2017-03-03 11:23:23 +00:00
gtully 2809befff5 [AMQ-6610] - fix up brittle jmock test 2017-03-03 10:14:30 +00:00
gtully e67d48680f [AMQ-6614] fix up jmx blockedSendsCount and producer view blocking flag for async send case. fix and test 2017-03-02 17:00:16 +00:00
Timothy Bish 90b808ab98 AMQ-6603 Stop tracking producer if creation failed
Track the message producer create and ensure it is not recreated on
failover if the creation resulted in an error response.  Add failover
level tests to cover consumer and producer failed create tracking.
2017-02-28 16:17:32 -05:00
gtully a1f6261fb2 [AMQ-6414] additional test that reproduces and validates 2017-02-27 16:35:54 +00:00
Christopher L. Shannon (cshannon) bab0887ed6 AMQ-6610 - Network connector mbean not registered on reload
On network connector add or update after broker start (such as the
runtime plugins) the mbean was not created.  There was also a couple of
other properties not set. Fixed the network connector start to be the
same for normal broker start and runtime reload.
2017-02-24 14:05:27 -05:00
gtully 816f81e605 [AMQ-6517] resolve intermittent test failure - wait for client connection to see broker disconnect 2017-02-22 14:35:27 +00:00
Christopher L. Shannon (cshannon) f6bf823ded AMQ-6599 - Properly apply soTimeout value to TcpTransport
https://issues.apache.org/jira/browse/AMQ-6599

The soTimeout value needs to be applied to the TcpTransport as well as
the socket because the NIO transports use the value later on when
establishing a connection
2017-02-17 08:03:50 -05:00
gtully da5742762a [AMQ-6547] final for inner class reference 2017-02-14 11:49:00 +00:00
gtully fad50812af [AMQ-6547] revert mod from AMQ-3143 such that waitForSpace respects child usage, fix test and validate mKahadb blocking send 2017-02-14 11:33:59 +00:00
gtully f5baebb001 intermittent failure - disable periodic expiry as it may use memory that effects the assertions 2017-02-10 16:03:15 +00:00
gtully d86c98a687 [AMQ-6587] - fix root cause of deletion candidate seeing sub. contention between adding sub to dests and adding dests to sub, also removing sub from dests twice could leave dest stat negative allowing invalid candidate for gc 2017-02-10 11:38:03 +00:00
gtully 0ee4f5b843 [AMQ-6587] additional contention window with new sub while gc is in progress - need to verify new sub is actually subscribed to the candidate for deletion. Fix and test 2017-02-07 13:53:40 +00:00
gtully 9b64e188b5 [AMQ-6432] issue was journal scan on newly created ack file. I left the relevant braces from AMQ-6288 in place. Fix and test 2017-02-03 16:58:52 +00:00
gtully 64b3203713 [AMQ-6587] - fix typo in test that needs 1.7 final 2017-02-01 16:43:02 +00:00
gtully e415d2921e [AMQ-6587] ensure subs added to new destination before destination is exposed in the destination map. sort gc contention with wildcard subs and anonymous publish. fix and test 2017-02-01 15:08:46 +00:00
Krzysztof Sobkowiak f09493727f [AMQ-6586] Compilation of activemq-unit-test fails
(cherry picked from commit 659d1f6ba5)
2017-01-31 15:32:34 -05:00
Vasco Veloso 687badb4fd AMQ-6577: honour usePrefetchExtension in TopicSubscription.
AMQ-6577: move usePrefetchExtension flag to AbstractSubscription to promote reuse.
2017-01-30 11:13:57 -05:00
Christopher L. Shannon (cshannon) d0c95146c3 https://issues.apache.org/jira/browse/AMQ-6579
Remove incorrect dispatch counter increment on message expiration in
TopicSubscription when a pending limit strategy is set
2017-01-25 11:16:43 -05:00
Christopher L. Shannon (cshannon) 56bb079c82 https://issues.apache.org/jira/browse/AMQ-1940
Queue purge now acquires the sendLock to prevent new messages from
coming in while purging.  The statistics are no longer zeroed out as
they should properly decrement as messages are removed.  These changes
should prevent the statistics from going negative.
2017-01-24 08:46:15 -05:00
gtully 030c44a554 [no jira] ensure clean db for test AMQ6463Test - intermittent ci failure 2017-01-16 11:11:45 +00:00
gtully 511b9b642a [AMQ-6562] - suppress warn of durable sub duplicate from the store on cache exhaustion - expected in the absense of ordered sequenceid and setBatch. Fix leak of duplicates pending processing on batch fill for the durable sub case and remove eager page in for prefetch=0 2017-01-13 11:06:05 +00:00
Christopher L. Shannon (cshannon) d9c74d7317 https://issues.apache.org/jira/browse/AMQ-6561
Stop connections on all connection attempt errors, not just security
exceptions, to prevent dangling open sockets.
2017-01-12 10:21:08 -05:00
gtully 3a0a7238b1 [no jira] remove hard coded 1099 dep to resolve ci failure in JmxAuditLogTest 2017-01-12 11:53:20 +00:00
gtully c76f109692 https://issues.apache.org/jira/browse/AMQ-4467 - modify fix check full against shared limit and high water mark against local limit, additional test 2017-01-10 11:18:00 +00:00
gtully 0ae90c0897 https://issues.apache.org/jira/browse/AMQ-6547 - add storeUsage attribute to mKahadb filtered adapter such that disk utilisation is available as a QOS 2016-12-20 14:47:22 +00:00
Christopher L. Shannon (cshannon) 25703fbd1f https://issues.apache.org/jira/browse/AMQ-6538
Fixing an issue with syncDurableSubs that cause a bridge failure when
adding multiple bridges between the same brokers
2016-12-13 11:58:57 -05:00
Christopher L. Shannon (cshannon) 4b3f07e90e https://issues.apache.org/jira/browse/AMQ-6441
https://issues.apache.org/jira/browse/AMQ-6526

Adding missing license headers
2016-12-07 13:32:18 -05:00
gtully 8a28c06555 [AMQ-6441] add option to specify the hard limits on a usage such that spurious values from the file system can be overridden. this closes #202 thanks William Crowell for the patch with test 2016-12-07 18:09:34 +00:00
William Crowell 41bec0d658 Fixes AMQ-6441 where a negative value can be returned with large AWS EFS files systems when calling java.io.File.getTotalSpace() 2016-12-07 10:45:12 +00:00
William Crowell f225120f61 Fixes AMQ-6441 where a negative value can be returned with large AWS EFS files systems when calling java.io.File.getTotalSpace() 2016-12-07 10:45:12 +00:00
gtully dc68ad8967 [AMQ-5875] add queue test variant to validate shared mkahaDb remains when one dest is deleted 2016-12-06 14:54:24 +00:00
gtully 6a0c65828a Revert "fix up createPublisher contract to throw on null topic param, match the java doc"
the java doc allows null for an anonymous publish - the check needs to go in TopicRequestor part of the jdk

This reverts commit 29ecfd6cdb.
2016-12-02 13:57:44 +00:00
gtully 29ecfd6cdb fix up createPublisher contract to throw on null topic param, match the java doc 2016-12-02 12:46:32 +00:00
Claus Ibsen 4e766d92c5 Add example using retroactive customer with a fixedsubscriptionrecoverypolicy for JMS Topic and broker restarted. Thanks to Charles Moulliard for the patch. This fixes #94. 2016-11-29 17:38:06 +01:00
gtully cf57559f1c [no jira] unit test that exercises failover with xa and missing replys 2016-11-29 12:04:24 +00:00
gtully dad629e889 [AMQ-6522] - remove hardcoded 32k batch limit from recovery check of the journal, fix and test 2016-11-29 11:32:03 +00:00
gtully 0a29533ed7 [AMQ-6520] respect kahadb indexDirectory for perDestination mKahaDB - fix and test 2016-11-25 16:44:28 +00:00
gtully cfdff4edc5 [AMQ-6518] - fix up aveMessageSize dest stat and test 2016-11-25 10:38:09 +00:00
gtully b6bca3976c [AMQ-6517] make pre dispatch redelivery policy check optional jms.redeliveryPolicy.preDispatchCheck=false 2016-11-24 17:02:37 +00:00
gtully 99b7a28ccb [AMQ-3166] fix typo that removed class name, sorry 2016-11-22 16:27:29 +00:00
gtully 7077d2b910 [AMQ-3166] init rollbackonly exception cause such that xaexception has meaning, thanks to james (jtahlborn) for the suggestion 2016-11-22 16:07:55 +00:00
Timothy Bish e050519ff6 https://issues.apache.org/jira/browse/AMQ-6500
Better handle prefetch extension and pull consumers over Topics to avoid
the remote not receiving all the messages available based on the credit
it has issued.
2016-11-18 11:59:01 -05:00
gtully 105128a92d [no jira] use the general wildcard for the drain test 2016-11-14 11:57:49 +00:00
Christopher L. Shannon (cshannon) 7e648d512d https://issues.apache.org/jira/browse/AMQ-6505
Fixing the auto transport protocol detection so that the byte buffer
that captures the initial bytes for detection is not shared across
threads. This was causing failed connections under high load and high cpu
usage under NIO
2016-11-12 10:02:32 -05:00
gtully 9d6bc3a5d8 [no jira] add replay policy to draining broker to allow drain to origin 2016-11-11 12:01:54 +00:00
gtully 7d0df2d01e [no jira] static network wildcard drain test 2016-11-11 11:49:56 +00:00
Christopher L. Shannon (cshannon) dca066287e https://issues.apache.org/jira/browse/AMQ-6494
Ignoring test that currently fails. The parent test is already ignored
in the build so I'm adding this one to be ignored as well.  It
currently fails on exceptions that are expected and needs to be fixed.
2016-11-08 08:20:19 -05:00
Hadrian Zbarcea dce2b61f87 AMQ-6494 Return ExceptionResponse during broker service shutdown 2016-11-04 09:30:09 -04:00
Christopher L. Shannon (cshannon) 016ae05d0e https://issues.apache.org/jira/browse/AMQ-6489
Adding a new ActiveMQXASslContextFactory and jndi support for it
in ActiveMQSslInitialContextFactory
2016-11-04 08:31:19 -04:00
Hadrian Zbarcea be24a133ef This closes #88 (merged as a65ac586). More file permissions fixes. 2016-11-03 14:26:34 -04:00
Hadrian Zbarcea d5a929c0d2 This closes #205. Won't fix. (fix even more file permissions) 2016-11-03 14:11:40 -04:00
Hadrian Zbarcea f9bec8f99a This closes #201. Won't fix. (fix some file permissions though) 2016-11-03 11:48:16 -04:00
Hadrian Zbarcea a6e35a6512 Test execution artifacts produced in ./target, so that clean runs cleanly 2016-11-01 14:48:12 -04:00
Christopher L. Shannon (cshannon) 5c80eda321 https://issues.apache.org/jira/browse/AMQ-6477
Fixing potential concurrent modification exception
2016-11-01 10:31:20 -04:00
Michael L. Bloom 11541e8608 https://issues.apache.org/jira/browse/AMQ-6489
Add support for SSL configurations using JNDI.
2016-10-31 12:03:33 -04:00
Christopher L. Shannon (cshannon) 7c3bb40100 https://issues.apache.org/jira/browse/AMQ-6477
ReduceMemoryFootprint now applies to non-persistent messages if they
have been marshalled and topics now clear memory after the recovery
policy check
2016-10-25 10:19:03 -04:00
Christopher L. Shannon (cshannon) d206621a73 https://issues.apache.org/jira/browse/AMQ-6472
Durable sync over a network bridge will now also sync non-durable
subscriptions proplrly if the consumer belongs to a destination that is
configured to force network durable subscriptions.
2016-10-20 13:47:38 -04:00
Christopher L. Shannon (cshannon) 406a34294b https://issues.apache.org/jira/browse/AMQ-6465
Properly decrementing the message reference count in
DemandForwardingBridgeSupport when messages supression is checked for
durable subscriptions
2016-10-14 12:16:07 -04:00
gtully 74a5381b9a AMQ-6463 - provide connection to scheduler context in case of deferred send or error 2016-10-11 11:58:37 +01:00
gtully 8493f6b4d7 AMQ-6459 - store based % usage needs to poll the store for the current value on each access 2016-10-07 14:31:52 +01:00
gtully e91f5c8062 AMQ-6454 - ensure message.acknowledge throws if consumer has closed and message has been released broker side 2016-10-07 09:57:28 +01:00
Christopher L. Shannon (cshannon) 72650a0b8b https://issues.apache.org/jira/browse/AMQ-6449
Disabling doclint now only activates for JDK 8
2016-10-03 07:37:53 -04:00
Christopher L. Shannon (cshannon) 02082b1aec NO-JIRA: More Java 8 JavaDoc fixes - also fixed findbugs for Java 8 2016-09-30 14:36:44 -04:00
gtully 5385fd1bb3 https://issues.apache.org/jira/browse/AMQ-6446 - use shared logger and pepend statements with connection counter. Old behaviour or per connection logger can be obtained with trace=true&jmxPort=0 2016-09-30 14:05:42 +01:00
gtully 634b42016a https://issues.apache.org/jira/browse/AMQ-5486 - allow selector manager to reject tasks - org.apache.activemq.transport.nio.SelectorManager.rejectWork leaving the default to caller runs policy. This allows a broker to implement qos for existing connections by forcing others away 2016-09-28 12:15:50 +01:00
gtully 08695ab303 https://issues.apache.org/jira/browse/AMQ-6184 - add workQueueCapacity config property default to 0 where a value > 0 swaps out the dsynchQ for a capicity limited blocking queue. This allows the core pool to grow on demand as before but also allows work to be queued when necessary 2016-09-28 10:04:22 +01:00
Christopher L. Shannon (cshannon) 18571ce09b https://issues.apache.org/jira/browse/AMQ-6430
Modifying patch so that only stores that persist the noLocal flag will
check if this flag has changed to prevent a subscription from being
deleted by mistake
2016-09-23 10:59:32 -04:00
Christopher L. Shannon (cshannon) 7c293b661f https://issues.apache.org/jira/browse/AMQ-6430
When a nolocal durable consumer reconnects the new connectionId is properly captured for
the NoLocal expression so that nolocal works on reconnect.  Also fixed
the detection of the nolocal value changing on consumer connect.
2016-09-21 09:34:46 -04:00
gtully ffee8b442f https://issues.apache.org/jira/browse/AMQ-6422 - match proton sender view credit to prefetchExtension - tracking credit to dispatch delta to track additional flow requests. Proton sender layer is distinct from the transport layer - they mirror each other 2016-09-21 10:33:20 +01:00
Timothy Bish 9f812a2103 NO-JIRA: Additional test on JobSchedulerStoreImpl
Pushes on the journal log GC logic to ensure that cleanup is occurring
when the redelivery plugin is scheduling more resends on TX rollback.
2016-09-19 10:53:50 -04:00
Christopher L. Shannon (cshannon) a038655605 https://issues.apache.org/jira/browse/AMQ-6423
Fixing durable sync over a network bridge so that network subscriptions
that are no longer permissible are also cleaned up
2016-09-08 08:28:26 -04:00
Christopher L. Shannon (cshannon) 9ab94883a8 https://issues.apache.org/jira/browse/AMQ-6420
Properly copying wire format options map before applying to the
transport when using auto transports so that the options do not get
cleared and will be used for all future connections
2016-09-07 07:42:13 -04:00
Christopher L. Shannon (cshannon) 98c5866c75 https://issues.apache.org/jira/browse/AMQ-6418
Properly setting the transport properties on the
AutoNIOSSLTransportServer and fixing the Stomp protocol to set the peer
certs when using auto+ssl
2016-09-06 10:17:05 -04:00
gtully a3f1aa0bda TrapMessageInJDBCStoreTest - intermittent ci failure. Avoid contention on datasource, use long lived connection for assertions 2016-09-02 11:27:12 +01:00
gtully 508df5359c sanity check on provider url params for connection factory 2016-09-02 10:38:26 +01:00
Timothy Bish bb8d32c04a https://issues.apache.org/jira/browse/AMQ-6387
Fix up the Memory Store such that it removes the references it adds to
messages when they are placed into the memory durable topic subscription
store.
2016-09-01 16:26:03 -04:00
gtully a0d05f8ea3 AMQ-2910 fix timing on test timeout - ensure consumer connection is started 2016-09-01 16:54:50 +01:00
gtully a9c7f7122b AMQ-6411 - tidy up latch between runs. Have not seen repeat of npe yet 2016-09-01 16:53:02 +01:00
gtully f8bc19b96d AMQ-6413 - ensure audit update on skipped store add for kahadb concurrentStoreAndDispatch. Fix and test 2016-09-01 16:46:21 +01:00
Christopher L. Shannon (cshannon) ed0e786b60 https://issues.apache.org/jira/browse/AMQ-6414
Changing the nio+ssl transports to trigger a serviceRead after start up
to prevent blocking. The prevents the channels from not reading in
certain cases, most notably with the auto+nio+ssl transport when used
for a network bridge.  Also added a couple tests and changed a network
bridge test to test out auto+nio+ssl.
2016-09-01 11:39:46 -04:00
Christopher L. Shannon (cshannon) e57de54410 NO-JIRA: Fixing OpenWireConnectionTimeoutTest failure 2016-09-01 10:10:52 -04:00
gtully bf5b1fcfce address npe in intermittent failure in ci 2016-08-30 15:39:49 +01:00
Timothy Bish de4f4e406f Fix NPE case so a meaningful error is reported on failure. 2016-08-29 17:05:21 -04:00
Christopher L. Shannon (cshannon) b9fad53fc6 https://issues.apache.org/jira/browse/AMQ-6067
The JDBCMessageStore now checks hasSpace() when running a message
recovery listener to prevent going past the max configured page size
2016-08-26 13:46:42 -04:00
gtully 2b1cda1964 AMQ-6406 - ensure duplicates trapped by the cursor-add or queue-page-in are removed from the message store 2016-08-25 15:01:19 +01:00
gtully e52a052761 add some diagnostics to track intermittent ci failure 2016-08-17 15:52:54 +01:00
gtully 4800a7a1a4 AMQ-6392 - allow mapping of host names via the publish address strategy 2016-08-09 15:22:28 +01:00
gtully 9249315688 AMQ-6389 - init the size attribute prior to logging a message send in the logging plugin 2016-08-08 16:46:49 +01:00
Christopher L. Shannon (cshannon) 06a21dbbb3 [maven-release-plugin] prepare for next development iteration 2016-08-02 09:03:37 -04:00
Christopher L. Shannon (cshannon) 71cbc65283 [maven-release-plugin] prepare release activemq-5.14.0 2016-08-02 09:02:54 -04:00
Christopher L. Shannon (cshannon) eb9c584fbd https://issues.apache.org/jira/browse/AMQ-6373
More tests and cleanup
2016-08-01 12:27:34 -04:00
Christopher L. Shannon (cshannon) e73ab34837 https://issues.apache.org/jira/browse/AMQ-6383
https://issues.apache.org/jira/browse/AMQ-6373

Adding a new flag that can be specified on a network bridge to allow
forcing of subscriptions to be durable.  Cleaned up some unit tests.
2016-08-01 10:02:56 -04:00
Christopher L. Shannon (cshannon) b1c4b1871f https://issues.apache.org/jira/browse/AMQ-6373
Moving some test code into a shared support class
2016-07-30 08:35:24 -04:00
Christopher L. Shannon (cshannon) 82295fd2c6 https://issues.apache.org/jira/browse/AMQ-6381
Fixing DurableTopicSubscription so that an ack will properly update the
forwards statistic on an ack
2016-07-29 15:56:52 -04:00
Christopher L. Shannon (cshannon) dd971a00f2 https://issues.apache.org/jira/browse/AMQ-6379
Removed unreliable check from unit test
2016-07-29 12:27:58 -04:00
Christopher L. Shannon (cshannon) 7118247b65 https://issues.apache.org/jira/browse/AMQ-6379
Fixing unit test so that it uses a random port and changing the default
platform details to be "java" if there is an error
2016-07-28 13:10:44 -04:00
Michael L. Bloom 8d5e84bb67 AMQ-6379 - Add openwire properties for provider name, provider version,
and platform details
2016-07-28 12:25:13 -04:00
Christopher L. Shannon (cshannon) cf3d419528 https://issues.apache.org/jira/browse/AMQ-6375
Adding non-blocking metrics to KahaDB to track message counts and sizes
for subscriptions.  Turned off by default but can be enabled on the
KahaDBPersistenceAdapter
2016-07-26 12:02:44 -04:00
gtully 2985651609 AMQ-6370 - speed up the test and wait a bit longer for sends in slow ci 2016-07-26 14:06:02 +01:00
gtully 01cfa7727d AMQ-6361 - fix additional test regression on topic sub expiry AMQ4083Test,MessageEvictionTest 2016-07-26 13:45:41 +01:00
Christopher L. Shannon (cshannon) 3953b9aaef https://issues.apache.org/jira/browse/AMQ-6373
Adding a new OpenWire command called BrokerSubscriptionInfo in order to
help synchronize durable subs across a network bridge.  Added OpenWire
version 12.  For dynamicallyIncludedDestination durable subs will now be
synchronized on a bridge reconnect as long as the bridge supports
conduitSubscriptions and dynamicOnly=false
2016-07-25 11:56:13 -04:00
gtully ad657cc202 AMQ-6370 - ensure derby instance is created 2016-07-25 13:41:05 +01:00
gtully 6cc2c1190d AMQ-6361 - fix contention over expiry processing with expiry task and client expiry ack, unit test regression sorted. 2016-07-22 15:18:31 +01:00
gtully 2a815c2e08 AMQ-6370 - move cleanup lock to connection allocation to avoid contention with between store and connection pool. pool connection grant or block is now guarded by store lock which lasts till connection is closed 2016-07-21 10:54:40 +01:00
Christopher L. Shannon (cshannon) 39184e2fb0 https://issues.apache.org/jira/browse/AMQ-6366
Fixing the duplex bridge case for restarting durable subscriptions when
dynamicOnly is false
2016-07-19 11:31:44 -04:00
Timothy Bish f43c090809 https://issues.apache.org/jira/browse/AMQ-6362
Add option connectResponseTimeout to allow a stuck connection in
ensureConnectionInfoSent from stalling out a client.  Timeout is
disabled by default.
2016-07-18 11:30:38 -04:00
Timothy Bish a3a5a1affa https://issues.apache.org/jira/browse/AMQ-6336
Ensure that when expired messages are handled client side that pull
consumers get a chance to see it and send a new pull request complete an
outstanding timed pull.
2016-07-15 16:45:35 -04:00
Timothy Bish cd5ea6c27f https://issues.apache.org/jira/browse/AMQ-6361
Honor the expired ack from the client as the authority on expiration
2016-07-15 15:08:26 -04:00
Christopher L. Shannon (cshannon) d635a36940 https://issues.apache.org/jira/browse/AMQ-6352
Fixing PList size tracking by moving the null assignment on removal to
after the onRemoval method is called to make sure that the decrement is
done properly.
2016-07-12 10:27:57 -04:00