remove duplicate code

git-svn-id: https://svn.apache.org/repos/asf/archiva/redback/redback-core/trunk@1437806 13f79535-47bb-0310-9956-ffa450edef68

redback-rbac/redback-rbac-providers/redback-rbac-ldap/src/main/java/org/apache/archiva/redback/rbac/ldap/LdapRbacManager.java

@@ -364,16 +364,24 @@ public class LdapRbacManager
             {
                 for ( String roleName : roleNames )
                 {
-                    Role role = this.rbacImpl.getRole( roleName );
+                    Role role = buildRole( roleName );
-                    role = ( role == null ) ? new RoleImpl( roleName ) : role;
-                    if ( role != null )
-                    {
-                        rolesCache.put( role.getName(), role );
                     roles.add( role );
                 }
             }
-            }
             else if ( this.ldapRoleMapper.isUseDefaultRoleName() )
+            {
+                Role role = buildRole( group );
+                roles.add( role );
+
+
+            }
+        }
+        return roles;
+
+    }
+
+    private Role buildRole( String group )
+        throws RbacManagerException
     {
         Role role = null;
         try
@@ -388,13 +396,9 @@ public class LdapRbacManager
         if ( role != null )
         {
             rolesCache.put( role.getName(), role );
-                    roles.add( role );
-                }
 
         }
-        }
+        return role;
-        return roles;
-
     }
 
     protected List<String> getRealRoles()