From e4fca67d31cab0379461f90c5c431b9459c502e3 Mon Sep 17 00:00:00 2001 From: Olivier Lamy Date: Wed, 8 Aug 2012 22:00:29 +0000 Subject: [PATCH] StringBuilder rather than StringBuffer git-svn-id: https://svn.apache.org/repos/asf/archiva/redback/redback-core/trunk@1370988 13f79535-47bb-0310-9956-ffa450edef68 --- .../archiva/redback/authentication/AuthenticationResult.java | 2 +- .../redback/authentication/DefaultAuthenticationManager.java | 2 +- .../authentication/PasswordBasedAuthenticationDataSource.java | 2 +- .../authentication/TokenBasedAuthenticationDataSource.java | 2 +- .../archiva/redback/integration/eXc/SecurityFilterCell.java | 2 +- .../archiva/redback/integration/model/UserCredentials.java | 2 +- .../org/apache/archiva/redback/integration/util/DateUtils.java | 2 +- .../archiva/redback/struts2/action/admin/SystemInfoAction.java | 2 +- .../struts2/interceptor/EnvironmentCheckInterceptor.java | 2 +- .../archiva/redback/keys/memory/MemoryAuthenticationKey.java | 2 +- .../main/java/org/apache/archiva/redback/rbac/jdo/JdoTool.java | 2 +- .../org/apache/archiva/redback/rbac/memory/MemoryOperation.java | 2 +- .../apache/archiva/redback/rbac/memory/MemoryPermission.java | 2 +- .../org/apache/archiva/redback/rbac/memory/MemoryResource.java | 2 +- .../java/org/apache/archiva/redback/rbac/memory/MemoryRole.java | 2 +- .../archiva/redback/rbac/memory/MemoryUserAssignment.java | 2 +- .../redback/tests/AbstractRbacManagerPerformanceTestCase.java | 2 +- .../java/org/apache/archiva/redback/users/jdo/JdoUserQuery.java | 2 +- 18 files changed, 18 insertions(+), 18 deletions(-) diff --git a/redback-authentication/redback-authentication-api/src/main/java/org/apache/archiva/redback/authentication/AuthenticationResult.java b/redback-authentication/redback-authentication-api/src/main/java/org/apache/archiva/redback/authentication/AuthenticationResult.java index 2fbcc808..189eb1fd 100644 --- a/redback-authentication/redback-authentication-api/src/main/java/org/apache/archiva/redback/authentication/AuthenticationResult.java +++ b/redback-authentication/redback-authentication-api/src/main/java/org/apache/archiva/redback/authentication/AuthenticationResult.java @@ -87,7 +87,7 @@ public class AuthenticationResult public String toString() { - StringBuffer sb = new StringBuffer(); + StringBuilder sb = new StringBuilder(); sb.append( "AuthenticationResult[" ); sb.append( "principal=" ).append( principal ); sb.append( ",isAuthenticated=" ).append( Boolean.toString( isAuthenticated ) ); diff --git a/redback-authentication/redback-authentication-api/src/main/java/org/apache/archiva/redback/authentication/DefaultAuthenticationManager.java b/redback-authentication/redback-authentication-api/src/main/java/org/apache/archiva/redback/authentication/DefaultAuthenticationManager.java index 5c74df87..7806fb10 100644 --- a/redback-authentication/redback-authentication-api/src/main/java/org/apache/archiva/redback/authentication/DefaultAuthenticationManager.java +++ b/redback-authentication/redback-authentication-api/src/main/java/org/apache/archiva/redback/authentication/DefaultAuthenticationManager.java @@ -109,7 +109,7 @@ public class DefaultAuthenticationManager private String knownAuthenticators() { - StringBuffer strbuf = new StringBuffer(); + StringBuilder strbuf = new StringBuilder(); for ( Authenticator authenticator : authenticators ) { diff --git a/redback-authentication/redback-authentication-api/src/main/java/org/apache/archiva/redback/authentication/PasswordBasedAuthenticationDataSource.java b/redback-authentication/redback-authentication-api/src/main/java/org/apache/archiva/redback/authentication/PasswordBasedAuthenticationDataSource.java index c156fd37..ad3a7f48 100644 --- a/redback-authentication/redback-authentication-api/src/main/java/org/apache/archiva/redback/authentication/PasswordBasedAuthenticationDataSource.java +++ b/redback-authentication/redback-authentication-api/src/main/java/org/apache/archiva/redback/authentication/PasswordBasedAuthenticationDataSource.java @@ -73,7 +73,7 @@ public class PasswordBasedAuthenticationDataSource public String toString() { - StringBuffer sb = new StringBuffer(); + StringBuilder sb = new StringBuilder(); sb.append( "PasswordBasedAuthenticationDataSource[" ); sb.append( "principal=" ).append( principal ); sb.append( ",password=" ); diff --git a/redback-authentication/redback-authentication-api/src/main/java/org/apache/archiva/redback/authentication/TokenBasedAuthenticationDataSource.java b/redback-authentication/redback-authentication-api/src/main/java/org/apache/archiva/redback/authentication/TokenBasedAuthenticationDataSource.java index 7a8e4ef9..3fcbb1f1 100644 --- a/redback-authentication/redback-authentication-api/src/main/java/org/apache/archiva/redback/authentication/TokenBasedAuthenticationDataSource.java +++ b/redback-authentication/redback-authentication-api/src/main/java/org/apache/archiva/redback/authentication/TokenBasedAuthenticationDataSource.java @@ -72,7 +72,7 @@ public class TokenBasedAuthenticationDataSource public String toString() { - StringBuffer sb = new StringBuffer(); + StringBuilder sb = new StringBuilder(); sb.append( "TokenBasedAuthenticationDataSource[" ); sb.append( "principal=" ).append( principal ); sb.append( ",token=" ).append( token ); diff --git a/redback-integrations/redback-common-integrations/src/main/java/org/apache/archiva/redback/integration/eXc/SecurityFilterCell.java b/redback-integrations/redback-common-integrations/src/main/java/org/apache/archiva/redback/integration/eXc/SecurityFilterCell.java index f6c65c37..46e8c5dd 100644 --- a/redback-integrations/redback-common-integrations/src/main/java/org/apache/archiva/redback/integration/eXc/SecurityFilterCell.java +++ b/redback-integrations/redback-common-integrations/src/main/java/org/apache/archiva/redback/integration/eXc/SecurityFilterCell.java @@ -102,7 +102,7 @@ public class SecurityFilterCell html.value( value ); } - StringBuffer onkeypress = new StringBuffer(); + StringBuilder onkeypress = new StringBuilder(); onkeypress.append( "if (event.keyCode == 13) {" ); onkeypress.append( new TableActions( model ).getFilterAction() ); onkeypress.append( "}" ); diff --git a/redback-integrations/redback-common-integrations/src/main/java/org/apache/archiva/redback/integration/model/UserCredentials.java b/redback-integrations/redback-common-integrations/src/main/java/org/apache/archiva/redback/integration/model/UserCredentials.java index dcb4135f..1f067562 100644 --- a/redback-integrations/redback-common-integrations/src/main/java/org/apache/archiva/redback/integration/model/UserCredentials.java +++ b/redback-integrations/redback-common-integrations/src/main/java/org/apache/archiva/redback/integration/model/UserCredentials.java @@ -64,7 +64,7 @@ public abstract class UserCredentials public String toString() { - StringBuffer sb = new StringBuffer(); + StringBuilder sb = new StringBuilder(); sb.append( "UserCredentials[" ); sb.append( "username=" ).append( username ); diff --git a/redback-integrations/redback-common-integrations/src/main/java/org/apache/archiva/redback/integration/util/DateUtils.java b/redback-integrations/redback-common-integrations/src/main/java/org/apache/archiva/redback/integration/util/DateUtils.java index f59e0f1a..dd867438 100644 --- a/redback-integrations/redback-common-integrations/src/main/java/org/apache/archiva/redback/integration/util/DateUtils.java +++ b/redback-integrations/redback-common-integrations/src/main/java/org/apache/archiva/redback/integration/util/DateUtils.java @@ -60,7 +60,7 @@ public class DateUtils SimpleDateFormat format = new SimpleDateFormat( dateFormat ); - StringBuffer out = new StringBuffer(); + StringBuilder out = new StringBuilder(); out.append( format.format( date ) ); out.append( " - " ); diff --git a/redback-integrations/redback-struts2/redback-struts2-integration/src/main/java/org/apache/archiva/redback/struts2/action/admin/SystemInfoAction.java b/redback-integrations/redback-struts2/redback-struts2-integration/src/main/java/org/apache/archiva/redback/struts2/action/admin/SystemInfoAction.java index 4f67651e..fd70caf4 100644 --- a/redback-integrations/redback-struts2/redback-struts2-integration/src/main/java/org/apache/archiva/redback/struts2/action/admin/SystemInfoAction.java +++ b/redback-integrations/redback-struts2/redback-struts2-integration/src/main/java/org/apache/archiva/redback/struts2/action/admin/SystemInfoAction.java @@ -127,7 +127,7 @@ public class SystemInfoAction * The recursive object dumping switchboard. * * @param seenObjects objects already seen (to prevent cycles) - * @param sb the stringbuffer to populate + * @param sb the StringBuilder to populate * @param obj the object to dump * @param indent the current indent string. * @param depth the depth in the tree. diff --git a/redback-integrations/redback-struts2/redback-struts2-integration/src/main/java/org/apache/archiva/redback/struts2/interceptor/EnvironmentCheckInterceptor.java b/redback-integrations/redback-struts2/redback-struts2-integration/src/main/java/org/apache/archiva/redback/struts2/interceptor/EnvironmentCheckInterceptor.java index 28905f2d..24f13a30 100644 --- a/redback-integrations/redback-struts2/redback-struts2-integration/src/main/java/org/apache/archiva/redback/struts2/interceptor/EnvironmentCheckInterceptor.java +++ b/redback-integrations/redback-struts2/redback-struts2-integration/src/main/java/org/apache/archiva/redback/struts2/interceptor/EnvironmentCheckInterceptor.java @@ -80,7 +80,7 @@ public class EnvironmentCheckInterceptor if ( !violations.isEmpty() ) { - StringBuffer msg = new StringBuffer(); + StringBuilder msg = new StringBuilder(); msg.append( "EnvironmentCheck Failure.\n" ); msg.append( "======================================================================\n" ); msg.append( " ENVIRONMENT FAILURE !! \n" ); diff --git a/redback-keys/redback-keys-providers/redback-keys-memory/src/main/java/org/apache/archiva/redback/keys/memory/MemoryAuthenticationKey.java b/redback-keys/redback-keys-providers/redback-keys-memory/src/main/java/org/apache/archiva/redback/keys/memory/MemoryAuthenticationKey.java index a464e8ca..de3d7140 100644 --- a/redback-keys/redback-keys-providers/redback-keys-memory/src/main/java/org/apache/archiva/redback/keys/memory/MemoryAuthenticationKey.java +++ b/redback-keys/redback-keys-providers/redback-keys-memory/src/main/java/org/apache/archiva/redback/keys/memory/MemoryAuthenticationKey.java @@ -94,7 +94,7 @@ public class MemoryAuthenticationKey public String toString() { - StringBuffer sb = new StringBuffer(); + StringBuilder sb = new StringBuilder(); sb.append( "MemoryAuthenticationKey[" ); sb.append( "key=" ).append( key ); diff --git a/redback-rbac/redback-rbac-providers/redback-rbac-jdo/src/main/java/org/apache/archiva/redback/rbac/jdo/JdoTool.java b/redback-rbac/redback-rbac-providers/redback-rbac-jdo/src/main/java/org/apache/archiva/redback/rbac/jdo/JdoTool.java index 48677aa7..6dcb9bc3 100644 --- a/redback-rbac/redback-rbac-providers/redback-rbac-jdo/src/main/java/org/apache/archiva/redback/rbac/jdo/JdoTool.java +++ b/redback-rbac/redback-rbac-providers/redback-rbac-jdo/src/main/java/org/apache/archiva/redback/rbac/jdo/JdoTool.java @@ -259,7 +259,7 @@ public class JdoTool query.declareImports( "import java.lang.String" ); - StringBuffer filter = new StringBuffer(); + StringBuilder filter = new StringBuilder(); if ( roleNames.size() > 0 ) { diff --git a/redback-rbac/redback-rbac-providers/redback-rbac-memory/src/main/java/org/apache/archiva/redback/rbac/memory/MemoryOperation.java b/redback-rbac/redback-rbac-providers/redback-rbac-memory/src/main/java/org/apache/archiva/redback/rbac/memory/MemoryOperation.java index 698cdf07..9bbac02b 100644 --- a/redback-rbac/redback-rbac-providers/redback-rbac-memory/src/main/java/org/apache/archiva/redback/rbac/memory/MemoryOperation.java +++ b/redback-rbac/redback-rbac-providers/redback-rbac-memory/src/main/java/org/apache/archiva/redback/rbac/memory/MemoryOperation.java @@ -149,7 +149,7 @@ public class MemoryOperation */ public String toString() { - StringBuffer buf = new StringBuffer(); + StringBuilder buf = new StringBuilder(); buf.append( "name = '" ); buf.append( getName() + "'" ); return buf.toString(); diff --git a/redback-rbac/redback-rbac-providers/redback-rbac-memory/src/main/java/org/apache/archiva/redback/rbac/memory/MemoryPermission.java b/redback-rbac/redback-rbac-providers/redback-rbac-memory/src/main/java/org/apache/archiva/redback/rbac/memory/MemoryPermission.java index 5c120bb7..f39e2439 100644 --- a/redback-rbac/redback-rbac-providers/redback-rbac-memory/src/main/java/org/apache/archiva/redback/rbac/memory/MemoryPermission.java +++ b/redback-rbac/redback-rbac-providers/redback-rbac-memory/src/main/java/org/apache/archiva/redback/rbac/memory/MemoryPermission.java @@ -178,7 +178,7 @@ public class MemoryPermission */ public String toString() { - StringBuffer buf = new StringBuffer(); + StringBuilder buf = new StringBuilder(); buf.append( "name = '" ); buf.append( getName() + "'" ); return buf.toString(); diff --git a/redback-rbac/redback-rbac-providers/redback-rbac-memory/src/main/java/org/apache/archiva/redback/rbac/memory/MemoryResource.java b/redback-rbac/redback-rbac-providers/redback-rbac-memory/src/main/java/org/apache/archiva/redback/rbac/memory/MemoryResource.java index 8baf8df9..1e3bb224 100644 --- a/redback-rbac/redback-rbac-providers/redback-rbac-memory/src/main/java/org/apache/archiva/redback/rbac/memory/MemoryResource.java +++ b/redback-rbac/redback-rbac-providers/redback-rbac-memory/src/main/java/org/apache/archiva/redback/rbac/memory/MemoryResource.java @@ -132,7 +132,7 @@ public class MemoryResource */ public String toString() { - StringBuffer buf = new StringBuffer(); + StringBuilder buf = new StringBuilder(); buf.append( "identifier = '" ).append( getIdentifier() + "'" ); return buf.toString(); } diff --git a/redback-rbac/redback-rbac-providers/redback-rbac-memory/src/main/java/org/apache/archiva/redback/rbac/memory/MemoryRole.java b/redback-rbac/redback-rbac-providers/redback-rbac-memory/src/main/java/org/apache/archiva/redback/rbac/memory/MemoryRole.java index 9a42433c..c78bfd1d 100644 --- a/redback-rbac/redback-rbac-providers/redback-rbac-memory/src/main/java/org/apache/archiva/redback/rbac/memory/MemoryRole.java +++ b/redback-rbac/redback-rbac-providers/redback-rbac-memory/src/main/java/org/apache/archiva/redback/rbac/memory/MemoryRole.java @@ -219,7 +219,7 @@ public class MemoryRole */ public java.lang.String toString() { - StringBuffer buf = new StringBuffer(); + StringBuilder buf = new StringBuilder(); buf.append( "name = '" ); buf.append( getName() + "'" ); return buf.toString(); diff --git a/redback-rbac/redback-rbac-providers/redback-rbac-memory/src/main/java/org/apache/archiva/redback/rbac/memory/MemoryUserAssignment.java b/redback-rbac/redback-rbac-providers/redback-rbac-memory/src/main/java/org/apache/archiva/redback/rbac/memory/MemoryUserAssignment.java index 403a6e07..49e01d27 100644 --- a/redback-rbac/redback-rbac-providers/redback-rbac-memory/src/main/java/org/apache/archiva/redback/rbac/memory/MemoryUserAssignment.java +++ b/redback-rbac/redback-rbac-providers/redback-rbac-memory/src/main/java/org/apache/archiva/redback/rbac/memory/MemoryUserAssignment.java @@ -132,7 +132,7 @@ public class MemoryUserAssignment */ public java.lang.String toString() { - StringBuffer buf = new StringBuffer(); + StringBuilder buf = new StringBuilder(); buf.append( "principal = '" ); buf.append( getPrincipal() + "'" ); return buf.toString(); diff --git a/redback-rbac/redback-rbac-tests/src/main/java/org/apache/archiva/redback/tests/AbstractRbacManagerPerformanceTestCase.java b/redback-rbac/redback-rbac-tests/src/main/java/org/apache/archiva/redback/tests/AbstractRbacManagerPerformanceTestCase.java index b442b3cf..212f2f6e 100644 --- a/redback-rbac/redback-rbac-tests/src/main/java/org/apache/archiva/redback/tests/AbstractRbacManagerPerformanceTestCase.java +++ b/redback-rbac/redback-rbac-tests/src/main/java/org/apache/archiva/redback/tests/AbstractRbacManagerPerformanceTestCase.java @@ -98,7 +98,7 @@ public class AbstractRbacManagerPerformanceTestCase { // Failure - StringBuffer stats = new StringBuffer(); + StringBuilder stats = new StringBuilder(); stats.append( "Stats on " ).append( msg ); stats.append( "\nStart Time (ms): " ).append( Long.toString( startTime ) ); diff --git a/redback-users/redback-users-providers/redback-users-jdo/src/main/java/org/apache/archiva/redback/users/jdo/JdoUserQuery.java b/redback-users/redback-users-providers/redback-users-jdo/src/main/java/org/apache/archiva/redback/users/jdo/JdoUserQuery.java index 5cb873c0..2a06caac 100644 --- a/redback-users/redback-users-providers/redback-users-jdo/src/main/java/org/apache/archiva/redback/users/jdo/JdoUserQuery.java +++ b/redback-users/redback-users-providers/redback-users-jdo/src/main/java/org/apache/archiva/redback/users/jdo/JdoUserQuery.java @@ -40,7 +40,7 @@ public class JdoUserQuery */ public String getOrdering() { - StringBuffer ordering = new StringBuffer(); + StringBuilder ordering = new StringBuilder(); if ( UserQuery.ORDER_BY_EMAIL.equals( getOrderBy() ) ) {