Apache
/
archiva
mirror of https://github.com/apache/archiva.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[MRM-144] clean up TODOs 

git-svn-id: https://svn.apache.org/repos/asf/maven/archiva/trunk@574898 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Brett Porter 2007-09-12 11:57:08 +00:00
parent 037c5872e2
commit 14658271d1
2 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
archiva-base/archiva-proxy/src/test/java/org/apache/maven/archiva/proxy/ManagedDefaultTransferTest.java
View File

@ -338,7 +338,7 @@ public class ManagedDefaultTransferTest
wagonMockControl.verify(); wagonMockControl.verify();
assertNoTempFiles( expectedFile ); assertNoTempFiles( expectedFile );
// TODO: do not want failures to present as a not found! // TODO: do not want failures to present as a not found [MRM-492]
// TODO: How much information on each failure should we pass back to the user vs. logging in the proxy? // TODO: How much information on each failure should we pass back to the user vs. logging in the proxy?
} }

5
archiva-web/archiva-webapp/src/main/java/org/apache/maven/archiva/web/action/admin/repositories/ConfigureRepositoryAction.java
View File

@ -234,7 +234,10 @@ public class ConfigureRepositoryAction
if ( !file.exists() ) if ( !file.exists() )
{ {
file.mkdirs(); file.mkdirs();
// TODO: error handling when this fails, or is not a directory! }
if ( !file.exists() || !file.isDirectory() )
{
throw new IOException( "unable to add repository - can not create the root directory: " + file );
} }
configuration.addManagedRepository( repository ); configuration.addManagedRepository( repository );