Apache/archiva
1
0
Fork 0
mirror of https://github.com/apache/archiva.git synced 2025-02-24 03:25:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

correctly close jarFile in a finally block

Browse Source 
git-svn-id: https://svn.apache.org/repos/asf/archiva/trunk@1358773 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Olivier Lamy 2012-07-08 16:16:01 +00:00
parent a044b089c9
commit 35c58406a8
1 changed files with 16 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
archiva-modules/archiva-web/archiva-rest/archiva-rest-services/src/main/java/org/apache/archiva/rest/services/DefaultBrowseService.java
View File

@ -752,6 +752,7 @@ public ArtifactContent getArtifactContentText( String groupId, String artifactId
} }
finally finally
{ {
closeQuietly( jarFile );
IOUtils.closeQuietly( inputStream ); IOUtils.closeQuietly( inputStream );
} }
} }
@ -782,6 +783,21 @@ public ArtifactContent getArtifactContentText( String groupId, String artifactId
return new ArtifactContent(); return new ArtifactContent();
} }
private void closeQuietly( JarFile jarFile )
{
if ( jarFile != null )
{
try
{
jarFile.close();
}
catch ( IOException e )
{
log.warn( "ignore error closing jarFile {}", jarFile.getName() );
}
}
}
//--------------------------- //---------------------------
// internals // internals
//--------------------------- //---------------------------