From 955aec2db3ee20ade7c8faeea7a99a402cd5ad56 Mon Sep 17 00:00:00 2001 From: Brett Porter Date: Sat, 22 Jul 2006 15:15:37 +0000 Subject: [PATCH] notes git-svn-id: https://svn.apache.org/repos/asf/maven/repository-manager/trunk@424594 13f79535-47bb-0310-9956-ffa450edef68 --- .../repository/scheduler/DefaultRepositoryTaskScheduler.java | 1 + .../repository/manager/web/action/admin/ConfigureAction.java | 4 ++++ 2 files changed, 5 insertions(+) diff --git a/maven-repository-core/src/main/java/org/apache/maven/repository/scheduler/DefaultRepositoryTaskScheduler.java b/maven-repository-core/src/main/java/org/apache/maven/repository/scheduler/DefaultRepositoryTaskScheduler.java index 2f0bf6647..be7a66e0f 100644 --- a/maven-repository-core/src/main/java/org/apache/maven/repository/scheduler/DefaultRepositoryTaskScheduler.java +++ b/maven-repository-core/src/main/java/org/apache/maven/repository/scheduler/DefaultRepositoryTaskScheduler.java @@ -109,6 +109,7 @@ public class DefaultRepositoryTaskScheduler new CronTrigger( INDEXER_JOB + "Trigger", DISCOVERER_GROUP, configuration.getIndexerCronExpression() ); scheduler.scheduleJob( jobDetail, trigger ); + // TODO: run as a job so it doesn't block startup/configuration saving try { indexerTask.executeNowIfNeeded(); diff --git a/maven-repository-webapp/src/main/java/org/apache/maven/repository/manager/web/action/admin/ConfigureAction.java b/maven-repository-webapp/src/main/java/org/apache/maven/repository/manager/web/action/admin/ConfigureAction.java index 2e8955957..2c4fd299e 100644 --- a/maven-repository-webapp/src/main/java/org/apache/maven/repository/manager/web/action/admin/ConfigureAction.java +++ b/maven-repository-webapp/src/main/java/org/apache/maven/repository/manager/web/action/admin/ConfigureAction.java @@ -68,6 +68,8 @@ public class ConfigureAction // TODO: these defaults belong in the model. They shouldn't be stored here, as you want them to re-default // should the repository change even if these didn't + // TODO: if these are changed, do we move the index or recreate it? + // TODO: these should be on an advanced configuration form, not the standard one if ( StringUtils.isEmpty( configuration.getIndexPath() ) ) { @@ -85,6 +87,8 @@ public class ConfigureAction configurationStore.storeConfiguration( configuration ); + // TODO: if the repository has changed, we need to check if indexing is needed + addActionMessage( "Successfully saved configuration" ); return SUCCESS;