Apache
/
archiva
mirror of https://github.com/apache/archiva.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

review/comment/delete some FIXME 

git-svn-id: https://svn.apache.org/repos/asf/archiva/trunk@1424533 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Olivier Lamy 2012-12-20 15:34:51 +00:00
parent 6d3d28eb21
commit 9682660dbc
6 changed files with 6 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
archiva-modules/archiva-base/archiva-consumers/archiva-core-consumers/src/main/java/org/apache/archiva/consumers/core/repository/AbstractRepositoryPurge.java
View File

@ -81,7 +81,6 @@ public abstract class AbstractRepositoryPurge
{
File artifactFile = repository.toFile( reference );
// FIXME: looks incomplete, might not delete related metadata?
for ( RepositoryListener listener : listeners )
{
listener.deleteArtifact( metadataRepository, repository.getId(), reference.getGroupId(),

4
archiva-modules/archiva-base/archiva-repository-admin/archiva-repository-admin-default/src/main/java/org/apache/archiva/admin/repository/proxyconnector/DefaultProxyConnectorAdmin.java
View File

@ -114,7 +114,7 @@ public class DefaultProxyConnectorAdmin
}
// FIXME take of proxyConnectorRules !
// FIXME take care of proxyConnectorRules !
public Boolean deleteProxyConnector( ProxyConnector proxyConnector, AuditInformation auditInformation )
throws RepositoryAdminException
{
@ -134,7 +134,7 @@ public class DefaultProxyConnectorAdmin
return Boolean.TRUE;
}
// FIXME take of proxyConnectorRules !
// FIXME care take of proxyConnectorRules !
public Boolean updateProxyConnector( ProxyConnector proxyConnector, AuditInformation auditInformation )
throws RepositoryAdminException
{

1
archiva-modules/archiva-web/archiva-rest/archiva-rest-services/src/main/java/org/apache/archiva/rest/services/DefaultBrowseService.java
View File

@ -1022,7 +1022,6 @@ public class DefaultBrowseService
if ( CollectionUtils.isEmpty( selectedRepos ) )
{
// FIXME 403 ???
return Collections.emptyList();
}

4
archiva-modules/archiva-web/archiva-rest/archiva-rest-services/src/main/java/org/apache/archiva/rest/services/DefaultRepositoriesService.java
View File

@ -400,8 +400,6 @@ public class DefaultRepositoriesService
String filename = artifactPath.substring( lastIndex + 1 );
// FIXME some dupe with uploadaction
boolean fixChecksums =
!( archivaAdministration.getKnownContentConsumers().contains( "create-missing-checksums" ) );
@ -471,8 +469,6 @@ public class DefaultRepositoriesService
return true;
}
//FIXME some duplicate with UploadAction
private void queueRepositoryTask( String repositoryId, File localFile )
{
RepositoryTask task = new RepositoryTask();

5
archiva-modules/archiva-web/archiva-rest/archiva-rest-services/src/main/java/org/apache/archiva/rest/services/DefaultSystemStatusService.java
View File

@ -188,7 +188,10 @@ public class DefaultSystemStatusService
private List<ConsumerScanningStatistics> mapConsumerScanningStatistics( RepositoryScannerInstance instance )
{
DecimalFormat decimalFormat = new DecimalFormat( "###.##" );
// FIXME take care of NPE here !!!
if ( instance.getConsumerCounts() == null )
{
return Collections.emptyList();
}
List<ConsumerScanningStatistics> ret =
new ArrayList<ConsumerScanningStatistics>( instance.getConsumerCounts().size() );
for ( Map.Entry<String, Long> entry : instance.getConsumerCounts().entrySet() )

1
archiva-modules/plugins/maven2-repository/src/main/java/org/apache/archiva/metadata/repository/storage/maven2/Maven2RepositoryStorage.java
View File

@ -96,7 +96,6 @@ import java.util.Map;
* Maven 2 repository format storage implementation. This class currently takes parameters to indicate the repository to
* deal with rather than being instantiated per-repository.
* FIXME: instantiate one per repository and allocate permanently from a factory (which can be obtained within the session).
* TODO: finish Maven 1 implementation to prove this API
* <p/>
* The session is passed in as an argument to obtain any necessary resources, rather than the class being instantiated
* within the session in the context of a single managed repository's resolution needs.