Apache/archiva
1
0
Fork 0
mirror of https://github.com/apache/archiva.git synced 2025-02-22 10:17:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

clarify some TODO elements

Browse Source 
git-svn-id: https://svn.apache.org/repos/asf/maven/archiva/trunk@441803 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Brett Porter 2006-09-09 15:51:32 +00:00
parent 1a3026414e
commit 9dd5b3e988
5 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
archiva-core/src/main/java/org/apache/maven/archiva/scheduler/DefaultRepositoryTaskScheduler.java
View File

@ -97,7 +97,7 @@ public void start()
private void scheduleJobs( Configuration configuration ) private void scheduleJobs( Configuration configuration )
throws ParseException, SchedulerException throws ParseException, SchedulerException
{ {
// TODO! would be nice to queue jobs that are triggered so we could avoid two running at the same time (so have a queue for discovery based jobs so they didn't thrash the repo) // TODO: would be nice to queue jobs that are triggered so we could avoid two running at the same time (so have a queue for discovery based jobs so they didn't thrash the repo)
if ( configuration.getIndexPath() != null ) if ( configuration.getIndexPath() != null )
{ {
JobDetail jobDetail = createJobDetail( INDEXER_JOB, indexerTask ); JobDetail jobDetail = createJobDetail( INDEXER_JOB, indexerTask );
@ -107,7 +107,7 @@ private void scheduleJobs( Configuration configuration )
new CronTrigger( INDEXER_JOB + "Trigger", DISCOVERER_GROUP, configuration.getIndexerCronExpression() ); new CronTrigger( INDEXER_JOB + "Trigger", DISCOVERER_GROUP, configuration.getIndexerCronExpression() );
scheduler.scheduleJob( jobDetail, trigger ); scheduler.scheduleJob( jobDetail, trigger );
// TODO: run as a job so it doesn't block startup/configuration saving! // TODO: run as a job so it doesn't block startup/configuration saving
try try
{ {
indexerTask.executeNowIfNeeded(); indexerTask.executeNowIfNeeded();

2
archiva-reports-standard/src/main/java/org/apache/maven/archiva/reporting/BadMetadataReportProcessor.java
View File

@ -264,7 +264,7 @@ private void checkRepositoryVersions( RepositoryMetadata metadata, ArtifactRepos
File versionsDir = File versionsDir =
new File( repository.getBasedir(), repository.pathOfRemoteRepositoryMetadata( metadata ) ).getParentFile(); new File( repository.getBasedir(), repository.pathOfRemoteRepositoryMetadata( metadata ) ).getParentFile();
// TODO! I don't know how this condition can happen, but it was seen on the main repository. // TODO: I don't know how this condition can happen, but it was seen on the main repository.
// Avoid hard failure // Avoid hard failure
if ( versionsDir.exists() ) if ( versionsDir.exists() )
{ {

2
archiva-webapp/src/main/java/org/apache/maven/archiva/web/action/ProxyAction.java
View File

@ -58,7 +58,7 @@ public String execute()
artifactStream = new FileInputStream( file ); artifactStream = new FileInputStream( file );
// TODO: could be better! // TODO: set the correct content type and other headers!
contentType = "application/octet-stream"; contentType = "application/octet-stream";
filename = file.getName(); filename = file.getName();

2
archiva-webapp/src/main/java/org/apache/maven/archiva/web/action/admin/DeleteSyncedRepositoryAction.java
View File

@ -43,6 +43,6 @@ protected void removeRepository( Configuration configuration, AbstractRepository
protected void removeContents( AbstractRepositoryConfiguration existingRepository ) protected void removeContents( AbstractRepositoryConfiguration existingRepository )
throws IOException throws IOException
{ {
// TODO! // TODO! remove the contents
} }
} }

2
archiva-webapp/src/main/webapp/WEB-INF/jsp/showArtifact.jsp
View File

@ -74,7 +74,7 @@
<ww:url action="proxy"> <ww:url action="proxy">
<%-- TODO! create a tag for this, include classifier for javadoc, sources below --%> <%-- TODO! create a tag for this, include classifier for javadoc, sources below --%>
<%-- TODO: what about other repositories? --%> <%-- TODO: what about other repositories? --%>
<%-- TODO! extension probably doesn't match type --%> <%-- TODO! extension probably doesn't match type. Use artifact handler instead. --%>
<ww:param name="path" <ww:param name="path"
value="%{'${model.groupId}/${model.artifactId}/${model.version}/${model.artifactId}-${model.version}.${model.packaging}'}"/> value="%{'${model.groupId}/${model.artifactId}/${model.version}/${model.artifactId}-${model.version}.${model.packaging}'}"/>
</ww:url> </ww:url>