diff --git a/maven-repository-artifact-applet/src/main/java/org/apache/maven/repository/applet/ChecksumApplet.java b/maven-repository-artifact-applet/src/main/java/org/apache/maven/repository/applet/ChecksumApplet.java index 635d8edfa..da9369350 100644 --- a/maven-repository-artifact-applet/src/main/java/org/apache/maven/repository/applet/ChecksumApplet.java +++ b/maven-repository-artifact-applet/src/main/java/org/apache/maven/repository/applet/ChecksumApplet.java @@ -29,7 +29,7 @@ import java.security.NoSuchAlgorithmException; import java.security.PrivilegedAction; /** - * TODO: Description. + * Applet that takes a file on the local filesystem and checksums it for sending to the server. * * @author Brett Porter */ diff --git a/maven-repository-discovery/src/main/java/org/apache/maven/repository/discovery/AbstractDiscoverer.java b/maven-repository-discovery/src/main/java/org/apache/maven/repository/discovery/AbstractDiscoverer.java index d2efc3a58..65db8a50d 100644 --- a/maven-repository-discovery/src/main/java/org/apache/maven/repository/discovery/AbstractDiscoverer.java +++ b/maven-repository-discovery/src/main/java/org/apache/maven/repository/discovery/AbstractDiscoverer.java @@ -28,7 +28,7 @@ import java.util.Iterator; import java.util.List; /** - * TODO [!]: Description. + * Base class for the artifact and metadata discoverers. * * @author Brett Porter */ diff --git a/maven-repository-discovery/src/main/java/org/apache/maven/repository/discovery/ArtifactDiscoverer.java b/maven-repository-discovery/src/main/java/org/apache/maven/repository/discovery/ArtifactDiscoverer.java index dc1d3c9b8..52b011b77 100644 --- a/maven-repository-discovery/src/main/java/org/apache/maven/repository/discovery/ArtifactDiscoverer.java +++ b/maven-repository-discovery/src/main/java/org/apache/maven/repository/discovery/ArtifactDiscoverer.java @@ -39,7 +39,6 @@ public interface ArtifactDiscoverer * @param blacklistedPatterns pattern that lists any files to prevent from being included when scanning * @param includeSnapshots whether to discover snapshots * @return the list of artifacts discovered - * @todo replace repositoryBase with wagon repository * @todo do we want blacklisted patterns in another form? Part of the object construction? * @todo should includeSnapshots be configuration on the component? * @todo instead of a returned list, should a listener be passed in? @@ -53,7 +52,6 @@ public interface ArtifactDiscoverer * @param blacklistedPatterns pattern that lists any files to prevent from being included when scanning * @param includeSnapshots whether to discover snapshots * @return the list of artifacts discovered - * @todo replace repositoryBase with wagon repository * @todo do we want blacklisted patterns in another form? Part of the object construction? * @todo should includeSnapshots be configuration on the component? * @todo instead of a returned list, should a listener be passed in? diff --git a/maven-repository-discovery/src/main/java/org/apache/maven/repository/discovery/DefaultMetadataDiscoverer.java b/maven-repository-discovery/src/main/java/org/apache/maven/repository/discovery/DefaultMetadataDiscoverer.java index 20f9d3d87..f68e799be 100644 --- a/maven-repository-discovery/src/main/java/org/apache/maven/repository/discovery/DefaultMetadataDiscoverer.java +++ b/maven-repository-discovery/src/main/java/org/apache/maven/repository/discovery/DefaultMetadataDiscoverer.java @@ -179,19 +179,19 @@ public class DefaultMetadataDiscoverer } catch ( FileNotFoundException fe ) { - // TODO: log ignored metadata + // TODO: log ignored metadata! } catch ( XmlPullParserException xe ) { - // TODO: log ignored metadata + // TODO: log ignored metadata! } catch ( MalformedURLException e ) { - // TODO: log ignored metadata + // TODO: log ignored metadata! } catch ( IOException ie ) { - // TODO: log ignored metadata + // TODO: log ignored metadata! } return metadata; diff --git a/maven-repository-proxy/src/main/java/org/apache/maven/repository/proxy/DefaultProxyManager.java b/maven-repository-proxy/src/main/java/org/apache/maven/repository/proxy/DefaultProxyManager.java index 0eaf52a66..08812b4de 100644 --- a/maven-repository-proxy/src/main/java/org/apache/maven/repository/proxy/DefaultProxyManager.java +++ b/maven-repository-proxy/src/main/java/org/apache/maven/repository/proxy/DefaultProxyManager.java @@ -52,7 +52,7 @@ import java.util.Map; * @author Edwin Punzalan * @plexus.component role="org.apache.maven.repository.proxy.ProxyManager" * @todo too much of wagon manager is reproduced here because checksums need to be downloaded separately - is that necessary? - * @todo this isn't reusing the parts of wagon manager than handle snapshots + * @todo this isn't reusing the parts of wagon manager than handle snapshots [!] */ public class DefaultProxyManager extends AbstractLogEnabled @@ -297,13 +297,13 @@ public class DefaultProxyManager private ArtifactRepositoryPolicy getReleasesPolicy() { - //todo get policy configuration from ProxyConfiguration + //todo get policy configuration from ProxyConfiguration [!] return new ArtifactRepositoryPolicy(); } private ArtifactRepositoryPolicy getSnapshotsPolicy() { - //todo get policy configuration from ProxyConfiguration + //todo get policy configuration from ProxyConfiguration [!] return new ArtifactRepositoryPolicy(); } @@ -392,7 +392,7 @@ public class DefaultProxyManager { wagon = wagonManager.getWagon( repository.getProtocol() ); - //@todo configure wagonManager + //@todo configure wagonManager [!] if ( useChecksum ) { diff --git a/maven-repository-proxy/src/main/java/org/apache/maven/repository/proxy/ProxyManager.java b/maven-repository-proxy/src/main/java/org/apache/maven/repository/proxy/ProxyManager.java index aec5ec068..b03bde0ba 100644 --- a/maven-repository-proxy/src/main/java/org/apache/maven/repository/proxy/ProxyManager.java +++ b/maven-repository-proxy/src/main/java/org/apache/maven/repository/proxy/ProxyManager.java @@ -25,7 +25,7 @@ import java.io.File; * Class used to bridge the servlet to the repository proxy implementation. * * @author Edwin Punzalan - * @todo the names get() and getRemoteFile() are confusing + * @todo the names get() and getRemoteFile() are confusing [!] */ public interface ProxyManager { diff --git a/maven-repository-proxy/src/main/java/org/apache/maven/repository/proxy/configuration/ProxyConfiguration.java b/maven-repository-proxy/src/main/java/org/apache/maven/repository/proxy/configuration/ProxyConfiguration.java index d873c0af2..b46acd1e0 100644 --- a/maven-repository-proxy/src/main/java/org/apache/maven/repository/proxy/configuration/ProxyConfiguration.java +++ b/maven-repository-proxy/src/main/java/org/apache/maven/repository/proxy/configuration/ProxyConfiguration.java @@ -29,7 +29,7 @@ import java.util.List; * * @author Edwin Punzalan * @plexus.component role="org.apache.maven.repository.proxy.configuration.ProxyConfiguration" - * @todo investigate how these should be set - probably plexus configuration + * @todo investigate how these should be set - probably plexus configuration [!] */ public class ProxyConfiguration { diff --git a/maven-repository-reports-standard/src/main/java/org/apache/maven/repository/reporting/CachedRepositoryQueryLayer.java b/maven-repository-reports-standard/src/main/java/org/apache/maven/repository/reporting/CachedRepositoryQueryLayer.java index f4bf85ff6..b0c1eac27 100644 --- a/maven-repository-reports-standard/src/main/java/org/apache/maven/repository/reporting/CachedRepositoryQueryLayer.java +++ b/maven-repository-reports-standard/src/main/java/org/apache/maven/repository/reporting/CachedRepositoryQueryLayer.java @@ -30,8 +30,7 @@ public class CachedRepositoryQueryLayer { private Cache cache; - private static final double CACHE_HIT_RATIO = 0.5; - + public static final double CACHE_HIT_RATIO = 0.5; public CachedRepositoryQueryLayer( ArtifactRepository repository ) { diff --git a/maven-repository-reports-standard/src/test/java/org/apache/maven/repository/reporting/CachedRepositoryQueryLayerTest.java b/maven-repository-reports-standard/src/test/java/org/apache/maven/repository/reporting/CachedRepositoryQueryLayerTest.java index 6c8e535cb..11c0b8e95 100644 --- a/maven-repository-reports-standard/src/test/java/org/apache/maven/repository/reporting/CachedRepositoryQueryLayerTest.java +++ b/maven-repository-reports-standard/src/test/java/org/apache/maven/repository/reporting/CachedRepositoryQueryLayerTest.java @@ -22,8 +22,6 @@ package org.apache.maven.repository.reporting; public class CachedRepositoryQueryLayerTest extends AbstractRepositoryQueryLayerTestCase { - // TODO: share - private static final double CACHE_HIT_RATIO = 0.5; protected void setUp() throws Exception @@ -38,7 +36,7 @@ public class CachedRepositoryQueryLayerTest testContainsArtifactTrue(); assertEquals( 0, queryLayer.getCacheHitRate(), 0 ); testContainsArtifactTrue(); - assertEquals( CACHE_HIT_RATIO, queryLayer.getCacheHitRate(), 0 ); + assertEquals( CachedRepositoryQueryLayer.CACHE_HIT_RATIO, queryLayer.getCacheHitRate(), 0 ); } public void testUseMetadataCache() @@ -47,7 +45,7 @@ public class CachedRepositoryQueryLayerTest testArtifactVersionsTrue(); assertEquals( 0, queryLayer.getCacheHitRate(), 0 ); testArtifactVersionsTrue(); - assertEquals( CACHE_HIT_RATIO, queryLayer.getCacheHitRate(), 0 ); + assertEquals( CachedRepositoryQueryLayer.CACHE_HIT_RATIO, queryLayer.getCacheHitRate(), 0 ); } public void testUseFileCacheOnSnapshot() @@ -55,6 +53,6 @@ public class CachedRepositoryQueryLayerTest testContainsSnapshotArtifactTrue(); assertEquals( 0, queryLayer.getCacheHitRate(), 0 ); testContainsSnapshotArtifactTrue(); - assertEquals( CACHE_HIT_RATIO, queryLayer.getCacheHitRate(), 0 ); + assertEquals( CachedRepositoryQueryLayer.CACHE_HIT_RATIO, queryLayer.getCacheHitRate(), 0 ); } } diff --git a/maven-repository-webapp/src/main/java/org/apache/maven/repository/manager/web/action/PackageSearchAction.java b/maven-repository-webapp/src/main/java/org/apache/maven/repository/manager/web/action/PackageSearchAction.java index 409dcc179..b13a48416 100644 --- a/maven-repository-webapp/src/main/java/org/apache/maven/repository/manager/web/action/PackageSearchAction.java +++ b/maven-repository-webapp/src/main/java/org/apache/maven/repository/manager/web/action/PackageSearchAction.java @@ -33,7 +33,7 @@ import java.net.MalformedURLException; import java.util.List; /** - * TODO: Description. + * Search by package name. * * @author Brett Porter * @plexus.component role="com.opensymphony.xwork.Action" role-hint="org.apache.maven.repository.manager.web.action.PackageSearchAction" @@ -82,7 +82,7 @@ public class PackageSearchAction return ERROR; } - // TODO: better config + // TODO: better config [!] String indexPath = configuration.getIndexDirectory(); // TODO: reduce the amount of lookup? diff --git a/maven-repository-webapp/src/main/java/org/apache/maven/repository/manager/web/action/RepositoryBrowseAction.java b/maven-repository-webapp/src/main/java/org/apache/maven/repository/manager/web/action/RepositoryBrowseAction.java index 870fe06fd..764adae5b 100644 --- a/maven-repository-webapp/src/main/java/org/apache/maven/repository/manager/web/action/RepositoryBrowseAction.java +++ b/maven-repository-webapp/src/main/java/org/apache/maven/repository/manager/web/action/RepositoryBrowseAction.java @@ -31,7 +31,7 @@ import java.util.Map; import java.util.TreeMap; /** - * TODO: Description. + * Browse the repository. * * @plexus.component role="com.opensymphony.xwork.Action" role-hint="org.apache.maven.repository.manager.web.action.RepositoryBrowseAction" */ diff --git a/maven-repository-webapp/src/main/java/org/apache/maven/repository/manager/web/execution/DiscovererExecution.java b/maven-repository-webapp/src/main/java/org/apache/maven/repository/manager/web/execution/DiscovererExecution.java index dcff2a798..975808b96 100644 --- a/maven-repository-webapp/src/main/java/org/apache/maven/repository/manager/web/execution/DiscovererExecution.java +++ b/maven-repository-webapp/src/main/java/org/apache/maven/repository/manager/web/execution/DiscovererExecution.java @@ -156,7 +156,7 @@ public class DiscovererExecution * * @throws MalformedURLException * @throws RepositoryIndexException - * @todo why is this any different from legacy? + * @todo why is this any different from legacy? [!] */ protected void executeDiscovererInDefaultRepo() throws MalformedURLException, RepositoryIndexException