Apache
/
archiva
mirror of https://github.com/apache/archiva.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[MRM-1632] Invalid Cron in a job means webapp will not start 

If syntax is invalid, log a warning instead of throwing the exception, and the
job will not be scheduled.


git-svn-id: https://svn.apache.org/repos/asf/archiva/trunk@1348883 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Brett Porter 2012-06-11 14:56:26 +00:00
parent 6f50378e6e
commit ced2e45916
1 changed files with 11 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
archiva-modules/archiva-scheduler/archiva-scheduler-indexing/src/main/java/org/apache/archiva/scheduler/indexing/DefaultDownloadRemoteIndexScheduler.java
View File

@ -190,9 +190,17 @@ public class DefaultDownloadRemoteIndexScheduler
{ {
log.info( "schedule download remote index for repository {} with cron expression {}", log.info( "schedule download remote index for repository {} with cron expression {}",
remoteRepository.getId(), remoteRepository.getCronExpression() ); remoteRepository.getId(), remoteRepository.getCronExpression() );
taskScheduler.schedule( try
new DownloadRemoteIndexTask( downloadRemoteIndexTaskRequest, this.runningRemoteDownloadIds ), {
new CronTrigger( remoteRepository.getCronExpression() ) ); CronTrigger cronTrigger = new CronTrigger( remoteRepository.getCronExpression() );
taskScheduler.schedule(
new DownloadRemoteIndexTask( downloadRemoteIndexTaskRequest, this.runningRemoteDownloadIds ),
cronTrigger );
}
catch ( IllegalArgumentException e )
{
log.warn( "Unable to schedule remote index download: " + e.getLocalizedMessage() );
}
if ( remoteRepository.isDownloadRemoteIndexOnStartup() ) if ( remoteRepository.isDownloadRemoteIndexOnStartup() )
{ {