diff --git a/archiva-modules/archiva-web/archiva-webapp-test/src/test/testng/org/apache/archiva/web/test/VirtualRepositoryTest.java b/archiva-modules/archiva-web/archiva-webapp-test/src/test/testng/org/apache/archiva/web/test/VirtualRepositoryTest.java index a17f0b005..9df08da44 100644 --- a/archiva-modules/archiva-web/archiva-webapp-test/src/test/testng/org/apache/archiva/web/test/VirtualRepositoryTest.java +++ b/archiva-modules/archiva-web/archiva-webapp-test/src/test/testng/org/apache/archiva/web/test/VirtualRepositoryTest.java @@ -27,18 +27,17 @@ import org.testng.Assert; public class VirtualRepositoryTest extends AbstractRepositoryTest { - // FIXME: says repositoryGroup id cannot be empty - @Test( enabled = false ) + @Test public void testAddRepositoryGroupNullValue() { - addRepositoryGroup( " " ); + addRepositoryGroup( " ", false ); assertTextPresent( "Identifier field is required." ); } @Test( dependsOnMethods = { "testWithCorrectUsernamePassword" } ) public void testAddRepositoryGroupValidValue() { - addRepositoryGroup( "testing" ); + addRepositoryGroup( "testing", true ); Assert.assertEquals( getSelenium().getText( "//div[@id='contentArea']/div[2]/div/div[1]/p[1]" ), "testing" ); } diff --git a/archiva-modules/archiva-web/archiva-webapp-test/src/test/testng/org/apache/archiva/web/test/parent/AbstractRepositoryTest.java b/archiva-modules/archiva-web/archiva-webapp-test/src/test/testng/org/apache/archiva/web/test/parent/AbstractRepositoryTest.java index 28451198f..a1214acfb 100644 --- a/archiva-modules/archiva-web/archiva-webapp-test/src/test/testng/org/apache/archiva/web/test/parent/AbstractRepositoryTest.java +++ b/archiva-modules/archiva-web/archiva-webapp-test/src/test/testng/org/apache/archiva/web/test/parent/AbstractRepositoryTest.java @@ -73,11 +73,11 @@ public abstract class AbstractRepositoryTest assertButtonWithValuePresent( "Cancel" ); } - public void addRepositoryGroup( String repoGroupName ) + public void addRepositoryGroup( String repoGroupName, boolean wait ) { goToRepositoryGroupsPage(); setFieldValue( "repositoryGroup.id", repoGroupName ); - clickButtonWithValue( "Add Group" ); + clickButtonWithValue( "Add Group", wait ); } public void addRepositoryToRepositoryGroup( String repositoryGroupName, String repositoryName ) diff --git a/archiva-modules/archiva-web/archiva-webapp/src/main/java/org/apache/archiva/web/action/admin/repositories/RepositoryGroupsAction.java b/archiva-modules/archiva-web/archiva-webapp/src/main/java/org/apache/archiva/web/action/admin/repositories/RepositoryGroupsAction.java index 7c5d9f86e..5d12e100b 100644 --- a/archiva-modules/archiva-web/archiva-webapp/src/main/java/org/apache/archiva/web/action/admin/repositories/RepositoryGroupsAction.java +++ b/archiva-modules/archiva-web/archiva-webapp/src/main/java/org/apache/archiva/web/action/admin/repositories/RepositoryGroupsAction.java @@ -65,8 +65,6 @@ public class RepositoryGroupsAction */ private String baseUrl; - private static final Pattern REPO_GROUP_ID_PATTERN = Pattern.compile( "[A-Za-z0-9\\._\\-]+" ); - public void setServletRequest( HttpServletRequest request ) { this.baseUrl = ContextUtils.getBaseURL( request, "repository" ); diff --git a/archiva-modules/archiva-web/archiva-webapp/src/main/resources/org/apache/archiva/web/action/admin/repositories/RepositoryGroupsAction-addRepositoryGroup-validation.xml b/archiva-modules/archiva-web/archiva-webapp/src/main/resources/org/apache/archiva/web/action/admin/repositories/RepositoryGroupsAction-addRepositoryGroup-validation.xml new file mode 100644 index 000000000..ba5c4a94e --- /dev/null +++ b/archiva-modules/archiva-web/archiva-webapp/src/main/resources/org/apache/archiva/web/action/admin/repositories/RepositoryGroupsAction-addRepositoryGroup-validation.xml @@ -0,0 +1,35 @@ + + + + + + + + + Identifier field is required. + + + true + ^[a-zA-Z0-9._-]+$ + Identifier must only contain alphanumeric characters, underscores(_), dots(.), and dashes(-). + + + diff --git a/archiva-modules/archiva-web/archiva-webapp/src/main/webapp/WEB-INF/jsp/admin/repositoryGroups.jsp b/archiva-modules/archiva-web/archiva-webapp/src/main/webapp/WEB-INF/jsp/admin/repositoryGroups.jsp index ec7c8c2dd..13bafd384 100644 --- a/archiva-modules/archiva-web/archiva-webapp/src/main/webapp/WEB-INF/jsp/admin/repositoryGroups.jsp +++ b/archiva-modules/archiva-web/archiva-webapp/src/main/webapp/WEB-INF/jsp/admin/repositoryGroups.jsp @@ -47,11 +47,10 @@
- - Identifier*: - + + - +