Apache
/
archiva
mirror of https://github.com/apache/archiva.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[MRM-118] clean up comments after some investigation 

git-svn-id: https://svn.apache.org/repos/asf/maven/repository-manager/trunk@412651 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Brett Porter 2006-06-08 04:35:49 +00:00
parent eba7bf274a
commit f3a4d92ba5
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
maven-repository-indexer/src/main/java/org/apache/maven/repository/indexing/AbstractRepositoryIndex.java
View File

@ -35,21 +35,21 @@ import java.util.zip.ZipEntry;
* Abstract class for RepositoryIndexers. * Abstract class for RepositoryIndexers.
* *
* @author Edwin Punzalan * @author Edwin Punzalan
* @todo [BP] overall am not happy with the design of this class and subclasses, but will refactor over time based on how it is used and by assessing how this affects Lucene's performance
*/ */
public abstract class AbstractRepositoryIndex public abstract class AbstractRepositoryIndex
implements RepositoryIndex implements RepositoryIndex
{ {
// TODO [!] can this be derived from the repository? // TODO: can this be derived from the repository? -- probably a sensible default, but still should be configurable, but this could just be on the call to open()
private String indexPath; private String indexPath;
private boolean indexOpen; private boolean indexOpen;
// TODO [!] why is the writer open for the life, but not the reader? why keep them open that length of time anyway? investigate best practices in Lucene // TODO: why is the writer open for the life, but not the reader? why keep them open that length of time anyway? investigate best practices in Lucene
private IndexWriter indexWriter; private IndexWriter indexWriter;
protected ArtifactRepository repository; protected ArtifactRepository repository;
// TODO [!] is this really needed externally?
private Analyzer analyzer; private Analyzer analyzer;
/** /**
@ -158,7 +158,7 @@ public abstract class AbstractRepositoryIndex
protected IndexWriter getIndexWriter() protected IndexWriter getIndexWriter()
throws IOException throws IOException
{ {
// TODO [!] why is this allowed to be called before open()? // TODO: why is this allowed to be called before open()?
if ( indexWriter == null ) if ( indexWriter == null )
{ {
indexWriter = new IndexWriter( indexPath, getAnalyzer(), false ); indexWriter = new IndexWriter( indexPath, getAnalyzer(), false );