From 01413dc53b15f966e6f497520f93fb1c5c077664 Mon Sep 17 00:00:00 2001 From: Arturo Bernal Date: Sat, 9 Oct 2021 07:48:01 +0200 Subject: [PATCH] Remove unnecessary Casting --- pom.xml | 3 +++ .../java/org/apache/commons/collections4/ComparatorUtils.java | 2 +- .../apache/commons/collections4/functors/SwitchClosure.java | 2 +- .../commons/collections4/functors/SwitchTransformer.java | 4 ++-- 4 files changed, 7 insertions(+), 4 deletions(-) diff --git a/pom.xml b/pom.xml index ad4348e82..83e41461a 100644 --- a/pom.xml +++ b/pom.xml @@ -458,6 +458,9 @@ Stefano Cordio + + Arturo Bernal + diff --git a/src/main/java/org/apache/commons/collections4/ComparatorUtils.java b/src/main/java/org/apache/commons/collections4/ComparatorUtils.java index 639bb4169..c4416e8d4 100644 --- a/src/main/java/org/apache/commons/collections4/ComparatorUtils.java +++ b/src/main/java/org/apache/commons/collections4/ComparatorUtils.java @@ -100,7 +100,7 @@ public class ComparatorUtils { @SuppressWarnings("unchecked") public static Comparator chainedComparator(final Collection> comparators) { return chainedComparator( - (Comparator[]) comparators.toArray(EMPTY_COMPARATOR_ARRAY) + comparators.toArray(EMPTY_COMPARATOR_ARRAY) ); } diff --git a/src/main/java/org/apache/commons/collections4/functors/SwitchClosure.java b/src/main/java/org/apache/commons/collections4/functors/SwitchClosure.java index 918851312..f800c38ba 100644 --- a/src/main/java/org/apache/commons/collections4/functors/SwitchClosure.java +++ b/src/main/java/org/apache/commons/collections4/functors/SwitchClosure.java @@ -119,7 +119,7 @@ public class SwitchClosure implements Closure, Serializable { final Closure[] closures, final Closure defaultClosure) { iPredicates = clone ? FunctorUtils.copy(predicates) : predicates; iClosures = clone ? FunctorUtils.copy(closures) : closures; - iDefault = (Closure) (defaultClosure == null ? NOPClosure.nopClosure() : defaultClosure); + iDefault = defaultClosure == null ? NOPClosure.nopClosure() : defaultClosure; } /** diff --git a/src/main/java/org/apache/commons/collections4/functors/SwitchTransformer.java b/src/main/java/org/apache/commons/collections4/functors/SwitchTransformer.java index 31dd04784..916b094c9 100644 --- a/src/main/java/org/apache/commons/collections4/functors/SwitchTransformer.java +++ b/src/main/java/org/apache/commons/collections4/functors/SwitchTransformer.java @@ -130,8 +130,8 @@ public class SwitchTransformer implements Transformer, Serializable final Transformer defaultTransformer) { iPredicates = clone ? FunctorUtils.copy(predicates) : predicates; iTransformers = clone ? FunctorUtils.copy(transformers) : transformers; - iDefault = (Transformer) (defaultTransformer == null ? - ConstantTransformer.nullTransformer() : defaultTransformer); + iDefault = defaultTransformer == null ? + ConstantTransformer.nullTransformer() : defaultTransformer; } /**