Apache
/
commons-collections
mirror of https://github.com/apache/commons-collections.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Raise embedded if into parent if.

This commit is contained in:
Gary Gregory 2021-02-28 12:19:37 -05:00
parent 4a845dc8bc
commit 11eb27dfb0
3 changed files with 12 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/main/java/org/apache/commons/collections4/sequence/SequencesComparator.java
View File

@ -203,10 +203,8 @@ public class SequencesComparator<T> {
++y; ++y;
} }
// Second step // Second step
if (delta % 2 != 0 && delta - d <= k && k <= delta + d) { if ((delta % 2 != 0 && delta - d <= k && k <= delta + d) && (vUp[i-delta] <= vDown[i])) { // NOPMD
if (vUp[i-delta] <= vDown[i]) { // NOPMD return buildSnake(vUp[i-delta], k + start1 - start2, end1, end2);
return buildSnake(vUp[i-delta], k + start1 - start2, end1, end2);
}
} }
} }
@ -229,10 +227,8 @@ public class SequencesComparator<T> {
y--; y--;
} }
// Second step // Second step
if (delta % 2 == 0 && -d <= k && k <= d ) { if ((delta % 2 == 0 && -d <= k && k <= d) && (vUp[i] <= vDown[i + delta])) { // NOPMD
if (vUp[i] <= vDown[i + delta]) { // NOPMD return buildSnake(vUp[i], k + start1 - start2, end1, end2);
return buildSnake(vUp[i], k + start1 - start2, end1, end2);
}
} }
} }
} }

12
src/main/java/org/apache/commons/collections4/trie/AbstractPatriciaTrie.java
View File

@ -172,14 +172,10 @@ abstract class AbstractPatriciaTrie<K, V> extends AbstractBitwiseTrie<K, V> {
} }
return root.setKeyValue(key, value); return root.setKeyValue(key, value);
} else if (KeyAnalyzer.isEqualBitKey(bitIndex)) { } else /* REPLACE OLD KEY+VALUE */
// This is a very special and rare case. if (KeyAnalyzer.isEqualBitKey(bitIndex) && found != root) { // NOPMD
incrementModCount();
/* REPLACE OLD KEY+VALUE */ return found.setKeyValue(key, value);
if (found != root) { // NOPMD
incrementModCount();
return found.setKeyValue(key, value);
}
} }
} }

12
src/test/java/org/apache/commons/collections4/FactoryUtilsTest.java
View File

@ -164,10 +164,8 @@ public class FactoryUtilsTest {
} }
@Override @Override
public boolean equals(final Object obj) { public boolean equals(final Object obj) {
if (obj instanceof Mock1) { if (obj instanceof Mock1 && (iVal == ((Mock1) obj).iVal)) {
if (iVal == ((Mock1) obj).iVal) { return true;
return true;
}
} }
return false; return false;
} }
@ -188,10 +186,8 @@ public class FactoryUtilsTest {
} }
@Override @Override
public boolean equals(final Object obj) { public boolean equals(final Object obj) {
if (obj instanceof Mock2) { if (obj instanceof Mock2 && (iVal == ((Mock2) obj).iVal)) {
if (iVal == ((Mock2) obj).iVal) { return true;
return true;
}
} }
return false; return false;
} }