Apache
/
commons-collections
mirror of https://github.com/apache/commons-collections.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[COLLECTIONS-407] improve performance of remove method by taking method result from underlying collection into account. Thanks to Adrian Nistor for reporting and providing a patch. 

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1351800 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Thomas Neidhart 2012-06-19 18:59:46 +00:00
parent c531834764
commit 19de811caf
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/main/java/org/apache/commons/collections/set/ListOrderedSet.java
View File

@ -42,7 +42,7 @@ import org.apache.commons.collections.list.UnmodifiableList;
* the set can be obtained via <code>asList()</code>.
* <p>
* This class cannot implement the <code>List</code> interface directly as
* various interface methods (notably equals/hashCode) are incompatable with a set.
* various interface methods (notably equals/hashCode) are incompatible with a set.
* <p>
* This class is Serializable from Commons Collections 3.1.
*
@ -200,7 +200,9 @@ public class ListOrderedSet<E> extends AbstractSerializableSetDecorator<E> imple
@Override
public boolean remove(Object object) {
boolean result = collection.remove(object);
setOrder.remove(object);
if (result) {
setOrder.remove(object);
}
return result;
}