Apache
/
commons-collections
mirror of https://github.com/apache/commons-collections.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[COLLECTIONS-455] Remove todos: keep decorated object protected. 

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1493902 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Thomas Neidhart 2013-06-17 19:40:34 +00:00
parent f9930aa9f3
commit 20619b096c
3 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/main/java/org/apache/commons/collections4/collection/AbstractCollectionDecorator.java
View File

@ -45,8 +45,6 @@ public abstract class AbstractCollectionDecorator<E>
/** Serialization version */ /** Serialization version */
private static final long serialVersionUID = 6249888059822088500L; private static final long serialVersionUID = 6249888059822088500L;
// TODO privatise field? read-only access - could use decorated() - apart from deserialisation
/** The collection being decorated */ /** The collection being decorated */
protected Collection<E> collection; protected Collection<E> collection;

2
src/main/java/org/apache/commons/collections4/map/AbstractMapDecorator.java
View File

@ -41,7 +41,7 @@ import java.util.Set;
public abstract class AbstractMapDecorator<K, V> extends AbstractIterableMap<K, V> { public abstract class AbstractMapDecorator<K, V> extends AbstractIterableMap<K, V> {
/** The map to decorate */ /** The map to decorate */
protected transient Map<K, V> map; // TODO Privatise? Only write access is for deserialisation protected transient Map<K, V> map;
/** /**
* Constructor only used in deserialization, do not use otherwise. * Constructor only used in deserialization, do not use otherwise.

2
src/main/java/org/apache/commons/collections4/splitmap/AbstractIterableGetMapDecorator.java
View File

@ -34,7 +34,7 @@ import org.apache.commons.collections4.map.EntrySetToMapIteratorAdapter;
public class AbstractIterableGetMapDecorator<K, V> implements IterableGet<K, V> { public class AbstractIterableGetMapDecorator<K, V> implements IterableGet<K, V> {
/** The map to decorate */ /** The map to decorate */
protected transient Map<K, V> map; // TODO Privatise? only external access is for deserialisation protected transient Map<K, V> map;
/** /**
* Create a new AbstractSplitMapDecorator. * Create a new AbstractSplitMapDecorator.