Fix boxing and some raw types warninga

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1023862 13f79535-47bb-0310-9956-ffa450edef68

src/test/org/apache/commons/collections/TestMapUtils.java

@@ -49,6 +49,7 @@ import org.apache.commons.collections.collection.TestTransformedCollection;
  * @author Janek Bogucki
  * @author Neil O'Toole
  */
+@SuppressWarnings("boxing")
 public class TestMapUtils extends BulkTest {
 
     public TestMapUtils(String name) {
@@ -744,7 +745,7 @@ public class TestMapUtils extends BulkTest {
 
     public void testPopulateMap() {
         // Setup Test Data
-        List list = new ArrayList();
+        List<String> list = new ArrayList<String>();
         list.add("1");
         list.add("3");
         list.add("5");
@@ -754,27 +755,27 @@ public class TestMapUtils extends BulkTest {
         list.add("6");
 
         // Now test key transform population
-        Map map = new HashMap();
+        Map<Object, Object> map = new HashMap<Object, Object>();
         MapUtils.populateMap(map, list, TestTransformedCollection.STRING_TO_INTEGER_TRANSFORMER);
         assertEquals(list.size(), map.size());
 
         for (int i = 0; i < list.size(); i++) {
-            assertEquals(true, map.containsKey(new Integer((String) list.get(i))));
+            assertEquals(true, map.containsKey(new Integer(list.get(i))));
             assertEquals(false, map.containsKey(list.get(i)));
             assertEquals(true, map.containsValue(list.get(i)));
-            assertEquals(list.get(i), map.get(new Integer((String) list.get(i))));
+            assertEquals(list.get(i), map.get(new Integer(list.get(i))));
         }
 
         // Now test both Key-Value transform population
-        map = new HashMap();
+        map = new HashMap<Object, Object>();
         MapUtils.populateMap(map, list, TestTransformedCollection.STRING_TO_INTEGER_TRANSFORMER, TestTransformedCollection.STRING_TO_INTEGER_TRANSFORMER);
 
         assertEquals(list.size(), map.size());
         for (int i = 0; i < list.size(); i++) {
-            assertEquals(true, map.containsKey(new Integer((String) list.get(i))));
+            assertEquals(true, map.containsKey(new Integer(list.get(i))));
             assertEquals(false, map.containsKey(list.get(i)));
-            assertEquals(true, map.containsValue(new Integer((String) list.get(i))));
-            assertEquals(new Integer((String) list.get(i)), map.get(new Integer((String) list.get(i))));
+            assertEquals(true, map.containsValue(new Integer(list.get(i))));
+            assertEquals(new Integer(list.get(i)), map.get(new Integer(list.get(i))));
         }
     }
 

src/test/org/apache/commons/collections/TestPredicateUtils.java

@@ -49,6 +49,7 @@ import org.junit.Test;
  * @author Stephen Colebourne
  * @author Matt Benson
  */
+@SuppressWarnings("boxing")
 public class TestPredicateUtils extends BasicPredicateTestBase {
     /**
      * Set up instance variables required by this test case.

src/test/org/apache/commons/collections/buffer/TestPriorityBuffer.java

@@ -39,6 +39,7 @@ import org.apache.commons.collections.comparators.ReverseComparator;
  * @author Michael A. Smith
  * @author Steve Phelps
  */
+@SuppressWarnings("boxing")
 public class TestPriorityBuffer<E> extends AbstractTestCollection<E> {
 
     public TestPriorityBuffer(String testName) {

src/test/org/apache/commons/collections/comparators/TestBooleanComparator.java

@@ -27,6 +27,7 @@ import java.util.List;
  *
  * @author Rodney Waldhoff
  */
+@SuppressWarnings("boxing")
 public class TestBooleanComparator extends AbstractTestComparator<Boolean> {
 
     // conventional

src/test/org/apache/commons/collections/comparators/TestComparableComparator.java

@@ -25,8 +25,8 @@ import java.util.List;
  *
  * @version $Revision$ $Date$
  *
- * @author Unknown
  */
+@SuppressWarnings("boxing")
 public class TestComparableComparator extends AbstractTestComparator<Integer> {
 
     public TestComparableComparator(String testName) {

src/test/org/apache/commons/collections/functors/AbstractTestAnyAllOnePredicate.java

@@ -73,6 +73,7 @@ public abstract class AbstractTestAnyAllOnePredicate<T> extends AbstractTestComp
      * Tests creating composite predicate instances with single predicates and verifies that the composite returns
      * the same value as the single predicate does. 
      */
+    @SuppressWarnings("boxing")
     public final void singleValues() {
         assertTrue(getPredicateInstance(true).evaluate(null));
         assertFalse(getPredicateInstance(false).evaluate(null));

src/test/org/apache/commons/collections/functors/MockPredicateTestBase.java

@@ -91,7 +91,7 @@ public abstract class MockPredicateTestBase<T> {
      *
      * @return a single mock predicate.
      */
-    @SuppressWarnings({"unchecked"})
+    @SuppressWarnings({"unchecked", "boxing"})
     protected final Predicate<T> createMockPredicate(final Boolean returnValue) {
         final Predicate<T> mockPredicate = EasyMock.createMock(Predicate.class);
         if (returnValue != null) {

src/test/org/apache/commons/collections/functors/TestAllPredicate.java

@@ -18,6 +18,7 @@ import java.util.Collections;
  *
  * @author Edwin Tellman
  */
+@SuppressWarnings("boxing")
 public class TestAllPredicate extends AbstractTestAnyAllOnePredicate<Integer> {
 
     /**

src/test/org/apache/commons/collections/functors/TestEqualPredicate.java

@@ -45,6 +45,7 @@ public class TestEqualPredicate extends BasicPredicateTestBase {
         assertTrue(equalPredicate(TRUE_OBJECT), TRUE_OBJECT);
     }
     
+    @SuppressWarnings("boxing")
     @Test
     public void testPredicateTypeCanBeSuperClassOfObject() throws Exception {
         Predicate<Number> predicate = equalPredicate((Number) 4);

src/test/org/apache/commons/collections/iterators/TestCollatingIterator.java

@@ -27,6 +27,7 @@ import org.apache.commons.collections.comparators.ComparableComparator;
  * @version $Revision$ $Date$
  * @author Rodney Waldhoff
  */
+@SuppressWarnings("boxing")
 public class TestCollatingIterator extends AbstractTestIterator<Integer> {
 
     //------------------------------------------------------------ Conventional

src/test/org/apache/commons/collections/iterators/TestFilterListIterator.java

@@ -31,6 +31,7 @@ import org.apache.commons.collections.Predicate;
  *
  * @author Rodney Waldhoff
  */
+@SuppressWarnings("boxing")
 public class TestFilterListIterator extends TestCase {
     public TestFilterListIterator(String testName) {
         super(testName);

src/test/org/apache/commons/collections/map/TestLazyMap.java

@@ -35,6 +35,7 @@ import org.junit.Test;
  *
  * @author Phil Steitz
  */
+@SuppressWarnings("boxing")
 public class TestLazyMap<K, V> extends AbstractTestIterableMap<K, V> {
 
     private static final Factory<Integer> oneFactory = FactoryUtils.constantFactory(1);

src/test/org/apache/commons/collections/map/TestLazySortedMap.java

@@ -38,6 +38,7 @@ import org.junit.Test;
  *
  * @author Phil Steitz
  */
+@SuppressWarnings("boxing")
 public class TestLazySortedMap<K, V> extends AbstractTestSortedMap<K, V> {
     
     private static final Factory<Integer> oneFactory = FactoryUtils.constantFactory(1);