Add final to some ivars.

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1734634 13f79535-47bb-0310-9956-ffa450edef68

src/main/java/org/apache/commons/collections4/ListUtils.java

@@ -580,7 +580,7 @@ public class ListUtils {
      * A helper class used to construct the longest common subsequence.
      */
     private static final class LcsVisitor<E> implements CommandVisitor<E> {
-        private ArrayList<E> sequence;
+        private final ArrayList<E> sequence;
 
         public LcsVisitor() {
             sequence = new ArrayList<E>();

src/main/java/org/apache/commons/collections4/iterators/PermutationIterator.java

@@ -46,12 +46,12 @@ public class PermutationIterator<E> implements Iterator<List<E>> {
     /**
      * Permutation is done on theses keys to handle equal objects.
      */
-    private int[] keys;
+    private final int[] keys;
 
     /**
      * Mapping between keys and objects.
      */
-    private Map<Integer, E> objectMap;
+    private final Map<Integer, E> objectMap;
 
     /**
      * Direction table used in the algorithm:
@@ -60,7 +60,7 @@ public class PermutationIterator<E> implements Iterator<List<E>> {
      *   <li>true is right</li>
      * </ul>
      */
-    private boolean[] direction;
+    private final boolean[] direction;
 
     /**
      * Next permutation to return. When a permutation is requested

src/main/java/org/apache/commons/collections4/iterators/PushbackIterator.java

@@ -39,7 +39,7 @@ public class PushbackIterator<E> implements Iterator<E> {
     private final Iterator<? extends E> iterator;
 
     /** The LIFO queue containing the pushed back items. */
-    private Deque<E> items = new ArrayDeque<E>();
+    private final Deque<E> items = new ArrayDeque<E>();
 
     //-----------------------------------------------------------------------
     /**

src/test/java/org/apache/commons/collections4/iterators/BoundedIteratorTest.java

@@ -30,7 +30,7 @@ import org.junit.Test;
 public class BoundedIteratorTest<E> extends AbstractIteratorTest<E> {
 
     /** Test array of size 7 */
-    private String[] testArray = {
+    private final String[] testArray = {
         "a", "b", "c", "d", "e", "f", "g"
     };
 

src/test/java/org/apache/commons/collections4/iterators/PeekingIteratorTest.java

@@ -34,7 +34,7 @@ import org.junit.Test;
  */
 public class PeekingIteratorTest<E> extends AbstractIteratorTest<E> {
 
-    private String[] testArray = { "a", "b", "c" };
+    private final String[] testArray = { "a", "b", "c" };
 
     private List<E> testList;
     

src/test/java/org/apache/commons/collections4/iterators/PushbackIteratorTest.java

@@ -32,7 +32,7 @@ import org.junit.Test;
  */
 public class PushbackIteratorTest<E> extends AbstractIteratorTest<E> {
 
-    private String[] testArray = { "a", "b", "c" };
+    private final String[] testArray = { "a", "b", "c" };
 
     private List<E> testList;
 

src/test/java/org/apache/commons/collections4/iterators/SkippingIteratorTest.java

@@ -30,7 +30,7 @@ import org.junit.Test;
 public class SkippingIteratorTest<E> extends AbstractIteratorTest<E> {
 
     /** Test array of size 7 */
-    private String[] testArray = {
+    private final String[] testArray = {
         "a", "b", "c", "d", "e", "f", "g"
     };