Apache
/
commons-collections
mirror of https://github.com/apache/commons-collections.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix TODO by documenting the possible exceptions, similar to e.g. java.util.ArrayList. 

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1449929 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Thomas Neidhart 2013-02-25 22:18:22 +00:00
parent bb9952dbed
commit 8106e48334
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/main/java/org/apache/commons/collections/bag/AbstractMapBag.java
View File

@ -453,11 +453,14 @@ public abstract class AbstractMapBag<E> implements Bag<E> {
* @param <T> the type of the array elements * @param <T> the type of the array elements
* @param array the array to populate * @param array the array to populate
* @return an array of all of this bag's elements * @return an array of all of this bag's elements
* @throws ArrayStoreException if the runtime type of the specified array is not
* a supertype of the runtime type of the elements in this list
* @throws NullPointerException if the specified array is null
*/ */
@SuppressWarnings("unchecked")
public <T> T[] toArray(T[] array) { public <T> T[] toArray(T[] array) {
final int size = size(); final int size = size();
if (array.length < size) { if (array.length < size) {
// This is safe, both are type T
array = (T[]) Array.newInstance(array.getClass().getComponentType(), size); array = (T[]) Array.newInstance(array.getClass().getComponentType(), size);
} }
@ -466,7 +469,6 @@ public abstract class AbstractMapBag<E> implements Bag<E> {
while (it.hasNext()) { while (it.hasNext()) {
final E current = it.next(); final E current = it.next();
for (int index = getCount(current); index > 0; index--) { for (int index = getCount(current); index > 0; index--) {
// TODO this is unsafe
array[i++] = (T) current; array[i++] = (T) current;
} }
} }