Apache
/
commons-collections
mirror of https://github.com/apache/commons-collections.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #143 from dota17/fixtypoForBloomfilter 

Fix typos for the Bloom filter components
This commit is contained in:
Alex Herbert 2020-03-25 12:34:56 +00:00 committed by GitHub
parent fbc3c06d78 092959ddcb
commit a02a0e6993
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/main/java/org/apache/commons/collections4/bloomfilter/BitSetBloomFilter.java
View File

@ -32,7 +32,7 @@ import org.apache.commons.collections4.bloomfilter.hasher.StaticHasher;
public class BitSetBloomFilter extends AbstractBloomFilter { public class BitSetBloomFilter extends AbstractBloomFilter {
/** /**
* The bitset that defines this BloomFilter. * The bitSet that defines this BloomFilter.
*/ */
private final BitSet bitSet; private final BitSet bitSet;

4
src/test/java/org/apache/commons/collections4/bloomfilter/AbstractBloomFilterTest.java
View File

@ -446,7 +446,7 @@ public abstract class AbstractBloomFilterTest {
* Tests that merging bloom filters works as expected with a generic BloomFilter. * Tests that merging bloom filters works as expected with a generic BloomFilter.
*/ */
@Test @Test
public final void mergeTest_GenenicBloomFilter() { public final void mergeTest_GenericBloomFilter() {
mergeTest_BloomFilter(this::createGenericFilter); mergeTest_BloomFilter(this::createGenericFilter);
} }
@ -598,7 +598,7 @@ public abstract class AbstractBloomFilterTest {
* Tests that the xorCardinality calculations are correct with a generic BloomFilter. * Tests that the xorCardinality calculations are correct with a generic BloomFilter.
*/ */
@Test @Test
public final void xorCardinalityTest_GenenicBloomFilter() { public final void xorCardinalityTest_GenericBloomFilter() {
xorCardinalityTest(this::createGenericFilter); xorCardinalityTest(this::createGenericFilter);
} }

6
src/test/java/org/apache/commons/collections4/bloomfilter/hasher/ShapeTest.java
View File

@ -88,7 +88,7 @@ public class ShapeTest {
} }
/** /**
* Tests that if the number of hash functions is less than 1 an exception is thrown. * Tests that if the number of hash functions is less than 1 an IllegalArgumentException is thrown.
*/ */
@Test @Test
public void constructor_items_bits_BadNumberOfHashFunctionsTest() { public void constructor_items_bits_BadNumberOfHashFunctionsTest() {
@ -212,7 +212,7 @@ public class ShapeTest {
} }
/** /**
* Tests that if the probability is less than or equal to 0 an IllegalArgumentException is thrown. * Tests that if the probability is less than or equal to 0 or more than or equal to 1 an IllegalArgumentException is thrown.
*/ */
@Test @Test
public void constructor_items_probability_BadProbabilityTest() { public void constructor_items_probability_BadProbabilityTest() {
@ -392,7 +392,7 @@ public class ShapeTest {
@Test @Test
public void constructor_probability_bits_hashTest() { public void constructor_probability_bits_hashTest() {
/* /*
* values from https://hur.st/bloomfilter/?n=5&p=.1&m=&k= * values from https://hur.st/bloomfilter/?n=5&p=.1&m=24&k=3
*/ */
final Shape filterConfig = new Shape(testFunction, 0.1, 24, 3); final Shape filterConfig = new Shape(testFunction, 0.1, 24, 3);