Apache
/
commons-collections
mirror of https://github.com/apache/commons-collections.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Use try-with-resources to fix a random failure seen on Java 12.

This commit is contained in:
Gary Gregory 2020-04-26 09:57:57 -04:00
parent bd8e77d607
commit a53127e3a5
1 changed files with 18 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
src/test/java/org/apache/commons/collections4/properties/EmptyPropertiesTest.java
View File

@ -247,18 +247,26 @@ public class EmptyPropertiesTest {
}
@Test
public void testSave() {
public void testSave() throws IOException {
final String comments = "Hello world!";
// actual
final ByteArrayOutputStream actual = new ByteArrayOutputStream();
PropertiesFactory.EMPTY_PROPERTIES.save(new PrintStream(actual), comments);
// expected
final ByteArrayOutputStream expected = new ByteArrayOutputStream();
PropertiesFactory.INSTANCE.createProperties().save(new PrintStream(expected), comments);
Assert.assertArrayEquals(expected.toByteArray(), actual.toByteArray());
expected.reset();
new Properties().save(new PrintStream(expected), comments);
Assert.assertArrayEquals(expected.toByteArray(), actual.toByteArray());
try (final ByteArrayOutputStream actual = new ByteArrayOutputStream()) {
try (final PrintStream out = new PrintStream(actual)) {
PropertiesFactory.EMPTY_PROPERTIES.save(out, comments);
}
// expected
try (final ByteArrayOutputStream expected = new ByteArrayOutputStream()) {
try (final PrintStream out = new PrintStream(expected)) {
PropertiesFactory.INSTANCE.createProperties().save(out, comments);
}
Assert.assertArrayEquals(expected.toByteArray(), actual.toByteArray());
expected.reset();
try (final PrintStream out = new PrintStream(expected)) {
new Properties().save(out, comments);
}
Assert.assertArrayEquals(expected.toByteArray(), actual.toByteArray());
}
}
}
@Test(expected = UnsupportedOperationException.class)