From e542eca84af464343bfbc016472658eba36fe7c3 Mon Sep 17 00:00:00 2001 From: Gary Gregory Date: Sun, 25 Aug 2024 16:22:02 -0400 Subject: [PATCH] Better parameter names --- .../collections4/bloomfilter/WrappedBloomFilter.java | 6 +++--- .../collection/AbstractCollectionDecorator.java | 6 +++--- .../java/org/apache/commons/collections4/map/Flat3Map.java | 6 +++--- .../collections4/multimap/AbstractMultiValuedMapTest.java | 4 ++-- .../apache/commons/collections4/set/EmptySetMutator.java | 4 ++-- 5 files changed, 13 insertions(+), 13 deletions(-) diff --git a/src/main/java/org/apache/commons/collections4/bloomfilter/WrappedBloomFilter.java b/src/main/java/org/apache/commons/collections4/bloomfilter/WrappedBloomFilter.java index 23afeee3a..a03ab0e85 100644 --- a/src/main/java/org/apache/commons/collections4/bloomfilter/WrappedBloomFilter.java +++ b/src/main/java/org/apache/commons/collections4/bloomfilter/WrappedBloomFilter.java @@ -30,10 +30,10 @@ public abstract class WrappedBloomFilter implements BloomFilter { /** * Wraps a Bloom filter. The wrapped filter is maintained as a reference * not a copy. Changes in one will be reflected in the other. - * @param bf The Bloom filter. + * @param wrapped The Bloom filter. */ - public WrappedBloomFilter(final BloomFilter bf) { - this.wrapped = bf; + public WrappedBloomFilter(final BloomFilter wrapped) { + this.wrapped = wrapped; } @Override diff --git a/src/main/java/org/apache/commons/collections4/collection/AbstractCollectionDecorator.java b/src/main/java/org/apache/commons/collections4/collection/AbstractCollectionDecorator.java index 0a5961308..c28e3ab51 100644 --- a/src/main/java/org/apache/commons/collections4/collection/AbstractCollectionDecorator.java +++ b/src/main/java/org/apache/commons/collections4/collection/AbstractCollectionDecorator.java @@ -155,10 +155,10 @@ public abstract class AbstractCollectionDecorator *

* NOTE: this method should only be used during deserialization * - * @param coll the decorated collection + * @param collection the decorated collection */ - protected void setCollection(final Collection coll) { - this.collection = coll; + protected void setCollection(final Collection collection) { + this.collection = collection; } @Override diff --git a/src/main/java/org/apache/commons/collections4/map/Flat3Map.java b/src/main/java/org/apache/commons/collections4/map/Flat3Map.java index 7a8a6b1a0..328fa5569 100644 --- a/src/main/java/org/apache/commons/collections4/map/Flat3Map.java +++ b/src/main/java/org/apache/commons/collections4/map/Flat3Map.java @@ -250,10 +250,10 @@ public class Flat3Map implements IterableMap, Serializable, Cloneabl * As a consequence, all subsequent call to {@link #getKey()}, * {@link #setValue(Object)} and {@link #getValue()} will fail. * - * @param flag the new value of the removed flag + * @param removed the new value of the removed flag */ - void setRemoved(final boolean flag) { - this.removed = flag; + void setRemoved(final boolean removed) { + this.removed = removed; } @Override diff --git a/src/test/java/org/apache/commons/collections4/multimap/AbstractMultiValuedMapTest.java b/src/test/java/org/apache/commons/collections4/multimap/AbstractMultiValuedMapTest.java index fd0e7b42d..ac80948e2 100644 --- a/src/test/java/org/apache/commons/collections4/multimap/AbstractMultiValuedMapTest.java +++ b/src/test/java/org/apache/commons/collections4/multimap/AbstractMultiValuedMapTest.java @@ -693,8 +693,8 @@ public abstract class AbstractMultiValuedMapTest extends AbstractObjectTes // assertEquals(expected, actual); // } - public void setConfirmed(final MultiValuedMap map) { - this.confirmed = map; + public void setConfirmed(final MultiValuedMap confirmed) { + this.confirmed = confirmed; } @Test diff --git a/src/test/java/org/apache/commons/collections4/set/EmptySetMutator.java b/src/test/java/org/apache/commons/collections4/set/EmptySetMutator.java index 43c47a4bf..a1c4a071e 100644 --- a/src/test/java/org/apache/commons/collections4/set/EmptySetMutator.java +++ b/src/test/java/org/apache/commons/collections4/set/EmptySetMutator.java @@ -32,8 +32,8 @@ final class EmptySetMutator implements CompositeSet.SetMutator { private final Set contained; - EmptySetMutator(final Set set) { - this.contained = set; + EmptySetMutator(final Set contained) { + this.contained = contained; } @Override