Apache
/
commons-collections
mirror of https://github.com/apache/commons-collections.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Rework test fixtures 

Next, grow the amount of data tested to find bugs in the tests with
non-repeatable map ordering
This commit is contained in:
Gary Gregory 2024-03-31 10:40:08 -04:00
parent 31b4116858
commit e5c95c28d2
1 changed files with 23 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

37
src/test/java/org/apache/commons/collections4/multimap/AbstractMultiValuedMapTest.java
View File

@ -1235,21 +1235,30 @@ public abstract class AbstractMultiValuedMapTest<K, V> extends AbstractObjectTes
assumeTrue(isRemoveSupported());
resetFull();
final MultiValuedMap<K, V> map = getMap();
@SuppressWarnings("unchecked")
final Iterator<V> it = map.get((K) "k0").iterator();
while (it.hasNext()) {
it.next();
it.remove();
int expectedSize = map.size();
final int maxK = getSampleKeySize();
for (int k = 0; k < maxK; k++) {
final String key = makeKey(k);
final int cpk = getSampleCountPerKey();
@SuppressWarnings("unchecked")
final Iterator<V> it = map.get((K) key).iterator();
while (it.hasNext()) {
it.next();
it.remove();
}
assertFalse(map.containsKey(key));
for (int j = 0; j < cpk; j++) {
assertFalse(map.containsMapping(key, makeValue(k + 1, j)));
final Object value = makeValue(k, j);
assertFalse(map.containsMapping(key, value));
assertFalse(map.containsValue(value));
}
expectedSize -= cpk;
assertEquals(expectedSize, map.size());
final Collection<V> coll = map.remove("k0");
assertNotNull(coll);
assertEquals(0, coll.size());
}
assertFalse(map.containsKey("k0"));
assertFalse(map.containsMapping("k0", "v1_1"));
assertFalse(map.containsMapping("k0", "v0_1"));
assertFalse(map.containsValue("v0_0"));
assertFalse(map.containsValue("v0_1"));
assertEquals(4, map.size());
final Collection<V> coll = map.remove("k0");
assertNotNull(coll);
assertEquals(0, coll.size());
}
@Test