Apache/commons-collections
1
0
Fork 0
mirror of https://github.com/apache/commons-collections.git synced 2025-02-08 02:59:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

Unnecessary code - the null check is already done below

Browse Source 
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477737 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Sebastian Bazley 2013-04-30 17:49:12 +00:00
parent 5df60bb0e6
commit f7f4b909d0
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/main/java/org/apache/commons/collections4/trie/CharacterKeyAnalyzer.java
View File

@ -74,7 +74,7 @@ public class CharacterKeyAnalyzer extends AbstractKeyAnalyzer<Character> {
* {@inheritDoc} * {@inheritDoc}
*/ */
public int bitIndex(final Character key, final int offsetInBits, final int lengthInBits, public int bitIndex(final Character key, final int offsetInBits, final int lengthInBits,
Character other, final int otherOffsetInBits, final int otherLengthInBits) { final Character other, final int otherOffsetInBits, final int otherLengthInBits) {
if (offsetInBits != 0 || otherOffsetInBits != 0) { if (offsetInBits != 0 || otherOffsetInBits != 0) {
throw new IllegalArgumentException("offsetInBits=" + offsetInBits throw new IllegalArgumentException("offsetInBits=" + offsetInBits
@ -86,10 +86,6 @@ public class CharacterKeyAnalyzer extends AbstractKeyAnalyzer<Character> {
return NULL_BIT_KEY; return NULL_BIT_KEY;
} }
if (other == null) {
other = Character.MIN_VALUE;
}
final char otherValue = other != null ? other.charValue() : Character.MIN_VALUE; final char otherValue = other != null ? other.charValue() : Character.MIN_VALUE;
if (keyValue != otherValue) { if (keyValue != otherValue) {