Commit Graph

3159 Commits

Author SHA1 Message Date
Gary Gregory 974e12ac42 Javadoc typos 2023-05-19 08:44:33 -04:00
Gary Gregory 01190c61ea Javadoc typos 2023-05-19 08:43:51 -04:00
Gary Gregory dd10e5e0e6 Bump tests from commons-io:commons-io 2.11.0 to 2.12.0 2023-05-17 09:11:30 -04:00
Gary Gregory e9dc3ebf60
Bump commons-parent from 56 to 57 #393 2023-04-27 13:32:23 -04:00
Gary Gregory 457d44e955 Organize imports 2023-04-23 15:28:29 -04:00
Gary Gregory 918874b842 [COLLECTIONS-839] Migrate Map tests to JUnit 5 assertions #391 2023-04-23 15:27:53 -04:00
Sam Ng 34f0b1cef5
[COLLECTIONS-839] migrate all tests to use junit5 assert and BulkTest not extend TestCase (#391) 2023-04-23 15:24:48 -04:00
Gary Gregory 8d77ecb0b3 Format: "catch(" -> "catch (" 2023-04-18 10:32:35 -04:00
Gary Gregory 68f3d6bf57 Javadoc/Comments: Remove extra "whitespace" 2023-03-25 09:51:13 -04:00
Gary Gregory fccb54d3a0 Javadoc: Remove extra "whitespace" 2023-03-25 09:21:10 -04:00
Gary Gregory 66b1c480a8 Javadoc 2023-03-13 09:31:20 -04:00
Gary Gregory ed63e2e17a Use XSD 2023-03-13 08:08:49 -04:00
Gary Gregory 1f297c969c Remove unused 2023-02-10 08:51:55 -05:00
Gary Gregory e75ffe7090 Fix spelling 2023-01-18 09:27:58 -05:00
Gary Gregory e3eaa8599e Fix typos 2023-01-15 07:55:27 -05:00
Gary Gregory 576fd97501 POM project name should contain "Apache" prefix 2023-01-15 07:44:28 -05:00
dependabot[bot] ae870195ba Bump maven-checkstyle-plugin from 3.2.0 to 3.2.1
Bumps [maven-checkstyle-plugin](https://github.com/apache/maven-checkstyle-plugin) from 3.2.0 to 3.2.1.
- [Release notes](https://github.com/apache/maven-checkstyle-plugin/releases)
- [Commits](https://github.com/apache/maven-checkstyle-plugin/compare/maven-checkstyle-plugin-3.2.0...maven-checkstyle-plugin-3.2.1)

---
updated-dependencies:
- dependency-name: org.apache.maven.plugins:maven-checkstyle-plugin
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-01-13 21:26:30 +01:00
Gary Gregory a48c70325e Javadoc fixes 2023-01-13 14:41:50 -05:00
Gary Gregory b56cb91d83
Bump easymock from 5.0.1 to 5.1.0 #375 2023-01-03 10:55:28 -05:00
Gary Gregory 944a25ef84
Bump commons-parent from 55 to 56 #373 2023-01-03 10:53:00 -05:00
Gary Gregory 1fb9183c70 Use Arrays.copyOf() 2022-12-28 16:20:57 -05:00
Gary Gregory 575d2c6a40
Remove use of JUnit4 junit.framework.Test class #371 2022-12-27 08:44:13 -05:00
Piyush Sagar b860d0ce3a
COLLECTIONS-806: Remove use of JUnit4 junit.framework.Test class (#371)
* COLLECTIONS-806: removed references of JUnit4 Test class

- Removed references of junit.framework.Test
- Removed unused method BulkTest.makeSuite()

* COLLECTIONS-806: removed unused imports
2022-12-27 08:42:57 -05:00
Gary Gregory 31e2dcb9da
Bump commons-parent from 54 to 55 #368 2022-12-16 11:19:48 -05:00
aherbert a1de787172 Collections-817: Update estimateN, estimateIntersection and
estimateUnion

Reworked calculations and updated javadoc.

Added documentation concerning n, intersection, and union calculations
in Shape class.

Modified estimatedIntersection to account for infinite values in
calculations.

This commit addresses a merge error that omitted all fixes  intended for
the changes in 64ed061e6a
2022-11-30 16:30:15 +00:00
aherbert 5bcab481f7 Remove public keyword from package level test members 2022-11-30 16:07:08 +00:00
aherbert d879329cd3 Remove empty line 2022-11-30 16:02:38 +00:00
aherbert 23677eb23e Javadoc comment typo 2022-11-30 16:00:26 +00:00
Gary Gregory 7b2c1b2b3e
Update changes.xml 2022-11-26 15:32:58 -05:00
Arturo Bernal 954d222aa6
Use Java style array decelerations (#362) 2022-11-26 15:32:07 -05:00
Gary Gregory 8279d9ba46 Merge branch 'master' of https://gitbox.apache.org/repos/asf/commons-collections.git 2022-11-26 07:26:41 -05:00
Gary Gregory 8d99d5f9bb Bump pmd from 6.51.0 to 6.52.0 2022-11-26 07:26:28 -05:00
Gary Gregory 6031f5395b Reuse constants 2022-11-25 09:19:47 -05:00
Gary Gregory a8c0df14ca Sort imports 2022-11-25 09:15:28 -05:00
yannizhou05 37cd2d8dc1
Fix flaky test in CollectionUtilsTest (#360) 2022-11-15 18:35:41 +00:00
Claude Warren d4a5f9f5f5
Collections-837: Remove HasherCollection
* Removed HasherCollection.

* Moved multiple hashing functions into TestingHashers.
2022-11-12 16:35:40 +00:00
aherbert 69cad46a92 Whitespace formatting 2022-11-09 12:50:06 +00:00
Gary Gregory 9bbfad5db3 Merge branch 'master' of https://gitbox.apache.org/repos/asf/commons-collections.git 2022-11-07 08:39:36 -05:00
Gary Gregory fd09ecccbd Javadocs and comments
Normalize spelling to "behavior"
2022-11-07 08:39:21 -05:00
Alex Herbert 2b3fae5aaa Use method reference 2022-11-07 09:15:27 +00:00
Gary Gregory 12bdb33dc0 Remove unnecessary parens 2022-11-06 11:50:09 -05:00
Gary Gregory b9c22565fe Javadoc 2022-11-06 11:42:00 -05:00
Gary Gregory fe28f8689e PMD: AbstractReferenceMap.WeakRef implements hashCode() but not equals() 2022-11-06 11:41:40 -05:00
Gary Gregory d22eb8951b PMD: AbstractReferenceMap.SoftRef implements hashCode() but not equals() 2022-11-06 11:35:53 -05:00
Gary Gregory e84ff4dff0 PMD: No need to nest
- PMD: No need to just call super
- PMD: Simplify ternary expression to expression
- PMD: Ignore empty loop warning
- Fix import
2022-11-06 11:32:13 -05:00
Gary Gregory 5848c936b7 PMD: Use direct access 2022-11-06 11:16:28 -05:00
Gary Gregory 17db5ba533 Simplify ignorance of caught exception 2022-11-06 11:13:29 -05:00
Gary Gregory 8e300bdec2 PMD: Use direct access 2022-11-06 11:09:25 -05:00
Gary Gregory e377b46bc8 These test classes can be static 2022-11-06 10:55:42 -05:00
Gary Gregory 4033393aaf Call to super is redundant 2022-11-06 10:54:50 -05:00
Gary Gregory 62b1cc6354 Use lambdas 2022-11-06 10:52:36 -05:00
Gary Gregory 8e4c50f928 Use Java 5 for each loop 2022-11-06 10:50:43 -05:00
Gary Gregory 0801d0d4ca Simpler lambdas 2022-11-06 10:46:33 -05:00
Gary Gregory e37d375d83 Add missing @Override
Use diamonds
Use final
2022-11-06 10:42:35 -05:00
Gary Gregory 8618b108f8 Add @SuppressWarnings and tweak formatting 2022-11-06 10:18:01 -05:00
Gary Gregory 5286ebe2c6
Fix minor typos #323 2022-11-06 09:57:27 -05:00
Marc Wrobel 3a5c5c2838
(chore) Fix minor typos (#323)
Fix various minor typos in :
- project documentations,
- javadoc and comments,
- method attribute and variable names,
- test method names.
2022-11-06 09:55:27 -05:00
Claude Warren b66b6cacbb
Fixed typos originally reported in pull #323 (#349) 2022-11-06 10:56:51 +00:00
Alex Herbert 3071aea62d Bloom filter code clean-up
Correct whitespace issues.

Javadoc additions and corrections.
2022-11-05 22:31:00 +00:00
Claude Warren a251c18dae
Collections-834: Clarify Bloom filter BitCountProducer operation (#335)
Document the expected behaviour of the BitCountProducer's mapping of indices to counts.

Updated IndexProducer and BitCountProducer tests to verify the expected indices and counts; and optionally verify the encounter order is sorted and indices are distinct.
2022-11-05 21:30:47 +00:00
Alex Herbert 9a6665af36 Remove Comparable from the Shape class
The Shape could be used as a key so implements equals and hashCode. The
ordering of a Shape is arbitrary.
2022-11-05 08:43:58 +00:00
Alex Herbert f4d5690ca8 Track changes 2022-11-05 07:59:22 +00:00
anantdahiya8 14d7d98e7e
COLLECTIONS-836: fix flaky test DualHashBidiMapTest (#353) 2022-11-05 07:50:37 +00:00
aherbert 9582007123 Make Hasher test classes package-private 2022-11-04 15:40:26 +00:00
Gary Gregory 107fbd6c1f Bump pmd from 6.50.0 to 6.51.0 2022-10-30 11:55:27 -04:00
dependabot[bot] a3889838df Bump easymock from 5.0.0 to 5.0.1
Bumps [easymock](https://github.com/easymock/easymock) from 5.0.0 to 5.0.1.
- [Release notes](https://github.com/easymock/easymock/releases)
- [Changelog](https://github.com/easymock/easymock/blob/master/ReleaseNotes.md)
- [Commits](https://github.com/easymock/easymock/compare/easymock-5.0.0...easymock-5.0.1)

---
updated-dependencies:
- dependency-name: org.easymock:easymock
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-10-29 08:28:26 +13:00
Gary Gregory dca05e593e
Bump easymock from 4.3 to 5.0.0 #352 2022-10-21 08:30:37 -04:00
Bruno P. Kinoshita 8c91a51546 [COLLECTIONS-814] Add change log 2022-10-19 15:09:21 +13:00
Angus 17bed2b555 [COLLECTIONS-814] CollectionUtils.removeAll() not throwing proper NullPointerException(NPE) if the first parameter is empty
Add null check
2022-10-19 15:07:20 +13:00
Bruno P. Kinoshita 463d2cc57b [COLLECTIONS-835] Add change log and credit 2022-10-19 14:08:05 +13:00
Marc Wrobel 297f7af4af [COLLECTIONS-835] Fix links in javadoc and documentations
- fix broken links,
- use direct links instead of redirects,
- use HTTPS where possible.
2022-10-19 14:07:20 +13:00
dependabot[bot] 3187cc0575 Bump actions/checkout from 3.0.2 to 3.1.0
Bumps [actions/checkout](https://github.com/actions/checkout) from 3.0.2 to 3.1.0.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](https://github.com/actions/checkout/compare/v3.0.2...93ea575cb5d8a053eaa0ac8fa3b40d7e05a33cc8)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-10-08 11:10:56 +13:00
dependabot[bot] e1dd9678e9 Bump commons.pmd-impl.version from 6.49.0 to 6.50.0
Bumps `commons.pmd-impl.version` from 6.49.0 to 6.50.0.

Updates `pmd-core` from 6.49.0 to 6.50.0
- [Release notes](https://github.com/pmd/pmd/releases)
- [Changelog](https://github.com/pmd/pmd/blob/master/docs/render_release_notes.rb)
- [Commits](https://github.com/pmd/pmd/compare/pmd_releases/6.49.0...pmd_releases/6.50.0)

Updates `pmd-java` from 6.49.0 to 6.50.0
- [Release notes](https://github.com/pmd/pmd/releases)
- [Changelog](https://github.com/pmd/pmd/blob/master/docs/render_release_notes.rb)
- [Commits](https://github.com/pmd/pmd/compare/pmd_releases/6.49.0...pmd_releases/6.50.0)

Updates `pmd-javascript` from 6.49.0 to 6.50.0
- [Release notes](https://github.com/pmd/pmd/releases)
- [Changelog](https://github.com/pmd/pmd/blob/master/docs/render_release_notes.rb)
- [Commits](https://github.com/pmd/pmd/compare/pmd_releases/6.49.0...pmd_releases/6.50.0)

Updates `pmd-jsp` from 6.49.0 to 6.50.0
- [Release notes](https://github.com/pmd/pmd/releases)
- [Changelog](https://github.com/pmd/pmd/blob/master/docs/render_release_notes.rb)
- [Commits](https://github.com/pmd/pmd/compare/pmd_releases/6.49.0...pmd_releases/6.50.0)

---
updated-dependencies:
- dependency-name: net.sourceforge.pmd:pmd-core
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: net.sourceforge.pmd:pmd-java
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: net.sourceforge.pmd:pmd-javascript
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: net.sourceforge.pmd:pmd-jsp
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-10-08 10:58:27 +13:00
dependabot[bot] 2ebb950848 Bump actions/cache from 3.0.9 to 3.0.10
Bumps [actions/cache](https://github.com/actions/cache) from 3.0.9 to 3.0.10.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](https://github.com/actions/cache/compare/v3.0.9...v3.0.10)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-10-08 10:56:13 +13:00
Partha Protim Paul 28c74518bc
Fix flaky test failure in 'AbstractCollectionTest.testCollectionToArray2'
Use the AbstractCollectionTest iteration order flag in Map and Bag tests. These tests have inner classes that extend AbstractCollectionTest to test their values collection. This should be robust to an unspecified iteration order.
2022-10-03 11:12:38 +01:00
Gary Gregory 917cdf1bf8 Bump actions/setup-java from 3 to 3.5.1 2022-10-01 14:32:15 -04:00
Gary Gregory 88844fdbdf
Bump actions/cache from 3.0.8 to 3.0.9 #342 2022-09-30 09:40:09 -04:00
Gary Gregory 474713f727 Doc: Bump commons-parent from 53 to 54 2022-09-24 11:26:46 -04:00
Gary Gregory 6aaab7da17 Bump japicmp-maven-plugin from 0.15.7 to 0.16.0 2022-09-24 11:26:04 -04:00
aherbert b284bc8e20 Track changes 2022-09-23 12:48:41 +01:00
aherbert c35d8c6fd1 Update test of unordered arrays
Matching the length and then matching items in a Set will not detect a
count mismatch of duplicates. This test now explicitly matches each item
once and only once.
2022-09-23 12:48:41 +01:00
Partha-SUST16 30a9ab835d Fix flaky test failure in SynchronizedBagTest#testCollectionToArray2
Closes #336
2022-09-23 12:48:10 +01:00
Gary Gregory 16710abc9a
Bump commons-parent from 53 to 54 #339 2022-09-22 17:21:28 -04:00
Gary Gregory 79077e8efd
Bump commons.junit.version from 5.9.0 to 5.9.1 #338 2022-09-22 16:45:59 -04:00
Alex Herbert 3bc37dcd6b Update IndexProducerTest to test the behaviour
IndexProducers are tested for consistency between the indices output by
forEach and asIndexArray.

In addition the output methods can be tested that the indices are
ordered or distinct.
2022-09-10 10:02:41 +01:00
Alex Herbert 2a6ec0fca0 Simplify random indices tests
Use streams to generate arrays.

Use BitSet to create a unique set of indices.
2022-09-10 10:02:41 +01:00
Alex Herbert 5920f32cd8 Fix typo 2022-09-10 10:02:41 +01:00
Claude Warren, Jr 9a58c1bbdf Collections-763: Remove BloomFilter constructors that create initial entry 2022-09-10 10:02:41 +01:00
dependabot[bot] 879d382703 Bump maven-pmd-plugin from 3.18.0 to 3.19.0
Bumps [maven-pmd-plugin](https://github.com/apache/maven-pmd-plugin) from 3.18.0 to 3.19.0.
- [Release notes](https://github.com/apache/maven-pmd-plugin/releases)
- [Commits](https://github.com/apache/maven-pmd-plugin/compare/maven-pmd-plugin-3.18.0...maven-pmd-plugin-3.19.0)

---
updated-dependencies:
- dependency-name: org.apache.maven.plugins:maven-pmd-plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-09-10 11:34:33 +12:00
Gary Gregory e20aad0753 Bump actions/checkout from 3 to 3.0.2. 2022-09-06 09:20:42 -07:00
Gary Gregory 49c399b143
Bump commons.pmd-impl.version from 6.48.0 to 6.49.0 #333 2022-09-02 08:14:46 -04:00
Gary Gregory a6e20efe62 Rename type parameter 2022-09-01 13:43:34 -04:00
aherbert 84fb830481 Formatting 2022-08-30 15:18:38 +01:00
Gary Gregory 955f7ab1eb Javadoc @link tags do not need to use a FQCN for classes in java.lang 2022-08-29 07:35:40 -04:00
Gary Gregory b605686f52 Javadoc @see tags do not need to use a FQCN for classes in java.lang 2022-08-29 07:06:39 -04:00
Gary Gregory 0f3ad2284e Fix typo independant -> independent 2022-08-28 12:14:07 -04:00
aherbert 7bf71f59b8 Use private inner class 2022-08-24 13:23:19 +01:00
aherbert 33489b9114 Use diamond operator 2022-08-24 13:23:19 +01:00
Gary Gregory d7f2a7a377 Bump maven-checkstyle-plugin 3.1.0 to 3.2.0. 2022-08-24 08:11:07 -04:00
Gary Gregory bf0970a71f Bump maven-pmd-plugin from 3.17.0 to 3.18.0 2022-08-24 08:08:18 -04:00