Commit Graph

2132 Commits

Author SHA1 Message Date
Thomas Neidhart 467d516b9c Cleanup of trie package.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1491615 13f79535-47bb-0310-9956-ffa450edef68
2013-06-10 21:46:19 +00:00
Thomas Neidhart edd64cfd82 [COLLECTIONS-472] Improved performance of AbstractMapBag#containsAll. Thanks to Adrian Nistor.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1491258 13f79535-47bb-0310-9956-ffa450edef68
2013-06-09 18:35:24 +00:00
Sebastian Bazley 8f5e319af8 A bit more Javadoc
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1482645 13f79535-47bb-0310-9956-ffa450edef68
2013-05-14 23:52:09 +00:00
Thomas Neidhart 2e36e5e908 [COLLECTIONS-461] Added javadoc clarification to Put. Thanks to mbenson.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1482544 13f79535-47bb-0310-9956-ffa450edef68
2013-05-14 20:02:25 +00:00
Thomas Neidhart 3b57c46c76 Fix version tag
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1482539 13f79535-47bb-0310-9956-ffa450edef68
2013-05-14 19:52:43 +00:00
Thomas Neidhart ee7ed6e655 Formatting + svn:keywords
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1482538 13f79535-47bb-0310-9956-ffa450edef68
2013-05-14 19:48:56 +00:00
Thomas Neidhart cdacd4a987 [COLLECTIONS-460] Change IteratorChain to use a Queue internally.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1482514 13f79535-47bb-0310-9956-ffa450edef68
2013-05-14 18:36:12 +00:00
Thomas Neidhart 556ac8b0ad Fix javadoc.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1482073 13f79535-47bb-0310-9956-ffa450edef68
2013-05-13 20:09:40 +00:00
Thomas Neidhart d9ed7afd9e [COLLECTIONS-466] Added entry to release notes.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1481621 13f79535-47bb-0310-9956-ffa450edef68
2013-05-12 18:43:06 +00:00
Thomas Neidhart a86de44927 Removed TODO, as the current API is fine imho: two versions, one for Iterable, one for Iterator.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1481606 13f79535-47bb-0310-9956-ffa450edef68
2013-05-12 16:58:49 +00:00
Thomas Neidhart 709aa7bf9c [COLLECTIONS-466] Replace Collection with Iterable where applicable in CollectionUtils.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1481605 13f79535-47bb-0310-9956-ffa450edef68
2013-05-12 16:56:26 +00:00
Thomas Neidhart 1194c69fb1 Formatting.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1481598 13f79535-47bb-0310-9956-ffa450edef68
2013-05-12 16:28:28 +00:00
Thomas Neidhart 1fe64733a2 [COLLECTIONS-466] Replaced Collection with Iterable in MapUtils.populateMap methods.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1480230 13f79535-47bb-0310-9956-ffa450edef68
2013-05-08 11:35:20 +00:00
Thomas Neidhart 54bbca8904 [COLLECTIONS-463] Add PushbackIterator. Thanks to Andy Seaborne.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1479763 13f79535-47bb-0310-9956-ffa450edef68
2013-05-07 05:28:39 +00:00
Thomas Neidhart d16f842887 Document the reason chainedIterator(Iterator, Iterator) still remains.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1479761 13f79535-47bb-0310-9956-ffa450edef68
2013-05-07 05:19:57 +00:00
Thomas Neidhart 73dcea01b1 [COLLECTIONS-462] Added PeekingIterator. Thanks to Andy Seaborne
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1479760 13f79535-47bb-0310-9956-ffa450edef68
2013-05-07 05:12:06 +00:00
Thomas Neidhart 278eed3e1f Add again chainedIterator method with 2 iterators to avoid generics warning in client code.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1479682 13f79535-47bb-0310-9956-ffa450edef68
2013-05-06 19:12:25 +00:00
Sebastian Bazley fbb81a37f8 Fix up a raw type
TODO: the whole test class looks wrong - why is it parameterised? If does not seem to have a specific instantiation

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1479412 13f79535-47bb-0310-9956-ffa450edef68
2013-05-05 22:30:51 +00:00
Sebastian Bazley c68c274bfa Document why warnings can be ignored here
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1479408 13f79535-47bb-0310-9956-ffa450edef68
2013-05-05 22:15:05 +00:00
Thomas Neidhart 0fc05eb81d Add missing since tags.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1479407 13f79535-47bb-0310-9956-ffa450edef68
2013-05-05 22:07:53 +00:00
Thomas Neidhart fc502e2479 Add missing since tags.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1479406 13f79535-47bb-0310-9956-ffa450edef68
2013-05-05 22:02:01 +00:00
Thomas Neidhart 9d32f4bbfd Add missing since tags.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1479405 13f79535-47bb-0310-9956-ffa450edef68
2013-05-05 21:58:52 +00:00
Thomas Neidhart 27a02f3d57 Add missing since tags.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1479403 13f79535-47bb-0310-9956-ffa450edef68
2013-05-05 21:54:13 +00:00
Thomas Neidhart 6a957e410a Add missing since tags.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1479401 13f79535-47bb-0310-9956-ffa450edef68
2013-05-05 21:51:47 +00:00
Thomas Neidhart b9b45674bd Add missing since tags.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1479400 13f79535-47bb-0310-9956-ffa450edef68
2013-05-05 21:49:47 +00:00
Thomas Neidhart 583ee805bd Add missing since tags.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1479399 13f79535-47bb-0310-9956-ffa450edef68
2013-05-05 21:46:48 +00:00
Thomas Neidhart 077913c7e9 Allow a broader range of inputs for a UniqueFilterIterator.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1479385 13f79535-47bb-0310-9956-ffa450edef68
2013-05-05 20:31:06 +00:00
Thomas Neidhart 081b62ef8d [COLLECTIONS-351] Add to changelog, changes have been performed and added to release notes.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1479349 13f79535-47bb-0310-9956-ffa450edef68
2013-05-05 16:20:55 +00:00
Thomas Neidhart a5e94c1727 [COLLECTIONS-453] finish with updating the changelog.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1479348 13f79535-47bb-0310-9956-ffa450edef68
2013-05-05 16:16:30 +00:00
Thomas Neidhart 94cfd56bd9 Use varargs instead of arrays as input argument where applicable.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1479347 13f79535-47bb-0310-9956-ffa450edef68
2013-05-05 16:01:15 +00:00
Thomas Neidhart 9687cf07f3 Use varargs instead of array in constructor.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1479344 13f79535-47bb-0310-9956-ffa450edef68
2013-05-05 15:48:01 +00:00
Thomas Neidhart 67e443370e Use also varargs in internal FunctorUtils.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1479343 13f79535-47bb-0310-9956-ffa450edef68
2013-05-05 15:43:38 +00:00
Thomas Neidhart ace5ba00f7 Use varargs parameter instead of array.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1479340 13f79535-47bb-0310-9956-ffa450edef68
2013-05-05 15:37:41 +00:00
Thomas Neidhart 4b2709eb5a Make javadoc happy.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1479338 13f79535-47bb-0310-9956-ffa450edef68
2013-05-05 15:21:44 +00:00
Thomas Neidhart 5878adfaf3 [COLLECTIONS-453] Fix SwitchClosure and SwitchTransformer.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1479337 13f79535-47bb-0310-9956-ffa450edef68
2013-05-05 15:20:59 +00:00
Thomas Neidhart 8283d966f4 [COLLECTIONS-453] Change ChainedTransformer and ChainedClosure constructors to copy input arguments, add private constructor for factory methods to not copy twice.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1479336 13f79535-47bb-0310-9956-ffa450edef68
2013-05-05 15:06:50 +00:00
Thomas Neidhart afcbced8ef Removed ClosureUtils.chainedClosure(Closure, Closure) method as there is already one with vararg parameters.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1479126 13f79535-47bb-0310-9956-ffa450edef68
2013-05-04 15:16:07 +00:00
Thomas Neidhart 2edf0b06a9 Removed unused field, the parent bidi map is accessed via decorated().
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1479122 13f79535-47bb-0310-9956-ffa450edef68
2013-05-04 15:08:41 +00:00
Thomas Neidhart 1436aa0fc7 First draft for migration guide.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1478764 13f79535-47bb-0310-9956-ffa450edef68
2013-05-03 13:02:20 +00:00
Thomas Neidhart ba78fe4a6d Update release notes.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1478739 13f79535-47bb-0310-9956-ffa450edef68
2013-05-03 11:47:35 +00:00
Thomas Neidhart 43e4df85bd [COLLECTIONS-453] Clone input parameters, add null check, final.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477839 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 21:32:47 +00:00
Thomas Neidhart 05f3b74fd5 [COLLECTIONS-453] Clone input parameters for InstantiateTransformer.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477838 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 21:29:26 +00:00
Sebastian Bazley 9f0af0bfee Document some valid @SuppressWarnings
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477829 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 21:11:28 +00:00
Thomas Neidhart 4b2778dd4a Updated description.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477807 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 20:14:39 +00:00
Thomas Neidhart 7d54ee797c Remove trailing spaces.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477802 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 20:01:28 +00:00
Thomas Neidhart 810250d722 Remove trailing spaces.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477799 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 19:56:11 +00:00
Thomas Neidhart b7a0c8d3de Remove trailing spaces.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477798 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 19:49:02 +00:00
Thomas Neidhart 88564caa20 Remove trailing spaces, formatting + javadoc.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477795 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 19:44:16 +00:00
Thomas Neidhart 9af55b6479 Remove trailing spaces.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477794 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 19:42:03 +00:00
Sebastian Bazley d31ea317a5 Ensure name is used
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477793 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 19:37:29 +00:00
Sebastian Bazley d403368879 Ignore boxing errors in test code
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477789 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 19:28:27 +00:00
Sebastian Bazley 46a1c86ab3 Explicit boxing
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477788 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 19:27:32 +00:00
Sebastian Bazley cf4d278990 Add hashCode() to keep Findbugs happy
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477787 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 19:26:42 +00:00
Sebastian Bazley c635393fb9 Unnecessary cast
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477785 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 19:24:02 +00:00
Sebastian Bazley 5d83e4deb8 Add some tests for toString
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477781 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 19:09:01 +00:00
Thomas Neidhart b7430de759 Remove trailing spaces.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477779 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 18:55:24 +00:00
Sebastian Bazley 0ba5e75432 Ensure switch statements have defaults; ensure IllegalStateException messages include the index value
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477774 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 18:48:14 +00:00
Thomas Neidhart b979fd11e1 Remove trailing spaces.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477772 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 18:44:21 +00:00
Thomas Neidhart eef240cfdf Remove trailing spaces.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477765 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 18:37:37 +00:00
Thomas Neidhart 6ee118d2a1 Remove trailing spaces.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477763 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 18:35:29 +00:00
Thomas Neidhart 274aa78fcd Remove trailing spaces.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477760 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 18:34:03 +00:00
Thomas Neidhart d6b40fdbe9 Remove trailing spaces.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477756 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 18:31:13 +00:00
Thomas Neidhart 315b0c786f Remove trailing spaces.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477753 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 18:24:24 +00:00
Thomas Neidhart 7d9196da0e Remove trailing spaces.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477752 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 18:21:52 +00:00
Thomas Neidhart 53cf9ed7f6 Remove trailing spaces.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477747 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 18:16:48 +00:00
Thomas Neidhart 3b9d20636a Remove trailing spaces.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477746 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 18:11:20 +00:00
Thomas Neidhart 75e7e31108 Remove trailing spaces.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477745 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 18:08:32 +00:00
Sebastian Bazley 9a2f53d2d5 Trailing spaces
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477741 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 17:58:35 +00:00
Sebastian Bazley 361b737752 Explicit boxing
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477740 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 17:53:55 +00:00
Sebastian Bazley 1e6dceb8cc Trailing spaces
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477739 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 17:51:06 +00:00
Sebastian Bazley bb3d861fcd Explicit boxing shows that NPE may occur so document it
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477738 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 17:50:45 +00:00
Sebastian Bazley f7f4b909d0 Unnecessary code - the null check is already done below
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477737 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 17:49:12 +00:00
Sebastian Bazley 5df60bb0e6 Trailing spaces
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477661 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 14:27:35 +00:00
Sebastian Bazley 30f5f14baa Add comment markers for remaining classes where fields could perhaps be privatised
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477647 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 14:15:54 +00:00
Sebastian Bazley c4de3dd2bb Some Fields can be private
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477645 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 14:14:40 +00:00
Sebastian Bazley 83119a80aa Fields can be private
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477629 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 13:44:39 +00:00
Sebastian Bazley d3aa5b7742 Fields can be private
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477627 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 13:37:36 +00:00
Sebastian Bazley d5b16405c7 Fields can be private
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477626 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 13:36:11 +00:00
Sebastian Bazley 8fe95aaec2 Fields can be private
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477625 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 13:35:22 +00:00
Sebastian Bazley b236d5259f Field can be private
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477624 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 13:31:19 +00:00
Sebastian Bazley 1f5e68b561 Don't rely on direct access to internal fields
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477622 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 13:30:36 +00:00
Sebastian Bazley 7f0046cf4e Field can be private
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477620 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 13:26:12 +00:00
Sebastian Bazley cde8451d63 Field can be private
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477619 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 13:25:01 +00:00
Sebastian Bazley 8041ccfe10 Fields can be private
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477618 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 13:20:53 +00:00
Sebastian Bazley c7f3ce1ab6 Fields can be private
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477614 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 13:11:28 +00:00
Sebastian Bazley b222008978 Field can be private
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477613 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 13:10:44 +00:00
Sebastian Bazley 35e45cc127 Privatise fields
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477612 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 13:09:57 +00:00
Sebastian Bazley 5ce18d6487 Privatise key & value; add protected setters (fields were protected)
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477599 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 12:44:12 +00:00
Sebastian Bazley 63252b4946 Use getter rather than direct access to key
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477597 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 12:43:06 +00:00
Sebastian Bazley 16d5b09656 Reduce visibility
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477522 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 09:46:50 +00:00
Sebastian Bazley 2bed7ce3f7 Privatise fields
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477521 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 09:46:12 +00:00
Thomas Neidhart 80e9621339 Do not use String.isEmpty in test class.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477518 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 09:26:31 +00:00
Thomas Neidhart c41e831722 [COLLECTIONS-456] Added additional overrides for providing an Equator, as well as for CharSequences.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477515 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 09:05:43 +00:00
Sebastian Bazley 40ad5dc2db COLLECTIONS-458 AbstractUntypedCollectionDecorator<E, D> is not used
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477514 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 09:03:12 +00:00
Thomas Neidhart 44dc835e0a [COLLECTIONS-404] Added the option to provide an Equator to test for equality, by default a DefaultEquator is used that delegates to Object.equals().
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477512 13f79535-47bb-0310-9956-ffa450edef68
2013-04-30 08:57:06 +00:00
Sebastian Bazley 4fa2b6e3ac Field might as well be final
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477401 13f79535-47bb-0310-9956-ffa450edef68
2013-04-29 22:59:34 +00:00
Sebastian Bazley fcf4320023 Make fields private (and final) if possible
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477400 13f79535-47bb-0310-9956-ffa450edef68
2013-04-29 22:58:50 +00:00
Thomas Neidhart 06cec18d4a Fix typo.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477314 13f79535-47bb-0310-9956-ffa450edef68
2013-04-29 20:11:28 +00:00
Thomas Neidhart 969ffdbb98 [COLLECTIONS-456] Added ListUtils.longestCommonSubsequence(List, List).
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477312 13f79535-47bb-0310-9956-ffa450edef68
2013-04-29 20:08:46 +00:00
Thomas Neidhart 72f33c83d4 [COLLECTIONS-404] Move comparators.sequence package to top-level.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477287 13f79535-47bb-0310-9956-ffa450edef68
2013-04-29 19:26:06 +00:00
Thomas Neidhart 6594da9e36 Make field private and provide a getter.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1477274 13f79535-47bb-0310-9956-ffa450edef68
2013-04-29 19:12:29 +00:00
Sebastian Bazley e55db317f2 Ensure oddness check works even for negative numbers
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1476868 13f79535-47bb-0310-9956-ffa450edef68
2013-04-28 23:57:35 +00:00
Sebastian Bazley 4a64a89920 Explicit boxing
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1476867 13f79535-47bb-0310-9956-ffa450edef68
2013-04-28 23:56:45 +00:00
Sebastian Bazley 25d443fb05 Simplify and avoid complaints about "dead store to actual"
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1476864 13f79535-47bb-0310-9956-ffa450edef68
2013-04-28 23:43:54 +00:00
Sebastian Bazley c1be92fbfb Oops - fix up 3 instances where distint Integer instances are required
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1476860 13f79535-47bb-0310-9956-ffa450edef68
2013-04-28 23:33:58 +00:00
Sebastian Bazley f86c69659a Don't use inefficient new Integer
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1476855 13f79535-47bb-0310-9956-ffa450edef68
2013-04-28 23:15:54 +00:00
Sebastian Bazley 05afd18933 Simplify and avoid complaints about "dead store to actual"
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1476853 13f79535-47bb-0310-9956-ffa450edef68
2013-04-28 23:09:52 +00:00
Sebastian Bazley 90634a969a Simplify and avoid complaints about "dead store to actual"
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1476852 13f79535-47bb-0310-9956-ffa450edef68
2013-04-28 22:59:14 +00:00
Sebastian Bazley f2b49b393c Findbugs points out that an int can never be > Integer.MAX_VALUE
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1476851 13f79535-47bb-0310-9956-ffa450edef68
2013-04-28 22:51:53 +00:00
Sebastian Bazley feb7b2fe0c No need to exactly invert whatever value is returned, especially as the Javadoc says we only return -1, 0 or +1.
This fixes Findbugs complaint about checking compareTo with a specific value, as well as avoiding a multiplication.

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1476850 13f79535-47bb-0310-9956-ffa450edef68
2013-04-28 22:48:08 +00:00
Thomas Neidhart e7ae9283ba [COLLECTIONS-404] Make Snake an inner class of SequencesComparator.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1476814 13f79535-47bb-0310-9956-ffa450edef68
2013-04-28 18:58:56 +00:00
Thomas Neidhart 9ea429c977 [COLLECTIONS-454] Fix findbugs warnings by returning independent Map.Entry objects from an entrySet() iterator in Flat3Map.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1476813 13f79535-47bb-0310-9956-ffa450edef68
2013-04-28 18:52:50 +00:00
Sebastian Bazley ce86f3f8aa Explicit boxing
This documents that the boxing is actually intended, rather than an error due to the accidental use of the wrong type.

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1476781 13f79535-47bb-0310-9956-ffa450edef68
2013-04-28 14:20:56 +00:00
Sebastian Bazley 842e39bef6 Fix Javadoc syntax
Javadoc does not seem to allow generic types, so use html entities to simulate the result
Neat hack from http://stackoverflow.com/questions/9482309/javadoc-bug-link-cant-handle-generics#comment-22244407

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1476780 13f79535-47bb-0310-9956-ffa450edef68
2013-04-28 14:18:27 +00:00
Sebastian Bazley 22ed893d2a Javadoc syntax
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1476777 13f79535-47bb-0310-9956-ffa450edef68
2013-04-28 14:10:37 +00:00
Sebastian Bazley 2803f385e6 Javadoc typos
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1476775 13f79535-47bb-0310-9956-ffa450edef68
2013-04-28 14:08:15 +00:00
Sebastian Bazley 2a5a1d0d77 Missing @Override
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1476773 13f79535-47bb-0310-9956-ffa450edef68
2013-04-28 14:03:48 +00:00
Sebastian Bazley 153f33ea77 Javadoc syntax error
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1476772 13f79535-47bb-0310-9956-ffa450edef68
2013-04-28 14:03:13 +00:00
Thomas Neidhart c71a9e8c2b [COLLECTIONS-296] Renamed CollectionUtils.merge to collate, simplify implementation by using a CollatingIterator.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1476770 13f79535-47bb-0310-9956-ffa450edef68
2013-04-28 13:58:37 +00:00
Thomas Neidhart 696c768716 Added more issues which were marked with fix version 4.0-beta1, applied one pending fix for using Arrays.toString.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1476681 13f79535-47bb-0310-9956-ffa450edef68
2013-04-27 21:48:13 +00:00
Thomas Neidhart 1377fa84d7 Fix javadoc links and code examples.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1476599 13f79535-47bb-0310-9956-ffa450edef68
2013-04-27 15:12:42 +00:00
Thomas Neidhart 047b8fb527 ignore false-positive from pmd
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1476593 13f79535-47bb-0310-9956-ffa450edef68
2013-04-27 14:44:48 +00:00
Thomas Neidhart bca5b3c0ff Fix PMD warnings.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1476589 13f79535-47bb-0310-9956-ffa450edef68
2013-04-27 14:35:38 +00:00
Thomas Neidhart cca574ea06 Replace references to getInstance with the corresponding factory method name.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1476582 13f79535-47bb-0310-9956-ffa450edef68
2013-04-27 14:13:54 +00:00
Thomas Neidhart fad4f969df Make DefaultEquator a singleton, hide default ctor.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1476578 13f79535-47bb-0310-9956-ffa450edef68
2013-04-27 14:02:30 +00:00
Thomas Neidhart d574dffb1f Make DefaultEquator serializable.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1476558 13f79535-47bb-0310-9956-ffa450edef68
2013-04-27 12:08:19 +00:00
Thomas Neidhart 803a9c6c17 [COLLECTIONS-310] SetUniqueList#subList now returns an unmodifiable list.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1476557 13f79535-47bb-0310-9956-ffa450edef68
2013-04-27 11:57:01 +00:00
Thomas Neidhart 4b9c68b55a Reordered tests.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1476555 13f79535-47bb-0310-9956-ffa450edef68
2013-04-27 11:23:06 +00:00
Thomas Neidhart c9e1e5c8f5 [COLLECTIONS-237] Added MultiValueMap.iterator() and clarified javadoc for entrySet().
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1476553 13f79535-47bb-0310-9956-ffa450edef68
2013-04-27 11:08:26 +00:00
Thomas Neidhart 50bd9f108b Added missing since tags
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1476507 13f79535-47bb-0310-9956-ffa450edef68
2013-04-27 07:16:48 +00:00
Thomas Neidhart 8641a2e3d5 Added TODO for AbstractQueueTest.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1475976 13f79535-47bb-0310-9956-ffa450edef68
2013-04-25 21:39:12 +00:00
Thomas Neidhart 8157a72408 Added an AbstractQueueTest as base class for all queue tests.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1475974 13f79535-47bb-0310-9956-ffa450edef68
2013-04-25 21:37:18 +00:00
Thomas Neidhart 0f32e037b9 classes have been renamed.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1475957 13f79535-47bb-0310-9956-ffa450edef68
2013-04-25 21:03:52 +00:00
Thomas Neidhart 7d2532b86b Enable serialization tests for bags.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1475955 13f79535-47bb-0310-9956-ffa450edef68
2013-04-25 20:56:05 +00:00
Thomas Neidhart 0c05822544 Reorder tests, remove TODO as it should be fine imho.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1475953 13f79535-47bb-0310-9956-ffa450edef68
2013-04-25 20:48:08 +00:00
Thomas Neidhart 766d9add03 [COLLECTIONS-263] Added MapUtils#populateMap(MultiMap, ...) methods.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1475949 13f79535-47bb-0310-9956-ffa450edef68
2013-04-25 20:38:58 +00:00
Thomas Neidhart b591dacd5c Fix some generics warnings in test classes.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1475940 13f79535-47bb-0310-9956-ffa450edef68
2013-04-25 20:09:15 +00:00
Thomas Neidhart cb3b31ed23 [COLLECTIONS-450] Added CollectionUtils.forAllButLastDo(...) methods. Thanks to J. Moldawski
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1475937 13f79535-47bb-0310-9956-ffa450edef68
2013-04-25 20:02:15 +00:00
Thomas Neidhart f7c4d60cda Finished adding all changes, cant believe it ...
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1471125 13f79535-47bb-0310-9956-ffa450edef68
2013-04-23 20:02:43 +00:00
Thomas Neidhart 5663fe652a Format change entry.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1470721 13f79535-47bb-0310-9956-ffa450edef68
2013-04-22 21:17:31 +00:00
Thomas Neidhart 100be78228 Added missing since tags.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1470720 13f79535-47bb-0310-9956-ffa450edef68
2013-04-22 21:10:55 +00:00
Thomas Neidhart 59d2633770 findbugs: add constructor that sets the member field, but may remove class as it is unused.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1470719 13f79535-47bb-0310-9956-ffa450edef68
2013-04-22 21:06:45 +00:00
Thomas Neidhart ea15ac123a More changelog entries.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1470713 13f79535-47bb-0310-9956-ffa450edef68
2013-04-22 20:54:41 +00:00
Thomas Neidhart 19c429783a More change entries, sorting.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1470702 13f79535-47bb-0310-9956-ffa450edef68
2013-04-22 20:24:42 +00:00
Thomas Neidhart 0751f75c4c Added more changelog entries from JIRA.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1470688 13f79535-47bb-0310-9956-ffa450edef68
2013-04-22 19:57:58 +00:00
Sebastian Bazley 6d1945c8ed Simplify
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1470346 13f79535-47bb-0310-9956-ffa450edef68
2013-04-21 21:03:39 +00:00
Sebastian Bazley b555f1d127 Missing @Override
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1470345 13f79535-47bb-0310-9956-ffa450edef68
2013-04-21 21:01:35 +00:00
Sebastian Bazley 724fa9400f Fix raw type
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1470344 13f79535-47bb-0310-9956-ffa450edef68
2013-04-21 20:59:57 +00:00
Sebastian Bazley a183825420 Javadoc typo
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1470343 13f79535-47bb-0310-9956-ffa450edef68
2013-04-21 20:43:00 +00:00
Sebastian Bazley eaa218844a Unnecessary suppresswarnings
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/collections/trunk@1470342 13f79535-47bb-0310-9956-ffa450edef68
2013-04-21 20:42:30 +00:00